[9] Review request for JDK-8165555: [macosx] VM crashes on second attempt to execute JCK interactive tests that use Robot (single JVM, agent)

Hi All, Kindly review the fix for JDK9. Bug: https://bugs.openjdk.java.net/browse/JDK-816 Webrev: http://cr.openjdk.java.net/~mhalder/816/webrev.00/ Issue: [macosx] VM

Review request for JDK-8166015: [PIT][TEST_BUG] stray character in java/awt/Focus/ModalDialogActivationTest/ModalDialogActivationTest.java

Hi, Please review this test bug fix for JDK9, Webrev: http://cr.openjdk.java.net/~arapte/8166015/webrev.00/ Bug: https://bugs.openjdk.java.net/browse/JDK-8166015 Issue:An unwanted character causes compiler error. Fix: Removed the character & did few small corrections as

Re: Review request for JDK-8166015: [PIT][TEST_BUG] stray character in java/awt/Focus/ModalDialogActivationTest/ModalDialogActivationTest.java

+1 --Semyon On 9/19/2016 3:32 PM, Ajit Ghaisas wrote: The fix looks good. Regards, Ajit *From:* Ambarish Rapte *Sent:* Monday, September 19, 2016 4:15 PM *To:* Sergey Bylokhov; Semyon Sadetsky; Ajit Ghaisas; awt-dev@openjdk.java.net *Subject:* Review request for JDK-8166015:

Re: Review request for JDK-8166015: [PIT][TEST_BUG] stray character in java/awt/Focus/ModalDialogActivationTest/ModalDialogActivationTest.java

The fix looks good. Regards, Ajit From: Ambarish Rapte Sent: Monday, September 19, 2016 4:15 PM To: Sergey Bylokhov; Semyon Sadetsky; Ajit Ghaisas; awt-dev@openjdk.java.net Subject: Review request for JDK-8166015: [PIT][TEST_BUG] stray character in

Re: [9] Review Request for 8041519: JVM crash on second DnD after modal dialog opened during Swing DnD operation

Looks good to me. On 7/17/15 7:27 PM, Semyon Sadetsky wrote: Hello, Please review fix for JDK9: bug: https://bugs.openjdk.java.net/browse/JDK-8041519 webrev: http://cr.openjdk.java.net/~ssadetsky/8041519/webrev.00/ This is regression from JDK-6342381. When a modal dialog blocks drop

Re: Best workaround for OSX Window leak? (JDK-8029147)

Hi, Andy. I suggest to check the latest jdk9 and jdk8. Do you able to reproduce this bug on jdk8u112? On 19.09.16 17:19, Andy Lee wrote: Not sure if this is the best place to ask, but I'm looking for good way to prevent the JFrame/JDialog memory leaks caused by

Re: Best workaround for OSX Window leak? (JDK-8029147)

Yes, I just tried my test case on JDK 8u112 and I can still reproduce the JFrame leak. On Mon, Sep 19, 2016 at 11:26 AM, Sergey Bylokhov < sergey.bylok...@oracle.com> wrote: > Hi, Andy. > I suggest to check the latest jdk9 and jdk8. Do you able to reproduce this > bug on jdk8u112? > > > On

Best workaround for OSX Window leak? (JDK-8029147)

Not sure if this is the best place to ask, but I'm looking for good way to prevent the JFrame/JDialog memory leaks caused by https://bugs.openjdk.java.net/browse/JDK-8029147 The best solution I've found so far is to use reflection to dig in and null out the 'target' fields on the LWComponentPeer

Re: [8u/9] Review request 8156116 : [macosx] two JNI locals to delete in AWTWindow.m, CGraphicsEnv.m

Hi, Anton. Should we backport it to jdk8u? On 20.05.16 12:12, Anton Tarasov wrote: Thank you! Anton. On 18 May 2016, at 18:54, Alexander Zvegintsev wrote: Looks fine to me too. Thanks, Alexander. On 05/17/2016 06:36 PM, Anton Tarasov wrote: Would

Re: Best workaround for OSX Window leak? (JDK-8029147)

In JDK 9 the problem seems to be partially fixed; only the most recently closed JFrame leaks (ie, a temporary leak). I was unable to get Visual VM to connect to the Java 9 process so I'm not exactly sure what was preventing the last JFrame from being GC'd. The Java 9 behavior would be sufficient

Re: Best workaround for OSX Window leak? (JDK-8029147)

On 19.09.16 19:13, Andy Lee wrote: Yes, I just tried my test case on JDK 8u112 and I can still reproduce the JFrame leak. And what about the latest jdk9? https://jdk9.java.net/download On Mon, Sep 19, 2016 at 11:26 AM, Sergey Bylokhov

Re: Best workaround for OSX Window leak? (JDK-8029147)

On 19.09.16 23:02, Andy Lee wrote: In JDK 9 the problem seems to be partially fixed; only the most recently closed JFrame leaks (ie, a temporary leak). I was unable to get Visual VM to connect to the Java 9 process so I'm not exactly sure what was preventing the last JFrame from being GC'd.

Re: [9] Review request for JDK-8165555: [macosx] VM crashes on second attempt to execute JCK interactive tests that use Robot (single JVM, agent)

Hi, Manajit. It seems that after the fix "(CRobotKeyCodeMapping *) sharedInstance" returns the new object per invocation, so it is not really sharedInstance. I am not sure I understand what is wrong in the current code, from the my point of view this is a correct singleton. It it true that

Re: [9] Review request for 8161910: [PIT] regression: HW/LW mixing seems broken on Unity

Looks good to me. On 8/30/16 7:18 PM, Semyon Sadetsky wrote: Sorry for inconvenience, but I have to update this fix once again. http://cr.openjdk.java.net/~ssadetsky/8161910/webrev.02 I have found the main root cause of the issue. In the 8036815 I have missed one insets_corrected = true;