Re: [OpenJDK 2D-Dev] RFR(M): 8170525: Fix minor issues in awt coding

Sorry. it is ops->GetRasInfo(env, ops, lockInfo); that initialises it .. That is still before the dereference Anyway, what was the reason for updating one function, but not the other. I don't mind the change, but the inconsistency looks odd. -phil. On 12/01/2016 03:03 AM, Lindenmaier,

Re: [OpenJDK 2D-Dev] RFR(M): 8170525: Fix minor issues in awt coding

Hi Phil, I added the initialization to the other function. http://cr.openjdk.java.net/~goetz/wr16/8170525-awt-dev/webrev.04/ I missed that because Coverity didn't complain. It's not a perfect tool, but it finds sufficient issues to make it worthwhile. Is the other awt code fine? Best regards,

Re: RFR(M): 8170525: Fix minor issues in awt coding

Hi Christoph, I changed the code in fontpath.c to use snprintf, that seems much better as the concatenated string is a literal anyways. Also, I fixed the spaces. I'll post a new webrev once I'm through all the reviews. Best regards, Goetz. > -Original Message- > From: Langer,

Re: [OpenJDK 2D-Dev] RFR(M): 8170525: Fix minor issues in awt coding

Hi Prasanta, good point, I added that too. Best regards, Goetz. > -Original Message- > From: Prasanta Sadhukhan [mailto:prasanta.sadhuk...@oracle.com] > Sent: Donnerstag, 1. Dezember 2016 06:05 > To: Phil Race ; Sergey Bylokhov > ;

Re: [OpenJDK 2D-Dev] RFR(M): 8170525: Fix minor issues in awt coding

Ah, no, that is just the field that is initialized with the Result of gtk3_get_color_for_flags() why I need to initialize it there. Best regards, Goetz. > -Original Message- > From: Lindenmaier, Goetz > Sent: Donnerstag, 1. Dezember 2016 12:10 > To: 'Prasanta Sadhukhan'