Re: RFR(M): 8185500: [TESTBUG] Add keywords headful/printer in java/awt and javax tests.

2017-08-04 Thread Lindenmaier, Goetz
Hi, I added another approx. 20 tests which are headful but are run only on mac. http://cr.openjdk.java.net/~goetz/wr17/8185500-headlessKey/webrev.01/ Best regards, Goetz. > -Original Message- > From: Lindenmaier, Goetz > Sent: Mittwoch, 2. August 2017 11:13 > To:

Re: [10] Review request for 8177414: Missing key events on Mac Os

2017-08-04 Thread Dmitry Markov
Thank you, Sergey! Looking for the second +1 from someone else. Thanks, Dmitry > On 4 Aug 2017, at 01:07, Sergey Bylokhov wrote: > > Looks fine. > > On 02.08.2017 7:26, Dmitry Markov wrote: >> Hello, >> Could you review a fix for jdk10, please? >>bug:

Re: [10] Review request for 8177414: Missing key events on Mac Os

2017-08-04 Thread Philip Race
Approved. -phil. On 8/4/17, 6:58 AM, Dmitry Markov wrote: Thank you, Sergey! Looking for the second +1 from someone else. Thanks, Dmitry On 4 Aug 2017, at 01:07, Sergey Bylokhov wrote: Looks fine. On 02.08.2017 7:26, Dmitry Markov wrote: Hello, Could you

Re: [10] Review request for JDK-8165863:[macosx] stack overflow in java/awt/Component/SetEnabledPerformance/SetEnabledPerformance.java

2017-08-04 Thread Philip Race
I don't know why but we do have recursion here : at java.awt.AWTEventMulticaster.componentMoved(java.desktop@9ea/AWTEventMulticaster.java:177) at java.awt.AWTEventMulticaster.componentMoved(java.desktop@9ea/AWTEventMulticaster.java:177) at

Re: [10] Review request for JDK-8165863:[macosx] stack overflow in java/awt/Component/SetEnabledPerformance/SetEnabledPerformance.java

2017-08-04 Thread Sergey Bylokhov
Hi, Manajit. The code in the test and the code in the JButton does not have any recursion and use only loops. All buttons itself are stored in the heap not on the stack. Can you please clarify, where in our code the default size of the stack is too small? On 04.08.2017 4:40, Manajit Halder

Re: [10] Review request for 8177414: Missing key events on Mac Os

2017-08-04 Thread Dmitry Markov
Thank you very much, Phil! Regards, Dmitry > On 4 Aug 2017, at 15:00, Philip Race wrote: > > Approved. > > -phil. > > On 8/4/17, 6:58 AM, Dmitry Markov wrote: >> Thank you, Sergey! >> >> Looking for the second +1 from someone else. >> >> Thanks, >> Dmitry >>> On 4