Re: [10] Review request for 8182043: Access to Windows Large Icons

Hi Semyon, ShellFolder2.cpp 944 pIcon->Extract(szBuf, index, , *0*, sz); I think 0 should really be |NULL|. The result of the call is ignored now. Is it intentional? Win32ShellFolder2.java 1010 private static Image makeIcon(long hIcon, int bsize) { |bsize| was called |baseSize| previously,

Re: [10] Review request for 8166772: Touch keyboard is not shown for text components on a screen touch

Hello Sergey, Thank you for clarification. I have just filed a CSR. CSR: https://bugs.openjdk.java.net/browse/JDK-8187970# Thank you, Anton On 25/09/2017 22:48, Sergey Bylokhov wrote: On 9/25/17 11:49, Anton Litvinov wrote: Hello Sergey, Thank you for approval of the fix. Yes, sure, I will

Re: [10] Review request for 8182043: Access to Windows Large Icons

Hi Alexey, On 9/26/2017 12:29 PM, Alexey Ivanov wrote: Hi Semyon, ShellFolder2.cpp 944 pIcon->Extract(szBuf, index, , *0*, sz); I think 0 should really be |NULL|. Ok, but both represent the null pointer in Win32. The result of the call is ignored now. Is it intentional? Yes, it has been

Re: Java 9 on OS X internal API com.apple.eio.FileManager

> On Sep 26, 2017, at 4:22 PM, mandy chung wrote: > > > > On 9/26/17 2:10 PM, Michael Hall wrote: >>> >>> The example below seems to be something that would be better >>> off in java.nio.files and so would not have been appropriate for the >>> desktop JEP and you may

Re: [10] Review request for 8182043: Access to Windows Large Icons

Hi Sergey, On 9/25/2017 1:44 PM, Sergey Bylokhov wrote: On 9/22/17 04:22, Alexey Ivanov wrote: There's no way of knowing in advance. Explorer does not restrict the size of icons (now), it's up to developers of a particular file handler to provide icons. Usually, there's only one icon with

Re: Java 9 on OS X internal API com.apple.eio.FileManager

> On Sep 26, 2017, at 12:20 PM, Phil Race wrote: > > I didn't do the work here so I am answering as best I can. > FileManager is not directly exposed but is used in implementing > a couple of APIs on the java.awt.Desktop class. This will not help developers who used

Re: Java 9 on OS X internal API com.apple.eio.FileManager

On 9/26/17 2:10 PM, Michael Hall wrote: The example below seems to be something that would be better off in java.nio.files and so would not have been appropriate for the desktop JEP and you may want to file an RFE against core-libs/java.nio I would agree this might not be the best fit to

Re: [10] Review request for 8155197: Focus transition issue

Hi Dmitry, On 9/26/2017 1:56 AM, Dmitry Markov wrote: Hi Semyon, Please find my answer inline. Thanks, Dmitry On 25 Sep 2017, at 22:26, Semyon Sadetsky wrote: Hi Dmitry, On 09/25/2017 01:09 PM, Dmitry Markov wrote: Hi Semyon, This issue and the problem

Re: [10] Review request for 8155197: Focus transition issue

Hi Semyon, > On 26 Sep 2017, at 23:46, Semyon Sadetsky wrote: > > Hi Dmitry, > > On 9/26/2017 1:56 AM, Dmitry Markov wrote: >> Hi Semyon, >> >> Please find my answer inline. >> >> Thanks, >> Dmitry >>> On 25 Sep 2017, at 22:26, Semyon Sadetsky

Re: Java 9 on OS X internal API com.apple.eio.FileManager

I didn't do the work here so I am answering as best I can. FileManager is not directly exposed but is used in implementing a couple of APIs on the java.awt.Desktop class. If you think some important use case that is appropriate there is missed then you can file an RFE on that. The example below

Java 9 on OS X internal API com.apple.eio.FileManager

I know JEP 272 covered the com.apple.eawt API’s. Is there nothing to cover the eio.FileManager? I have code using it to try and determine platform specific location’s for files public static Path getFolder(DataTypes option) { File f = null; try {

Re: [10] Review request for 8155197: Focus transition issue

Hi Semyon, Please find my answer inline. Thanks, Dmitry > On 25 Sep 2017, at 22:26, Semyon Sadetsky wrote: > > Hi Dmitry, > > > On 09/25/2017 01:09 PM, Dmitry Markov wrote: >> Hi Semyon, >> >> This issue and the problem addressed by 8139218 and 8159432 are