Changeset: 4eeff1fda9ea
Author:serb
Date: 2011-04-15 16:51 +0400
URL: http://hg.openjdk.java.net/jdk7/awt/jdk/rev/4eeff1fda9ea
6983562: Two java/awt tests failing just on jdk7b108
Reviewed-by: art, denis, dcherepanov
! src/windows/native/sun/windows/awt_Button.cpp
!
Changeset: f05164caa490
Author:serb
Date: 2011-05-30 17:16 +0400
URL: http://hg.openjdk.java.net/jdk7/awt/jdk/rev/f05164caa490
7045193: interactive JCK tests java_awt/interactive/FileDialogTests fail
Reviewed-by: dcherepanov, dav, art, denis
!
Changeset: 6ee24f03760d
Author:serb
Date: 2011-07-15 19:18 +0400
URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/6ee24f03760d
7043679: Wrong class name is used in Java_sun_awt_windows_WPrinterJob_initIDs
Reviewed-by: dav, art
! src/windows/native/sun/windows/awt_PrintJob.cpp
Vote: YES
08.09.2011 20:02, Artem Ananiev wrote:
Hi, awt-dev,
according to the OpenJDK community Bylaws [1], as an AWT group member
I hereby propose to add Oleg Pekhovskiy to the list of group users.
Oleg is a member of AWT engineering group at Oracle and has already
contributed a number
Changeset: 28f768c41a90
Author:serb
Date: 2011-11-12 04:13 +0400
URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/28f768c41a90
6996291: command line selection of MToolkit by
-Dawt.toolkit=sun.awt.motif.MToolkit fails from jdk7 b21 on
Reviewed-by: art, dcherepanov, bae, prr
!
Changeset: 79b5c5a8c7e9
Author:serb
Date: 2011-12-05 17:11 +0400
URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/79b5c5a8c7e9
7115400: jdk 8 awt-gate build fails in headless toolkit on solaris.
Reviewed-by: prr, art, bae
! make/sun/awt/FILES_c_unix.gmk
+
Hi, Anthony.
What happens if small decorated nonresizable window became
resizable(growbox will be shown). As far I understand window should
increase its size? Correct?
15.02.2012 17:15, Anthony Petrov wrote:
Hello,
Please review a fix for http://bugs.sun.com/view_bug.do?bug_id=7124553
at:
Hi Anthony.
probably it would be good to add 2 regression tests for this issue?
1) For the current issue, which wasn't found by the existing tests.
2) For the issue which was not resolved in the current fix.
16.03.2012 19:22, Anthony Petrov wrote:
Hello,
Please review a fix for
for things that should be
improved eventually, so instead I've filed a CR 7155164 to address
this issue later.
--
best regards,
Anthony
On 3/19/2012 4:23 PM, Sergey Bylokhov wrote:
Hi Anthony.
probably it would be good to add 2 regression tests for this issue?
1) For the current issue, which
Hi Everyone,
This is a forward port from jdk 7u4:
http://hg.openjdk.java.net/jdk7u/jdk7u4-dev/jdk/rev/91ede930328c
Deadlock happens when 2 threads lock delegateLock and DefaultCaret
object in different order. Removed code initially was added to stop
recursion between paintPeer and
Hi Everyone,
This is a forward port from jdk 7u4:
hg.openjdk.java.net/jdk7u/jdk7u4-dev/jdk/rev/7816a64158c4
Now we reset selection in text components on focuslost event.
Bug: http://monaco.sfbay.sun.com/detail.jsf?cr=7124528
Webrev can be found at:
Hi, Artem.
AWT tree lock used for locking delegate.
26.03.2012 17:37, Artem Ananiev wrote:
Hi, Sergey,
On 3/22/2012 6:05 PM, Sergey Bylokhov wrote:
Hi Everyone,
This is a forward port from jdk 7u4:
http://hg.openjdk.java.net/jdk7u/jdk7u4-dev/jdk/rev/91ede930328c
Deadlock happens when 2
Hi Everyone,
We should check container status before we set status of the component.
This check was done during initialization before, it was moved to
setEnabled() method.
Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7097771
Webrev can be found at:
Hi Artem.
Done.
26.03.2012 19:26, Artem Ananiev написал:
On 3/26/2012 5:37 PM, Sergey Bylokhov wrote:
Hi, Artem.
AWT tree lock used for locking delegate.
Ah, right, I was confused by the method name, getDelegateLock()... OK,
could you add some information to the bug, please? Right now
Hi Everyone,
We should accept empty KeyEquivalent in case of shortcut removing.
Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7124551
Webrev can be found at: http://cr.openjdk.java.net/~serb/7124551/webrev.00/
--
Best regards, Sergey.
Hi Everyone,
This is a forward port from jdk 7u4:
http://hg.openjdk.java.net/jdk7u/jdk7u4-dev/jdk/rev/fab57f1dc2aa
The general bug is that we repaint native part of the LWPanelPeer after
UPDATE event. This is not mac specific bug, because we do the same
things on XToolkit too. But this demo
Hi Everyone,
Two issues resolved:
1) We should set caret position before the text selection.
2) On macosx we clear selection when the test component lost its focus,
so test was simplified and instructions dialog was removed (because
sometimes it steal the focus from the text component)
Bug:
Hi Mike.
28.03.2012 20:18, Mike Swingler wrote:
Does this change the behavior of where the cursor ends up if you press
the left or right keys while there is a selection? We get this wrong
in Java SE 6, and I was wondering if this corrects that behavior.
Regards, Mike Swingler Apple Inc.
No.
Changeset: 74a1284ca75a
Author:serb
Date: 2012-03-29 17:31 +0400
URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/74a1284ca75a
7124551: [macosx] Once added, Menu shortcut cannot be removed
Reviewed-by: art, anthony
! src/macosx/native/sun/awt/CMenuItem.m
Hi Everyone,
We should accept empty KeyEquivalent in case of shortcut removing.
This is a back port from jdk 8:
http://hg.openjdk.java.net/jdk8/awt/jdk/rev/74a1284ca75a
Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7124551
Webrev can be found at:
Hi Everyone,
On the latest version the dispose works as expected, but the test
expects that the window will be fully red. But it is not true on the mac
because of resizegrowboxwindow. Testcase updated.
Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7124401
Webrev can be found at:
Hi Everyone,
In the fix doPrivileged was added to Dialog.show().
Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7080109
Webrev can be found at: http://cr.openjdk.java.net/~serb/7080109/webrev.00/
--
Best regards, Sergey.
Hi Everyone,
A subcomponents may want to override the cursor over some of their
parts(LWTextAreaPeer changes the cursor over scrollbars).
Changes description:
1. LWComponentPeer.java:
- Just one method added getCursor();
2. LWCursorManager.java:
- updateCursorImpl now use
Hi Everyone,
See comments from the bug description:
/1. The image in Standard frame is not painted, until the frame is
[manually] resized./
Fixed: Observer was added to the drawImage().
/ 2. Test instructions should be corrected to have an explicit statement
about components layout.
Hi Everyone,
This testcase was targeted to the bug in metal and motif lf.
Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7124534
Webrev can be found at: http://cr.openjdk.java.net/~serb/7124534/webrev.00/
Webrev against closed part:
Changeset: 933ea89bec06
Author:serb
Date: 2012-04-05 18:27 +0400
URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/933ea89bec06
7150105: [macosx] four scroll-buttons don't display. scroll-sliders cursors are
TextCursor.
Reviewed-by: anthony, art, alexp
!
Changeset: 14646df8f386
Author:serb
Date: 2012-04-05 19:01 +0400
URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/14646df8f386
7124401: [macosx] After call Frame dispose() application continues to work
Reviewed-by: art, alexp
!
Changeset: 004d53e61c3b
Author:serb
Date: 2012-04-05 19:43 +0400
URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/004d53e61c3b
7124528: [macosx] Selection is not cleared properly in text component.
Reviewed-by: anthony, art
! src/macosx/classes/sun/lwawt/LWTextFieldPeer.java
Changeset: dc0d4cf71dfb
Author:serb
Date: 2012-04-05 20:38 +0400
URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/dc0d4cf71dfb
7125657: [macosx] SpreadSheet demo has the broken display when clicking outside
of the table.
Reviewed-by: alexp, anthony, art
!
05.04.2012 14:53, Artem Ananiev написал:
Hi, Sergey,
On 3/28/2012 8:05 PM, Sergey Bylokhov wrote:
Hi Everyone,
Two issues resolved:
1) We should set caret position before the text selection.
it's not clear why this particular change fixes the selection. Could
you add more comments
Hi Everyone,
Cursor for blocked window was fixed. Now we use default cursor in this case.
Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7147055
Webrev can be found at: http://cr.openjdk.java.net/~serb/7147055/webrev.00
--
Best regards, Sergey.
Changeset: 33c604bf074f
Author:serb
Date: 2012-04-10 22:09 +0400
URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/33c604bf074f
7097771: setEnabled does not work for components in disabled containers.
Reviewed-by: art, anthony
! src/solaris/classes/sun/awt/X11/XComponentPeer.java
+
Hi Everyone,
This is a port of 7155298 to macosx.
Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7160623
Webrev can be found at: http://cr.openjdk.java.net/~serb/7160623/webrev.00
Discussion about xawt fix:
http://mail.openjdk.java.net/pipermail/awt-dev/2012-March/002381.html
--
(
cond, modalFilter, 0);
}
}
);
if (!secondaryLoop.enter()) {
secondaryLoop = null;
}
Thanks,
Artem
On 3/30/2012 8:22 PM, Sergey Bylokhov wrote:
Hi Everyone,
In the fix doPrivileged was added to Dialog.show().
Bug: http://bugs.sun.com/bugdatabase
Hi, Alexander.
Fix looks good.
16.04.2012 22:12, Alexander Zuev wrote
Hello,
please review my fix for CR 7161109: [macosx] JCK AWT interactive
test DnDTextDropTest fails on MacOS
The fix is just a forward-port of fix for CR 7124262 which was not
synced up into jdk8 workspace.
Bug
of TextArea that consists of 10
rows by 60 columns. What did you mean then?
Thanks,
On 4/16/2012 6:50 PM, Sergey Bylokhov wrote:
Hi Everyone,
LWScrollPanePeer.getMinimumSize() on macosx should work in the same
way, as on other platforms.
Bug: http://bugs.sun.com/bugdatabase/view_bug.do
Hi Everybody.
Looks like on the server we still use jcheck without fix for Objective-C
files? Does anybody know how to apply the fix to jdk8? (see attachment)
[jdk]
pulling from http://hg.openjdk.java.net/jdk8/awt/jdk
searching for changes
adding changesets
adding manifests
adding file changes
Hi Everyone.
Does anybody has a chance to review the fix? One more reviewer needed.
Thanks.
09.04.2012 19:57, Sergey Bylokhov wrote:
Hi Everyone,
Cursor for blocked window was fixed. Now we use default cursor in this
case.
Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7147055
Hi Everyone.
Artem thanks for review. Does anybody has a chance to review the fix?
One more reviewer needed.
Thanks.
16.04.2012 21:00, Sergey Bylokhov wrote:
Hi, Artem.
Thanks for view.
Scope was changed. Here is an updated version:
http://cr.openjdk.java.net/~serb/7080109/webrev.01
Changeset: 0feee4541f67
Author:serb
Date: 2012-05-04 21:25 +0400
URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/0feee4541f67
7147055: [macosx] Cursors are changing over a blocked window; also blinking
Reviewed-by: art, kizune
! src/macosx/classes/sun/lwawt/LWCursorManager.java
Hi, Alexandr.
In this fix fileDialog variable was deleted from the Notepad.java. But
it is used in Stylepad demo. So now full jdk build failed with error:
C:\moe\workspaces\jdk\8\awt-mix\build\windows-i586\democlasses\demo\jfc\Stylepad\src\Stylepad.java:249:
error: cannot find symbol
Changeset: 912e666b4e1d
Author:serb
Date: 2012-05-10 20:05 +0400
URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/912e666b4e1d
7080109: Dialog.show() lacks doPrivileged() to access system event queue
Reviewed-by: art, anthony
! src/share/classes/java/awt/Dialog.java
+
Hi, Anthony.
Fix looks good.
11.05.2012 19:55, Anthony Petrov wrote:
Hello,
This is a backport of exactly the same fix from JDK 8.
Bug: http://bugs.sun.com/view_bug.do?bug_id=7166437
Fix: http://cr.openjdk.java.net/~anthony/7u6-8-UTILITY-7166437.0/
--
best regards,
Anthony
Hi Everyone,
This is a back port from jdk 8 to jdk 7u6.
In the fix doPrivileged was added to Dialog.show().
Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7080109
Webrev can be found at: http://cr.openjdk.java.net/~serb/7080109/webrev.01
jdk8 changeset:
Hi Everyone,
This is a back port from jdk 8 to jdk 7u6.
In the fix doPrivileged was added to Dialog.show().
Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7080109
Webrev can be found at: http://cr.openjdk.java.net/~serb/7080109/webrev.01
jdk8 changeset:
Thanks, Anthony.
Does anybody has a chance to review the fix? One more reviewer needed.
04.05.2012 16:09, Anthony Petrov wrote:
The fix still looks fine.
--
best regards,
Anthony
On 5/3/2012 7:16 PM, Sergey Bylokhov wrote:
Hi Everyone,
This is a back port from jdk 8 to jdk 7u6.
Bug: http
Hi, Jonathan,
Fix looks good. But I guess this bug was not caught by the regression
tests, so new test should be added(automatic test is better).
23.05.2012 14:15, Jonathan Lu wrote:
Hi Sergey,
On 05/22/2012 10:23 PM, Sergey Bylokhov wrote:
Hi, Jonathan,
Looks like this bug is duplicate
Hi, Denis.
I guess that copyright header should be added.
31.05.2012 14:59, Denis S. Fokin wrote:
Hi,
could you take a look at the next fix. I have moved the test from the
closed repository and changed
Util.blockTillDisplayed(spinner2);
to
31.05.2012 16:49, Sergey Bylokhov wrote:
Hi, Denis.
I guess that copyright header should be added.
And probably it should be fixed in 8 first?
31.05.2012 14:59, Denis S. Fokin wrote:
Hi,
could you take a look at the next fix. I have moved the test from the
closed repository and changed
Hi Everyone,
Please review the fix.
Notes from the bug and comments:
1. setVisible() should be called at the end of the peers initialization.
We can move super.initialize() to the end of the peers initializations.
Initialize() was split to initialize() and initializeImpl(). In the
initialize()
Hi, Denis.
Fix looks good.
01.06.2012 15:12, Denis S. Fokin wrote:
Hi Artem, Sergey,
to make thins simpler I have just added 'throws' clause to methods
signatures. This way any problem should lead to a test failure.
http://cr.openjdk.java.net/~denis/7112115/webrev.05
Thank you,
Denis.
Hi, Denis.
Fix looks good.
01.06.2012 17:11, Denis S. Fokin wrote:
Hi,
This is a direct backport of the next change-set from jdk 8 into jdk 7u6
http://hg.openjdk.java.net/jdk8/awt-gate/jdk/rev/fd27852f3ea5
Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7112115
Thank you,
Denis.
Fix looks good.
Thanks.
04.06.2012 18:48, Anthony Petrov wrote:
AWT/MacOSX-port-dev teams,
Could I get a review for this one-line fix please?
--
best regards,
Anthony
On 06/01/12 12:47, Henri Gomez wrote:
Tested and it works for me.
I just produced jdk7u b12 with it :
Hi Everyone,
Please review the fix.
Shaped window was implemented as a translucent window with constrained
graphics. Now translucent window doesn't use separate BufferedImage as a
back buffer. Also alpha value for the swing back buffer was
enabled(Shared code changed).
Note that shaped
Hi, Anthony.
Fix looks good.
05.06.2012 15:40, Anthony Petrov wrote:
Hi Artem and Sergey,
Please review a direct back-port of this one-line fix for
http://bugs.sun.com/view_bug.do?bug_id=7172722 at:
http://cr.openjdk.java.net/~anthony/7u6-11-MacUniversalBuild-7172722.0/
The fix has been
painting.
Is the lag so very noticeable? On other platforms we don't actually do
this, and I don't recall any issues about such lags.
Yes The difference is noticeable. So I update the comments and leave it
as is for now.
--
best regards,
Anthony
On 5/31/2012 5:43 PM, Sergey Bylokhov wrote:
Hi
such lags.
--
best regards,
Anthony
On 5/31/2012 5:43 PM, Sergey Bylokhov wrote:
Hi Everyone,
Please review the fix.
Notes from the bug and comments:
1. setVisible() should be called at the end of the peers
initialization. We can move super.initialize() to the end of the
peers initializations
regards,
Anthony
On 6/4/2012 7:49 PM, Sergey Bylokhov wrote:
Hi Everyone,
Please review the fix.
Shaped window was implemented as a translucent window with
constrained graphics. Now translucent window doesn't use separate
BufferedImage as a back buffer. Also alpha value for the swing back
Hi Alexander.
Fix looks good to me.
23.05.2012 14:34, Alexander Scherbatiy wrote:
Could one more person review the fix? I need at least two reviewers
before pushing it.
Thanks,
Alexandr.
On 4/26/2012 2:03 PM, Alexander Scherbatiy wrote:
Could someone else review the fix? I
Hi, Anthony.
yes I will make the new version soon.
09.06.2012 17:15, Anthony Petrov wrote:
Thanks for the comments. Will there be an updated version of the fix?
--
best regards,
Anthony
On 6/5/2012 10:25 PM, Sergey Bylokhov wrote:
05.06.2012 19:05, Anthony Petrov написал:
Hi Sergey
Hi Anthony.
See my comments inline:
09.06.2012 17:34, Anthony Petrov wrote:
Hi Sergey,
Thanks for clarifications. Please find my comments below.
On 6/5/2012 8:13 PM, Sergey Bylokhov wrote:
3. src/macosx/classes/sun/lwawt/LWWindowPeer.java
179 updateInsets(platformWindow.getInsets
Hi Everyone,
This is a back port from jdk 8 to jdk 7u6.
Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7147055
Webrev can be found at: http://cr.openjdk.java.net/~serb/7147055/webrev.00/
jdk8 changeset: hg.openjdk.java.net/jdk8/awt/jdk/rev/0feee4541f67
--
Best regards, Sergey.
Hi Everyone,
This is a back port from jdk 8 to jdk 7u6.
Review:
http://mail.openjdk.java.net/pipermail/awt-dev/2012-April/002502.html
Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7150105
Webrev can be found at: http://cr.openjdk.java.net/~serb/7150105/webrev.00/
jdk8 changeset:
Thanks, Anthony.
Does anybody has a chance to review it?
On 18.06.2012 19:11, Anthony Petrov wrote:
Looks good.
--
best regards,
Anthony
On 06/15/12 15:40, Sergey Bylokhov wrote:
Hi Everyone,
This is a back port from jdk 8 to jdk 7u6.
Review:
http://mail.openjdk.java.net/pipermail/awt-dev
, Sergey Bylokhov wrote:
Hi Everyone,
Please review the fix.
Notes from the bug and comments:
1. setVisible() should be called at the end of the peers initialization.
We can move super.initialize() to the end of the peers initializations.
Initialize() was split to initialize() and initializeImpl
isSwingBackbufferTranslucencySupported() to
return different values, it would be fine to call it only once to
avoid possible perf regressions.
done.
Thanks,
Artem
On 6/4/2012 7:49 PM, Sergey Bylokhov wrote:
Hi Everyone,
Please review the fix.
Shaped window was implemented as a translucent window with constrained
.
The same comment applies to the lines 1510-1513.
fixed
--
best regards,
Anthony
On 06/25/12 14:42, Sergey Bylokhov wrote:
Hi, Artem, Anthony.
New version of the fix:
http://cr.openjdk.java.net/~serb/7124244/webrev.01
13.06.2012 06:30, Artem Ananiev wrote:
Hi, Sergey,
a few minor comments:
1
, but nothing prevents users from calling this method
directly), so it should be stored as a copy, not as a reference.
done
Thanks,
Artem
On 6/25/2012 2:42 PM, Sergey Bylokhov wrote:
Hi, Artem, Anthony.
New version of the fix:
http://cr.openjdk.java.net/~serb/7124244/webrev.01
13.06.2012 06:30, Artem
Changeset: 7d1eae258183
Author:serb
Date: 2012-06-26 13:46 +0400
URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/7d1eae258183
7142091: [macosx] RFE: Refactoring of peer initialization/disposing
Reviewed-by: anthony, art
! src/macosx/classes/sun/lwawt/LWButtonPeer.java
!
Hi Everyone,
Please review the fix.
Notes from the bug and comments:
1. setVisible() should be called at the end of the peers initialization.
We can move super.initialize() to the end of the peers initializations.
Initialize() was split to initialize() and initializeImpl(). In the
initialize()
(right now it's constructed from Shape in AWT
internal code, but nothing prevents users from calling this method
directly), so it should be stored as a copy, not as a reference.
Thanks,
Artem
On 6/25/2012 2:42 PM, Sergey Bylokhov wrote:
Hi, Artem, Anthony.
New version of the fix:
http
Changeset: f1a90ee31b38
Author:serb
Date: 2012-07-04 14:38 +0400
URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/f1a90ee31b38
7124244: [macosx] Shaped windows support
Reviewed-by: anthony, art
! src/macosx/classes/sun/java2d/opengl/CGLLayer.java
!
wrote:
Hi Sergey,
Thanks for the review.
On 7/4/2012 7:07 PM, Sergey Bylokhov wrote:
Why there are two different methods for isZoomed?
481 final boolean isZoomed = *this.normalBounds == null*;
Here we determine a new state that needs to be set to an undecorated
window
, Anthony Petrov wrote:
Hi Sergey,
Thanks for the review.
On 7/4/2012 7:07 PM, Sergey Bylokhov wrote:
Why there are two different methods for isZoomed?
481 final boolean isZoomed = *this.normalBounds == null*;
Here we determine a new state that needs to be set to an undecorated
window
Hi, Anthony.
Fix looks good.
06.07.2012 15:23, Anthony Petrov wrote:
Hi Sergey,
Please review a fix for http://bugs.sun.com/view_bug.do?bug_id=7177173
at:
http://cr.openjdk.java.net/~anthony/7u6-17-MaximizedBoth-7177173.0/
This is a 100% direct back-port of the same fix from JDK 8.
--
Hi Everyone,
Please review the fix. This is a direct backport from JDK 8 to 7u6.
Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7124244
Webrev can be found at: http://cr.openjdk.java.net/~serb/7124244/webrev.04/
jdk8 changeset: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/f1a90ee31b38
Hi Everyone,
Please review the fix. This is a direct backport from JDK 8 to 7u6.
Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7124513
Webrev can be found at: http://cr.openjdk.java.net/~serb/7124513/webrev.01
jdk8 changeset: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/80c592c9458e
--
Hi, Anthony.
Fix looks good.
10.07.2012 13:52, Anthony Petrov wrote:
Hi Sergey and Oleg,
Please review a fix for http://bugs.sun.com/view_bug.do?bug_id=7162144
at:
http://cr.openjdk.java.net/~anthony/7u6-16-missingAWTThread-7162144.0/
Notes:
1. To prevent a hang, invokeAndWait() will
Hi Everyone,
Please review the fix.
Bug in SwingUtilities.convertMouseEvent().This method does not convert
extended state of the event.
Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7170657
Webrev can be found at: http://cr.openjdk.java.net/~serb/7170657/webrev.00
--
Best regards,
Hi, Pavel.
Thanks for review. See comments inline
12.07.2012 20:26, Pavel Porvatov wrote:
Hi Sergey,
The fix looks good. Could you please remove unnecessary code from the
test like:
1. @run main/othervm bug7170657
done
2. The FAILED field: you can throw exception from the fail method
In
Hi, Alexander.
Can we remove these checks from the peers and move them to
TextComponent.setText()?
20.07.2012 17:05, Alexander Scherbatiy wrote:
bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7184365
webrev: http://cr.openjdk.java.net/~alexsch/7184365/webrev.00/
The failed test
Thanks! Phil
20.07.2012 21:15, Phil Race wrote:
Looks ok to me ..
-phil.
On 7/20/2012 10:05 AM, Sergey Bylokhov wrote:
I need one more reviewer.
Artem thanks.
20.07.2012 19:56, Artem Ananiev wrote:
Sergey,
the fix looks good.
Thanks,
Artem
On 7/20/2012 3:24 PM, Sergey Bylokhov wrote
Hi, Alexander.
Does we get correct text in the textfield in the testcase from the
CR(printAll)?
23.07.2012 14:14, Alexander Scherbatiy wrote:
Please review the fix:
bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7185512
webrev: http://cr.openjdk.java.net/~alexsch/7185512/webrev.00/
Fix looks good.
23.07.2012 16:57, Alexander Scherbatiy wrote:
On 7/23/2012 2:29 PM, Sergey Bylokhov wrote:
Hi, Alexander.
Does we get correct text in the textfield in the testcase from the
CR(printAll)?
I think it can be treated as a separated issue that the RICHEDIT
control
Hi, Alexander.
Fix looks good
23.07.2012 17:28, Alexander Zuev wrote:
On 7/23/12 17:19, Artem Ananiev wrote:
On 7/23/2012 2:53 PM, Alexander Zuev wrote:
Artem,
these native methods should not be called according to the logic of the
class so we shouldn't safeguard them.
Could you elaborate
Hi, Alexander.
Fix looks good.
25.07.2012 18:50, Alexander Scherbatiy wrote:
On 7/24/2012 4:32 PM, Sergey Bylokhov wrote:
Hi, Alexander.
A few comments:
- LWTextComponentPeer.setText can be final now.
- Behavior of TextComponent.setText(null) getText() were changed
for null values if peer
Hi, Alexander.
Probably all this stuff can be simplified? Can you try to change
TrackingRect to TrackingArea with appropriate flags like
NSTrackingEnabledDuringMouseDrag etc.
07.08.2012 15:17, Alexander Scherbatiy wrote:
bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7171045
Hi Everyone,
Please review the fix.
When we translate calls from our swing menu components to awt peer we
resets information about shortcut in the setLabel().
This happens because of ScreenMenuItem.setAccelerator() method call
peers setLabel(..,..,..) directly and does not initialize
Hi Everyone,
Please review the fix.
We should support apple.awt.fileDialogForDirectories
Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7161437
Webrev can be found at: http://cr.openjdk.java.net/~serb/7161437/webrev.00/
Fix was contributed-by: Marco Dinacci
Discussion here:
10.08.2012 16:26, Alexander Zuev wrote:
Hello,
please review my fix for CR 7177144: [macosx] Drag and drop not
working (regression in 7u6)
I still tink we shouldn't move the instanceof check to the earlier
stage since this check may be costly
so it should not be performed unless other
Changeset: b41845694f39
Author:serb
Date: 2012-08-13 17:43 +0400
URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/b41845694f39
7161437: [macosx] awt.FileDialog doesn't respond appropriately for mac when
selecting folders
Reviewed-by: art, anthony
Contributed-by: Marco Dinacci
Hi, Alexander.
Fix looks good.
13.08.2012 18:28, Alexander Zuev wrote:
Well, it works this way too and fix is much more compact so here it is
- a new version available at
http://cr.openjdk.java.net/~kizune/7177144/webrev.03
WBR,
Alex
On 8/10/12 19:41, Artem Ananiev wrote:
Hi, Alex,
what
Thanks Leonid.
Does anybody has a chance to review it?
08.08.2012 10:20, Leonid Romanov wrote:
Looks reasonable.
-Original Message-
From: Sergey Bylokhov [mailto:sergey.bylok...@oracle.com]
Sent: Tuesday, August 07, 2012 3:40 PM
To: Leonid Romanov; Mike Swingler; awt-dev
Hi Everyone,
Please review the fix.
Description of main changes:
CPlatformComponent.java:
-Unused peer and target references were removed.
-Wrong return value for nativeSetBounds() was changed from long to
void.
AWTSurfaceLayers.m:
-layer.bounds was replaced by layer.frame, because
Changeset: 65d874d16d59
Author:serb
Date: 2012-08-15 15:02 +0400
URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/65d874d16d59
7172187: [macosx] JAWT native CALayer not positioned over Canvas
Reviewed-by: art, anthony
! src/macosx/classes/sun/lwawt/LWComponentPeer.java
!
Does anybody has a chance to review it?
Thanks.
13.08.2012 19:26, Sergey Bylokhov wrote:
Thanks Leonid.
Does anybody has a chance to review it?
08.08.2012 10:20, Leonid Romanov wrote:
Looks reasonable.
-Original Message-
From: Sergey Bylokhov [mailto:sergey.bylok...@oracle.com]
Sent
Hi,Anthony.
I guess that getMinimumSize() in the setSizeConstraints should be
wrapped with isMinimumSizeSet like it was in LWWindowsPeer, same for
getMaximumSize()
21.08.2012 18:35, Anthony Petrov wrote:
Hi Artem and Sergey,
Please review a fix for
There are no volunteers?
20.08.2012 13:55, Sergey Bylokhov wrote:
Does anybody has a chance to review it?
Thanks.
13.08.2012 19:26, Sergey Bylokhov wrote:
Thanks Leonid.
Does anybody has a chance to review it?
08.08.2012 10:20, Leonid Romanov wrote:
Looks reasonable.
-Original Message
Hi, Alexander.
So NSTrackingCursorUpdate option is not necessary?
27.08.2012 15:29, Alexander Scherbatiy wrote:
On 8/25/2012 12:49 AM, Sergey Bylokhov wrote:
Hi Alexander.
In the fix NSTrackingArea has NSTrackingCursorUpdate option but i did
not see cursorUpdate: method. Probably we can get
Hi Everybody.
Looks like on the server we still use jcheck without fix for Objective-C
files? Does anybody know how to apply the fix to jdk8? (see attachment)
[jdk]
pulling from http://hg.openjdk.java.net/jdk8/awt/jdk
searching for changes
adding changesets
adding manifests
adding file changes
1 - 100 of 2855 matches
Mail list logo
