Sorry for the late follow up. Out last week.
+1 for proposal below.
+0 for getDocumentationAsString()
--
Tom Jordahl
From: keith chapman [mailto:[EMAIL PROTECTED]
Sent: Wednesday, November 07, 2007 12:34 AM
To: axis-dev@ws.apache.org
Subject: Re:
So shall we settle for
public OMNode getDocumentation();
public void setDocumentation(OMNode documentation);
public void setDocumentation(String documentation);
and do we need public String getDocumentationAsString();?
Thanks,
Keith.
On 11/1/07, keith chapman [EMAIL PROTECTED] wrote:
We can
+1 that we'd be making the keep-the-simple-case-simple rule by losing the
String method.
Keith, what's the harm in having two methods? That is, do both.
Sanjiva.
Tom Jordahl wrote:
Removing String as an argument type seems like a bad idea to me for two
reasons:
1. Breaking API
We can have the setter method for both but not the getter.
So we can have
public void setDocumentation(String documentation);
but we cant have
public String getDocumentation(); cause we would already have public OMNode
getDocumentation();
Thanks,
Keith.
On 11/1/07, Sanjiva Weerawarana [EMAIL
Hi Tom,
Yes its not very common to have xml is tour documentation but there are
occations where such information can be helpful. Here is a sample wsdl which
has documentation as XML.
http://mashups.wso2.org/services/nationalgeographic?wsdl2annotation=true If
you look at the source of it you will
BTW I forgot to mention that this site is powered by axis2.
Thanks,
Keith.
On 10/31/07, keith chapman [EMAIL PROTECTED] wrote:
Hi Tom,
Yes its not very common to have xml is tour documentation but there are
occations where such information can be helpful. Here is a sample wsdl which
has
+1.
keith chapman wrote:
Hi Devs,
Currently the method signature for det/get documentation in
AxisDescriptio is as follows.
public String getDocumentation();
public void setDocumentation(String documentation);
As you can see it treats the documentation as a string. There are
Well, +1 except for the fact that you can't overload getDocumentation()
and just change the return type - so there's no way to deprecate that
one without adding another method like getDocumentationOM(). We could
either do that and avoid breaking existing stuff, or just change
+1 for changing getDocumentation to return OMNode (no deprecation, same will
have to go for setDocumentation). Although this is an API method its mostly
used from within for generating the WSDL.
Thanks,
Keith.
On 10/26/07, Glen Daniels [EMAIL PROTECTED] wrote:
Well, +1 except for the fact that
Removing String as an argument type seems like a bad idea to me for two
reasons:
1. Breaking API compatibility, if it is public, is not nice.
2. If I want to put a string there (which I think you are saying goes in
the documentation elements of the WSDL) you are making me create
another
Hi Devs,
Currently the method signature for det/get documentation in AxisDescriptio
is as follows.
public String getDocumentation();
public void setDocumentation(String documentation);
As you can see it treats the documentation as a string. There are occasions
where the documentation
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
+1 from me.
If some one calls the earlier methods, you can serialize the OMNode and
return, which i think is the easier to do.
Chinthaka
keith chapman wrote:
Hi Devs,
Currently the method signature for det/get documentation in
AxisDescriptio
On 10/26/07, Eran Chinthaka [EMAIL PROTECTED] wrote:
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
+1 from me.
If some one calls the earlier methods, you can serialize the OMNode and
return, which i think is the easier to do.
Sure.
Thanks,
Keith.
Chinthaka
keith chapman wrote:
Hi
13 matches
Mail list logo
