Review: Approve
--
https://code.launchpad.net/~bratsche/dbusmenu/fix-autogen/+merge/28200
Your team ayatana-commits is subscribed to branch lp:dbusmenu.
___
Mailing list: https://launchpad.net/~ayatana-commits
Post to :
Review: Approve
--
https://code.launchpad.net/~bratsche/dbusmenu/fix-shortcut-from-gtkmenuitem/+merge/28204
Your team ayatana-commits is subscribed to branch lp:dbusmenu.
___
Mailing list: https://launchpad.net/~ayatana-commits
Post to :
The proposal to merge lp:~bratsche/appmenu-gtk/accelerators into lp:appmenu-gtk
has been updated.
Status: Needs review = Approved
--
https://code.launchpad.net/~bratsche/appmenu-gtk/accelerators/+merge/28205
Your team ayatana-commits is subscribed to branch lp:appmenu-gtk.
Ted Gould has proposed merging lp:~ted/dbusmenu/value-protection into
lp:dbusmenu.
Requested reviews:
DBus Menu Team (dbusmenu-team)
Not a fix, but stops it from crashing.
--
https://code.launchpad.net/~ted/dbusmenu/value-protection/+merge/28234
Your team ayatana-commits is subscribed
The proposal to merge lp:~mterry/dbusmenu/gtk3 into lp:dbusmenu has been
updated.
Status: Needs review = Work in progress
--
https://code.launchpad.net/~mterry/dbusmenu/gtk3/+merge/27992
Your team ayatana-commits is subscribed to branch lp:dbusmenu.
Ted Gould has proposed merging lp:~ted/indicator-appmenu/no-crashing-srsly into
lp:indicator-appmenu.
Requested reviews:
Indicator Applet Developers (indicator-applet-developers)
The most important thing here is setting the private variable. But, there is
some other good protections
Review: Approve
--
https://code.launchpad.net/~ken-vandine/indicator-application/policy-0.0-cil/+merge/28096
Your team ayatana-commits is subscribed to branch lp:indicator-application.
___
Mailing list: https://launchpad.net/~ayatana-commits
Post to
Ted Gould has proposed merging lp:~ted/indicator-appmenu/accelerator-support
into lp:indicator-appmenu.
Requested reviews:
Indicator Applet Developers (indicator-applet-developers)
Adds the indicator side of accelerators. Needs dbusmenu trunk.
--
https://code.launchpad.net/~ted/indicator
Review: Approve
I'm so not going to verify that line by line :)
review approve
--
https://code.launchpad.net/~cjcurran/indicator-sound/tabs_vs_spaces/+merge/27910
Your team ayatana-commits is subscribed to branch lp:indicator-sound.
___
Mailing
On Fri, 2010-06-18 at 07:13 +, David Barth wrote:
Oh the joys of packaging combined with xml!
Just for the record, this isn't packaging related... it's a file used by
the gapi2-parser to generate some of the bindings code.
--
On Fri, 2010-06-18 at 07:09 +, David Barth wrote:
2. If there is a bug to fix, is there a bug report? If there is
an error, is there a test case to show that this fixes the error?
Yes. https://bugs.launchpad.net/indicator-application/+bug/594199
3. is the second g_return_if_fail
Ted Gould has proposed merging lp:~ted/indicator-appmenu/glist-love into
lp:indicator-appmenu.
Requested reviews:
Indicator Applet Developers (indicator-applet-developers)
Reshuffle the switch function to be flatter.
--
https://code.launchpad.net/~ted/indicator-appmenu/glist-love/+merge
Review: Approve
Looks fine to me.
review approve
On Wed, 2010-06-16 at 21:13 +, Cody Russell wrote:
Cody Russell has proposed merging
lp:~bratsche/appmenu-gtk/ubuntu-no-proxy-support into lp:appmenu-gtk.
Requested reviews:
Canonical Desktop Experience Team (canonical-dx-team)
Ted Gould has proposed merging lp:~ted/indicator-appmenu/application-fallback
into lp:indicator-appmenu.
Requested reviews:
Indicator Applet Developers (indicator-applet-developers)
Doesn't do anything super useful. But it puts blank menus in for application
fallback and desktop fallback
Mikkel,
I thought that there was an easy way to get the specific name change in GDBus.
I figured we'd pick up that optimization when we ported from dbus-glib to GDBus.
Ted
--
https://code.launchpad.net/~bratsche/appmenu-gtk/almost-rewrite/+merge/27638
Your team ayatana-commits is subscribed
Ted Gould has proposed merging lp:~ted/indicator-appmenu/remove-people into
lp:indicator-appmenu.
Requested reviews:
Indicator Applet Developers (indicator-applet-developers)
Track when people go away and remove their menus.
--
https://code.launchpad.net/~ted/indicator-appmenu/remove-people
On Wed, 2010-06-09 at 12:28 +0800, Sam Spilsbury wrote:
On Wed, 2010-06-09 at 10:18 +0800, Sam Spilsbury wrote:
As far as I know, with martin's NETWM idea to have the decorator paint
the behind of the window, this basically means that the window can
be reparented at 0x0 in the decoration,
On Wed, 2010-06-09 at 00:45 -0400, Scott Kitterman wrote:
On Tue, 2010-06-08 at 18:41 +0200, Martin Gräßlin wrote:
As mentioned in my open letter: I want to help you. I am willing to spend
my
time and expertise on this issue to ensure that we don't end with an
utterly
broken CSD
On Mon, 2010-06-07 at 15:01 -0400, Scott Kitterman wrote:
Without CSD there is nothing to fix. I'd prefer not breaking things in the
first place and that's one small point. I still don't know what you want out
of CSD the merits all the work to patch apps back into the consistency we
Ted Gould has proposed merging lp:~ted/dbusmenu/submenu-marking into
lp:dbusmenu.
Requested reviews:
DBus Menu Team (dbusmenu-team)
Adding submenu attribute support.
--
https://code.launchpad.net/~ted/dbusmenu/submenu-marking/+merge/27083
Your team ayatana-commits is subscribed to branch
Ted Gould has proposed merging lp:~ted/indicator-appmenu/hiding-entries into
lp:indicator-appmenu.
Requested reviews:
Indicator Applet Developers (indicator-applet-developers)
Support for visibility and enabled properties for items on the main menubar.
--
https://code.launchpad.net/~ted
On Mon, 2010-06-07 at 03:25 -0400, Scott Kitterman wrote:
On Sunday, June 06, 2010 03:39:40 pm Ted Gould wrote:
On Sat, 2010-06-05 at 23:31 -0400, Scott Kitterman wrote:
So I think it's worth continuing the conversation. I'm personally quite
concerned that we are about to have
On Mon, 2010-06-07 at 18:09 +0200, Martin Gräßlin wrote:
Am Montag 07 Juni 2010, 17:11:32 schrieb Ted Gould:
Sure, but I think that implies that the change doesn't create a
permanent split more a temporary split. There's no reason that Qt
couldn't support CSD and I imagine
On Mon, 2010-06-07 at 13:50 -0400, Scott Kitterman wrote:
It's lack of integration with my desktop is one of my two major dislikes I
have for with Chromium. I completely agree that better integration is
important, I don't see how it relates to a requirement for CSD. I think
window
On Mon, 2010-06-07 at 14:09 -0400, Scott Kitterman wrote:
In plasma-netbook, we use a Kwin theme that does not include the application
control buttons and embed them in and application control widget in the
autohide panel to save vertical space. Currently this works for both KDE and
Gnome
Review: Approve
--
https://code.launchpad.net/~bratsche/appmenu-gtk/display-both/+merge/26954
Your team ayatana-commits is subscribed to branch lp:appmenu-gtk.
___
Mailing list: https://launchpad.net/~ayatana-commits
Post to :
On Sat, 2010-06-05 at 23:31 -0400, Scott Kitterman wrote:
So I think it's worth continuing the conversation. I'm personally quite
concerned that we are about to have a permanent split between GTK/Gnome and
Qt/KDE on this topic that will make future work on desktop consistency much
more
Ted Gould has proposed merging lp:~ted/indicator-appmenu/bamf-it into
lp:indicator-appmenu.
Requested reviews:
Indicator Applet Developers (indicator-applet-developers)
Basic application switching support. Still doesn't detect applications
leaving, but does switch between them. Also
The proposal to merge lp:~ted/indicator-appmenu/debug-interface into
lp:indicator-appmenu has been updated.
Status: Needs review = Superseded
--
https://code.launchpad.net/~ted/indicator-appmenu/debug-interface/+merge/26626
Your team ayatana-commits is subscribed to branch
Ted Gould has proposed merging lp:~ted/indicator-appmenu/debug-interface into
lp:indicator-appmenu.
Requested reviews:
Indicator Applet Developers (indicator-applet-developers)
A little debug interface for getting the current menu. Also adding some
small scripts to get it, and pass
Review: Approve
--
https://code.launchpad.net/~bratsche/appmenu-gtk/window-registration/+merge/26547
Your team ayatana-commits is subscribed to branch lp:appmenu-gtk.
___
Mailing list: https://launchpad.net/~ayatana-commits
Post to :
Review: Approve
Looks good to me!
review approve
On Sun, 2010-05-23 at 10:48 +, Sense Hofstede wrote:
Sense Hofstede has proposed merging
lp:~qense/indicator-application/doc-intro-fixes into lp:indicator-application.
Requested reviews:
Indicator Applet Developers
Ted Gould has proposed merging
lp:~ted/indicator-applet/hide-when-everythings-gone into lp:indicator-applet.
Requested reviews:
Indicator Applet Developers (indicator-applet-developers)
Making it so the menu items hide and show based on the indicators
themselves.
--
https
Does the allocated memory passed to menu_child_realized() ever get freed? It
doesn't look like it is.
Nope, wasn't. Fixed r29
--
https://code.launchpad.net/~ted/indicator-appmenu/base-on-client/+merge/26196
Your team ayatana-commits is subscribed to branch lp:indicator-appmenu.
Ted Gould has proposed merging lp:~ted/dbusmenu/fix-vapi-files into lp:dbusmenu.
Requested reviews:
DBus Menu Team (dbusmenu-team)
Fixing the VAPI files for Conor
--
https://code.launchpad.net/~ted/dbusmenu/fix-vapi-files/+merge/25700
Your team ayatana-commits is subscribed to branch
On Tue, 2010-05-18 at 09:54 -0600, Jeremy Nickurak wrote:
If the messaging menu, and other indicator features are to be
supported by upstream, I believe we need to reduce the barrier of
adoption. If gnome-shell, kde, xfce, and every other random
window-manager/desktop-environment (which almost
On Mon, 2010-05-17 at 11:57 -0600, Jeremy Nickurak wrote:
On Thu, May 13, 2010 at 05:17, Mark Shuttleworth m...@ubuntu.com
wrote:
The apps should always degrade to older / alternative
behaviours. It's a
bug if they don't, and I'm sorry if the Empathy case was badly
On Mon, 2010-05-17 at 15:51 -0600, Jeremy Nickurak wrote:
On Mon, May 17, 2010 at 15:31, Ted Gould t...@ubuntu.com wrote:
With Application Indicators we manage the fallback into the
notification area by default, so application developers don't
need to worry about
On Wed, 2010-05-12 at 15:41 -0600, Jeremy Nickurak wrote:
On Wed, May 12, 2010 at 15:39, Ted Gould t...@ubuntu.com wrote:
It should. The problem you're probably seeing is that we
don't have the
service die when you remove the applet. It's wired in, but we
Ted Gould has proposed merging lp:~ted/indicator-appmenu/qt-integration-fixes
into lp:indicator-appmenu with lp:~ted/indicator-appmenu/ordering as a
prerequisite.
Requested reviews:
Indicator Applet Developers (indicator-applet-developers)
Increasing timeouts and having mneumonics for QT
Ted Gould has proposed merging lp:~ted/dbusmenu/reject-text-nodes into
lp:dbusmenu.
Requested reviews:
DBus Menu Team (dbusmenu-team)
Check to make sure they're real nodes before parsing more.
--
https://code.launchpad.net/~ted/dbusmenu/reject-text-nodes/+merge/24955
Your team ayatana
Ted Gould has proposed merging lp:~ted/libindicate/vapi-and-friends into
lp:libindicate.
Requested reviews:
Indicator Applet Developers (indicator-applet-developers)
Build the VAPI files for Conor.
--
https://code.launchpad.net/~ted/libindicate/vapi-and-friends/+merge/24599
Your team
Ted Gould has proposed merging lp:~ted/indicator-applet/window-menus into
lp:indicator-applet.
Requested reviews:
Indicator Applet Developers (indicator-applet-developers)
Adds a new build target for the appmenu indicator.
--
https://code.launchpad.net/~ted/indicator-applet/window-menus
Review: Approve
review approve
On Wed, 2010-04-28 at 10:36 +, Kees Cook wrote:
Kees Cook has proposed merging lp:~kees/indicator-messages/trunk-lp-533021
into lp:indicator-messages.
Requested reviews:
Indicator Applet Developers (indicator-applet-developers)
Related bugs:
On Tue, 2010-04-27 at 17:52 +0200, Johan Euphrosine wrote:
I was wondering if Ubuntu design team would consider using this kind
of tools to crowdsource user interface testing:
http://fivesecondtest.com/
That's pretty neat actually. Very simple idea. We need to build that
in to Launchpad.
Hello Ayatana,
So as Lucid winds down and UDS is coming like a freight train I thought
it would be a good time to start looking at would could be done in the
Maverick cycle for application indicators. Here are some of the design
issues that I see have come up in the Lucid cycle that I think need
On Mon, 2010-04-26 at 13:57 -0500, Scott Kitterman wrote:
David Siegel david.sie...@canonical.com wrote:
What does this have to do with the notification area changes? Please
continue this conversation elsewhere if you must. Let's all do our
part to keep Ayatana discussions on track.
I guess
On Tue, 2010-04-27 at 04:54 +0800, Chow Loong Jin wrote:
On Tuesday 27,April,2010 03:48 AM, Ted Gould wrote:
For application indicators we're currently only taking icon names for
the icons. This allows for consistent theming of the icons along with
the panel theme. The problem
Review: Approve
review approve
On Thu, 2010-04-22 at 18:30 +, Conor Curran wrote:
Conor Curran has proposed merging
lp:~cjcurran/indicator-sound/volume_setting_code_refactor into
lp:indicator-sound.
Requested reviews:
Indicator Applet Developers (indicator-applet-developers)
Ted Gould has proposed merging lp:~ted/dbusmenu/extra-references-track into
lp:dbusmenu.
Requested reviews:
DBus Menu Team (dbusmenu-team)
Extra refs. There were some extra refs, and cleaning up those exposed
situations where they were holding the fort down. Basically the async
property
Review: Approve
Looks good!
review approve
--
https://code.launchpad.net/~keturn/indicator-applet/cleanup-gcc-warnings/+merge/23579
Your team ayatana-commits is subscribed to branch lp:indicator-applet.
___
Mailing list:
Ted Gould has proposed merging lp:~ted/indicator-messages/eclipse-on-desktop
into lp:indicator-messages.
Requested reviews:
Indicator Applet Developers (indicator-applet-developers)
Make it so that when a desktop file is parsed we check to see if it's
eclipsed by a running application
Ted Gould has proposed merging lp:~ted/dbusmenu/ordering-issues-again into
lp:dbusmenu.
Requested reviews:
DBus Menu Team (dbusmenu-team)
Most importantly this makes it so the GTK layer uses the realized count for
positioning the menu items instead of the absolute count to remove race
Ted Gould has proposed merging lp:~ted/indicator-session/bug543393 into
lp:indicator-session.
Requested reviews:
Indicator Applet Developers (indicator-applet-developers)
Related bugs:
#543393 indicator-session-service crashed with SIGSEGV in
g_cclosure_marshal_VOID()
https
Ted Gould has proposed merging lp:~ted/indicator-session/configurable-restart
into lp:indicator-session.
Requested reviews:
Indicator Applet Developers (indicator-applet-developers)
Adds GConf keys to suppress the restart and shutdown menu items.
--
https://code.launchpad.net/~ted/indicator
Review: Approve
review approve
--
https://code.launchpad.net/~agateau/dbusmenu/document-visible-property/+merge/22700
Your team ayatana-commits is subscribed to branch lp:dbusmenu.
___
Mailing list: https://launchpad.net/~ayatana-commits
Post to
Ted Gould has proposed merging lp:~ted/indicator-applet/bug553918 into
lp:indicator-applet.
Requested reviews:
Indicator Applet Developers (indicator-applet-developers)
Related bugs:
#553918 Keyboard shortcut usage blocks keyboard and other menus
https://bugs.launchpad.net/bugs/553918
On Thu, 2010-04-01 at 08:57 +, Aurélien Gâteau wrote:
Actually the code Ted merged is a bit different, so this
FIXME no longer apply I think.
Well, kinda. It just pushes the FIXME into the GTK lib instead of being
in the Glib one. But I think it can be fixed without changing GLib now
Ted Gould has proposed merging lp:~ted/indicator-session/bug548620 into
lp:indicator-session.
Requested reviews:
Indicator Applet Developers (indicator-applet-developers)
Related bugs:
#548620 gtk-logout-helper crashed with signal 5 in __libc_start_main()
https://bugs.launchpad.net/bugs
Ted Gould has proposed merging lp:~ted/indicator-messages/notification-grouping
into lp:indicator-messages.
Requested reviews:
Indicator Applet Developers (indicator-applet-developers)
Fixes a few little bugs. Basically makes the item visiblity tied
closely to the application. It also
Ted Gould has proposed merging lp:~ted/dbusmenu/menu-update-bug into
lp:dbusmenu.
Requested reviews:
DBus Menu Team (dbusmenu-team)
Changes the parse function from using take_children to using
get_children and handling the fallout from that. This makes it so that
menus don't disappear
On Wed, 2010-03-31 at 21:32 +, Cody Russell wrote:
+if (dmenu != NULL) {
+ DbusmenuGtkClient *client = dbusmenu_gtkmenu_get_client
(dmenu);
+
+ dbusmenu_client_add_type_handler (DBUSMENU_CLIENT (client),
DBUSMENU_ENTRY_MENUITEM_TYPE, new_entry_item);
+}
You shouldn't
Review: Approve
review approve
--
https://code.launchpad.net/~bratsche/indicator-me/fix-restarting-service/+merge/22573
Your team ayatana-commits is subscribed to branch lp:indicator-me.
___
Mailing list: https://launchpad.net/~ayatana-commits
Post
Ted Gould has proposed merging
lp:~ted/indicator-messages/indicator-service-arch into lp:indicator-messages.
Requested reviews:
Indicator Applet Developers (indicator-applet-developers)
Switching indicator-messages over to the libindicator service
architecture that all the other indicators
On Mon, 2010-03-29 at 20:19 +0100, David Balch wrote:
A further refinement would be to make the Restart required... text
in the menu red as well, to tie the meaning of the icon colour to the
menu action...
The current theming system makes that unrealistic. The application can
provide icon
On Mon, 2010-03-29 at 16:17 -0400, Jim Rorie wrote:
Could you not use red arrows like the blue ones in the messaging
indicator?
Yes, icons would be fine. We should probably come up with something
more holistic as was mentioned in another fork of this thread. I'm not
sure that Application
The proposal to merge lp:~kelemeng/indicator-session/bug547131 into
lp:indicator-session has been updated.
Status: Needs review = Merged
--
https://code.edge.launchpad.net/~kelemeng/indicator-session/bug547131/+merge/22164
Your team ayatana-commits is subscribed to branch
David,
If you could please review the practicality of submitting this at this point in
the release cycle. On one hand it helps translators, on the other hand it
invalidates a bunch of strings.
Thanks,
Ted
--
https://code.edge.launchpad.net/~ted/evolution-indicator/plural-forms/+merge/22413
On Thu, 2010-03-25 at 15:21 -0400, Jorge O. Castro wrote:
Copy to (and then my home and Desktop)
Move to (and then my home and Desktop again)
Move to Trash
Send to...
I wonder if we couldn't make these more reasonable by using a combined
menu item similar to Tomboy's pins. Basically have a
Ted Gould has proposed merging lp:~ted/indicator-session/go-to-sleep into
lp:indicator-session.
Requested reviews:
Indicator Applet Developers (indicator-applet-developers)
Changing the menu item to 'Suspend'
--
https://code.launchpad.net/~ted/indicator-session/go-to-sleep/+merge/22162
Your
Ted Gould has proposed merging lp:~ted/dbusmenu/blank-icon-support into
lp:dbusmenu.
Requested reviews:
DBus Menu Team (dbusmenu-team)
Adding the ability to set the icon to blank so that there is space
taken but no icon placed there.
--
https://code.launchpad.net/~ted/dbusmenu/blank-icon
Ted Gould has proposed merging
lp:~ted/indicator-messages/command-item-blank-icon into lp:indicator-messages.
Requested reviews:
Indicator Applet Developers (indicator-applet-developers)
Adds blank icons to command items.
--
https://code.launchpad.net/~ted/indicator-messages/command-item
Ted Gould has proposed merging lp:~ted/indicator-session/avatar-scaling into
lp:indicator-session.
Requested reviews:
Indicator Applet Developers (indicator-applet-developers)
Fixes large avatars so they don't dominate the menu.
--
https://code.launchpad.net/~ted/indicator-session/avatar
Ted Gould has proposed merging lp:~ted/indicator-messages/app-item-icon-refresh
into lp:indicator-messages.
Requested reviews:
Indicator Applet Developers (indicator-applet-developers)
Allow the icons to refresh as well. This catches cases were we haven't
gotten the icon name yet.
--
https
Ted Gould has proposed merging
lp:~ted/indicator-messages/seen-applications-list into lp:indicator-messages.
Requested reviews:
Indicator Applet Developers (indicator-applet-developers)
Watches for when applications start to know whether they've been seen by
the messaging menu before
On Tue, 2010-03-23 at 19:11 +0100, dani planas armangue wrote:
hi,indicators are a great adoption. but have one problem (integrated,
mail, chat, diffusion accounts, etc. ..) and when you reach a new
message does not know which category you arrive. This is perhaps an easy
solution to the
Review: Needs Information
I can't find where you're emitting the User Changed signal. It seems like that
should also be added into the DBus interface spec for the service.
Also, you need to add a GConf Schema for the GConf key.
--
Review: Approve
* I think that entry_activate_cb() shouldn't use the parameter
name gmi as other places that's be used for GTK Menu item
and might confuse things. (it confused me in the limited scope
of the diff)
* I'm unsure why the static was removed from
Ted Gould has proposed merging lp:~ted/indicator-messages/running-indicator
into lp:indicator-messages.
Requested reviews:
Indicator Applet Developers (indicator-applet-developers)
Adds a small icon on the gutter of the application items that are
running.
--
https://code.launchpad.net/~ted
Review: Approve
review approve
On Wed, 2010-03-24 at 01:05 +, Cody Russell wrote:
Cody Russell has proposed merging lp:~bratsche/dbusmenu/remove-warning into
lp:dbusmenu.
Requested reviews:
DBus Menu Team (dbusmenu-team)
Related bugs:
#534854 indicator-applet logs 'GTK not
Review: Abstain
--
https://code.edge.launchpad.net/~dbarth/indicator-me/character-limit/+merge/21442
Your team ayatana-commits is subscribed to branch lp:indicator-me.
___
Mailing list: https://launchpad.net/~ayatana-commits
Post to :
Review: Approve
review approve
--
https://code.launchpad.net/~bratsche/indicator-applet/scroll/+merge/21532
Your team ayatana-commits is subscribed to branch lp:indicator-applet.
___
Mailing list: https://launchpad.net/~ayatana-commits
Post to :
Ted Gould has proposed merging lp:~ted/indicator-session/switch-from-caps into
lp:indicator-session.
Requested reviews:
Indicator Applet Developers (indicator-applet-developers)
Related bugs:
#540265 Switch from is miscapitalized
https://bugs.launchpad.net/bugs/540265
Capitalization fix
Ted Gould has proposed merging lp:~ted/indicator-messages/bug540148 into
lp:indicator-messages.
Requested reviews:
Indicator Applet Developers (indicator-applet-developers)
Related bugs:
#540148 Translations for shortcuts are only loaded when starting the
application
https
Ted Gould has proposed merging
lp:~ted/indicator-session/being-a-better-house-guest into lp:indicator-session.
Requested reviews:
Indicator Applet Developers (indicator-applet-developers)
Wow, basically the goal of this branch is to get it so that we can see
when the guest user is logged
Ted Gould has proposed merging lp:~ted/indicator-session/user-icons into
lp:indicator-session.
Requested reviews:
Indicator Applet Developers (indicator-applet-developers)
Putting user icons into the menu. Use the stock person if there is no
user icon available for the user.
--
https
Ted Gould has proposed merging lp:~ted/indicator-messages/avatar-spacing into
lp:indicator-messages.
Requested reviews:
Indicator Applet Developers (indicator-applet-developers)
Fixing the avatars to have the same spacing as the other items. And, in
the case of missing avatars, to align
Ted Gould has proposed merging
lp:~ted/indicator-messages/libindicator-icon-handling into
lp:indicator-messages.
Requested reviews:
Indicator Applet Developers (indicator-applet-developers)
Make the messaging indicator use the helper library so we're all the
same. For better or worse
On Tue, 2010-03-16 at 08:33 +, David Barth wrote:
Not sure if you're also testing for the screensaver lock option
to be enable to display the lock option or not.
No, this is just looking at the lock down key. It isn't looking at the
screensaver settings.
--
On Tue, 2010-03-16 at 08:14 +, David Barth wrote:
The changes are fine. I'm wondering what the namespace should be. I
was using /system/indicator-me, so are there Gnome guidelines on how
to organize the namespace and what should use the /system configuration
tree?
Uhm, I'm not sure
Review: Approve
On Tue, 2010-03-16 at 10:46 +, David Barth wrote:
This branch enables proper radio marks on status items
and also computes the indeterminate status based on
diverging online statuses.
For the indentation, just use tabs :)
If you want to add a new icon name you need to
Ted Gould has proposed merging lp:~ted/indicator-session/gconf-notify-remove
into lp:indicator-session.
Requested reviews:
Indicator Applet Developers (indicator-applet-developers)
Making it so that we track the gconf registrations so that we can remove
them as well.
--
https
Ted Gould has proposed merging
lp:~ted/indicator-session/not-really-locking-screen into lp:indicator-session.
Requested reviews:
Indicator Applet Developers (indicator-applet-developers)
Make it so that we follow the GConf key for the screensaver to see if
we're locking or not. If we're
Ted Gould has proposed merging lp:~ted/indicator-sound/libindicator-icon-update
into lp:indicator-sound.
Requested reviews:
Indicator Applet Developers (indicator-applet-developers)
Related bugs:
#537977 display a mute icon until volume is changed since update
https://bugs.launchpad.net
Ted Gould has proposed merging lp:~ted/indicator-me/libindicator-icon-update
into lp:indicator-me.
Requested reviews:
Indicator Applet Developers (indicator-applet-developers)
Related bugs:
#538923 status changes to offline on updates
https://bugs.launchpad.net/bugs/538923
Use the update
Ted Gould has proposed merging lp:~ted/indicator-session/screensaver-gconf-key
into lp:indicator-session.
Requested reviews:
Indicator Applet Developers (indicator-applet-developers)
Making it so that we hide the lockscreen item if the gconf lockdown key
is set. Also ended up having
Ted Gould has proposed merging lp:~ted/indicator-session/lock-on-switch into
lp:indicator-session with lp:~ted/indicator-session/screensaver-gconf-key as a
prerequisite.
Requested reviews:
Indicator Applet Developers (indicator-applet-developers)
Make it so that when we switch users we lock
Ted Gould has proposed merging lp:~ted/indicator-session/gconf-key-for-logout
into lp:indicator-session.
Requested reviews:
Indicator Applet Developers (indicator-applet-developers)
Adds a GConf key to hide the logout button on the session menu.
--
https://code.launchpad.net/~ted/indicator
Ted Gould has proposed merging lp:~ted/indicator-session/i18n-fix-for-switch
into lp:indicator-session.
Requested reviews:
Indicator Applet Developers (indicator-applet-developers)
Setting up the indicator to use library translations so they'll be
grabbed from the right domain.
--
https
Ted Gould has proposed merging
lp:~ted/indicator-session/panel-icon-shows-restart into lp:indicator-session.
Requested reviews:
Indicator Applet Developers (indicator-applet-developers)
A rather large patch to make it so that the icon on the panel can
change. Basically we had to add another
401 - 500 of 617 matches
Mail list logo
