[Ayatana-commits] [Merge] lp:~bilalakhtar/indicator-sound/fix-594396 into lp:indicator-sound

2010-08-11 Thread Bilal Akhtar
Bilal Akhtar has proposed merging lp:~bilalakhtar/indicator-sound/fix-594396 into lp:indicator-sound. Requested reviews: Conor Curran (cjcurran) Indicator Applet Developers (indicator-applet-developers) Related bugs: #594396 Sound Effects should not be the default tab in Sound Preferences

Re: [Ayatana-commits] [Merge] lp:~cjcurran/indicator-sound/mpris2-implementation into lp:indicator-sound

2010-08-11 Thread Ted Gould
Review: Approve The code seems okay. I'm a bit worried that it seems we're choosing mpris 1 vs. 2 by a lookup table. It seems we should be able to see which interface that the music player is exporting and choose the best one there. --

[Ayatana-commits] [Merge] lp:~ted/indicator-application/x-label-branch into lp:indicator-application

2010-08-11 Thread Ted Gould
Ted Gould has proposed merging lp:~ted/indicator-application/x-label-branch into lp:indicator-application. Requested reviews: Indicator Applet Developers (indicator-applet-developers) Moving the label attributes to the X namespace as the KDE folks aren't interested in it. Hopefully they'll

Re: [Ayatana-commits] [Merge] lp:~cjcurran/indicator-sound/mpris2-implementation into lp:indicator-sound

2010-08-11 Thread Conor Curran
Agreed Ted, this is rough and ready. I am not going to do anymore mpris2 work until the spec has been finalized at which point automatic interface selection will be implemented. From the conversation on #mpris the finalized spec is going to be very different. --

[Ayatana-commits] [Merge] lp:~cjcurran/indicator-sound/mpris2-implementation into lp:indicator-sound

2010-08-11 Thread noreply
The proposal to merge lp:~cjcurran/indicator-sound/mpris2-implementation into lp:indicator-sound has been updated. Status: Needs review = Merged -- https://code.launchpad.net/~cjcurran/indicator-sound/mpris2-implementation/+merge/32368 Your team ayatana-commits is subscribed to branch