[Ayatana-commits] [Merge] lp:~cjcurran/indicator-sound/banshee-fix-plus-random-slider-crasher into lp:indicator-sound

2010-09-10 Thread Conor Curran
Conor Curran has proposed merging lp:~cjcurran/indicator-sound/banshee-fix-plus-random-slider-crasher into lp:indicator-sound. Requested reviews: Indicator Applet Developers (indicator-applet-developers) Related bugs: #615277 indicator-applet crashed with SIGSEGV in gtk_range_get_value()

Re: [Ayatana-commits] [Merge] lp:~cjcurran/indicator-sound/banshee-fix-plus-random-slider-crasher into lp:indicator-sound

2010-09-10 Thread David Barth
Review: Needs Fixing line 356: if delta is zero, it won't look cool -- https://code.launchpad.net/~cjcurran/indicator-sound/banshee-fix-plus-random-slider-crasher/+merge/35080 Your team ayatana-commits is subscribed to branch lp:indicator-sound. ___

Re: [Ayatana-commits] [Merge] lp:~dbarth/indicator-me/gconf-switch into lp:indicator-me

2010-09-10 Thread Sebastien Bacher
the change is buggy since you don't migrate the key value, better to wait next cycle and the gsettings updates to migrate the key and value -- https://code.launchpad.net/~dbarth/indicator-me/gconf-switch/+merge/35094 Your team ayatana-commits is subscribed to branch lp:indicator-me.

Re: [Ayatana-commits] [Merge] lp:~cjcurran/indicator-sound/banshee-fix-plus-random-slider-crasher into lp:indicator-sound

2010-09-10 Thread David Barth
also, the theme change cb does nothing. add a comment in the code to state whether there is a TODO or whether it's a no-op on purpose. -- https://code.launchpad.net/~cjcurran/indicator-sound/banshee-fix-plus-random-slider-crasher/+merge/35080 Your team ayatana-commits is subscribed to branch

[Ayatana-commits] [Merge] lp:~ken-vandine/indicator-appmenu/bump_bamf_dep into lp:indicator-appmenu

2010-09-10 Thread Ken VanDine
Ken VanDine has proposed merging lp:~ken-vandine/indicator-appmenu/bump_bamf_dep into lp:indicator-appmenu. Requested reviews: Indicator Applet Developers (indicator-applet-developers) Bump libbamf-dev min version --

[Ayatana-commits] [Merge] lp:~cjcurran/indicator-sound/banshee-fix-plus-random-slider-crasher into lp:indicator-sound

2010-09-10 Thread noreply
The proposal to merge lp:~cjcurran/indicator-sound/banshee-fix-plus-random-slider-crasher into lp:indicator-sound has been updated. Status: Needs review = Merged -- https://code.launchpad.net/~cjcurran/indicator-sound/banshee-fix-plus-random-slider-crasher/+merge/35080 Your team

[Ayatana-commits] [Merge] lp:~cimi/indicator-sound/use-gtk-colors into lp:indicator-sound

2010-09-10 Thread Conor Curran
Conor Curran has proposed merging lp:~cimi/indicator-sound/use-gtk-colors into lp:indicator-sound. Requested reviews: Conor Curran (cjcurran) -- https://code.launchpad.net/~cimi/indicator-sound/use-gtk-colors/+merge/35101 Your team ayatana-commits is subscribed to branch lp:indicator-sound.

[Ayatana-commits] [Merge] lp:~cimi/indicator-sound/use-gtk-colors into lp:indicator-sound

2010-09-10 Thread Conor Curran
The proposal to merge lp:~cimi/indicator-sound/use-gtk-colors into lp:indicator-sound has been updated. Status: Needs review = Merged -- https://code.launchpad.net/~cimi/indicator-sound/use-gtk-colors/+merge/35101 Your team ayatana-commits is subscribed to branch lp:indicator-sound.

[Ayatana-commits] [Merge] lp:~bratsche/appmenu-gtk/toplevel-destroyed-fix into lp:appmenu-gtk

2010-09-10 Thread noreply
The proposal to merge lp:~bratsche/appmenu-gtk/toplevel-destroyed-fix into lp:appmenu-gtk has been updated. Status: Needs review = Merged -- https://code.launchpad.net/~bratsche/appmenu-gtk/toplevel-destroyed-fix/+merge/35017 Your team ayatana-commits is subscribed to branch lp:appmenu-gtk.

Re: [Ayatana-commits] [Merge] lp:~ken-vandine/indicator-appmenu/bump_bamf_dep into lp:indicator-appmenu

2010-09-10 Thread Ted Gould
Review: Needs Information BAMF doesn't export it's full version into the pkgconfig file... so we can't really check the version in the configure file. So, I think we either should fix BAMF or not merge something that implies that we can check it. review needsinfo --

Re: [Ayatana-commits] [Merge] lp:~dbarth/indicator-me/clean-checkmarks into lp:indicator-me

2010-09-10 Thread Ted Gould
Review: Approve review approve -- https://code.launchpad.net/~dbarth/indicator-me/clean-checkmarks/+merge/35061 Your team ayatana-commits is subscribed to branch lp:indicator-me. ___ Mailing list: https://launchpad.net/~ayatana-commits Post to

[Ayatana-commits] [Branch ~indicator-applet-developers/indicator-me/trunk] Rev 105: some improvements

2010-09-10 Thread noreply
revno: 105 committer: David Barth david.ba...@canonical.com branch nick: indicator-me.entry timestamp: Fri 2010-09-10 23:07:08 +0200 message: some improvements modified: src/indicator-me.c -- lp:indicator-me

[Ayatana-commits] [Branch ~indicator-applet-developers/indicator-me/trunk] Rev 104: first attempt at putting a hint in the entry

2010-09-10 Thread noreply
revno: 104 committer: David Barth david.ba...@canonical.com branch nick: indicator-me.entry timestamp: Fri 2010-09-10 09:29:03 +0200 message: first attempt at putting a hint in the entry modified: src/dbus-shared-names.h

[Ayatana-commits] [Branch ~indicator-applet-developers/indicator-me/trunk] 2 revisions removed

2010-09-10 Thread noreply
2 revisions were removed from the branch. -- lp:indicator-me https://code.launchpad.net/~indicator-applet-developers/indicator-me/trunk Your team ayatana-commits is subscribed to branch lp:indicator-me. To unsubscribe from this branch go to