Review: Approve
Looks good!
--
https://code.launchpad.net/~ken-vandine/indicator-me/gdbus/+merge/46178
Your team ayatana-commits is subscribed to branch lp:indicator-me.
___
Mailing list: https://launchpad.net/~ayatana-commits
Post to :
The proposal to merge lp:~ken-vandine/indicator-me/gdbus into lp:indicator-me
has been updated.
Status: Needs review = Merged
For more details, see:
https://code.launchpad.net/~ken-vandine/indicator-me/gdbus/+merge/46178
--
Review: Needs Fixing
conncetion_changed()
Should really check to see if status_proxy_cancel is NULL as well so that you
don't allocate two of them.
status_proxy_cb()
You shouldn't cast the user_data to self before checking the error. There is a
few cases where the indicator could be
3 matches
Mail list logo
