Re: [B.A.T.M.A.N.] [PATCH] Don't process the icmp packet further when we could not read it

2008-07-18 Thread Simon Wunderlich
Hey Sven, thanks for the patches! Both of them look good so i applied them. By the way, if anyone knows something like "git am" for svn (applying patches directly from a mailbox), please tell me. :D regards, Simon On Fri, Jul 18, 2008 at 01:18:28PM +0200, Sven Eckelmann wrote: > __copy_f

[B.A.T.M.A.N.] [PATCH] Don't process the icmp packet further when we could not read it

2008-07-18 Thread Sven Eckelmann
__copy_from_user returns the number of bytes it could not read when it fails. It makes no sense to process the data further if we don't have it in a complete form. access_ok will only check if it may be valid but not if it is definitly valid. Signed-off-by: Sven Eckelmann --- batman-adv-kernella

[B.A.T.M.A.N.] [PATCH] Move more compatibility code to compat.h

2008-07-18 Thread Sven Eckelmann
Use the madwifi-like compat.h to keep as much of the #ifLINUX_VERSION.. stuff out of the code to increase the readability. Parts which weren't moved are the device creation/deletion, which is to different to move it to compat.h, and the module count. Signed-off-by: Sven Eckelmann --- batman-adv-

b.a.t.m.a.n@lists.open-mesh.org

2008-07-18 Thread Simon Wunderlich
Hello Mark, the lines of your error messages seem to be wrong. As Sven pointed out, your SVN checkout might be broken. Please check your gateway.c file against the latest trunk: https://dev.open-mesh.net/svn/batman/trunk/batman/linux/modules/gateway.c and see if it is matching. There is no code ab

b.a.t.m.a.n@lists.open-mesh.org

2008-07-18 Thread Sven Eckelmann
On Friday 18 July 2008 03:48:27 Mark Kelly wrote: > I just got around to trying this again on 2.6.26 final and I'm still > getting a fail error on the gateway module, and I've tried it using > r1099 and r1100 under openwrt on an ixp4xx board. Please look at device.c on line 88 till 92. There should

Re: [B.A.T.M.A.N.] [PATCH] batman-adv-kernelland linux-2.6.21 compatibility

2008-07-18 Thread Marek Lindner
On Thursday, 17. July 2008 16:00:54 Simon Wunderlich wrote: > thank you for the patch, it looks good to me so i applied it. Having a > compat.h is a good idea, maybe we should use it even more to get rid of > some ugly #ifdef's. :) Yes, I agree - I like that idea. > We welcome any kind of patche

b.a.t.m.a.n@lists.open-mesh.org

2008-07-18 Thread Mark Kelly
Hey Simon, I just got around to trying this again on 2.6.26 final and I'm still getting a fail error on the gateway module, and I've tried it using r1099 and r1100 under openwrt on an ixp4xx board. make[3]: Entering directory `/opt/openwrt/k1/build_dir/linux-ixp4xx_generic/linux-2.6.26' CC [M]

Re: [B.A.T.M.A.N.] Batman 0.3 + Freifunk setup questions

2008-07-18 Thread Simon Wunderlich
Hello Don, Debug Level 2 will list the available gateways. There is no need to restart BATMAN, it will notice the new gateway available gateways automatically (the gateways are announced with the BATMAN-packets). One of the gateways will be selected depending on the configuration at -r. You mig

Re: [B.A.T.M.A.N.] Batman 0.3 + Freifunk setup questions

2008-07-18 Thread Don Davis
Simon Wunderlich wrote: On Thu, Jul 17, 2008 at 03:13:17PM -0500, Don Davis wrote: batmand -g 5mb eth1 vlan1 #for gw? Hello Don, try "-g 5mbit" instead of "-g 5mb". Seems this wrong option is silently ignored ... best regards, Simon Thank you. That did do the trick. Is the gateway

Re: [B.A.T.M.A.N.] Batman 0.3 + Freifunk setup questions

2008-07-18 Thread Simon Wunderlich
On Thu, Jul 17, 2008 at 03:13:17PM -0500, Don Davis wrote: > batmand -g 5mb eth1 vlan1 #for gw? Hello Don, try "-g 5mbit" instead of "-g 5mb". Seems this wrong option is silently ignored ... best regards, Simon signature.asc Description: Digital signature