[B.A.T.M.A.N.] [PATCH next] batman-adv: fix local translation output

2013-01-24 Thread Antonio Quartulli
The last-seen field has to be print for all the entries but the one marked as no-purge. Introduced by 15727323d9f8864b2d41930940acc38de987045a (batman-adv: don't print the last_seen time for bat0 TT local entry) Signed-off-by: Antonio Quartulli or...@autistici.org --- translation-table.c | 4

[B.A.T.M.A.N.] [PATCHv2 next] batman-adv: fix local translation table output

2013-01-24 Thread Antonio Quartulli
The last-seen field has to be printed for all the local entries but the one marked with the no-purge flag Introduced by 15727323d9f8864b2d41930940acc38de987045a (batman-adv: don't print the last_seen time for bat0 TT local entry) Signed-off-by: Antonio Quartulli or...@autistici.org --- v2: -

Re: [B.A.T.M.A.N.] batman-adv: Unable to add interface in LXC

2013-01-24 Thread Antonio Quartulli
Hello Pau, On Mon, Jan 21, 2013 at 10:11:15AM +0100, Pau Koning wrote: Did you check your kernel log messages ? I'd expect batman-adv to print something there in case of an error. No output at all Sorry for the long delay. However batman-adv does not support lxc at the moment. Therefore

Re: [B.A.T.M.A.N.] [PATCH 2/2] batman-adv: filter out invalid DAT entries

2013-01-24 Thread Marek Lindner
On Thursday, January 24, 2013 05:53:52 Antonio Quartulli wrote: It might make sense though to check for different types of addresses that are invalid for ARP (zeronet, loopback, multicast, etc.), but I wanted to keep the patch as simple as possible. If you think these should be filtered as

Re: [B.A.T.M.A.N.] [PATCH 2/2] batman-adv: filter out invalid DAT entries

2013-01-24 Thread Marek Lindner
On Thursday, January 24, 2013 21:38:58 Antonio Quartulli wrote: On Thu, Jan 24, 2013 at 09:36:11PM +0800, Marek Lindner wrote: On Thursday, January 24, 2013 05:53:52 Antonio Quartulli wrote: It might make sense though to check for different types of addresses that are invalid for ARP

Re: [B.A.T.M.A.N.] [PATCHv3 6/6] batman-adv: Receive coded packets and decode them.

2013-01-24 Thread Marek Lindner
On Monday, January 21, 2013 18:22:26 Martin Hundebøll wrote: --- a/types.h +++ b/types.h @@ -308,6 +308,10 @@ enum batadv_counters { BATADV_CNT_NC_RECODE, BATADV_CNT_NC_RECODE_BYTES, BATADV_CNT_NC_BUFFER, + BATADV_CNT_NC_DECODE, +

Re: [B.A.T.M.A.N.] [PATCHv3 4/6] batman-adv: Code and transmit packets if possible.

2013-01-24 Thread Marek Lindner
On Monday, January 21, 2013 18:22:24 Martin Hundebøll wrote: diff --git a/types.h b/types.h index 612a658..fc65df3 100644 --- a/types.h +++ b/types.h @@ -302,6 +302,12 @@ enum batadv_counters { BATADV_CNT_DAT_PUT_RX, BATADV_CNT_DAT_CACHED_REPLY_TX, #endif +#ifdef

Re: [B.A.T.M.A.N.] [PATCHv3 2/6] batman-adv: Detect coding nodes and remove these after timeout

2013-01-24 Thread Marek Lindner
On Monday, January 21, 2013 18:22:22 Martin Hundebøll wrote: @@ -430,9 +440,12 @@ struct batadv_priv_dat { /** * struct batadv_priv_nc - per mesh interface network coding private data * @work: work queue callback item for cleanup + * @min_tq: only consider neighbors for encoding if

Re: [B.A.T.M.A.N.] [PATCH 2/2] batman-adv: filter out invalid DAT entries

2013-01-24 Thread Matthias Schiffer
On 01/24/2013 02:47 PM, Marek Lindner wrote: On Thursday, January 24, 2013 21:38:58 Antonio Quartulli wrote: I thought the same, but in batadv_arp_get_type() we have a general check that discards wrong/bogus ARP request. Here instead we are filtering correct ARP requests that DAT should not

Re: [B.A.T.M.A.N.] [PATCH 2/2] batman-adv: filter out invalid DAT entries

2013-01-24 Thread Antonio Quartulli
On Thu, Jan 24, 2013 at 03:44:35PM +0100, Matthias Schiffer wrote: On 01/24/2013 02:47 PM, Marek Lindner wrote: On Thursday, January 24, 2013 21:38:58 Antonio Quartulli wrote: I thought the same, but in batadv_arp_get_type() we have a general check that discards wrong/bogus ARP request.

[B.A.T.M.A.N.] [PATCH v2 1/2] batman-adv: check for more types of invalid IP addresses in DAT

2013-01-24 Thread Matthias Schiffer
There are more types of IP addresses that may appear in ARP packets that we don't want to process. While some of these should never appear in sane ARP packets, a 0.0.0.0 source is used for duplicate address detection and thus seen quite often. Signed-off-by: Matthias Schiffer

[B.A.T.M.A.N.] [PATCH v2 2/2] batman-adv: filter ARP packets with invalid MAC addresses in DAT

2013-01-24 Thread Matthias Schiffer
We never want multicast MAC addresses in the Distributed ARP Table, so it's best to completely ignore ARP packets containing them where we expect unicast addresses. Signed-off-by: Matthias Schiffer mschif...@universe-factory.net --- distributed-arp-table.c | 13 + 1 file changed, 13

Re: [B.A.T.M.A.N.] [PATCH 2/2] batman-adv: filter out invalid DAT entries

2013-01-24 Thread Matthias Schiffer
Okay, here is the new version, in two parts. I like the first version better, but maybe this one is more consistent... Matthias

Re: [B.A.T.M.A.N.] [PATCH v2 2/2] batman-adv: filter ARP packets with invalid MAC addresses in DAT

2013-01-24 Thread Matthias Schiffer
On 01/24/2013 06:18 PM, Matthias Schiffer wrote: We never want multicast MAC addresses in the Distributed ARP Table, so it's best to completely ignore ARP packets containing them where we expect unicast addresses. Signed-off-by: Matthias Schiffer mschif...@universe-factory.net ---