Re: [B.A.T.M.A.N.] [PATCHv2] batman-adv: use __constant_htons when possible

On Sun, May 12, 2013 at 10:09:57PM +0200, Antonio Quartulli wrote: When comparing a network ordered value with a constant, it is better to convert the constant at compile time by means of __constant_htons() instead of converting the value at runtime using ntohs(). This refactoring may

[B.A.T.M.A.N.] pull request for net: batman-adv 2013-05-17

Hello David, here you have one fix intended for net/linux-3.10. This patch is fixing a global fault protection that can be triggered on module removal due to the double invocation of call_rcu() in chain. While fixing, the patch is also adding some kernel doc to the changed functions. Consider

[B.A.T.M.A.N.] [PATCHv3] batman-adv: use __constant_htons when possible

When comparing a network ordered value with a constant, it is better to convert the constant at compile time by means of __constant_htons() instead of converting the value at runtime using ntohs(). This refactoring may slightly improve the code performance. Signed-off-by: Antonio Quartulli

Re: [B.A.T.M.A.N.] pull request for net: batman-adv 2013-05-17

From: Antonio Quartulli or...@autistici.org Date: Fri, 17 May 2013 10:10:10 +0200 here you have one fix intended for net/linux-3.10. This patch is fixing a global fault protection that can be triggered on module removal due to the double invocation of call_rcu() in chain. While fixing, the

Re: [B.A.T.M.A.N.] Basic Multicast Optimizations

Hey Linus, On Fri, May 17, 2013 at 03:38:56AM +0200, Linus Lüssing wrote: For the non-link-local IPv4 multicast addresses, could we use the current mechanism (drop/unicast/broadcast) by getting the assigned multicast addresses? (of course, assuming we have no bridge) We could - after

[B.A.T.M.A.N.] [RFC 1/4] batman-adv: renamed batadv_dat_snoop_*_arp_* functions to batadv_dat_snoop_*_msg_*

From: mihail.coste...@gmail.com mihail.coste...@gmail.com Renamed snooping functions in order to suggest that they should work on more protocols than ARP. Signed-off-by: Mihail Costea mihail.coste...@gmail.com Signed-off-by: Stefan Popa stefan.a.p...@intel.com Reviewed-by: Stefan Popa

[B.A.T.M.A.N.] [RFC 2/4] batman-adv: added IPv6 to DAT and generic functions in distributed-arp-table.c

From: mihail.coste...@gmail.com mihail.coste...@gmail.com Added IPv6 functionality to generic functions implemented in the first patch. Signed-off-by: Mihail Costea mihail.coste...@gmail.com Signed-off-by: Stefan Popa stefan.a.p...@intel.com Reviewed-by: Stefan Popa stefan.a.p...@intel.com ---

[B.A.T.M.A.N.] [RFC 3/4] batman-adv: added necessary functions for NDP, like checking if a packet is valid or creating a Neighbor Advertisement

From: mihail.coste...@gmail.com mihail.coste...@gmail.com Added functions needed for NDP snooping, like getting the IPv6 addresses or getting the target HW address from an Neighbor Advertisement (NA). Also added functions to create NA for Neighbor Solicitations that have already the HW address in

[B.A.T.M.A.N.] [RFC 4/4] batman-adv: generalize snooping mechanism in order to suport NDP too

From: mihail.coste...@gmail.com mihail.coste...@gmail.com Generalized snooping functions in order to support Neighbor Advertisement and Neighbor Solicitation too. Signed-off-by: Mihail Costea mihail.coste...@gmail.com Signed-off-by: Stefan Popa stefan.a.p...@intel.com Reviewed-by: Stefan Popa

Re: [B.A.T.M.A.N.] [RFC 1/4] batman-adv: renamed batadv_dat_snoop_*_arp_* functions to batadv_dat_snoop_*_msg_*

Hi, For now is only for RFC, because there is a problem with the calculation of router and override flags (see comments in RFC 3/4). The code is based on the patch sent 2 weeks ago (the one with the generalization). There is no hurry with the review, because in 1 week I leave the country and it

[B.A.T.M.A.N.] [PATCH] batctl: fix typos in error messages

From: Antonio Quartulli anto...@open-mesh.com Signed-off-by: Antonio Quartulli anto...@open-mesh.com --- bisect_iv.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/bisect_iv.c b/bisect_iv.c index f958511..0dbc2ef 100644 --- a/bisect_iv.c +++ b/bisect_iv.c @@ -1525,13