Re: [B.A.T.M.A.N.] [PATCH] batman-adv: Disable CONFIG_BATMAN_ADV_DEBUGFS by default

On Sonntag, 18. März 2018 15:39:07 CET Linus Lüssing wrote: [...] > Since this patch is not urgent, would it make sentence to delay > this patch for after the next release maybe? That should give > maintainers at least a two months window to upgrade batctl. Ok Kind regards, Sven

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: Disable CONFIG_BATMAN_ADV_DEBUGFS by default

On Sun, Mar 18, 2018 at 10:34:29AM +0100, Sven Eckelmann wrote: > All tools which were known to the batman-adv development team are > supporting the batman-adv netlink interface since a while. Also debugfs is > not supported for batman-adv interfaces in any non-default netns. Thus > disabling

[B.A.T.M.A.N.] [PATCH] batman-adv: Fix skbuff rcsum on packet reroute

batadv_check_unicast_ttvn may redirect a packet to itself or another originator. This involves rewriting the ttvn and the destination address in the batadv unicast header. These field were not yet pulled (with skb rcsum update) and thus any change to them also requires a change in the receive

Re: [B.A.T.M.A.N.] [PATCH maint 3/3] batman-adv: do not modify batadv packet header before pulling it

On 03/18/2018 09:15 AM, Sven Eckelmann wrote: > On Freitag, 16. März 2018 11:29:11 CET Matthias Schiffer wrote: >> batadv_check_unicast_ttvn() may modify the batadv header, leading to >> checksum errors in the following processing of the packet. >> >> Rather than fixing up the checksum, simply

[B.A.T.M.A.N.] [PATCH] batman-adv: Disable CONFIG_BATMAN_ADV_DEBUGFS by default

All tools which were known to the batman-adv development team are supporting the batman-adv netlink interface since a while. Also debugfs is not supported for batman-adv interfaces in any non-default netns. Thus disabling CONFIG_BATMAN_ADV_DEBUGFS by default should not cause problems on most

Re: [B.A.T.M.A.N.] [PATCH maint 1/3] batman-adv: update data pointers after skb_cow()

On Freitag, 16. März 2018 11:29:09 CET Matthias Schiffer wrote: > batadv_check_unicast_ttvn() calls skb_cow(), so pointers into the SKB data > must be (re)set after calling it. The ethhdr variable is dropped > altogether. > > Signed-off-by: Matthias Schiffer > ---

Re: [B.A.T.M.A.N.] [PATCH maint 3/3] batman-adv: do not modify batadv packet header before pulling it

On Freitag, 16. März 2018 11:29:11 CET Matthias Schiffer wrote: > batadv_check_unicast_ttvn() may modify the batadv header, leading to > checksum errors in the following processing of the packet. > > Rather than fixing up the checksum, simply pull the batadv header before > modifying it (and push