Re: [syzbot] WARNING: suspicious RCU usage in __dev_queue_xmit

2022-01-10 Thread Florian Westphal
syzbot wrote: > Hello, > > syzbot found the following issue on: > > HEAD commit:4c375272fb0b Merge branch 'net-add-preliminary-netdev-refc.. > git tree: net-next > console output: https://syzkaller.appspot.com/x/log.txt?x=164749a9b0 > kernel config:

Re: [B.A.T.M.A.N.] "Kernel bug detected [...] nf_ct_del_from_dying_or_unconfirmed_list"

2019-01-28 Thread Florian Westphal
Chieh-Min Wang wrote: > I think 71d8c47fc653711c4(netfilter: conntrack: introduce clash > resolution on insertion race) is doing the same logic for resolving > conntrack clashing. No, that commit dealsl with the case where two skbs have different conntrack objects but where tuples are the same.

Re: [B.A.T.M.A.N.] "Kernel bug detected [...] nf_ct_del_from_dying_or_unconfirmed_list"

2019-01-28 Thread Florian Westphal
Pablo Neira Ayuso wrote: > I don't think letting the packet go through is a good idea. Not sure > NAT will work fine, packets would go through being unmangled? I think > we should still drop the packet until we fix this. Unfortuntely this is still a band-aid solution, nfqueue + bridge doesn't

Re: [B.A.T.M.A.N.] "Kernel bug detected [...] nf_ct_del_from_dying_or_unconfirmed_list"

2019-01-28 Thread Florian Westphal
Chieh-Min Wang wrote: > I think this is the same issue as this one. > > http://patchwork.ozlabs.org/patch/995825/ Yes, likely.

Re: [B.A.T.M.A.N.] "Kernel bug detected [...] nf_ct_del_from_dying_or_unconfirmed_list"

2019-01-27 Thread Florian Westphal
Linus Lüssing wrote: > This only happens upon sending a SIGTERM to the network manager > "netifd" (so upon network shutdown). And only if the node is connected > to mesh of reasonable size, so if there is a certain amount of > multicast traffic for the multicast-to-multi-unicast patch to work on.

Re: [B.A.T.M.A.N.] [PATCH net v2 1/1] net: batman-adv: Treat NET_XMIT_CN as transmit successfully

2016-11-21 Thread Florian Westphal
f...@ikuai8.com wrote: > From: Gao Feng > > The tc could return NET_XMIT_CN as one congestion notification, but > it does not mean the packet is lost. Other modules like ipvlan, > macvlan, and others treat NET_XMIT_CN as success too. > > So batman-adv should

[B.A.T.M.A.N.] [PATCH] batman-adv: fix skb deref after free

2016-05-10 Thread Florian Westphal
batadv_send_skb_to_orig() calls dev_queue_xmit() so we can't use skb->len. Signed-off-by: Florian Westphal <f...@strlen.de> --- Noticed during review, compile tested only. net/batman-adv/routing.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/net/batman-adv/ro

[B.A.T.M.A.N.] [PATCH net-next 4/5] treewide: replace dev->trans_start update with helper

2016-05-03 Thread Florian Westphal
org Cc: linux-wirel...@vger.kernel.org Cc: linux-s...@vger.kernel.org Cc: de...@driverdev.osuosl.org Cc: b.a.t.m.a.n@lists.open-mesh.org Cc: linux-blueto...@vger.kernel.org Signed-off-by: Florian Westphal <f...@strlen.de> --- Checkpatch complains about whitespace damage, but this extra w