Re: Batman adv selective broadcast mechanism

2021-03-24 Thread Linus Lüssing
Hi, On Wed, Mar 24, 2021 at 12:16:16PM -, oytunya...@hotmail.com wrote: > Hi everybody, > > As I check, batman-adv protocol, sends IP broadcast packets, to every > slave interface, including the slave interface from which the broadcast > packet is received. Is there any way for

[PATCH maint] batman-adv: Fix order of kernel doc in batadv_priv

2021-03-23 Thread Linus Lüssing
During the inlining process of kerneldoc some comments were placed at the wrong struct members. Fixing this by reordering the comments. Fixes: 6369b8e999af ("batman-adv: Use inline kernel-doc for enum/struct") Signed-off-by: Linus Lüssing --- Note: checkpatch shows me a warning: ```

Re: batman-adv for kbit level speeds, external neighbor info

2021-03-16 Thread Linus Lüssing
On Tue, Mar 16, 2021 at 01:17:50PM -, oytunya...@hotmail.com wrote: > Hi everybody, > > I have some questions about batman-adv. > Do you suggest, batman-adv, for speeds like 2.4kbit/s (very slow > networks)? I tried to use batctl throughput_override, for such a setup. It > seems at

[PATCH v2] net: bridge: mcast: rename br_ip's u member to dst

2020-09-28 Thread Linus Lüssing
Signed-off-by: Nikolay Aleksandrov [linus.luess...@c0d3.blue: Add compat code] Signed-off-by: Linus Lüssing --- Compat v2: * added BUILD_BUG_ON size+offset checks as suggested by Sven (thanks!) compat-include/linux/if_bridge.h | 56 net/batman-adv/multicast.c

Re: [PATCH 2/2] batman-adv: mcast: rename br_ip's u member to dst

2020-09-27 Thread Linus Lüssing
On Sat, Sep 26, 2020 at 10:12:20AM +0200, Sven Eckelmann wrote: > From: Nikolay Aleksandrov > > Since now we have src in br_ip, u no longer makes sense so rename > it to dst. No functional changes. > > Signed-off-by: Nikolay Aleksandrov > Signed-off-by: David S. Miller > [s...@narfation.org:

[PATCH] net: bridge: mcast: rename br_ip's u member to dst

2020-09-27 Thread Linus Lüssing
Signed-off-by: Nikolay Aleksandrov [linus.luess...@c0d3.blue: Add compat code] Signed-off-by: Linus Lüssing --- compat-include/linux/if_bridge.h | 39 net/batman-adv/multicast.c | 14 ++-- 2 files changed, 46 insertions(+), 7 deletions(-) create mode

Re: [PATCH net-next v2 06/16] net: bridge: mcast: rename br_ip's u member to dst

2020-09-22 Thread Linus Lüssing
On Tue, Sep 22, 2020 at 07:51:19PM +0200, Linus Lüssing wrote: > I don't see a "src" in br_ip in net-next/master at the moment. Or > is that supposed to be added with your IGMPv3 implementation in > the future? Ah, sorry, found the according patch (*) it in my other inbox. Neve

Re: [PATCH net-next v2 06/16] net: bridge: mcast: rename br_ip's u member to dst

2020-09-22 Thread Linus Lüssing
On Tue, Sep 22, 2020 at 10:30:17AM +0300, Nikolay Aleksandrov wrote: > From: Nikolay Aleksandrov > > Since now we have src in br_ip, u no longer makes sense so rename > it to dst. No functional changes. > > v2: fix build with CONFIG_BATMAN_ADV_MCAST Hi Nikolay, I don't see a "src" in br_ip in

[PATCH maint v6 3/3] batman-adv: mcast: fix duplicate mcast packets from BLA backbone to mesh

2020-09-15 Thread Linus Lüssing
-in-unicast packet from a BLA backbone gateway claiming the node and by that avoid potential redundant transmissions in the first place. Fixes: e5cf86d30a9b ("batman-adv: add broadcast duplicate check") Signed-off-by: Linus Lüssing --- net/batman-adv/bridge_loop_avoidan

[PATCH maint v6 2/3] batman-adv: mcast: fix duplicate mcast packets in BLA backbone from mesh

2020-09-15 Thread Linus Lüssing
, 3 address batman-adv unicast header. So let's use this to distinguish. Fixes: e32470167379 ("batman-adv: check incoming packet type for bla") Signed-off-by: Linus Lüssing --- net/batman-adv/bridge_loop_avoidance.c | 34 +++--- net/batman-adv/bridge_loop_avoidance.h

[PATCH maint v5 0/3] batman-adv: mcast: BLA fixes

2020-09-15 Thread Linus Lüssing
These are three fixes for issues which occur when using the batman-adv multicast-to-unicast feature. They fix issues when using the multicast-to-unicast conversion while BLA is enabled and some nodes are sharing the same LAN side. Here it either causes "just" duplicates in the "good" scenario

[PATCH maint v6 1/3] batman-adv: mcast: fix duplicate mcast packets in BLA backbone from LAN

2020-09-15 Thread Linus Lüssing
;batman-adv: Modified forwarding behaviour for multicast packets") Signed-off-by: Linus Lüssing --- net/batman-adv/multicast.c | 46 ++--- net/batman-adv/multicast.h | 15 +++ net/batman-adv/soft-interface.c | 5 ++-- 3 files changed, 53 insertions

[PATCH maint v5 3/3] batman-adv: mcast: fix duplicate mcast packets from BLA backbone to mesh

2020-09-14 Thread Linus Lüssing
-in-unicast packet from a BLA backbone gateway claiming the node and by that avoid potential redundant transmissions in the first place. Fixes: e5cf86d30a9b ("batman-adv: add broadcast duplicate check") Signed-off-by: Linus Lüssing --- net/batman-adv/bridge_loop_avoidan

[PATCH maint v5 1/3] batman-adv: mcast: fix duplicate mcast packets in BLA backbone from LAN

2020-09-14 Thread Linus Lüssing
;batman-adv: Modified forwarding behaviour for multicast packets") Signed-off-by: Linus Lüssing --- net/batman-adv/multicast.c | 46 ++--- net/batman-adv/multicast.h | 15 +++ net/batman-adv/soft-interface.c | 5 ++-- 3 files changed, 53 insertions

[PATCH maint v5 2/3] batman-adv: mcast: fix duplicate mcast packets in BLA backbone from mesh

2020-09-14 Thread Linus Lüssing
, 3 address batman-adv unicast header. So let's use this to distinguish. Fixes: e32470167379 ("batman-adv: check incoming packet type for bla") Signed-off-by: Linus Lüssing --- net/batman-adv/bridge_loop_avoidance.c | 34 +++--- net/batman-adv/bridge_loop_avoidance.h

[PATCH maint v5 0/3] batman-adv: mcast: BLA fixes

2020-09-14 Thread Linus Lüssing
These are three fixes for issues which occur when using the batman-adv multicast-to-unicast feature. They fix issues when using the multicast-to-unicast conversion while BLA is enabled and some nodes are sharing the same LAN side. Here it either causes "just" duplicates in the "good" scenario

[PATCH maint v4 2/3] batman-adv: mcast: fix duplicate mcast packets in BLA backbone from mesh

2020-09-14 Thread Linus Lüssing
, 3 address batman-adv unicast header. So let's use this to distinguish. Fixes: e32470167379 ("batman-adv: check incoming packet type for bla") Signed-off-by: Linus Lüssing --- net/batman-adv/bridge_loop_avoidance.c | 34 +++--- net/batman-adv/bridge_loop_avoidance.h

[PATCH maint v4 0/3] batman-adv: mcast: BLA fixes

2020-09-14 Thread Linus Lüssing
These are three fixes for issues which occur when using the batman-adv multicast-to-unicast feature. They fix issues when using the multicast-to-unicast conversion while BLA is enabled and some nodes are sharing the same LAN side. Here it either causes "just" duplicates in the "good" scenario

[PATCH maint v4 3/3] batman-adv: mcast: fix duplicate mcast packets from BLA backbone to mesh

2020-09-14 Thread Linus Lüssing
-in-unicast packet from a BLA backbone gateway claiming the node and by that avoid potential redundant transmissions in the first place. Fixes: e5cf86d30a9b ("batman-adv: add broadcast duplicate check") Signed-off-by: Linus Lüssing --- net/batman-adv/bridge_loop_avoidan

[PATCH maint v4 1/3] batman-adv: mcast: fix duplicate mcast packets in BLA backbone from LAN

2020-09-14 Thread Linus Lüssing
;batman-adv: Modified forwarding behaviour for multicast packets") Signed-off-by: Linus Lüssing --- net/batman-adv/multicast.c | 46 ++--- net/batman-adv/multicast.h | 15 +++ net/batman-adv/soft-interface.c | 5 ++-- 3 files changed, 53 insertions

[PATCH maint v3 0/3] batman-adv: mcast: BLA fixes

2020-09-13 Thread Linus Lüssing
These are three fixes for issues which occur when using the batman-adv multicast-to-unicast feature. They fix issues when using the multicast-to-unicast conversion while BLA is enabled and some nodes are sharing the same LAN side. Here it either causes "just" duplicates in the "good" scenario

[PATCH maint v3 2/3] batman-adv: mcast: fix duplicate mcast packets in BLA backbone from mesh

2020-09-13 Thread Linus Lüssing
, 3 address batman-adv unicast header. So let's use this to distinguish. Fixes: e32470167379 ("batman-adv: check incoming packet type for bla") Signed-off-by: Linus Lüssing --- net/batman-adv/bridge_loop_avoidance.c | 34 +++--- net/batman-adv/bridge_loop_avoidance.h

[PATCH maint v3 1/3] batman-adv: mcast: fix duplicate mcast packets in BLA backbone from LAN

2020-09-13 Thread Linus Lüssing
;batman-adv: Modified forwarding behaviour for multicast packets") Signed-off-by: Linus Lüssing --- net/batman-adv/multicast.c | 46 ++--- net/batman-adv/multicast.h | 5 net/batman-adv/soft-interface.c | 5 ++-- 3 files changed, 43 insertions(+), 1

[PATCH maint v3 3/3] batman-adv: mcast: fix duplicate mcast packets from BLA backbone to mesh

2020-09-13 Thread Linus Lüssing
-in-unicast packet from a BLA backbone gateway claiming the node and by that avoid potential redundant transmissions in the first place. Fixes: e5cf86d30a9b ("batman-adv: add broadcast duplicate check") Signed-off-by: Linus Lüssing --- net/batman-adv/bridge_loop_avoidan

[PATCH] batctl: tcpdump: Fix endianness in ICMPv6 Echo Request/Reply parsing

2020-09-13 Thread Linus Lüssing
t;) Signed-off-by: Linus Lüssing --- tcpdump.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/tcpdump.c b/tcpdump.c index db93681..b9edc20 100644 --- a/tcpdump.c +++ b/tcpdump.c @@ -589,13 +589,15 @@ static void dump_ipv6(unsigned char *packet_buff, ssize_t

Re: [PATCH maint v2 3/4] batman-adv: mcast: fix duplicate mcast packets in BLA backbone from mesh

2020-09-09 Thread Linus Lüssing
On Wed, Sep 09, 2020 at 04:53:57PM +0200, Linus Lüssing wrote: > So the only solution I could think of for now is > excluding DHCPv6 from multicast feature in TX of the originator... > (in batadv_mcast_forw_mode_check_ipv6(), adding excludes for > ff02::1:2 and ff05::1:3). Ah, wa

Re: [PATCH maint v2 4/4] batman-adv: mcast: fix duplicate mcast packets from BLA backbone to mesh

2020-09-09 Thread Linus Lüssing
On Wed, Sep 09, 2020 at 02:15:51PM +0200, Simon Wunderlich wrote: > On Friday, September 4, 2020 8:28:03 PM CEST Linus Lüssing wrote: > > @@ -1626,7 +1626,8 @@ bool batadv_bla_check_bcast_duplist(struct batadv_priv > > *bat_priv, if (entry->crc != crc) > >

Re: [PATCH maint v2 3/4] batman-adv: mcast: fix duplicate mcast packets in BLA backbone from mesh

2020-09-09 Thread Linus Lüssing
On Wed, Sep 09, 2020 at 04:53:57PM +0200, Linus Lüssing wrote: > So the only solution I could think of for now is > excluding DHCPv6 from multicast feature in TX of the originator... > (in batadv_mcast_forw_mode_check_ipv6(), adding excludes for > ff02::1:2 and ff05::1:3). And t

Re: [PATCH maint v2 3/4] batman-adv: mcast: fix duplicate mcast packets in BLA backbone from mesh

2020-09-09 Thread Linus Lüssing
hdr->h_dest). The former refers to the batman-adv packet header, while the latter refers to the destination MAC of the inner ethernet header. > On Friday, September 4, 2020 8:28:02 PM CEST Linus Lüssing wrote: > > For DHCPv6: This is even trickier... DHCPv6 potentially uses > &g

Re: Is it possible to send all batman-adv traffic through http proxy cache?

2020-09-04 Thread Linus Lüssing
Hi, On Fri, Aug 28, 2020 at 06:00:59PM -0400, Chuck Ritola wrote: > Is it possible to send all batman-adv ethernet traffic through an HTTP > proxy cache such as Squid? Not really, there are a bunch of headers too many for an HTTP caching proxy to work with batman-adv. I'm wondering, are HTTP

[PATCH maint v2 4/4] batman-adv: mcast: fix duplicate mcast packets from BLA backbone to mesh

2020-09-04 Thread Linus Lüssing
-in-unicast packet from a BLA backbone gateway claiming the node and by that avoid potential redundant transmissions in the first place. Fixes: e5cf86d30a9b ("batman-adv: add broadcast duplicate check") Signed-off-by: Linus Lüssing --- net/batman-adv/bridge_loop_avoida

[PATCH maint v2 3/4] batman-adv: mcast: fix duplicate mcast packets in BLA backbone from mesh

2020-09-04 Thread Linus Lüssing
way feature. Ergo, the newly introduced claim check won't wrongly drop a DHCPv6 packet received via the gateway feature either. Fixes: e32470167379 ("batman-adv: check incoming packet type for bla") Signed-off-by: Linus Lüssing --- net/batman-adv/bridge_loop_avoidance.c | 6 -- 1 fi

[PATCH maint v2 1/4] batman-adv: mcast/TT: fix wrongly dropped or rerouted packets

2020-09-04 Thread Linus Lüssing
at the moment and will just continue to send the multicast frame to both the new and old destination for a while in case of such a roaming multicast listener. Fixes: cea194d90b11 ("batman-adv: improved client announcement mechanism") Signed-off-by: Linus Lüssing --- net/batman-adv/routing.c |

[PATCH maint v2 2/4] batman-adv: mcast: fix duplicate mcast packets in BLA backbone from LAN

2020-09-04 Thread Linus Lüssing
;batman-adv: Modified forwarding behaviour for multicast packets") Signed-off-by: Linus Lüssing --- net/batman-adv/send.c | 13 + 1 file changed, 13 insertions(+) diff --git a/net/batman-adv/send.c b/net/batman-adv/send.c index d267b948..67f493c0 100644 --- a/net/batman-adv/send.c +

[PATCH maint v2 0/4] batman-adv: mcast: TT/BLA fixes

2020-09-04 Thread Linus Lüssing
Hi, These are four fixes for issues which occur when using the batman-adv multicast-to-unicast feature. The first one fixes an issue of an intermediate node snitching multicast-to-unicast packets and either dropping it or rerouting it to another node. Which causes lost packets on some and

Re: [PATCH maint 1/4] batman-adv: mcast/TT: fix wrongly dropped or rerouted packets

2020-08-31 Thread Linus Lüssing
Argh, forgot the "Fixes:" lines for all four patches... Need to get some sleep now though, so will need to do that tomorrow (unless someone beats me to it - I wouldn't mind :-) ).

[PATCH maint 4/4] batman-adv: mcast: fix duplicate mcast packets from BLA backbone to mesh

2020-08-31 Thread Linus Lüssing
-in-unicast packet from a BLA backbone gateway claiming the node and by that avoid potential redundant transmissions in the first place. Signed-off-by: Linus Lüssing --- net/batman-adv/bridge_loop_avoidance.c | 86 +- 1 file changed, 70 insertions(+), 16 deletions(-) diff

[PATCH maint 3/4] batman-adv: mcast: fix duplicate mcast packets in BLA backbone from mesh

2020-08-31 Thread Linus Lüssing
way feature. Ergo, the newly introduced claim check won't wrongly drop a DHCPv6 packet received via the gateway feature either. Signed-off-by: Linus Lüssing --- net/batman-adv/bridge_loop_avoidance.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/net/batman-

[PATCH maint 1/4] batman-adv: mcast/TT: fix wrongly dropped or rerouted packets

2020-08-31 Thread Linus Lüssing
at the moment and will just continue to send the multicast frame to both the new and old destination for a while in case of such a roaming multicast listener. Signed-off-by: Linus Lüssing --- net/batman-adv/routing.c | 4 1 file changed, 4 insertions(+) diff --git a/net/batman-adv/routing.c b/net

[PATCH maint 2/4] batman-adv: mcast: fix duplicate mcast packets in BLA backbone from LAN

2020-08-31 Thread Linus Lüssing
ection and neighbor discovery and therefore leads to long delays before being able to establish TCP connections, for instance. And it also leads to the Linux bridge printing messages like: "br-lan: received packet on eth1 with own address as source address ..." Signed-off-by: Linus Lüssing ---

[PATCH] batman-adv: bla: fix type misuse for backbone_gw hash indexing

2020-08-27 Thread Linus Lüssing
From: Linus Lüssing It seems that due to a copy & paste error the void pointer in batadv_choose_backbone_gw() is cast to the wrong type. Fixing this by using "struct batadv_bla_backbone_gw" instead of "struct batadv_bla_claim" which better matches the caller's side.

[PATCH] batman-adv: Fix own OGM check in aggregated OGMs

2020-07-30 Thread Linus Lüssing
. Fixes: 667996ebeab ("batman-adv: OGMv2 - implement originators logic") Signed-off-by: Linus Lüssing --- net/batman-adv/bat_v_ogm.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/net/batman-adv/bat_v_ogm.c b/net/batman-adv/bat_v_ogm.c index 0f8495b9

Re: Batman_V Originator Loop Issue

2020-07-27 Thread Linus Lüssing
On Mon, Jul 27, 2020 at 04:28:15PM -, lavincen...@gmail.com wrote: > Linus > > I would love to try it out and help with the development, but unfortunately I > do not have the time to do that. My internship is coming to a close, and I > need to use a version I know works to provide good

Re: Batman_V Originator Loop Issue

2020-07-24 Thread Linus Lüssing
On Fri, Jul 24, 2020 at 03:00:33PM -, lavincen...@gmail.com wrote: > Linus, > > I have a working network with aggregated_ogms enabled and DAT disabled.I just > tried disabling aggregated_ogms and the network continued to function > properly. I then enabled DAT and the network continued to

Re: Batman_V Originator Loop Issue

2020-07-09 Thread Linus Lüssing
Hi Luke, On Wed, Jul 08, 2020 at 03:26:49PM -, lavincen...@gmail.com wrote: > Simon, > > When I enable DAT on all of my nodes, the network breaks down. With DAT > disabled on all the nodes, the network works fine. > > As I develop my project, I would like to take advantage of the mesh wide

Re: [PATCH] mac80211: mesh: add mesh_param "mesh_nolearn" to skip path discovery

2020-06-17 Thread Linus Lüssing
On 16/06/2020 12:16, Linus Lüssing wrote: The new mesh_nolearn parameter allows to skip the PREQ/PREP exchange in this scenario, leading to a reduced delay, reduced packet buffering and simplifies HWMP in general. And a third observation we've made with HWMP: When running iperf with 16

[PATCH v3] mac80211: mesh: add mesh_param "mesh_nolearn" to skip path discovery

2020-06-17 Thread Linus Lüssing
From: Linus Lüssing Currently, before being able to forward a packet between two 802.11s nodes, both a PLINK handshake is performed upon receiving a beacon and then later a PREQ/PREP exchange for path discovery is performed on demand upon receiving a data frame to forward. When running a mesh

[PATCH v3] iw: mesh: add mesh_param "mesh_nolearn" to skip path discovery

2020-06-17 Thread Linus Lüssing
From: Linus Lüssing Currently, before being able to forward a packet between two 802.11s nodes, both a PLINK handshake is performed upon receiving a beacon and then later a PREQ/PREP exchange for path discovery is performed on demand upon receiving a data frame to forward. When running a mesh

[PATCH v2] iw: mesh: add mesh_param "mesh_nolearn" to skip path discovery

2020-06-16 Thread Linus Lüssing
From: Linus Lüssing Currently, before being able to forward a packet between two 802.11s nodes, both a PLINK handshake is performed upon receiving a beacon and then later a PREQ/PREP exchange for path discovery is performed on demand upon receiving a data frame to forward. When running a mesh

[PATCH v2] mac80211: mesh: add mesh_param "mesh_nolearn" to skip path discovery

2020-06-16 Thread Linus Lüssing
From: Linus Lüssing Currently, before being able to forward a packet between two 802.11s nodes, both a PLINK handshake is performed upon receiving a beacon and then later a PREQ/PREP exchange for path discovery is performed on demand upon receiving a data frame to forward. When running a mesh

Re: [PATCH] mac80211: mesh: add mesh_param "mesh_nolearn" to skip path discovery

2020-06-16 Thread Linus Lüssing
The new mesh_nolearn parameter allows to skip the PREQ/PREP exchange in this scenario, leading to a reduced delay, reduced packet buffering and simplifies HWMP in general. Also another small remark regarding the simplification: Next to the timer re-arming bug / crash [0] we also stumbled over

[PATCH] iw: mesh: add mesh_param "mesh_nolearn" to skip path discovery

2020-06-16 Thread Linus Lüssing
From: Linus Lüssing Currently, before being able to forward a packet between two 802.11s nodes, both a PLINK handshake is performed upon receiving a beacon and then later a PREQ/PREP exchange for path discovery is performed on demand upon receiving a data frame to forward. When running a mesh

[PATCH] mac80211: mesh: add mesh_param "mesh_nolearn" to skip path discovery

2020-06-16 Thread Linus Lüssing
From: Linus Lüssing Currently, before being able to forward a packet between two 802.11s nodes, both a PLINK handshake is performed upon receiving a beacon and then later a PREQ/PREP exchange for path discovery is performed on demand upon receiving a data frame to forward. When running a mesh

Re: [PATCH v2] batctl: Add per interface hop penalty command

2020-06-04 Thread Linus Lüssing
On Thu, Jun 04, 2020 at 09:43:53PM +0200, Linus Lüssing wrote: > This patch extends the hop penalty setting to be configurable not only > on a node scope but also on a per hard interface basis. > > Signed-off-by: Linus Lüssing > --- > README.rst| 7 ++- >

[PATCH v2] batctl: Add per interface hop penalty command

2020-06-04 Thread Linus Lüssing
This patch extends the hop penalty setting to be configurable not only on a node scope but also on a per hard interface basis. Signed-off-by: Linus Lüssing --- README.rst| 7 ++- event.c | 4 hop_penalty.c | 47 +++ man/batctl.8

[PATCH] batctl: Change/fix a throughput override function name

2020-06-01 Thread Linus Lüssing
Fixes a copy and paste error in one of the function names of the throughput override comand. Fixes: e5e6560df828 ("batctl: Add throughput_override setting command") Signed-off-by: Linus Lüssing --- throughput_override.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)

[PATCH] batman-adv: Introduce a configurable per interface hop penalty

2020-06-01 Thread Linus Lüssing
, wire them together with some veth pairs and then tune the hop penalty to achieve an effect similar to a tunable per interface hop penalty. This patch introduces a new, configurable, per hard interface hop penalty to simplify such setups. Signed-off-by: Linus Lüssing --- include/uapi/linux

[PATCH] batctl: Add per interface hop penalty command

2020-06-01 Thread Linus Lüssing
This patch extends the hop penalty setting to be configurable not only on a node scope but also on a per hard interface basis. Signed-off-by: Linus Lüssing --- Makefile | 1 + README.rst | 7 ++- if_hop_penalty.c | 113 +++ man

Re: [PATCH] batman-adv: Add Sven to MAINTAINERS file

2019-08-21 Thread Linus Lüssing
+1

Re: [RFC] batman-adv: ELP - use wifi tx bitrate as fallback throughput

2019-08-11 Thread Linus Lüssing
On Sun, Aug 11, 2019 at 09:07:05PM +0800, Marek Lindner wrote: > From: René Treffer > > Some wifi drivers (e.g. ath10k) provide per-station rx/tx values but no > estimated throughput. Setting a better estimate than the default 1 MBit > makes these devices work well with B.A.T.M.A.N. V. > >

[PATCH v3 1/2] batman-adv: BATMAN_V: introduce per hard-iface OGMv2 queues

2019-08-04 Thread Linus Lüssing
-by: Linus Lüssing --- net/batman-adv/bat_v.c | 7 ++ net/batman-adv/bat_v_ogm.c | 153 - net/batman-adv/bat_v_ogm.h | 3 + net/batman-adv/types.h | 12 +++ 4 files changed, 173 insertions(+), 2 deletions(-) diff --git a/net/batman-adv/bat_v.c b/net

[PATCH v3 2/2] batman-adv: BATMAN_V: aggregate OGMv2 packets

2019-08-04 Thread Linus Lüssing
Instead of transmitting individual OGMv2 packets from the aggregation queue merge those OGMv2 packets into a single one and transmit this aggregate instead. This reduces overhead as it saves an ethernet header and a transmission per aggregated OGMv2 packet. Signed-off-by: Linus Lüssing --- net

[PATCH v3 0/2] batman-adv: BATMAN_V: OGMv2 packet aggregation

2019-08-04 Thread Linus Lüssing
Hi, This small patchset implements the transmission side for the OGMv2 packet aggregation in BATMAN_V. The receiver part was already implemented and seems to work nicely. The first patch implements the necessary queueing mechanism, utilizing skb queues. The second patch then implements the

[PATCH v2 2/2] batman-adv: BATMAN_V: aggregate OGMv2 packets

2019-08-04 Thread Linus Lüssing
Instead of transmitting individual OGMv2 packets from the aggregation queue merge those OGMv2 packets into a single one and transmit this aggregate instead. This reduces overhead as it saves an ethernet header and a transmission per aggregated OGMv2 packet. Signed-off-by: Linus Lüssing --- net

[PATCH v2 0/2] batman-adv: BATMAN_V: OGMv2 packet aggregation

2019-08-04 Thread Linus Lüssing
Hi, This small patchset implements the transmission side for the OGMv2 packet aggregation in BATMAN_V. The receiver part was already implemented and seems to work nicely. The first patch implements the necessary queueing mechanism, utilizing skb queues. The second patch then implements the

[PATCH v2 1/2] batman-adv: BATMAN_V: introduce per hard-iface OGMv2 queues

2019-08-04 Thread Linus Lüssing
-by: Linus Lüssing --- net/batman-adv/bat_v.c | 7 ++ net/batman-adv/bat_v_ogm.c | 152 - net/batman-adv/bat_v_ogm.h | 3 + net/batman-adv/types.h | 15 4 files changed, 175 insertions(+), 2 deletions(-) diff --git a/net/batman-adv/bat_v.c b/net

[PATCH 2/2] batman-adv: BATMAN_V: aggregate OGMv2 packets

2019-08-03 Thread Linus Lüssing
Instead of transmitting individual OGMv2 packets from the aggregation queue merge those OGMv2 packets into a single one and transmit this aggregate instead. This reduces overhead as it saves an ethernet header and a transmission per aggregated OGMv2 packet. Signed-off-by: Linus Lüssing --- net

[PATCH 0/2] batman-adv: BATMAN_V: OGMv2 packet aggregation

2019-08-03 Thread Linus Lüssing
Hi, This small patchset implements the transmission side for the OGMv2 packet aggregation in BATMAN_V. The receiver part was already implemented and seems to work nicely. The first patch implements the necessary queueing mechanism, utilizing skb queues. The second patch then implements the

Re: [PATCH] batman-adv: Fix deletion of RTR(4|6) mcast list entries

2019-07-07 Thread Linus Lüssing
wapper/0/0 > > Fixes: 0a7733468f95 ("batman-adv: mcast: detect, distribute and maintain > multicast router presence") > Signed-off-by: Sven Eckelmann > --- > Cc: Linus Lüssing > > See https://www.open-mesh.org/issues/395 > --- Acked-by: Linus Lüssing

Re: [RFC net-next] net: dsa: add support for MC_DISABLED attribute

2019-07-02 Thread Linus Lüssing
Hi Ido, > Do you differentiate between IPv4 and IPv6 in batman-adv? For most things, yes: The querier state is kept separately for IPv4 and IPv6. And we do have something like a "router node" flag to signalize that a node needs all multicast traffic, which is split into IPv4 and IPv6. The "MDB"

Re: [RFC net-next] net: dsa: add support for MC_DISABLED attribute

2019-06-30 Thread Linus Lüssing
On Sat, Jun 29, 2019 at 07:29:45PM +0300, Ido Schimmel wrote: > I would like to avoid having drivers take the querier state into account > as it will only complicate things further. I absolutely share your pain. Initially in the early prototypes of multicast awareness in batman-adv we did not

Re: [PATCH 2/4] batctl: Integrate hardif setting framework

2019-06-16 Thread Linus Lüssing
On Thu, Jun 13, 2019 at 09:12:15PM +0200, Sven Eckelmann wrote: > batctl currently supports settings which are either mesh interface or vlan > specific. But B.A.T.M.A.N. V introduced two additional settings which are > hard (slave) interface specific. > > To support these, an additional command

[PATCH v5 2/2] batman-adv: mcast: apply optimizations for routable packets, too

2019-06-11 Thread Linus Lüssing
Now that we not only track the presence of multicast listeners but also multicast routers we can safely apply group-aware multicast-to-unicast forwarding to packets with a destination address of scope greater than link-local as well. Signed-off-by: Linus Lüssing --- net/batman-adv/multicast.c

[PATCH v5 1/2] batman-adv: mcast: detect, distribute and maintain multicast router presence

2019-06-11 Thread Linus Lüssing
st notably not just multicast routers but also unicast ones and is not applicable for IPv4). If no multicast router is detected then this is signalized via the new BATADV_MCAST_WANT_NO_RTR4 and BATADV_MCAST_WANT_NO_RTR6 multicast tvlv flags. Signed-off-by: Linus Lüssing --- include/uapi/linux/batad

[PATCH v5 0/2] batman-adv: Add routable multicast optimizations

2019-06-11 Thread Linus Lüssing
The following patchset fills the next gaps in the multicast address rules page by adding support for group-aware optimizations for multicast addresses of scope greater than link-local. So far, only link-local addresses were optimized as packets with routable addresses not only need to be forwarded

Re: [PATCH v4 1/2] batman-adv: mcast: detect, distribute and maintain multicast router presence

2019-06-10 Thread Linus Lüssing
On Tue, Jun 11, 2019 at 01:14:14AM +0200, Linus Lüssing wrote: > On Mon, Jun 10, 2019 at 09:24:26AM +0200, Sven Eckelmann wrote: > > On Monday, 10 June 2019 02:45:34 CEST Linus Lüssing wrote: > > > @@ -107,12 +107,20 @@ enum batadv_icmp_packettype { > > > * @BATADV_

Re: [PATCH v4 1/2] batman-adv: mcast: detect, distribute and maintain multicast router presence

2019-06-10 Thread Linus Lüssing
On Mon, Jun 10, 2019 at 09:24:26AM +0200, Sven Eckelmann wrote: > On Monday, 10 June 2019 02:45:34 CEST Linus Lüssing wrote: > > @@ -107,12 +107,20 @@ enum batadv_icmp_packettype { > > * @BATADV_MCAST_WANT_ALL_UNSNOOPABLES: we want all packets destined for > > * 22

[PATCH v4 2/2] batman-adv: mcast: apply optimizations for routeable packets, too

2019-06-09 Thread Linus Lüssing
Now that we not only track the presence of multicast listeners but also multicast routers we can safely apply group-aware multicast-to-unicast forwarding to packets with a destination address of scope greater than link-local as well. Signed-off-by: Linus Lüssing --- net/batman-adv/multicast.c

[PATCH v4 1/2] batman-adv: mcast: detect, distribute and maintain multicast router presence

2019-06-09 Thread Linus Lüssing
ility - so that old nodes will always have them "set"). Signed-off-by: Linus Lüssing --- include/uapi/linux/batadv_packet.h | 8 + net/batman-adv/multicast.c | 404 + net/batman-adv/originator.c| 3 +- net/batman-adv/types.h

[PATCH v4 0/2] batman-adv: Add routeable multicast optimizations

2019-06-09 Thread Linus Lüssing
The following patchset fills the next gaps in the multicast address rules page by adding support for group-aware optimizations for multicast addresses of scope greater than link-local. So far, only link-local addresses were optimized as packets with routeable addresses not only need to be

Re: [PATCH v3 1/2] batman-adv: mcast: detect, distribute and maintain multicast router presence

2019-06-08 Thread Linus Lüssing
On Thu, Jun 06, 2019 at 05:48:32PM +0200, Sven Eckelmann wrote: > On Sunday, 26 May 2019 18:48:28 CEST Linus Lüssing wrote: > > If a multicast router is detected then this is signalized via the new > > BATADV_MCAST_WANT_ALL_RTR4 and BATADV_MCAST_WANT_ALL_RTR6 > > multic

Re: [PATCH maint v2] batman-adv: Fix duplicated OGMs on NETDEV_UP

2019-06-02 Thread Linus Lüssing
_interface processed the new interface or when a > NETDEV_UP event was received for this slave interfac. As result, each > NETDEV_UP would schedule a new OGM worker for the interface and thus OGMs > would be send a lot more than expected. > > Fixes: 0d8468553c3c ("batman-adv: remove

[PATCH v3 2/2] batman-adv: mcast: apply optimizations for routeable packets, too

2019-05-26 Thread Linus Lüssing
Now that we not only track the presence of multicast listeners but also multicast routers we can safely apply group-aware multicast-to-unicast forwarding to packets with a destination address of scope greater than link-local as well. Signed-off-by: Linus Lüssing --- net/batman-adv/multicast.c

[PATCH v3 0/2] batman-adv: Add routeable multicast optimizations

2019-05-26 Thread Linus Lüssing
The following patchset fills the next gaps in the multicast address rules page by adding support for group-aware optimizations for multicast addresses of scope greater than link-local. So far, only link-local addresses were optimized as packets with routeable addresses not only need to be

[PATCH v3 1/2] batman-adv: mcast: detect, distribute and maintain multicast router presence

2019-05-26 Thread Linus Lüssing
ility - so that old nodes will always have them "set"). Signed-off-by: Linus Lüssing --- include/uapi/linux/batadv_packet.h | 8 + net/batman-adv/multicast.c | 414 + net/batman-adv/types.h | 29 ++ 3 files changed, 400 insertions(+), 5

[PATCH v4 2/2] batman-adv: mcast: avoid redundant multicast TT entries with bridges

2019-05-26 Thread Linus Lüssing
is redundant to the WANT_ALL_UNSNOOPABLES. With this patch such redundant TT entries are avoided. Signed-off-by: Linus Lüssing --- net/batman-adv/multicast.c | 33 +++-- 1 file changed, 27 insertions(+), 6 deletions(-) diff --git a/net/batman-adv/multicast.c b/net/batman-adv

[PATCH v4 1/2] batman-adv: mcast: collect softif listeners from IP lists instead

2019-05-26 Thread Linus Lüssing
. Signed-off-by: Linus Lüssing --- net/batman-adv/multicast.c | 258 + 1 file changed, 173 insertions(+), 85 deletions(-) diff --git a/net/batman-adv/multicast.c b/net/batman-adv/multicast.c index af0e2ce8..693e3bba 100644 --- a/net/batman-adv/multicast.c +++ b

[PATCH v4 0/2] batman-adv: routeable multicast preparations

2019-05-26 Thread Linus Lüssing
This patchset provides some code restructuring in preparation for the support of routeable multicast addresses. The first one swaps the kernel MAC multicast list with the equivalent IPv4 and IPv6 ones: This allows an easier filtering later. Patch 2 is a first application of such filtering and

Re: [PATCH v2] batman-adv: Introduce no noflood mark

2019-05-14 Thread Linus Lüssing
On Tue, May 07, 2019 at 05:17:23PM +0200, Linus Lüssing wrote: > Maybe more importantly even before the bcast_packet->seqno is > increased. It could become an issue if a node were increasing it's > seqno quickly without other nodes noticing the new seqnos. > Broadcast packets

[PATCH 2/3] batman-adv: allow broadcast packet type with unicast destination

2019-05-14 Thread Linus Lüssing
this patch relaxes the ethernet destination check for batman-adv broadcast packets and adds the necessary capability tracking for later compatibility checking. Signed-off-by: Linus Lüssing --- include/uapi/linux/batadv_packet.h | 2 + net/batman-adv/bat_iv_ogm.c| 6 ++- net/batman-adv

[PATCH 0/3] batman-adv: broadcast flooding improvements

2019-05-14 Thread Linus Lüssing
Hi, This patchset adds two improvements for the broadcast flooding algorithm: The first patch refactors/reorders the broadcast packet queueing. Before a broadcast packet was always queued. Now the queueing decision is performed on a per interface basis. Also the first broadcast is always

[PATCH 3/3] batman-adv: forward broadcast packets via unicast transmissions

2019-05-14 Thread Linus Lüssing
) to further reduce unicast transmissions. Signed-off-by: Linus Lüssing --- net/batman-adv/hard-interface.c | 1 + net/batman-adv/routing.c| 38 net/batman-adv/send.c | 156 net/batman-adv/types.h | 8 ++ 4 files changed, 203

[PATCH 1/3] batman-adv: bcast: queue per interface, if needed

2019-05-14 Thread Linus Lüssing
alternative strategies for transmissions on wireless interfaces in the future (for instance sending via unicast transmissions on wireless interfaces, without queueing in batman-adv, if appropriate). Signed-off-by: Linus Lüssing --- net/batman-adv/main.h | 1 - net/batman-adv/routing.c

Re: [PATCH v2] batman-adv: Introduce no noflood mark

2019-05-07 Thread Linus Lüssing
On Tue, May 07, 2019 at 05:17:23PM +0200, Linus Lüssing wrote: > > This would even allow some fancy stuff like rate limiting or per hardif > > behavior. With the problem that there is no package yet which does this in > > gluon. > > Ah, that's an interesting idea

Re: [PATCH v2] batman-adv: Introduce no noflood mark

2019-05-07 Thread Linus Lüssing
On Tue, May 07, 2019 at 10:21:40AM +0200, Sven Eckelmann wrote: > On Tuesday, 7 May 2019 10:00:18 CEST Marek Lindner wrote: > [...] > > > I still don't see why this has to be implemented in batman-adv and not as > > > an > > > external filter (tc-ebpf or something like that). > > > > As I

[PATCH v3] batctl: Add noflood_mark command

2019-05-07 Thread Linus Lüssing
Adds support for the new 'noflood_mark' setting in batman-adv. Signed-off-by: Linus Lüssing --- Changelog v3: * changed command from a noflood tri-state option to a value/mask one similar to the isolation mark * noflood.c -> noflood_mark.c Changelog v2: * added noflood.c --- Makef

[PATCH v2] batman-adv: Introduce no noflood mark

2019-05-07 Thread Linus Lüssing
to a limited number of nodes only and are therefore creating no burdon to unrelated nodes. Signed-off-by: Linus Lüssing --- https://www.open-mesh.org/projects/batman-adv/wiki/Noflood-broadcast-prevention Changelog v2: * rebased to master * sysfs -> netlink --- include/uapi/linux/batman_adv.h |

Re: [B.A.T.M.A.N.] [PATCH 0/6] batman-adv: Add routeable multicast optimizations

2019-05-06 Thread Linus Lüssing
On Sun, May 05, 2019 at 07:37:48PM +0200, Sven Eckelmann wrote: > ecsv/pu: headers > > > diff --git a/net/batman-adv/multicast.c b/net/batman-adv/multicast.c > index ca4898d3..f106728b 100644 > --- a/net/batman-adv/multicast.c > +++ b/net/batman-adv/multicast.c >

[PATCH v2 0/2] batman-adv: Add routeable multicast optimizations

2019-05-06 Thread Linus Lüssing
The following patchset fills the next gaps in the multicast address rules page by adding support for group-aware optimizations for multicast addresses of scope greater than link-local. So far, only link-local addresses were optimized as packets with routeable addresses not only need to be

[PATCH v2 2/2] batman-adv: mcast: apply optimizations for routeable packets, too

2019-05-06 Thread Linus Lüssing
Now that we not only track the presence of multicast listeners but also multicast routers we can safely apply group-aware multicast-to-unicast forwarding to packets with a destination address of scope greater than link-local as well. Signed-off-by: Linus Lüssing --- net/batman-adv/multicast.c

<    1   2   3   4   5   6   7   8   9   10   >