Re: [PATCH net v2] bridge: mcast: fix disabled snooping after long uptime

2024-01-27 Thread Nikolay Aleksandrov
;) > Signed-off-by: Linus Lüssing > --- > Changelog v2: > * removed "inline" from br_multicast_query_delay_expired() > > net/bridge/br_multicast.c | 20 +++----- > net/bridge/br_private.h | 4 ++-- > 2 files changed, 17 insertions(+), 7 deletions(-) > Acked-by: Nikolay Aleksandrov

Re: [PATCH v3 net-next] net: make use of helper netif_is_bridge_master()

2021-10-16 Thread Nikolay Aleksandrov via B.A.T.M.A.N
r_mdb.c | 4 ++-- > net/bridge/br_netfilter_hooks.c | 2 +- > net/bridge/br_netlink.c | 4 ++-- > net/core/rtnetlink.c | 2 +- > 9 files changed, 14 insertions(+), 14 deletions(-) > LGTM, Reviewed-by: Nikolay Aleksandrov --- End Message ---

Re: [net-next v2 10/11] net: bridge: mcast: add ip4+ip6 mcast router timers to mdb netlink

2021-05-11 Thread Nikolay Aleksandrov
: Linus Lüssing > --- > include/uapi/linux/if_bridge.h | 2 ++ > net/bridge/br_mdb.c| 8 +++- > 2 files changed, 9 insertions(+), 1 deletion(-) > Acked-by: Nikolay Aleksandrov > diff --git a/include/uapi/linux/if_bridge.h b/include/uapi/linux/if_bridge.

Re: [net-next v2 09/11] net: bridge: mcast: split multicast router state for IPv4 and IPv6

2021-05-11 Thread Nikolay Aleksandrov
On 11/05/2021 12:29, Nikolay Aleksandrov wrote: > On 09/05/2021 22:45, Linus Lüssing wrote: >> A multicast router for IPv4 does not imply that the same host also is a >> multicast router for IPv6 and vice versa. >> >> To reduce multicast traffic when a host is only a

Re: [net-next v2 11/11] net: bridge: mcast: export multicast router presence adjacent to a port

2021-05-11 Thread Nikolay Aleksandrov
On 09/05/2021 22:45, Linus Lüssing wrote: > To properly support routable multicast addresses in batman-adv in a > group-aware way, a batman-adv node needs to know if it serves multicast > routers. > > This adds a function to the bridge to export this so that batman-adv > can then make full use of

Re: [net-next v2 09/11] net: bridge: mcast: split multicast router state for IPv4 and IPv6

2021-05-11 Thread Nikolay Aleksandrov
On 09/05/2021 22:45, Linus Lüssing wrote: > A multicast router for IPv4 does not imply that the same host also is a > multicast router for IPv6 and vice versa. > > To reduce multicast traffic when a host is only a multicast router for > one of these two protocol families, keep router state for

Re: [net-next v2 08/11] net: bridge: mcast: split router port del+notify for mcast router split

2021-05-11 Thread Nikolay Aleksandrov
On 09/05/2021 22:45, Linus Lüssing wrote: > In preparation for the upcoming split of multicast router state into > their IPv4 and IPv6 variants split router port deletion and notification > into two functions. When we disable a port for instance later we want to > only send one notification to

Re: [net-next v2 06/11] net: bridge: mcast: prepare expiry functions for mcast router split

2021-05-11 Thread Nikolay Aleksandrov
On 09/05/2021 22:45, Linus Lüssing wrote: > In preparation for the upcoming split of multicast router state into > their IPv4 and IPv6 variants move the protocol specific timer access to > an ip4 wrapper function. > > Signed-off-by: Linus Lüssing > --- > net/bridge/br_multicast.c | 31

Re: [net-next v2 05/11] net: bridge: mcast: prepare is-router function for mcast router split

2021-05-11 Thread Nikolay Aleksandrov
gt; > Signed-off-by: Linus Lüssing > --- > net/bridge/br_input.c | 2 +- > net/bridge/br_multicast.c | 5 +++-- > net/bridge/br_private.h | 36 > 3 files changed, 36 insertions(+), 7 deletions(-) > Minor comment below, but either wa

Re: [net-next v2 04/11] net: bridge: mcast: prepare query reception for mcast router split

2021-05-11 Thread Nikolay Aleksandrov
ip6 variants for br_multicast_query_received(). > > Signed-off-by: Linus Lüssing > --- > net/bridge/br_multicast.c | 53 --- > 1 file changed, 27 insertions(+), 26 deletions(-) > Acked-by: Nikolay Aleksandrov > diff --git a/net/bridge/br_multicast.c b/

Re: [net-next v2 03/11] net: bridge: mcast: prepare mdb netlink for mcast router split

2021-05-11 Thread Nikolay Aleksandrov
On 09/05/2021 22:45, Linus Lüssing wrote: > In preparation for the upcoming split of multicast router state into > their IPv4 and IPv6 variants and to avoid IPv6 #ifdef clutter later add > some inline functions for the protocol specific parts in the mdb router > netlink code. Also the we need

Re: [net-next v2 02/11] net: bridge: mcast: add wrappers for router node retrieval

2021-05-11 Thread Nikolay Aleksandrov
On 09/05/2021 22:45, Linus Lüssing wrote: > In preparation for the upcoming split of multicast router state into > their IPv4 and IPv6 variants and to avoid IPv6 #ifdef clutter later add > two wrapper functions for router node retrieval in the payload > forwarding code. > > Signed-off-by: Linus

Re: [net-next v2 01/11] net: bridge: mcast: rename multicast router lists and timers

2021-05-11 Thread Nikolay Aleksandrov
--- > net/bridge/br_forward.c | 2 +- > net/bridge/br_mdb.c | 6 ++--- > net/bridge/br_multicast.c | 48 +++ > net/bridge/br_private.h | 10 > 4 files changed, 33 insertions(+), 33 deletions(-) > Acked-by: Nikolay Ale

Re: [PATCH net-next 1/2] net: bridge: mcast: split multicast router state for IPv4 and IPv6

2021-04-25 Thread Nikolay Aleksandrov
On 25/04/2021 19:00, Linus Lüssing wrote: > A multicast router for IPv4 does not imply that the same host also is a > multicast router for IPv6 and vice versa. > > To reduce multicast traffic when a host is only a multicast router for > one of these two protocol families, keep router state for

[PATCH net-next v2 06/16] net: bridge: mcast: rename br_ip's u member to dst

2020-09-22 Thread Nikolay Aleksandrov
From: Nikolay Aleksandrov Since now we have src in br_ip, u no longer makes sense so rename it to dst. No functional changes. v2: fix build with CONFIG_BATMAN_ADV_MCAST CC: Marek Lindner CC: Simon Wunderlich CC: Antonio Quartulli CC: Sven Eckelmann CC: b.a.t.m.a.n@lists.open-mesh.org

Re: [PATCH net-next 06/16] net: bridge: mcast: rename br_ip's u member to dst

2020-09-21 Thread Nikolay Aleksandrov
On Mon, 2020-09-21 at 21:30 +0800, kernel test robot wrote: > Hi Nikolay, > > I love your patch! Yet something to improve: > > [auto build test ERROR on net-next/master] > > url: > https://github.com/0day-ci/linux/commits/Nikolay-Aleksandrov/net-bridge-mcast-IGMPv

[PATCH net-next 06/16] net: bridge: mcast: rename br_ip's u member to dst

2020-09-21 Thread Nikolay Aleksandrov
From: Nikolay Aleksandrov Since now we have src in br_ip, u no longer makes sense so rename it to dst. No functional changes. CC: Marek Lindner CC: Simon Wunderlich CC: Antonio Quartulli CC: b.a.t.m.a.n@lists.open-mesh.org Signed-off-by: Nikolay Aleksandrov --- include/linux/if_bridge.h

Re: [RFC net-next] net: dsa: add support for MC_DISABLED attribute

2019-07-02 Thread Nikolay Aleksandrov
On 30/06/2019 19:56, Linus Lüssing wrote: > On Sat, Jun 29, 2019 at 07:29:45PM +0300, Ido Schimmel wrote: >> I would like to avoid having drivers take the querier state into account >> as it will only complicate things further. > > I absolutely share your pain. Initially in the early prototypes

Re: [B.A.T.M.A.N.] [PATCH net-next 0/4] bridge: implement Multicast Router Discovery (RFC4286)

2018-12-21 Thread Nikolay Aleksandrov
On 12/21/18 5:15 PM, Linus Lüssing wrote: > Hi, > > This patchset adds initial Multicast Router Discovery support to > the Linux bridge (RFC4286). With MRD it is possible to detect multicast > routers and mark bridge ports and forward multicast packets to such routers > accordingly. > > So far,