Re: [B.A.T.M.A.N.] [PATCH maint] batman-adv: Fix transmission of final, 16th fragment

2017-02-21 Thread Sven Eckelmann
On Montag, 13. Februar 2017 20:44:31 CET Linus Lüssing wrote: > Trying to split and transmit a unicast packet in 16 parts will fail for > the final fragment: After having sent the 15th one with a frag_packet.no > index of 14, we will increase the the index to 15 - and return with an > error code

Re: [B.A.T.M.A.N.] [PATCH maint] batman-adv: Fix transmission of final, 16th fragment

2017-02-14 Thread Linus Lüssing
On Mon, Feb 13, 2017 at 10:23:52PM +0100, Sven Eckelmann wrote: > On Montag, 13. Februar 2017 21:00:08 CET Linus Lüssing wrote: > [...] > > And one more thing which seems fishy to me in this function: > > > > 526 /* Make room for the fragment header. */ > > 527 if

Re: [B.A.T.M.A.N.] [PATCH maint] batman-adv: Fix transmission of final, 16th fragment

2017-02-13 Thread Sven Eckelmann
On Montag, 13. Februar 2017 21:00:08 CET Linus Lüssing wrote: [...] > And one more thing which seems fishy to me in this function: > > 526 /* Make room for the fragment header. */ > 527 if (batadv_skb_head_push(skb, header_size) < 0 || > 528 pskb_expand_head(skb,

Re: [B.A.T.M.A.N.] [PATCH maint] batman-adv: Fix transmission of final, 16th fragment

2017-02-13 Thread Sven Eckelmann
On Montag, 13. Februar 2017 20:44:31 CET Linus Lüssing wrote: > Trying to split and transmit a unicast packet in 16 parts will fail for > the final fragment: After having sent the 15th one with a frag_packet.no > index of 14, we will increase the the index to 15 - and return with an > error code

Re: [B.A.T.M.A.N.] [PATCH maint] batman-adv: Fix transmission of final, 16th fragment

2017-02-13 Thread Linus Lüssing
On Mon, Feb 13, 2017 at 08:44:31PM +0100, Linus Lüssing wrote: > Trying to split and transmit a unicast packet in 16 parts will fail for > the final fragment: After having sent the 15th one with a frag_packet.no > index of 14, we will increase the the index to 15 - and return with an > error code

[B.A.T.M.A.N.] [PATCH maint] batman-adv: Fix transmission of final, 16th fragment

2017-02-13 Thread Linus Lüssing
Trying to split and transmit a unicast packet in 16 parts will fail for the final fragment: After having sent the 15th one with a frag_packet.no index of 14, we will increase the the index to 15 - and return with an error code immediately, even though one more fragment is due for transmission and