Re: [B.A.T.M.A.N.] [RFCv3] batman-adv: Modified DAT structures and functions in order to support both IPv4 and IPv6

2013-04-20 Thread Antonio Quartulli
On Fri, Apr 19, 2013 at 09:39:17 +0300, Mihail Costea wrote: On 19 April 2013 15:38, Antonio Quartulli or...@autistici.org wrote: I think this define is pretty overkill..What about creating a function which only takes care of converting a generic DHT data in a string. Later you can invoke

Re: [B.A.T.M.A.N.] [RFCv3] batman-adv: Modified DAT structures and functions in order to support both IPv4 and IPv6

2013-04-20 Thread Mihail Costea
On 20 April 2013 16:56, Antonio Quartulli or...@autistici.org wrote: On Fri, Apr 19, 2013 at 09:39:17 +0300, Mihail Costea wrote: On 19 April 2013 15:38, Antonio Quartulli or...@autistici.org wrote: I think this define is pretty overkill..What about creating a function which only takes

Re: [B.A.T.M.A.N.] [RFCv3] batman-adv: Modified DAT structures and functions in order to support both IPv4 and IPv6

2013-04-19 Thread Antonio Quartulli
Hi Mihail, On Mon, Apr 15, 2013 at 12:37:33PM +0300, Mihail Costea wrote: [...] +#ifdef CONFIG_BATMAN_ADV_DEBUG + +#if IS_ENABLED(CONFIG_IPV6) + +/* batadv_dat_dbg_ip - print similar debug message for IPv4 and IPv6. + * @bat_priv: the bat priv with all the soft interface information +

Re: [B.A.T.M.A.N.] [RFCv3] batman-adv: Modified DAT structures and functions in order to support both IPv4 and IPv6

2013-04-19 Thread Mihail Costea
On 19 April 2013 15:38, Antonio Quartulli or...@autistici.org wrote: Hi Mihail, On Mon, Apr 15, 2013 at 12:37:33PM +0300, Mihail Costea wrote: [...] +#ifdef CONFIG_BATMAN_ADV_DEBUG + +#if IS_ENABLED(CONFIG_IPV6) + +/* batadv_dat_dbg_ip - print similar debug message for IPv4 and

[B.A.T.M.A.N.] [RFCv3] batman-adv: Modified DAT structures and functions in order to support both IPv4 and IPv6

2013-04-15 Thread Mihail Costea
Subject: [RFCv3] batman-adv: Modified DAT structures and functions in order to support both IPv4 and IPv6 Signed-off-by: Mihail Costea mihail.coste...@gmail.com Signed-off-by: Stefan Popa stefan.a.p...@intel.com Reviewed-by: Stefan Popa stefan.a.p...@intel.com --- Removed the ugly debug