Re: [PATCH v3] batman-adv: Add flex array to struct batadv_tvlv_tt_data

2024-05-09 Thread Erick Archer
Hi Sven and Kees, First of all, thanks for the reviews, comments and advices. On Mon, May 06, 2024 at 09:27:46AM -0700, Kees Cook wrote: > On Sat, May 04, 2024 at 07:08:39PM +0200, Erick Archer wrote: > > > If this is the right path, can these changes be merged into a > > single patch or is it

Re: [PATCH v3] batman-adv: Add flex array to struct batadv_tvlv_tt_data

2024-05-06 Thread Kees Cook
On Sun, May 05, 2024 at 05:22:10PM +0200, Sven Eckelmann wrote: > On Saturday, 4 May 2024 19:08:39 CEST Erick Archer wrote: > [...] > > > Thanks for the updates. But I can't accept this at the moment because > > > __counted_by_be is used in an uapi header without it being defined > > >

Re: [PATCH v3] batman-adv: Add flex array to struct batadv_tvlv_tt_data

2024-05-06 Thread Kees Cook
On Sat, May 04, 2024 at 07:08:39PM +0200, Erick Archer wrote: > Hi Sven, > > On Sat, May 04, 2024 at 11:35:38AM +0200, Sven Eckelmann wrote: > > On Wednesday, 1 May 2024 17:02:42 CEST Erick Archer wrote: > > > diff --git a/include/uapi/linux/batadv_packet.h > > >

Re: [PATCH v3] batman-adv: Add flex array to struct batadv_tvlv_tt_data

2024-05-05 Thread Sven Eckelmann
On Saturday, 4 May 2024 19:08:39 CEST Erick Archer wrote: [...] > > Thanks for the updates. But I can't accept this at the moment because > > __counted_by_be is used in an uapi header without it being defined > > include/uapi/linux/stddef.h (and this file is also not included in this > >

Re: [PATCH v3] batman-adv: Add flex array to struct batadv_tvlv_tt_data

2024-05-04 Thread Erick Archer
Hi Sven, On Sat, May 04, 2024 at 11:35:38AM +0200, Sven Eckelmann wrote: > On Wednesday, 1 May 2024 17:02:42 CEST Erick Archer wrote: > > diff --git a/include/uapi/linux/batadv_packet.h > > b/include/uapi/linux/batadv_packet.h > > index 6e25753015df..dfbe30536995 100644 > > ---

Re: [PATCH v3] batman-adv: Add flex array to struct batadv_tvlv_tt_data

2024-05-04 Thread Sven Eckelmann
On Wednesday, 1 May 2024 17:02:42 CEST Erick Archer wrote: > diff --git a/include/uapi/linux/batadv_packet.h > b/include/uapi/linux/batadv_packet.h > index 6e25753015df..dfbe30536995 100644 > --- a/include/uapi/linux/batadv_packet.h > +++ b/include/uapi/linux/batadv_packet.h [...] > +/** > + *

Re: [PATCH v3] batman-adv: Add flex array to struct batadv_tvlv_tt_data

2024-05-01 Thread Kees Cook
On Wed, May 01, 2024 at 05:02:42PM +0200, Erick Archer wrote: > The "struct batadv_tvlv_tt_data" uses a dynamically sized set of > trailing elements. Specifically, it uses an array of structures of type > "batadv_tvlv_tt_vlan_data". So, use the preferred way in the kernel > declaring a flexible

[PATCH v3] batman-adv: Add flex array to struct batadv_tvlv_tt_data

2024-05-01 Thread Erick Archer
The "struct batadv_tvlv_tt_data" uses a dynamically sized set of trailing elements. Specifically, it uses an array of structures of type "batadv_tvlv_tt_vlan_data". So, use the preferred way in the kernel declaring a flexible array [1]. At the same time, prepare for the coming implementation by