Re: [B.A.T.M.A.N.] [PATCH] batman-adv: Add get_ethtool_stats() support

2012-04-17 Thread Antonio Quartulli
On Tue, Apr 17, 2012 at 01:24:55 +0200, Martin Hundebøll wrote: @@ -488,6 +492,8 @@ bool dat_snoop_outgoing_arp_reply(struct bat_priv *bat_priv, arp_neigh_update(bat_priv, ip_src, hw_src); arp_neigh_update(bat_priv, ip_dst, hw_dst); + bat_priv-bat_stats.dat_reply_tx++; +

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: Add get_ethtool_stats() support

2012-04-17 Thread Antonio Quartulli
On Tue, Apr 17, 2012 at 09:12:42AM +0200, Antonio Quartulli wrote: On Tue, Apr 17, 2012 at 01:24:55 +0200, Martin Hundebøll wrote: +static void bat_get_ethtool_stats(struct net_device *dev, + struct ethtool_stats *stats, u64 *data) +{ + struct bat_priv

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: Add get_ethtool_stats() support

2012-04-17 Thread Marek Lindner
On Tuesday, April 17, 2012 01:24:55 Martin Hundebøll wrote: Added additional counters in a bat_stats structure, which are exported through the ethtool api. The counters are specific to batman-adv and includes: forwarded packets management packets (OGMs at this point) translation table

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: Add get_ethtool_stats() support

2012-04-17 Thread Martin Hundebøll
Hi Antonio, Thank you for your comments. On 04/17/2012 09:12 AM, Antonio Quartulli wrote: On Tue, Apr 17, 2012 at 01:24:55 +0200, Martin Hundebøll wrote: @@ -488,6 +492,8 @@ bool dat_snoop_outgoing_arp_reply(struct bat_priv *bat_priv, arp_neigh_update(bat_priv, ip_src, hw_src);

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: Add get_ethtool_stats() support

2012-04-17 Thread Martin Hundebøll
Hi Marek, On 04/17/2012 10:19 AM, Marek Lindner wrote: On Tuesday, April 17, 2012 01:24:55 Martin Hundebøll wrote: Added additional counters in a bat_stats structure, which are exported through the ethtool api. The counters are specific to batman-adv and includes: forwarded packets

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: Add get_ethtool_stats() support

2012-04-17 Thread Antonio Quartulli
On Tue, Apr 17, 2012 at 03:24:48PM +0200, Martin Hundebøll wrote: +struct bat_stats { + uint64_t forward; + uint64_t mgmt_tx; + uint64_t mgmt_rx; + uint64_t tt_request_tx; + uint64_t tt_request_rx; + uint64_t tt_response_tx; + uint64_t tt_response_rx; + uint64_t