Re: [B.A.T.M.A.N.] [PATCHv2] batman-adv: fix visualization output without neighbors on the primary interface

2012-05-10 Thread Matthias Schiffer
On 05/09/2012 06:10 PM, Martin Hundebøll wrote: While reading about TLV's on wikipedia[1], I came across a MAC discovery protocol[2], LLDP, which eventually lead me to OpenLLDP[3]. If this also works on 802.11, I think we have a winner :) Okay, so I tested 4 open-source LLDP implementations

Re: [B.A.T.M.A.N.] [PATCHv2] batman-adv: fix visualization output without neighbors on the primary interface

2012-05-10 Thread Marek Lindner
On Friday, May 11, 2012 03:47:30 Matthias Schiffer wrote: 1st, implementations [1-3] aren't very configurable, and [4], an implementation by Intel, is hard to configure and *huge* (stripped binary ~400KB). Most of the implementations don't support announcing IPv6 addresses (I'm not sure which

Re: [B.A.T.M.A.N.] [PATCHv2] batman-adv: fix visualization output without neighbors on the primary interface

2012-05-10 Thread Matthias Schiffer
On 05/10/2012 10:19 PM, Marek Lindner wrote: On Friday, May 11, 2012 03:47:30 Matthias Schiffer wrote: 2nd, I think without batman-adv specific extensions LLDP isn't very useful, as the LLDP daemon only cares about the bat0/bridge MAC addresses, and not the hardif MAC addresses which are

Re: [B.A.T.M.A.N.] [PATCHv2] batman-adv: fix visualization output without neighbors on the primary interface

2012-05-09 Thread Marek Lindner
On Wednesday, May 09, 2012 04:52:18 Guido Iribarren wrote: I see your point, but then one could also ask why the visualization has to be in the kernel at all... That is a valid question and has been debated several times already. The vis server is a borderline case - the consensus is/was

Re: [B.A.T.M.A.N.] [PATCHv2] batman-adv: fix visualization output without neighbors on the primary interface

2012-05-09 Thread Martin Hundebøll
Hi Guido, On 05/08/2012 10:52 PM, Guido Iribarren wrote: mDNS solutions like avahi translate between hostnames and ips, while batman visualization deals with MACs, and those cannot necessarily be obtained from IPs (in some cases, ARP will help, but won't work in interfaces without IPs) maybe

Re: [B.A.T.M.A.N.] [PATCHv2] batman-adv: fix visualization output without neighbors on the primary interface

2012-05-08 Thread Marek Lindner
On Monday, May 07, 2012 19:10:19 Matthias Schiffer wrote: On 05/07/2012 08:40 AM, Marek Lindner wrote: If you wish to replace the mac addresses with readable name you can simply use a bat-hosts file to tell batctl which mac address should be replaced. Check the bat-hosts section in our

Re: [B.A.T.M.A.N.] [PATCHv2] batman-adv: fix visualization output without neighbors on the primary interface

2012-05-08 Thread Matthias Schiffer
On 05/08/2012 08:04 AM, Marek Lindner wrote: On Monday, May 07, 2012 19:10:19 Matthias Schiffer wrote: On 05/07/2012 08:40 AM, Marek Lindner wrote: If you wish to replace the mac addresses with readable name you can simply use a bat-hosts file to tell batctl which mac address should be

Re: [B.A.T.M.A.N.] [PATCHv2] batman-adv: fix visualization output without neighbors on the primary interface

2012-05-08 Thread Guido Iribarren
supply its own hostname for vis in my opinion. I think one possibility to add this without breaking compatiblity would be adding a hostname record after the neighbor entries in the vis packets. Flooding the network with arbitrary data like hostnames, service announcements, weather info, etc

Re: [B.A.T.M.A.N.] [PATCHv2] batman-adv: fix visualization output without neighbors on the primary interface

2012-05-07 Thread Marek Lindner
On Monday, May 07, 2012 12:35:31 Matthias Schiffer wrote: On 05/06/2012 10:14 PM, Simon Wunderlich wrote: Your patch does the trick, although I think this ugly function could use a rewrite. First counting bytes and then allocating this size to do exactly the same thing again is not really

Re: [B.A.T.M.A.N.] [PATCHv2] batman-adv: fix visualization output without neighbors on the primary interface

2012-05-07 Thread Sven Eckelmann
On Monday, May 07, 2012 06:35:31 AM Matthias Schiffer wrote: [] I have some questions about the code though: - Is there any reason vis_seq_print_text() allocates a buffer at all instead of just printing the data directy into the seq_file? Looking at the seq_printf implementation, there

Re: [B.A.T.M.A.N.] [PATCHv2] batman-adv: fix visualization output without neighbors on the primary interface

2012-05-07 Thread Marek Lindner
On Saturday, May 05, 2012 23:51:53 Matthias Schiffer wrote: The primary entry and the corresponding secondary entries are missing when there are no neighbors on the primary interface. This also causes the TT entries to miss and makes nodes with multiply secondary interface fall apart since

Re: [B.A.T.M.A.N.] [PATCHv2] batman-adv: fix visualization output without neighbors on the primary interface

2012-05-07 Thread Matthias Schiffer
On 05/07/2012 08:40 AM, Marek Lindner wrote: If you wish to replace the mac addresses with readable name you can simply use a bat-hosts file to tell batctl which mac address should be replaced. Check the bat-hosts section in our batctl online manpage:

Re: [B.A.T.M.A.N.] [PATCHv2] batman-adv: fix visualization output without neighbors on the primary interface

2012-05-06 Thread Simon Wunderlich
Acked-by: Simon Wunderlich s...@hrz.tu-chemnitz.de Your patch does the trick, although I think this ugly function could use a rewrite. First counting bytes and then allocating this size to do exactly the same thing again is not really good style. If you would like to volunteer to do this job

Re: [B.A.T.M.A.N.] [PATCHv2] batman-adv: fix visualization output without neighbors on the primary interface

2012-05-06 Thread Matthias Schiffer
On 05/06/2012 10:14 PM, Simon Wunderlich wrote: Your patch does the trick, although I think this ugly function could use a rewrite. First counting bytes and then allocating this size to do exactly the same thing again is not really good style. If you would like to volunteer to do this job