Re: [B.A.T.M.A.N.] [patch] adding subgraph-feature to vis-output in dot-file-format

2009-08-30 Thread Linus Lüssing
Yep, works fine for me, compiled and run it on our three virtual machines and looks the same as with my original patch. I also had a quick look at the json output and I think the patch should not have broken anything of that either, but a json-expert should have a look at it again. Also it might ma

Re: [B.A.T.M.A.N.] [patch] adding subgraph-feature to vis-output in dot-file-format

2009-08-30 Thread Simon Wunderlich
Hi, On Sun, Aug 30, 2009 at 09:37:52AM +0200, Andrew Lunn wrote: > > Cheers, Linus > > > > PPS: I had to introduce a src-field in the vis-packet-struct, > > therefore the compatibility version had to be increased as well. > > I'm thinking about linux-mainline here. > > Does it make sense to have

Re: [B.A.T.M.A.N.] [patch] adding subgraph-feature to vis-output in dot-file-format

2009-08-30 Thread Andrew Lunn
> Linus, Andrew: please give it a try on your systems. I currently don't have > machines set up to test, so this is a dry run. :) I don't yet know if i can. I'm off to Finland for two weeks, working in the Finnish branch of the company i work for. I don't know how well the internal FI-CH network

Re: [B.A.T.M.A.N.] [patch] adding subgraph-feature to vis-output in dot-file-format

2009-08-30 Thread Simon Wunderlich
This is a small review of Linus patch. It contains: * minor style adaptions * optional compile flag VIS_SUBCLUSTERS_DISABLED to prevent vis parser breakages * sanity checks for kmalloc() Linus, Andrew: please give it a try on your systems. I currently don't have machines set up to test, so th

Re: [B.A.T.M.A.N.] HSB announces the second Wireless Battle Mesh (Brussels, 17-18 Oct)

2009-08-30 Thread Marek Lindner
On Monday 31 August 2009 00:52:45 Simon Wunderlich wrote: > Sounds nice, i'm in. ;) Yeah, me too. :) Marek

Re: [B.A.T.M.A.N.] HSB announces the second Wireless Battle Mesh (Brussels, 17-18 Oct)

2009-08-30 Thread Simon Wunderlich
Sounds nice, i'm in. ;) On Sat, Aug 29, 2009 at 09:38:24AM +0200, Benjamin Henrion wrote: > > === > HackerSpaceBrussels announces the second Wireless Battle Mesh > WBM2009 v2 (Brussels, 17-18 October) >

Re: [B.A.T.M.A.N.] [patch] adding subgraph-feature to vis-output in dot-file-format

2009-08-30 Thread Andrew Lunn
> Cheers, Linus > > PPS: I had to introduce a src-field in the vis-packet-struct, > therefore the compatibility version had to be increased as well. I'm thinking about linux-mainline here. Does it make sense to have a version number per message type? Some things we can do backward compatibility e

Re: [B.A.T.M.A.N.] [patch] adding subgraph-feature to vis-output in dot-file-format

2009-08-30 Thread Linus Lüssing
And if someone prefers a visual example, a simple setup like node1 <-> node2 <-> node3 results into a dot-file like this: digraph { "22:05:f9:aa:77:1f" -> "a2:14:84:e5:e5:46" [label="1.15"] "22:05:f9:aa:77:1f" -> "00:ff:5b:62:9c:a3" [label="HNA"] subgraph "cluster_22:05:f9:

[B.A.T.M.A.N.] [patch] adding subgraph-feature to vis-output in dot-file-format

2009-08-30 Thread Linus Lüssing
Pfeh... long night again, but here you go. With this patch, batman-adv now supports the subgraphing-feature of the dot-file-format. The vis-output can then be parsed with "fdp -Tsvg -Gcharset=utf8 /proc/net/batman-adv/vis > test.svg" for example. Interfaces belonging to one BATMAN-node can be fo