Re: [B.A.T.M.A.N.] [PATCH] batman-adv: Fixes rounding issues in vis.c

2009-12-17 Thread Marek Lindner
On Friday 18 December 2009 03:04:33 Linus Lüssing wrote: > This patches fixes two rounding issues in vis.c for sending and > purging vis packets. Before, the timers and timeouts always got > rounded down to seconds, though we want a precision in > milliseconds. > This also fixes a kernel panic that

[B.A.T.M.A.N.] [PATCH] batman-adv: Fixes rounding issues in vis.c

2009-12-17 Thread Linus Lüssing
This patches fixes two rounding issues in vis.c for sending and purging vis packets. Before, the timers and timeouts always got rounded down to seconds, though we want a precision in milliseconds. This also fixes a kernel panic that occures when lowering the timer for sending vis packets (vis_inter

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: Use forw_bcast_list_lock always in disabled interrupt context

2009-12-17 Thread Sven Eckelmann
On Thu, Dec 17, 2009 at 03:34:47PM +0100, Sven Eckelmann wrote: [...] > > When finding this bug, did you take any notes etc, which could > > contribute to such a document? > [...] > > The documentation about the context in which each lock/function is used isn't > really there for the kernel. As t

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: Use forw_bcast_list_lock always in disabled interrupt context

2009-12-17 Thread Sven Eckelmann
On Thu, Dec 17, 2009 at 01:25:44PM +0100, Andrew Lunn wrote: > This reminds me of something i keep intending to do, but never get > around to. > > It would be nice to have a LOCKING.TXT document, with the following > Table of Contents. > > 1) What locks we have and what they protect. > > 2) What

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: Use forw_bcast_list_lock always in disabled interrupt context

2009-12-17 Thread Marek Lindner
On Thursday 17 December 2009 20:11:55 Sven Eckelmann wrote: > forw_bcast_list_lock is spin_locked in both process and softirq context. > SoftIRQ calls the spinlock with disabled IRQ and normal process context > with enabled IRQs. > > When process context is inside an spin_locked area protected by

Re: [B.A.T.M.A.N.] [BULK] Re: required network to run

2009-12-17 Thread Conner, Eric
Simon thanks for the insight, and actually that is what I originally thought that a mesh routing protocol would do for me. But my question still remains, how do I configure my linux box so that it uses batmand to discover the other computers that aren't part of the network? batmand tells me it

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: Use forw_bcast_list_lock always in disabled interrupt context

2009-12-17 Thread Andrew Lunn
Hi Sven This reminds me of something i keep intending to do, but never get around to. It would be nice to have a LOCKING.TXT document, with the following Table of Contents. 1) What locks we have and what they protect. 2) What different contexts different parts of the code run in. These two sec

[B.A.T.M.A.N.] [PATCH] batman-adv: Use forw_bcast_list_lock always in disabled interrupt context

2009-12-17 Thread Sven Eckelmann
forw_bcast_list_lock is spin_locked in both process and softirq context. SoftIRQ calls the spinlock with disabled IRQ and normal process context with enabled IRQs. When process context is inside an spin_locked area protected by forw_bcast_list_lock and gets interrupted by an IRQ, it could happen t

[B.A.T.M.A.N.] We made LWN!

2009-12-17 Thread Andrew Lunn
Hi Folks For those of you with an LWN subscription, take a look at: http://lwn.net/Articles/366084/ We get a one line mention in the section about the 2.6.33 merge window :-) Andrew

Re: [B.A.T.M.A.N.] required network to run

2009-12-17 Thread Simon Wunderlich
Hello Eric, the basic idea of meshing in general is: the destination nodes are probably not in the coverage area of your radio, but you still want to talk to these nodes. For example, imagine a city network where all nodes are connected to each other: You wifi cards signal is only strong enoug