Re: [B.A.T.M.A.N.] [PATCH 1/2] batman-adv: convert multiple /proc files to use sysfs

2010-02-28 Thread Andrew Lunn
Hi Marek I've not looked into the details yet, just a quick glans. However maybe we should discuss this point: @@ -249,6 +249,8 @@ static void rebuild_batman_packet(struct batman_if *batman_if) void schedule_own_packet(struct batman_if *batman_if) { + /* FIXME: each batman_if will

Re: [B.A.T.M.A.N.] [PATCH 1/2] batman-adv: convert multiple /proc files to use sysfs

2010-02-28 Thread Marek Lindner
On Sunday 28 February 2010 17:37:28 Andrew Lunn wrote: With time i expect that bat_priv will gain many more members as global variables are replaced with variables per mesh. Rather than passing to functions a member, pass the pointer and let the function dereference it. I think it will make

Re: [B.A.T.M.A.N.] slowpath warning

2010-02-28 Thread Simon Wunderlich
Hello, i can reproduce the slowpath warning in the trunk within my qemu setup. When i start a server, some of the clients show this slow path warning. I've tried Andrews patch, and i can not see any memory leaks - it varies in a 100k window. However some of the servers crash after some time (30