[B.A.T.M.A.N.] [PATCHv2] batman-adv: Reorganize sequence number handling

2010-04-06 Thread Simon Wunderlich
BATMAN and broadcast packets are tracked with a sequence number window of currently 64 entries to measure and avoid duplicates. Packets which have a sequence number smaller than the newest received packet minus 64 are not within this sequence number window anymore and are called "old packets" from

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: Reorganize sequence number handling

2010-04-06 Thread Simon Wunderlich
Found the bug, it happens when the difference between the received and last seqno is exactly -64. We also have bugs in this regard in the current implementation: if seq_diff is -64, bit_get_packet calls bit_mark(). However there is a check inside which ignores -64, so nothing bad happens. if se

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: Reorganize sequence number handling

2010-04-06 Thread Simon Wunderlich
Hi Linus, i've verified and can reproduce the problem. The queue limitation patch removes the OOM problems, but the same packets are still broadcasted. It is always the same sequence number which is sent many times - the same packet should not be sent more than 3 times. All nodes but the origina

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: Reorganize sequence number handling

2010-04-06 Thread Linus Lüssing
On Tue, Apr 06, 2010 at 12:41:29PM +0200, Simon Wunderlich wrote: > Hi Linus, > > from the time where the messages come (the printk is removed in the submitted > version of the patch BTW), we can see that there is a 30 second period between > the protection time starts - as it is supposed to be. >

Re: [B.A.T.M.A.N.] Multiple gateways and WRT54GL's

2010-04-06 Thread Bastian Bittorf
* Marek Lindner [06.04.2010 11:50]: > > I read the announcement but does it work (especially the adhoc mode) ? I'd be > really interested in hearing about first hand experience. without problems, minstrel also does the job. it is working since a long time, but only in trunk. bye, Bastian si

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: Reorganize sequence number handling

2010-04-06 Thread Simon Wunderlich
Hi Linus, from the time where the messages come (the printk is removed in the submitted version of the patch BTW), we can see that there is a 30 second period between the protection time starts - as it is supposed to be. I guess you have stopped your broadcast ping after ~900 seconds, but still r

Re: [B.A.T.M.A.N.] Multiple gateways and WRT54GL's

2010-04-06 Thread Marek Lindner
On Tuesday 06 April 2010 16:10:57 Bastian Bittorf wrote: > this is an old rumour since some days, the new kamikaze-release > "backfire" now fully supports the wrt54gl's wifi (b43+mac80211) with > an opensource driver which make's it possible to use kernel 2.6.32+ I read the announcement but does i

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: Reorganize sequence number handling

2010-04-06 Thread Linus Lüssing
Hi Simon, sorry, I need to resign my ack again, I guess. I now noticed that I couldn't reproduce the issue anymore because of not being able to produce enough broadcasts (~3x83 small packets per second). It turned out, that the ping utility itself seems to limit the interval when it gets no icmp r

Re: [B.A.T.M.A.N.] Multiple gateways and WRT54GL's

2010-04-06 Thread Bastian Bittorf
* Marek Lindner [06.04.2010 07:50]: > the WRT54G still depends on the precompiled proprietary wifi driver only > available for linux 2.4.20. OpenWRT tries to move to the open driver but I this is an old rumour since some days, the new kamikaze-release "backfire" now fully supports the wrt54gl'

Re: [B.A.T.M.A.N.] Multiple gateways and WRT54GL's

2010-04-06 Thread Marek Lindner
Hi, > I manage a campus network which runs a fibre backbone between critical > points. I wish to impliment a wireless mesh to link non-critical points > and "fill-the-gaps" so to speak. It is thus possible that more than one > wireless point could act as a gateway to the main network. I under

Re: [B.A.T.M.A.N.] [PATCH] batctl: Parse allowed settings for sysfs without whitespace before newline

2010-04-06 Thread Marek Lindner
On Monday 05 April 2010 00:33:57 Sven Eckelmann wrote: > The current settings parser assumes that a newline is at the end of each > line starting with "commands:". Luis de Bethencourt reported that this > is a bad coding style and should be avoided. Ok, I just verfied and committed your patch whic