Re: [B.A.T.M.A.N.] routing loops on interconnected routers / adhoc + ethernet

2012-03-03 Thread Nicolás Echániz
On 03/03/2012 04:53 AM, Marek Lindner wrote: On Saturday, March 03, 2012 15:39:09 Nicolás Echániz wrote: this happens with the nodes configured according to: http://www.open-mesh.org/wiki/batman-adv/Bridge-loop-avoidance or so we understand! If the ethernet is used for mesh purposes

Re: [B.A.T.M.A.N.] routing loops on interconnected routers / adhoc + ethernet

2012-03-03 Thread Nicolás Echániz
On 03/03/2012 05:43 AM, Marek Lindner wrote: On Saturday, March 03, 2012 16:16:15 Nicolás Echániz wrote: Maerk thanks for your fast reply. In fact, that's how we started, that's what I meant by: We have also tried adding eth0 to bat0 and take it out of br-lan, which also works but gives

Re: [B.A.T.M.A.N.] routing loops on interconnected routers / adhoc + ethernet

2012-03-03 Thread Nicolás Echániz
On 03/03/2012 07:14 AM, Nicolás Echániz wrote: On 03/03/2012 05:43 AM, Marek Lindner wrote: You should not have loops either way but it is easy to build loops in complicated setups. At first we should understand your setup and configuration. Drawing a little picture that shows what

Re: [B.A.T.M.A.N.] [PATCH 3/6] batman-adv: register batman ogm receive function during protocol init

2012-03-03 Thread Simon Wunderlich
On Thu, Mar 01, 2012 at 03:35:18PM +0800, Marek Lindner wrote: -static void bat_iv_ogm_receive(struct hard_iface *if_incoming, -struct sk_buff *skb) +static void _bat_iv_ogm_receive(struct sk_buff *skb, + struct hard_iface *if_incoming)

Re: [B.A.T.M.A.N.] [PATCH 1/6] batman-adv: introduce is_single_hop_neigh variable to increase readability

2012-03-03 Thread Simon Wunderlich
Hey Marek, I did a rough review over your patches, and a more detailed one to the HZ/jiffies patch. Looks fine, nice approach to get some more compatibility in. You've also added the handler table from our beer discussion - nice. ;) Apart from some minor comments on patch no. 3, feel free to

Re: [B.A.T.M.A.N.] routing loops on interconnected routers / adhoc + ethernet

2012-03-03 Thread Nicolás Echániz
On 03/03/2012 08:32 AM, Marek Lindner wrote: On Saturday, March 03, 2012 18:24:40 Nicolás Echániz wrote: On 03/03/2012 07:14 AM, Nicolás Echániz wrote: On 03/03/2012 05:43 AM, Marek Lindner wrote: You should not have loops either way but it is easy to build loops in complicated setups. At