Re: [B.A.T.M.A.N.] [[PATCHv2]] batman-adv: Change make install path and run depmod

2012-05-06 Thread Marek Lindner
On Thursday, May 03, 2012 16:15:07 Martin Hundebøll wrote: Currently, when installing the out-of-tree module on distributions that use gzipped modules, batman-adv.ko will be installed next to batman-adv.ko.gz, which is selected by kmod. By changing the install path to /lib/modules/`uname

Re: [B.A.T.M.A.N.] [PATCHv2 1/2] batman-adv: Only set hash class after hash is initialized

2012-05-06 Thread Marek Lindner
On Saturday, May 05, 2012 19:27:27 Sven Eckelmann wrote: We must be sure that there was no error during the creation of the hash before we can set the hash lock class. The class set function was added to the wrong place in 2c9aa3b4c37bd55148f5f25212c89e7bf5f28497 Applied in revision af01e99.

Re: [B.A.T.M.A.N.] [PATCHv2 2/2] batman-adv: Return error codes instead of -1 on failures

2012-05-06 Thread Marek Lindner
On Saturday, May 05, 2012 19:27:28 Sven Eckelmann wrote: Signed-off-by: Sven Eckelmann s...@narfation.org --- bat_sysfs.c |2 +- bridge_loop_avoidance.c |6 +++--- main.c | 27 --- originator.c| 18

Re: [B.A.T.M.A.N.] [PATCHv2] batman-adv: fix visualization output without neighbors on the primary interface

2012-05-06 Thread Simon Wunderlich
Acked-by: Simon Wunderlich s...@hrz.tu-chemnitz.de Your patch does the trick, although I think this ugly function could use a rewrite. First counting bytes and then allocating this size to do exactly the same thing again is not really good style. If you would like to volunteer to do this job

[B.A.T.M.A.N.] [PATCH] batman-adv: turn tt commit code into routing protocol agnostic API

2012-05-06 Thread Marek Lindner
Prior to this patch the translation table code made assumptions about how the routing protocol works and where its buffers are stored (to directly modify them). Each protocol now calls the tt code with the relevant pointers, thereby abstracting the code. Signed-off-by: Marek Lindner

Re: [B.A.T.M.A.N.] [PATCHv2] batman-adv: fix visualization output without neighbors on the primary interface

2012-05-06 Thread Matthias Schiffer
On 05/06/2012 10:14 PM, Simon Wunderlich wrote: Your patch does the trick, although I think this ugly function could use a rewrite. First counting bytes and then allocating this size to do exactly the same thing again is not really good style. If you would like to volunteer to do this job