Re: [B.A.T.M.A.N.] [PATCHv4] batman-adv: Add the backbone gateway list to debugfs

2012-06-18 Thread Sven Eckelmann
On Mon, Jun 18, 2012 at 12:21:32PM +0200, Simon Wunderlich wrote: + msecs = msecs % 1000; + + + is_own = batadv_compare_eth(backbone_gw-orig, Why two empty lines? +static inline int batadv_bla_backbone_table_seq_print_text(struct seq_file *seq, +

[B.A.T.M.A.N.] [PATCH] batman-adv: fix race condition in TT full-table replacement

2012-06-18 Thread Antonio Quartulli
In the current TT code, when a TT_Response containing a full table is received form an originator, the node first purges all the clients for that originator in the global translation-table and then merges the new received table. During the purging phase each client deletion is done by means of a

[B.A.T.M.A.N.] [PATCHv5] batman-adv: Add the backbone gateway list to debugfs

2012-06-18 Thread Simon Wunderlich
This is especially useful if there are no claims yet, but we still want to know which gateways are using bridge loop avoidance in the network. Signed-off-by: Simon Wunderlich s...@hrz.tu-chemnitz.de --- [EDITv2: forgot to rename the function ...] [EDITv3: add README entry] [EDITv4: fix style]

Re: [B.A.T.M.A.N.] link alternation when radios are not on batman-adv router?

2012-06-18 Thread gtolon
Hi Simon, thanks for your reply! El 15/06/2012 06:55 a.m., Simon Wunderlich escribió: On Thu, Jun 14, 2012 at 04:51:01PM -0300, gto...@inti.gob.ar wrote: Hi, we are interested too in interface alternating, so we made some tests to understand how it works. As you can see on the attached

[B.A.T.M.A.N.] pull request: batman-adv 2012-06-18

2012-06-18 Thread Antonio Quartulli
Hello David, here is our first set of changes intended for next-next/linux-3.6. Patch 2 fixes a major bug in the TranslationTable code where the old value of skb-data is used for memory access even if the data was relocated. Patches 4, 10, 11, 13, 14 are endianess-related cleanups that we

[B.A.T.M.A.N.] [PATCH 01/19] batman-adv: update internal version number

2012-06-18 Thread Antonio Quartulli
From: Sven Eckelmann s...@narfation.org Signed-off-by: Sven Eckelmann s...@narfation.org Signed-off-by: Antonio Quartulli or...@autistici.org --- net/batman-adv/main.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/batman-adv/main.h b/net/batman-adv/main.h index

[B.A.T.M.A.N.] [PATCH 03/19] batman-adv: Initialize lockdep class keys for hashes

2012-06-18 Thread Antonio Quartulli
From: Sven Eckelmann s...@narfation.org The hash for claim and backbone hash in the bridge loop avoidance code receive the same key because they are getting initialized by hash_new with the same key. Lockdep will create a backtrace when they are used recursively. This can be avoided by

[B.A.T.M.A.N.] [PATCH 04/19] batman-adv: convert bat_priv-tt_crc from atomic_t to uint16_t

2012-06-18 Thread Antonio Quartulli
In the code we neever need to atomically check and set the bat_priv-tt_crc field value. It is simply set and read once in different pieces of the code. Therefore this field can be safely be converted from atomic_t to uint16_t. Reported-by: Al Viro v...@zeniv.linux.org.uk Signed-off-by: Antonio

[B.A.T.M.A.N.] [PATCH 05/19] batman-adv: Add get_ethtool_stats() support

2012-06-18 Thread Antonio Quartulli
From: Martin Hundebøll mar...@hundeboll.net Added additional counters in a bat_stats structure, which are exported through the ethtool api. The counters are specific to batman-adv and includes: forwarded packets and bytes management packets and bytes (aggregated OGMs at this point) translation

[B.A.T.M.A.N.] [PATCH 06/19] batman-adv: avoid characters requiring shell escapes in protocol names

2012-06-18 Thread Antonio Quartulli
From: Marek Lindner lindner_ma...@yahoo.de Reported-by: Andrew Lunn and...@lunn.ch Signed-off-by: Marek Lindner lindner_ma...@yahoo.de Signed-off-by: Sven Eckelmann s...@narfation.org Signed-off-by: Antonio Quartulli or...@autistici.org --- net/batman-adv/bat_iv_ogm.c |2 +-

[B.A.T.M.A.N.] [PATCH 08/19] batman-adv: return added entries instead of number of possibly added entries

2012-06-18 Thread Antonio Quartulli
From: Marek Lindner lindner_ma...@yahoo.de Signed-off-by: Marek Lindner lindner_ma...@yahoo.de Acked-by: Antonio Quartulli or...@autistici.org Signed-off-by: Sven Eckelmann s...@narfation.org Signed-off-by: Antonio Quartulli or...@autistici.org --- net/batman-adv/translation-table.c |2 +- 1

[B.A.T.M.A.N.] [PATCH 09/19] batman-adv: get rid of pointless cast in memcpy()

2012-06-18 Thread Antonio Quartulli
From: Al Viro v...@zeniv.linux.org.uk memcpy() arguments are void *, precisely to avoid that kind of pointless casts. Signed-off-by: Al Viro v...@zeniv.linux.org.uk Signed-off-by: Sven Eckelmann s...@narfation.org Signed-off-by: Antonio Quartulli or...@autistici.org ---

[B.A.T.M.A.N.] [PATCH 10/19] batman-adv: trivial endianness annotations

2012-06-18 Thread Antonio Quartulli
From: Al Viro v...@zeniv.linux.org.uk Signed-off-by: Al Viro v...@zeniv.linux.org.uk Signed-off-by: Sven Eckelmann s...@narfation.org Signed-off-by: Antonio Quartulli or...@autistici.org --- net/batman-adv/bridge_loop_avoidance.c |6 +++--- net/batman-adv/packet.h| 12

[B.A.T.M.A.N.] [PATCH 11/19] batman-adv: keep batman_ogm_packet -seqno net-endian all along

2012-06-18 Thread Antonio Quartulli
From: Al Viro v...@zeniv.linux.org.uk Signed-off-by: Al Viro v...@zeniv.linux.org.uk Signed-off-by: Sven Eckelmann s...@narfation.org Signed-off-by: Antonio Quartulli or...@autistici.org --- net/batman-adv/bat_iv_ogm.c | 22 +++--- net/batman-adv/packet.h |2 +- 2 files

[B.A.T.M.A.N.] [PATCH 12/19] batman-adv: Return error codes instead of -1 on failures

2012-06-18 Thread Antonio Quartulli
From: Sven Eckelmann s...@narfation.org Signed-off-by: Sven Eckelmann s...@narfation.org Signed-off-by: Antonio Quartulli or...@autistici.org --- net/batman-adv/bat_debugfs.c | 11 +++ net/batman-adv/bat_iv_ogm.c|2 +- net/batman-adv/bat_sysfs.c |

[B.A.T.M.A.N.] [PATCH 13/19] batman-adv: don't bother flipping -tt_data

2012-06-18 Thread Antonio Quartulli
From: Al Viro v...@zeniv.linux.org.uk just keep it net-endian all along Signed-off-by: Al Viro v...@zeniv.linux.org.uk [lindner_ma...@yahoo.de: fix checkpatch warnings] Signed-off-by: Marek Lindner lindner_ma...@yahoo.de Signed-off-by: Sven Eckelmann s...@narfation.org Signed-off-by: Antonio

[B.A.T.M.A.N.] [PATCH 14/19] batman-adv: don't bother flipping -tt_crc

2012-06-18 Thread Antonio Quartulli
From: Al Viro v...@zeniv.linux.org.uk Keep it net-endian Signed-off-by: Al Viro v...@zeniv.linux.org.uk Signed-off-by: Sven Eckelmann s...@narfation.org Signed-off-by: Antonio Quartulli or...@autistici.org --- net/batman-adv/bat_iv_ogm.c | 10 ++ net/batman-adv/packet.h |2 +-

[B.A.T.M.A.N.] [PATCH 15/19] batman-adv: fix visualization output without neighbors on the primary interface

2012-06-18 Thread Antonio Quartulli
From: Matthias Schiffer mschif...@universe-factory.net The primary entry and the corresponding secondary entries are missing when there are no neighbors on the primary interface. This also causes the TT entries to miss and makes nodes with multiply secondary interface fall apart since there is no

[B.A.T.M.A.N.] [PATCH 16/19] batman-adv: turn tt commit code into routing protocol agnostic API

2012-06-18 Thread Antonio Quartulli
From: Marek Lindner lindner_ma...@yahoo.de Prior to this patch the translation table code made assumptions about how the routing protocol works and where its buffers are stored (to directly modify them). Each protocol now calls the tt code with the relevant pointers, thereby abstracting the code.

[B.A.T.M.A.N.] [PATCH 17/19] batman-adv: use DBG_ALL in log_level sysfs definition

2012-06-18 Thread Antonio Quartulli
Each time a new log level is added the developer must change either the DBG_ALL enum definition and the hard coded value in the bat_sysfs.c for the log_level attribute max value. This is extremely error prone. With this patch the code directly uses DBG_ALL in the sysfs definition Signed-off-by:

[B.A.T.M.A.N.] [PATCH 19/19] batman-adv: only store changed gw_bandwidth values

2012-06-18 Thread Antonio Quartulli
From: Marek Lindner lindner_ma...@yahoo.de Signed-off-by: Marek Lindner lindner_ma...@yahoo.de Signed-off-by: Sven Eckelmann s...@narfation.org Signed-off-by: Antonio Quartulli or...@autistici.org --- net/batman-adv/gateway_common.c |3 +++ 1 file changed, 3 insertions(+) diff --git

Re: [B.A.T.M.A.N.] pull request: batman-adv 2012-06-18

2012-06-18 Thread David Miller
From: Antonio Quartulli or...@autistici.org Date: Mon, 18 Jun 2012 22:39:04 +0200 Hello David, here is our first set of changes intended for next-next/linux-3.6. Patch 2 fixes a major bug in the TranslationTable code where the old value of skb-data is used for memory access even if