Re: [B.A.T.M.A.N.] [PATCH 1/2] batman-adv: Write lockdep xmit class in late initialization phase

2012-08-30 Thread Antonio Quartulli
On Mon, Aug 27, 2012 at 10:53:50AM +0200, Sven Eckelmann wrote: e27bb6fa916451e9eaced16e7c21d5b71a3b7f30 (batman-adv: Set special lockdep classes to avoid lockdep warning) introduced a lockdep class for the tx queue, but did not set it in the correct initialization phase. The batman-adv

[B.A.T.M.A.N.] [PATCH] batman-adv: roaming re-routing mechanism redesign

2012-08-30 Thread Antonio Quartulli
The roaming re-routing procedure has been slightly revised in order to get rid of the tt_poss_change variable that was not clearly representing the node/client states. Now the code directly relies on the TT_CLIENT_ROAM flag that can be set on the involved local/global clients. This improvement

[B.A.T.M.A.N.] [PATCH] batman-adv: don't rely on positions in struct for hashing

2012-08-30 Thread Simon Wunderlich
The hash functions in the bridge loop avoidance code expects the VLAN vid to be right after the mac address, but this is not guaranteed. Fix this by explicitly hashing over the right fields of the struct. Reported-by: Marek Lindner lindner_ma...@yahoo.de Signed-off-by: Simon Wunderlich

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: don't rely on positions in struct for hashing

2012-08-30 Thread Antonio Quartulli
On Thu, Aug 30, 2012 at 06:22:27PM +0200, Simon Wunderlich wrote: The hash functions in the bridge loop avoidance code expects the VLAN vid to be right after the mac address, but this is not guaranteed. Fix this by explicitly hashing over the right fields of the struct. What about creating

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: don't rely on positions in struct for hashing

2012-08-30 Thread Antonio Quartulli
On Thu, Aug 30, 2012 at 06:33:52PM +0200, Antonio Quartulli wrote: On Thu, Aug 30, 2012 at 06:22:27PM +0200, Simon Wunderlich wrote: The hash functions in the bridge loop avoidance code expects the VLAN vid to be right after the mac address, but this is not guaranteed. Fix this by