[B.A.T.M.A.N.] [PATCH] batman-adv: dirty hack to recompute mac_len in the rx path

2012-10-14 Thread Simon Wunderlich
It is possible that the mac_len is not properly exported because of strange device configuration (this behaviour has been observed when using batman-adv on top of a vlan interface). Therefore it is needed to explicitly recompute it at the very beginning of the rx path. This is done by appending

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: Remove instant overwritten variable initialization

2012-10-14 Thread Marek Lindner
On Sunday, October 07, 2012 18:02:22 Sven Eckelmann wrote: Signed-off-by: Sven Eckelmann s...@narfation.org --- routing.c |2 +- sysfs.c |2 +- translation-table.c | 20 ++-- 3 files changed, 12 insertions(+), 12 deletions(-) Applied in

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: Mark best gateway in transtable_global debugfs

2012-10-14 Thread Marek Lindner
On Sunday, October 07, 2012 19:34:15 Sven Eckelmann wrote: The transtable_global debug file can show multiple entries for a single client when multiple gateways exist. The chosen gateway isn't marked in the list and therefore the user cannot easily debug the situation when there is a problem

[B.A.T.M.A.N.] [PATCHv5 1/3] batctl: add support for the DAT local table

2012-10-14 Thread Antonio Quartulli
With the introduction of DAT in batman-adv, another table is now exported through debugfs. This patch adds the possibility to print it Signed-off-by: Antonio Quartulli or...@autistici.org --- v5: - long option renamed from 'datcache' to dat_cache' README | 18 ++ debug.c

[B.A.T.M.A.N.] [PATCHv5 2/3] batctl: add support for the DAT log level

2012-10-14 Thread Antonio Quartulli
Signed-off-by: Antonio Quartulli or...@autistici.org --- v5: - noop. README | 1 + man/batctl.8 | 7 --- sys.c| 7 ++- 3 files changed, 11 insertions(+), 4 deletions(-) diff --git a/README b/README index 5e58452..0958fcb 100644 --- a/README +++ b/README @@ -342,6 +342,7

[B.A.T.M.A.N.] [PATCHv5 3/3] batctl: add DAT runtime switch support

2012-10-14 Thread Antonio Quartulli
Signed-off-by: Antonio Quartulli or...@autistici.org --- v5: - noop. functions.c | 1 + man/batctl.8 | 4 sys.c| 6 ++ sys.h| 1 + 4 files changed, 12 insertions(+) diff --git a/functions.c b/functions.c index 0d88137..1cde235 100644 --- a/functions.c +++

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: fix DAT packet counting

2012-10-14 Thread Marek Lindner
On Tuesday, October 09, 2012 21:00:11 Antonio Quartulli wrote: DAT packets must be counted before any batadv_dat_snoop_incoming_* invocation otherwise the code flow can jump the counters increment at all Signed-off-by: Antonio Quartulli or...@autistici.org --- routing.c | 8 1

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: enable fast client detection using unicast_4addr packets

2012-10-14 Thread Marek Lindner
On Tuesday, October 09, 2012 21:04:47 Antonio Quartulli wrote: @@ -1061,9 +1063,12 @@ int batadv_recv_unicast_packet(struct sk_buff *skb, /* packet for me */ if (batadv_is_my_mac(unicast_packet-dest)) { - if (is4addr) + if (is4addr) {

Re: [B.A.T.M.A.N.] [PATCHv5 1/3] batctl: add support for the DAT local table

2012-10-14 Thread Marek Lindner
On Sunday, October 14, 2012 22:54:31 Antonio Quartulli wrote: With the introduction of DAT in batman-adv, another table is now exported through debugfs. This patch adds the possibility to print it Signed-off-by: Antonio Quartulli or...@autistici.org --- v5: - long option renamed from

[B.A.T.M.A.N.] [PATCHv2] batman-adv: enable fast client detection using unicast_4addr packets

2012-10-14 Thread Antonio Quartulli
The early client detection mechanism can be extended to find new clients by means of unicast_4addr packets. The unicast_4addr packet contains as well as the broadcast packet (which is currently used in this mechanism) the address of the originating node and can therefore be used to install new

Re: [B.A.T.M.A.N.] [PATCHv5 2/3] batctl: add support for the DAT log level

2012-10-14 Thread Marek Lindner
On Sunday, October 14, 2012 22:54:32 Antonio Quartulli wrote: Signed-off-by: Antonio Quartulli or...@autistici.org --- v5: - noop. README | 1 + man/batctl.8 | 7 --- sys.c| 7 ++- 3 files changed, 11 insertions(+), 4 deletions(-) Applied in revision ac27265.

Re: [B.A.T.M.A.N.] [PATCHv5 3/3] batctl: add DAT runtime switch support

2012-10-14 Thread Marek Lindner
On Sunday, October 14, 2012 22:54:33 Antonio Quartulli wrote: Signed-off-by: Antonio Quartulli or...@autistici.org --- v5: - noop. functions.c | 1 + man/batctl.8 | 4 sys.c| 6 ++ sys.h| 1 + 4 files changed, 12 insertions(+) Applied in revision f395fb7.

[B.A.T.M.A.N.] [PATCHv3] batman-adv: enable fast client detection using unicast_4addr packets

2012-10-14 Thread Antonio Quartulli
The early client detection mechanism can be extended to find new clients by means of unicast_4addr packets. The unicast_4addr packet contains as well as the broadcast packet (which is currently used in this mechanism) the address of the originating node and can therefore be used to install new

Re: [B.A.T.M.A.N.] [PATCHv3] batman-adv: enable fast client detection using unicast_4addr packets

2012-10-14 Thread Marek Lindner
On Sunday, October 14, 2012 23:19:19 Antonio Quartulli wrote: The early client detection mechanism can be extended to find new clients by means of unicast_4addr packets. The unicast_4addr packet contains as well as the broadcast packet (which is currently used in this mechanism) the address

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: dirty hack to recompute mac_len in the rx path

2012-10-14 Thread Marek Lindner
On Sunday, October 14, 2012 20:46:57 Simon Wunderlich wrote: It is possible that the mac_len is not properly exported because of strange device configuration (this behaviour has been observed when using batman-adv on top of a vlan interface). Therefore it is needed to explicitly recompute it

[B.A.T.M.A.N.] [PATCH 1/2] batman-adv: support array of debugfs general attributes

2012-10-14 Thread Antonio Quartulli
This patch adds support for an array of debugfs general (not soft_iface specific) attributes. With this change it will be possible to add more general attributes by simply appending them to the array without touching the rest of the code. Signed-off-by: Antonio Quartulli or...@autistici.org ---

Re: [B.A.T.M.A.N.] [PATCH 2/2] batman-adv: export compatibility version via debugfs

2012-10-14 Thread Antonio Quartulli
On Sun, Oct 14, 2012 at 10:03:01PM +0200, Antonio Quartulli wrote: Different versions of the batman-adv module may use the same compatibility version, but this is not understandable at runtime (the only way is to parse the kernel log and fetch the batman-adv advertisement message on loading).

[B.A.T.M.A.N.] [PATCHv4 1/4] batctl: Translate client mac to originator mac for ping/traceroute

2012-10-14 Thread Sven Eckelmann
A user may want to check the path selected by batman-adv for any client when only the MAC of the device with the IPv4 is known, but not the originator address. batctl can assist the user by parsing the global translation table to automatically translate it for him. The ping itself will only be

[B.A.T.M.A.N.] [PATCHv4 2/4] batctl: Allow to use IPv4 addresses for ping/traceroute

2012-10-14 Thread Sven Eckelmann
IPv4 addresses and hostnames are easier to remember than many MAC addresses. batctl can automatically resolve the MAC address of the target device when the IP is configured on top of the batman-adv device and the source and destination batman-adv interface are in the same IPv4 subnet.

[B.A.T.M.A.N.] [PATCHv4 3/4] batctl: Allow to skip header in debug table output

2012-10-14 Thread Sven Eckelmann
Signed-off-by: Sven Eckelmann s...@narfation.org --- rebased on DAT debug.c | 18 +++--- debug.h |1 + functions.c |7 ++- functions.h |3 ++- main.c |2 +- man/batctl.8 |3 +++ sys.c| 14 +++--- 7 files changed, 35

[B.A.T.M.A.N.] [PATCHv4 4/4] batctl: Add filter option for debug tables

2012-10-14 Thread Sven Eckelmann
Users may only want to query information about specific originator or clients when looking at the debug tables. This can easily be done using a simple grep when the originator mac is known. More problematic are clients or IP addresses. The user has to perform the steps already done for