Re: [B.A.T.M.A.N.] [PATCH] batman-adv: Recommend not to change Makefile for configuration

2012-10-18 Thread Marek Lindner
On Thursday, October 18, 2012 17:43:54 Sven Eckelmann wrote: The Makefile suggests to change it to enable or disable features. This resulted in patch submissions with changed Makefile even when this change would not be necessary. Instead the configuration should be done using the make

Re: [B.A.T.M.A.N.] [PATCH 2/2] batman-adv: Fix build of batman-adv without BLA

2012-10-18 Thread Marek Lindner
On Thursday, October 18, 2012 16:48:32 Sven Eckelmann wrote: 4c1721b39c8a77c99e8f4de97b5d5d112006406c (batman-adv: Fix potential broadcast BLA-duplicate-check race condition) introduced a spinlock for bridge loop avoidance which was initialized outside of bla. This causes an build error when

[B.A.T.M.A.N.] [PATCHv4] batman-adv: Fix broadcast duplist for fragmentation

2012-10-18 Thread Simon Wunderlich
If the skb is fragmented, the checksum must be computed on the individual fragments, just using skb-data may fail on fragmented data. Instead of doing linearizing the packet, use the new batadv_crc32 to do that more efficiently- it should not hurt replacing the old crc16 by the new crc32.

[B.A.T.M.A.N.] pull request: batman-adv 2012-10-18

2012-10-18 Thread Antonio Quartulli
Hello David, here are two fixes intended for net. The first one fixes the CRC computation used to check for broadcast packet duplicates. The wrong result lead to many (more than 80%) broadcast packets being dropped and so making the network very slow and mostly unusable. Think about all the ARP

[B.A.T.M.A.N.] [PATCH 1/2] batman-adv: Fix broadcast packet CRC calculation

2012-10-18 Thread Antonio Quartulli
From: Linus Lüssing linus.luess...@web.de So far the crc16 checksum for a batman-adv broadcast data packet, received on a batman-adv hard interface, was calculated over zero bytes of its content leading to many incoming broadcast data packets wrongly being dropped (60-80% packet loss). This

Re: [B.A.T.M.A.N.] pull request: batman-adv 2012-10-18

2012-10-18 Thread David Miller
From: Antonio Quartulli or...@autistici.org Date: Thu, 18 Oct 2012 21:24:53 +0200 here are two fixes intended for net. The first one fixes the CRC computation used to check for broadcast packet duplicates. The wrong result lead to many (more than 80%) broadcast packets being dropped and so

Re: [B.A.T.M.A.N.] How to detect gateway mode in openwrt?

2012-10-18 Thread Gui Iribarren
On Wed, Oct 17, 2012 at 6:14 PM, Sophana K sophan...@gmail.com wrote: I may have found a possible solution by parsing the output of batctl transglobal, and look for the gateway mac address. If the gateway is in the transglobal table, it is accessed through the mesh, and it is probably not