Re: [B.A.T.M.A.N.] slowpath warning

2010-01-28 Thread Andrew Lunn
On Thu, Jan 28, 2010 at 08:09:57AM +0800, Marek Lindner wrote: Hi, nope, does not seem to work, still the same issue I also tried it on my laptop here with the patch installed and it is a very similar call trace, although here it is send_vis_packets instead of vis_quit in the call

Re: [B.A.T.M.A.N.] bat_events: page allocation failure (batman-adv maint)

2010-01-25 Thread Andrew Lunn
On Sun, Jan 24, 2010 at 10:00:10PM +0100, Andrew Lunn wrote: On Sun, Jan 24, 2010 at 09:42:12PM +0100, Linus L??ssing wrote: Hi Andrew, Here is the output with the symbols inserted. I can reproduce this memory leak very reliable now, by just activating the vis server (didn't do

Re: [B.A.T.M.A.N.] bat_events: page allocation failure (batman-adv maint)

2010-01-25 Thread Andrew Lunn
Staging: batman-adv: Fix skbuff leak in VIS code. The vis code takes a copy of the data inside the skbuf if it is interesting for us, so we always need to release the skbuf. Reported-by: Linus L?ssing linus.luess...@web.de Signed-off-by: Andrew Lunn and...@lunn.ch Index: routing.c

Re: [B.A.T.M.A.N.] bat_events: page allocation failure (batman-adv maint)

2010-01-24 Thread Andrew Lunn
On Sun, Jan 24, 2010 at 09:42:12PM +0100, Linus L??ssing wrote: Hi Andrew, Here is the output with the symbols inserted. I can reproduce this memory leak very reliable now, by just activating the vis server (didn't do that with the logs I've posted before) in a couple of minutes. free is

Re: [B.A.T.M.A.N.] State of batman-adv in mainline

2010-01-23 Thread Andrew Lunn
On Sat, Jan 23, 2010 at 11:27:30AM +0800, Marek Lindner wrote: Hey, Our first patch landed by GregKH just before the merge window for 2.6.33 opened. This patch made it into 2.6.33-rc1. So at around the end of march when 2.6.33 is released, we will be in mainline. All patches

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: Add bonding functionality

2010-01-19 Thread Andrew Lunn
On Tue, Jan 19, 2010 at 08:12:49AM +0800, Marek Lindner wrote: On Monday 18 January 2010 23:24:26 Andrew Lunn wrote: gw_node_update() is missing a rcu_read_unlock(); before the return inside the list_for_each_entry_rcu() loop. The others are less serious, but should be corrected as well

Re: [B.A.T.M.A.N.] batman-adv on different archs

2010-01-18 Thread Andrew Lunn
The problem comes when I try to add my little ARM based linux box onto the group. Again same sources used (latest stable from the wiki), crosscompiles fine and I can load the module as normal on the box. Setup goes as it should on both the device and the laptop, and both systems seems to be

Re: [B.A.T.M.A.N.] batman-adv on different archs

2010-01-18 Thread Andrew Lunn
Yes, the devices are talking to each other. real recv indicates you received the other node's messages but the other node does not repeat our own broadcasts (see own_bcast). Would be interesting to see the log from the other side. It looks like the messages get dropped there. It would

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: Add bonding functionality

2010-01-18 Thread Andrew Lunn
On Mon, Jan 18, 2010 at 07:31:22PM +0800, Marek Lindner wrote: Hi, i've just committed this patch in revision 1551, as no further comments and critiques came in. I would consider this patch rather simple, and as experimental feature it is switched off by default anyways ... :)

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: Add bonding functionality

2010-01-18 Thread Andrew Lunn
CHECK /home/lunn/batman/trunk/batman-adv-kernelland/gateway_common.c /home/lunn/batman/trunk/batman-adv-kernelland/gateway_common.c:28:6: warning: symbol 'kbit_to_gw_srv_class' was not declared. Should it be static? CHECK /home/lunn/batman/trunk/batman-adv-kernelland/gateway_client.c

Re: [B.A.T.M.A.N.] network down timeout

2010-01-15 Thread Andrew Lunn
On Fri, Jan 15, 2010 at 09:34:08AM -0500, ecfu wrote: Because I am dealing with rapidly changing networks, like to the point where applications could be complete in less than 3 minutes This still does not explain why the entry is a problem. Please could you explain in a bit more detail what

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: atomic variable for vis-srv activation

2010-01-15 Thread Andrew Lunn
On Fri, Jan 15, 2010 at 07:34:38PM +0100, Sven Eckelmann wrote: Marek Lindner wrote: On Monday 11 January 2010 12:57:56 you wrote: This fixes the bug discovered by Marek Lindner which did not allow turning on the vis-server before an interface has been added. With this patch we are

Re: [B.A.T.M.A.N.] network down timeout

2010-01-14 Thread Andrew Lunn
On Thu, Jan 14, 2010 at 08:40:25AM -0500, ecfu wrote: Is there a configuration setting for batman-adv to timeout on a connection? i.e. if I lose a node in my network, I noticed it took a long time for that node to leave the originators list. What is this based on or in other words when does

Re: [B.A.T.M.A.N.] Are older kernels abandoned?

2010-01-11 Thread Andrew Lunn
On Sun, Jan 10, 2010 at 11:29:46PM -0800, Gus Wirth wrote: Now that work is under way to incorporate B.A.T.M.A.N (batman-adv) into the mainline Linux kernel, hopefully 2.6.33, will older kernels be abandoned? I have some embedded systems that are on 2.6.30.10 and running fine, and I really

Re: [B.A.T.M.A.N.] Maximum MTU (was Re: B.A.T.M.A.N. V outlook)

2010-01-08 Thread Andrew Lunn
Would you happen to know what the maximum MTU you could use on the wireless interface? The 802.11 standard says the MSDU size is 2304 octets. How many IP bytes you can fit into this depends on what encryption scheme you are using, which adds different size headers. However your hardware may

[B.A.T.M.A.N.] [PATCH] Staging: batman-adv: Update the README for mainline usage.

2010-01-06 Thread Andrew Lunn
The module now only compiles inside mainline, so remove the comments about different versions of the kernel it can be used with. Also update comments about building with debug enabled and how to use the VIS data now that it no longer natively outputs dot or JSON. Signed-off-by: Andrew Lunn

Re: [B.A.T.M.A.N.] [PATCH 3/3] batman-adv: send DHCP requests directly to the chosen gw

2010-01-05 Thread Andrew Lunn
+bool gw_is_target(struct sk_buff *skb) +{ + struct ethhdr *ethhdr; + struct iphdr *iphdr; + struct udphdr *udphdr; + + if (atomic_read(gw_mode) != GW_MODE_CLIENT) + return false; + + if (!curr_gateway) + return false; + + ethhdr =

Re: [B.A.T.M.A.N.] [PATCH 1/3] batman-adv: atomic variable for vis-srv activation

2010-01-05 Thread Andrew Lunn
* checkpatch reports 8 errors 8 warnings Ehm, just got 1 error at the else part... (sorry, never used checkpatch before, hope that I'm not handling it wrong in any way...) The number of errors will vary depending on which version of checkpatch you use. I tend to use the one from the current

Re: [B.A.T.M.A.N.] batman-adv gateway support

2010-01-04 Thread Andrew Lunn
Would it be possible to decide via a more general mechanism, maybe via a BPF filter, which packets get sent to the gateway? For instance, it would be nice to be able to say that all ARP requests for *.*.*.1 also got sent to the gateway direct :-) This would also make adding IPv6 support

[B.A.T.M.A.N.] [PATCH 14/17] Staging: batman-adv: Allow the MAC address to be set

2010-01-02 Thread Andrew Lunn
devices, causing mayhem. This patch allows the MAC address to be set by the user. Signed-off-by: Andrew Lunn and...@lunn.ch Signed-off-by: Simon Wunderlich s...@hrz.tu-chemnitz.de --- drivers/staging/batman-adv/soft-interface.c| 13 +++-- drivers/staging/batman-adv/translation

[B.A.T.M.A.N.] [PATCH 01/17] Staging: batman-adv: Remove NULL pointer check

2010-01-02 Thread Andrew Lunn
From: Sven Eckelmann sven.eckelm...@gmx.de It is safe to call kfree(NULL) which makes this extra check unneeded. It was found using checkpatch.pl from linux-2.6 Signed-off-by: Sven Eckelmann sven.eckelm...@gmx.de Acked-by: Simon Wunderlich s...@hrz.tu-chemnitz.de Signed-off-by: Andrew Lunn

[B.A.T.M.A.N.] [PATCH 09/17] Staging: batman-adv: moving vis output formats out of the kernel

2010-01-02 Thread Andrew Lunn
. Signed-off-by: Andrew Lunn and...@lunn.ch Signed-off-by: Marek Lindner lindner_ma...@yahoo.de --- drivers/staging/batman-adv/TODO | 11 --- drivers/staging/batman-adv/proc.c | 171 + drivers/staging/batman-adv/proc.h |9 -- 3 files changed, 61 insertions

[B.A.T.M.A.N.] [PATCH 11/17] Staging: batman-adv: splitting /proc vis file into vis_server and vis_data

2010-01-02 Thread Andrew Lunn
vis_server to enable/disable the vis server and to retrieve its status * use vis_data to retrieve the vis raw data (if the server is enabled) Signed-off-by: Marek Lindner lindner_ma...@yahoo.de Signed-off-by: Andrew Lunn and...@lunn.ch --- drivers/staging/batman-adv/proc.c | 172

[B.A.T.M.A.N.] [PATCH 10/17] Staging: batman-adv: remove obsoleted vis_format /proc file

2010-01-02 Thread Andrew Lunn
...@web.de Signed-off-by: Marek Lindner lindner_ma...@yahoo.de Signed-off-by: Andrew Lunn and...@lunn.ch --- drivers/staging/batman-adv/proc.c | 79 + drivers/staging/batman-adv/vis.h |5 -- 2 files changed, 1 insertions(+), 83 deletions(-) diff --git

[B.A.T.M.A.N.] [PATCH 15/17] Staging: batman-adv: Use printk(%pM) for MAC addresses

2010-01-02 Thread Andrew Lunn
by Gus Wirth. Signed-off-by: Andrew Lunn and...@lunn.ch Signed-off-by: Simon Wunderlich s...@hrz.tu-chemnitz.de --- drivers/staging/batman-adv/TODO|4 - drivers/staging/batman-adv/compat.h| 82 ++- drivers/staging/batman-adv/device.c

[B.A.T.M.A.N.] [PATCH 08/17] Staging: batman-adv: fix minor orig table layout bug

2010-01-02 Thread Andrew Lunn
From: Marek Lindner lindner_ma...@yahoo.de The originator table contained a TAB instead of a space which broke the layout as well as the batctl parser. Signed-off-by: Marek Lindner lindner_ma...@yahoo.de Signed-off-by: Andrew Lunn and...@lunn.ch --- drivers/staging/batman-adv/proc.c |2

[B.A.T.M.A.N.] [PATCH 16/17] Staging: batman-adv: Remove compat.h

2010-01-02 Thread Andrew Lunn
From: Simon Wunderlich s...@hrz.tu-chemnitz.de Since we are now part of mainline, we don't need compat.h to allow building of the module with old versions of the kernel. Signed-off-by: Andrew Lunn and...@lunn.ch --- drivers/staging/batman-adv/TODO|3 - drivers/staging/batman

[B.A.T.M.A.N.] [PATCH 07/17] Staging: batman-adv: Fixes rounding issues in vis.c

2010-01-02 Thread Andrew Lunn
the timer for sending vis packets (vis_interval) to less than 1000ms in main.c manually. Signed-off-by: Linus Lüssing linus.luess...@web.de Acked-by: Marek Lindner lindner_ma...@yahoo.de Signed-off-by: Andrew Lunn and...@lunn.ch --- drivers/staging/batman-adv/vis.c |4 ++-- 1 files changed, 2

[B.A.T.M.A.N.] [PATCH 05/17] Staging: batman-adv: consistent spelling of neighbors

2010-01-02 Thread Andrew Lunn
From: Simon Wunderlich s...@hrz.tu-chemnitz.de we have written neighbors, neighbours and bad spelled versions of this word, this patch should make it consistent. Signed-off-by: Simon Wunderlich s...@hrz.tu-chemnitz.de Signed-off-by: Andrew Lunn and...@lunn.ch --- drivers/staging/batman-adv

[B.A.T.M.A.N.] [PATCH 04/17] Staging: batman-adv: initialize static hash iterators

2010-01-02 Thread Andrew Lunn
a little faster/safer Tested with 9 QEMU instances, no obvious regression found. Signed-off-by: Simon Wunderlich s...@hrz.tu-chemnitz.de Signed-off-by: Andrew Lunn and...@lunn.ch --- drivers/staging/batman-adv/hard-interface.c|6 ++-- drivers/staging/batman-adv/hash.c | 23

[B.A.T.M.A.N.] [PATCH 06/17] Staging: batman-adv: Use forw_bcast_list_lock always with disabled interrupts

2010-01-02 Thread Andrew Lunn
any chance of resurrection. All functions called in process context must disable IRQs when they try to get get that lock to to prevent any reschedule due to IRQs. Signed-off-by: Sven Eckelmann sven.eckelm...@gmx.de Acked-by: Marek Lindner lindner_ma...@yahoo.de Signed-off-by: Andrew Lunn

[B.A.T.M.A.N.] [PATCH 03/17] Staging: batman-adv: Replace KERN_DEBUG with bat_dbg

2010-01-02 Thread Andrew Lunn
Ameya Palande requested we replace printk(KERN_DEBUG ) by pr_debug() I decided it was better to use our debug macro. Signed-off-by: Andrew Lunn and...@lunn.ch Acked-by: Marek Lindner lindner_ma...@yahoo.de --- drivers/staging/batman-adv/TODO |6 -- drivers/staging/batman-adv/device.c

[B.A.T.M.A.N.] [PATCH 13/17] Staging: batman-adv: receive packets directly using skbs

2010-01-02 Thread Andrew Lunn
Acked-by: Linus Lüssing linus.luess...@web.de Signed-off-by: Andrew Lunn and...@lunn.ch --- drivers/staging/batman-adv/aggregation.c| 13 +- drivers/staging/batman-adv/device.c | 24 +- drivers/staging/batman-adv/hard-interface.c | 154 ++--- drivers/staging/batman-adv/hard

Re: [B.A.T.M.A.N.] Correct smaller typographical errors

2010-01-02 Thread Andrew Lunn
There is also some sentence in the batman manpage which should maybe changed. Maybe a native english speaking person could check if it is valid and understandable. B.A.T.M.A.N tries to find the best available connection by watching the uplinks throughput and the link quality. It is O.K. I

[B.A.T.M.A.N.] Missing unlocks

2010-01-01 Thread Andrew Lunn
Hi Simon I just built batman-adv with make C=1 so that sparse it used to check the code. It found a few missing unlocks... drivers/staging/batman-adv/routing.c:585:12: warning: context imbalance in 'recv_my_icmp_packet' - different lock contexts for basic block This is the return if the

[B.A.T.M.A.N.] [Patch 1/1] Staging: batman-adv: Use printk(%pM) for MAC addresses

2009-12-31 Thread Andrew Lunn
in bat_printk.c so that the code is more likely to build with older kernels. Only build bat_printk.c with kernels that require it, thanks to Simon Wunderlich Makefile.kbuild patch. Signed-off-by: Andrew Lunn and...@lunn.ch Index: Makefile.kbuild

Re: [B.A.T.M.A.N.] [patchv2] batman-adv: Use printk(%pM) for MAC addres

2009-12-31 Thread Andrew Lunn
On Sun, Dec 13, 2009 at 08:01:49PM +0100, Simon Wunderlich wrote: Hello Andrew, i've checked your patch against older kernel, and there seem to be some compile problems. E.g. compiling against 2.6.26, i find: CC [M] /home/dotslash/msrc/batman-svn/batman-adv-kernelland/bat_printk.o

Re: [B.A.T.M.A.N.] [PATCHv2 no pgp] batman-adv: receive packets directly using skbs

2009-12-31 Thread Andrew Lunn
I try to summarize where each lock is used so we can decide if it is ok to revert some of them to spin_lock again. This should also resolve a request I got from Andrew some time ago. Hi Sven Thanks for this. [...] So it is complete correct to use irqsave everywhere (as you have commited it

[B.A.T.M.A.N.] Coccinelle tests?

2009-12-31 Thread Andrew Lunn
...@diku.dk - Date: Thu, 31 Dec 2009 17:40:21 +0100 (CET) From: Julia Lawall ju...@diku.dk To: Andrew Lunn and...@lunn.ch Subject: Re: Standard coccinelle tests? X-Spam-Status: No, score=-2.6 required=4.0 tests=BAYES_00 autolearn=ham version=3.2.5 I ran all of my tests on your code, and came up

[B.A.T.M.A.N.] We made LWN!

2009-12-17 Thread Andrew Lunn
Hi Folks For those of you with an LWN subscription, take a look at: http://lwn.net/Articles/366084/ We get a one line mention in the section about the 2.6.33 merge window :-) Andrew

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: Use forw_bcast_list_lock always in disabled interrupt context

2009-12-17 Thread Andrew Lunn
Hi Sven This reminds me of something i keep intending to do, but never get around to. It would be nice to have a LOCKING.TXT document, with the following Table of Contents. 1) What locks we have and what they protect. 2) What different contexts different parts of the code run in. These two

Re: [B.A.T.M.A.N.] /proc vis rework

2009-12-13 Thread Andrew Lunn
And I wanted to ask, what do you think about unifying the specific help output? For instance having this Usage: ...-header and the alignment for the following items the same way as it is done for other batctl commands as well. I thought about that. However the architecture allows different

Re: [B.A.T.M.A.N.] /proc vis rework

2009-12-12 Thread Andrew Lunn
On Fri, Dec 11, 2009 at 11:58:35PM +0100, Linus L??ssing wrote: Hi Andrew, your patch seems to work pretty well here, tested it with 9 batman-nodes in the same room. Nevertheless I found a couple of smaller bugs in there: - batctl segfaults, if batctl vis has no following argument - batctl

[B.A.T.M.A.N.] FWD: [PATCH 227/235] staging: batman-adv meshing protocol

2009-12-12 Thread Andrew Lunn
Kroah-Hartman gre...@suse.de To: de...@linuxdriverproject.org Cc: Andrew Lunn and...@lunn.ch, Greg Kroah-Hartman gre...@suse.de Subject: [PATCH 227/235] staging: batman-adv meshing protocol X-Spam-Status: No, score=-2.6 required=4.0 tests=BAYES_00 autolearn=ham version=3.2.5 From: Andrew Lunn

Re: [B.A.T.M.A.N.] general theory question RE: dhcp on a peer only mesh

2009-12-09 Thread Andrew Lunn
On Tue, Dec 08, 2009 at 08:24:01PM -0800, George Sanders wrote: This is not a BATMAN specific question, but I see very clueful chatter here and would appreciate any comments. My question is: Who provides IP addresses in a truly ad-hoc, truly peer only mesh network ? One option is

[B.A.T.M.A.N.] [PATCH 03/10] staging:batman-adv:Andrews refactored routing.c file patch: I broke a lot of the big functions up into many smaller ones. This helps with readability and there is now a l

2009-12-09 Thread Andrew Lunn
From: simon si...@45894c77-fb22-0410-b583-ff6e7d5dbf6c Signed-off-by: Andrew Lunn andrew.l...@ascom.ch Acked-by: Marek Lindner lindner_ma...@yahoo.de Acked-by: Simon Wunderlich simon.wunderl...@s2003.tu-chemnitz.de git-svn-id: http://downloads.open-mesh.net/svn/batman/trunk/batman-adv-kernell

[B.A.T.M.A.N.] [PATCH 01/10] staging:batman-adv:replace internal logging mechanism with standard kernel logging

2009-12-09 Thread Andrew Lunn
From: marek ma...@45894c77-fb22-0410-b583-ff6e7d5dbf6c Signed-off-by: Andrew Lunn and...@lunn.ch git-svn-id: http://downloads.open-mesh.net/svn/batman/trunk/batman-adv-kernell...@1482 45894c77-fb22-0410-b583-ff6e7d5dbf6c --- Makefile.kbuild |4 +- README | 66

[B.A.T.M.A.N.] [PATCH 04/10] staging:batman-adv:stop permanent warnings if a device is added but deactivated.

2009-12-09 Thread Andrew Lunn
From: simon si...@45894c77-fb22-0410-b583-ff6e7d5dbf6c Signed-off-by: Simon Wunderlich simon.wunderl...@s2003.tu-chemnitz.de Signed-off-by: Andrew Lunn and...@lunn.ch git-svn-id: http://downloads.open-mesh.net/svn/batman/trunk/batman-adv-kernell...@1487 45894c77-fb22-0410-b583-ff6e7d5dbf6c

[B.A.T.M.A.N.] [PATCH 08/10] staging:batman-adv:Fix the naming of the debug option in Kconfig.

2009-12-09 Thread Andrew Lunn
Signed-off-by: Andrew Lunn and...@lunn.ch --- drivers/staging/batman-adv/Kconfig |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/batman-adv/Kconfig b/drivers/staging/batman-adv/Kconfig index b9742e7..698eb31 100644 --- a/drivers/staging/batman-adv

[B.A.T.M.A.N.] [PATCH 07/10] staging:batman-adv:Updating orig_str for debug

2009-12-09 Thread Andrew Lunn
initialised also before commit 1488 (which was probably the reason for mistakenly removing it). This tiny patch adds the orig_str again, but initialises it now as well. Signed-off-by: Linus Luessing linus.luess...@web.de Signed-off-by: Andrew Lunn and...@lunn.ch git-svn-id: http://downloads.open-mesh.net

[B.A.T.M.A.N.] [PATCH 09/10] staging:batman-adv:correctly name the configuration option for debugging

2009-12-09 Thread Andrew Lunn
From: marek ma...@45894c77-fb22-0410-b583-ff6e7d5dbf6c Signed-off-by: Andrew Lunn and...@lunn.ch Signed-off-by: Marek Lindner lindner_ma...@yahoo.de git-svn-id: http://downloads.open-mesh.net/svn/batman/trunk/batman-adv-kernell...@1491 45894c77-fb22-0410-b583-ff6e7d5dbf6c --- Makefile.kbuild

[B.A.T.M.A.N.] [PATCH 10/10] staging:batman-adv:Add Kconfig dependancies on PROC_FS and PACKET.

2009-12-09 Thread Andrew Lunn
Signed-off-by: Andrew Lunn and...@lunn.ch --- drivers/staging/batman-adv/Kconfig |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/staging/batman-adv/Kconfig b/drivers/staging/batman-adv/Kconfig index 698eb31..69e8fb0 100644 --- a/drivers/staging/batman-adv

[B.A.T.M.A.N.] [PATCH 06/10] staging:batman-adv:if discarding a packet, we need to read it under any condition.

2009-12-09 Thread Andrew Lunn
From: simon si...@45894c77-fb22-0410-b583-ff6e7d5dbf6c Signed-off-by: Simon Wunderlich simon.wunderl...@s2003.tu-chemnitz.de Signed-off-by: Andrew Lunn and...@lunn.ch git-svn-id: http://downloads.open-mesh.net/svn/batman/trunk/batman-adv-kernell...@1489 45894c77-fb22-0410-b583-ff6e7d5dbf6c

[B.A.T.M.A.N.] [patch] batman-adv: Use printk(%pM) for MAC addresses

2009-12-04 Thread Andrew Lunn
than 2.6.29 the printk support from 2.6.31 has been imported into batman-adv and will be used for formatting the output before passing it onto the native printk() function. --- Signed-off-by Andrew Lunn and...@lunn.ch Index: Makefile.kbuild

Re: [B.A.T.M.A.N.] [patch] batman-adv: Use printk(%pM) for MAC addresses

2009-12-04 Thread Andrew Lunn
-bat_dbg(DBG_ROUTES, Deleting route towards: %s\n, -orig_str); +bat_dbg(DBG_ROUTES, Deleting route towards: %pMs\n, +orig_node-orig); There is an extra s after the the replacement %pM. Thanks Andrew

[B.A.T.M.A.N.] [patchv2] batman-adv: Use printk(%pM) for MAC addres

2009-12-04 Thread Andrew Lunn
than 2.6.29 the printk support from 2.6.31 has been imported into batman-adv and will be used for formatting the output before passing it onto the native printk() function. --- Fix the typo found by Gus Wirth. grep pMs suggests the typo only occurred once. Signed-off-by: Andrew Lunn and...@lunn.ch

Re: [B.A.T.M.A.N.] [PATCH] Updating orig_str for debug

2009-12-03 Thread Andrew Lunn
you are probably right but I know that Andrew has a patch in his pipeline which will remove these addr_to_string() calls entirely (printk can handle mac addresses for us). Until then we can live with this workaround. :) I've been holding off on this patch because of Simon's big lock removal

Re: [B.A.T.M.A.N.] [PATCH] Removing the big batman lock

2009-12-03 Thread Andrew Lunn
On Thu, Dec 03, 2009 at 02:31:22AM +0100, Linus L??ssing wrote: Hi Simon, I just gave your patch a try on my laptop and could successfully, reproduceably crash my kernel in the following way: This looks like a deadlock. Simon: Did you try lockdep on this new code?

Re: [B.A.T.M.A.N.] [PATCHv2] [batman-adv] Removing the big batman lock

2009-12-03 Thread Andrew Lunn
It seems to deadlock according to https://lists.open-mesh.net/pipermail/b.a.t.m.a.n/2009-December/001938.html Patch was modified by Sven Eckelmann sven.eckelm...@gmx.de to apply cleanly against r1490. Is this just modification so that it cleanly applies? Or does it also fix the deadlock?

Re: [B.A.T.M.A.N.] [PATCH] Removing the big batman lock

2009-11-30 Thread Andrew Lunn
On Sun, Nov 29, 2009 at 09:09:50PM +0100, Simon Wunderlich wrote: I did some testing, including loading, unloading, killing individual nodes etc, which seems to be clean so far. However there might be more race conditions introduced by this large patch, and i'm therefore requesting a careful

[B.A.T.M.A.N.] /proc vis rework

2009-11-30 Thread Andrew Lunn
=== --- batctl/vis.c (revision 0) +++ batctl/vis.c (revision 0) @@ -0,0 +1,323 @@ +/* Copyright (C) 2009 B.A.T.M.A.N. contributors: + * Andrew Lunn and...@lunn.ch + * + * This program is free software; you can redistribute it and/or + * modify it under the terms of version 2 of the GNU General Public

Re: [B.A.T.M.A.N.] basic B.A.T.M.A.N-adv setup

2009-10-21 Thread Andrew Lunn
On Wed, Oct 21, 2009 at 08:54:02AM +0200, Francesco wrote: HI all, I've now downloaded and $make latest batman-adv trunk from $svn co http://downloads.open-mesh.net/svn/batman/trunk/batman-adv-kernelland/ I have issues with batctl trunk: $svn co

Re: [B.A.T.M.A.N.] Changing vis output ready for mainline...

2009-10-13 Thread Andrew Lunn
So, the question is whether we want to make batctl the almighty tool that we always depend on or are we trying to find alternative solutions to avoid that dependency ? One option for the case at hand might be debugfs (http://lwn.net/Articles/115282/). It is another filesystem which needs

Re: [B.A.T.M.A.N.] Changing vis output ready for mainline...

2009-10-13 Thread Andrew Lunn
Couple of questions: * Would (TQ_Value / 255) be equivalent to the label value in the current vis output? Here is the current kernel code: #define TQ_MAX_VALUE 255 [snip] /* kernel has no printf-support for %f? it'd be better * to return this in float. */ int_part =

[B.A.T.M.A.N.] Changing vis output ready for mainline...

2009-10-12 Thread Andrew Lunn
Hi Folks We need to discuss the changes which are needed to the VIS output for inclusion of batman into mainline. At the moment the vis output can be read from /proc/net/batman-adv/vis. It supports two formats, graphviz dot and JSON. This can be selected using the file

Re: [B.A.T.M.A.N.] Changing vis output ready for mainline...

2009-10-12 Thread Andrew Lunn
A current vis output would be: fe:fe:00:00:04:01 - fe:fe:00:00:05:01 [label=1.0] fe:fe:00:00:04:01 - fe:fe:00:00:03:01 [label=1.0] fe:fe:00:00:04:01 - 00:ff:7c:3c:ec:e0 [label=HNA] subgraph cluster_fe:fe:00:00:04:01 { fe:fe:00:00:04:01

Re: [B.A.T.M.A.N.] batman-adv and TCP problem

2009-10-06 Thread Andrew Lunn
On Tue, Oct 06, 2009 at 12:33:55PM +0200, a wrote: Dear Sven, Marek you can find as attachment the dump on eth2 of GW (tcpdump -ni eth2 -s 0 -w gw.cap); the output of batctl td -p 4 eth1 is: 10:29:15.51 BAT 52:54:00:00:20:01 52:54:00:00:30:01: UCAST, ttl 50, IP 192.168.100.2.9001

Re: [B.A.T.M.A.N.] Fwd: Re: Debian extra modules

2009-10-06 Thread Andrew Lunn
The postifx setup is quite simple at the moment: It rejects all unknown / unregistered mail. Greylisting is not in place yet. I quickly ran pflogsumm to give you an impression: Per-Day Traffic Summary date received delivered deferredbounced rejected

Re: [B.A.T.M.A.N.] Fwd: Re: Debian extra modules

2009-10-06 Thread Andrew Lunn
I never feel real happy about the filtering of spamassassines bayesian analysis as it marks important mails for me as spam from time to time. You are not forced to use the bayesian analysis part of spamassassin. It has lots of there methods for detecting spam as well as Bayesian. Andrew

Re: [B.A.T.M.A.N.] VGER mailing list request

2009-10-05 Thread Andrew Lunn
On Sun, Oct 04, 2009 at 05:12:21PM -0700, David Miller wrote: From: Andrew Lunn and...@lunn.ch Date: Sun, 4 Oct 2009 19:41:27 +0200 Is likely acceptance in staging sufficient for ...for which their upstream acceptance is imminent.? A lot of code doesn't make it past staging, and gets

Re: [B.A.T.M.A.N.] VGER mailing list request

2009-10-04 Thread Andrew Lunn
On Sat, Oct 03, 2009 at 09:15:39PM -0600, Jacob Marble wrote: This is my correspondence with David, aka postmas...@vger. At this point, I need someone else (Marek, etc.) to contact David if we are to move forward with VGER. I will contact David. I assume this is David Miller. Andrew

Re: [B.A.T.M.A.N.] mailing list migration (was: development flow)

2009-09-29 Thread Andrew Lunn
a) filters spam very well b) allows the list to be hosted using our domain name, not yours We meet both of those requirement. Just keep in mind that since you cannot have a domain point to two servers (Mailman requires a web server), you will need to use a domain name that is not in

Re: [B.A.T.M.A.N.] mailing list migration (was: development flow)

2009-09-28 Thread Andrew Lunn
Sorry for the delay, busy week. So, I'm looking for a mailing host that: a) has experience hosting, and so can filter spam without hassle b) lets us use open-mesh.net instead of super-duper-mailing-host.com c) hosts open source gratis a and b are must have, c would be nice. I've looked

Re: [B.A.T.M.A.N.] mailing list migration (was: development flow)

2009-09-19 Thread Andrew Lunn
I don't have a server that would work for this, but I think it would be nice to find a service that hosts FOSS projects for free, but normally charges for the service. ??That way, no one in the batman project has to worry about servers failing/upgrading/migrating/etc. The first example

Re: [B.A.T.M.A.N.] development flow

2009-09-08 Thread Andrew Lunn
Hi Folks Sorry for suddenly disappearing after getting some momentum going for getting batman into mainline. My employer sent me to Finland to work on a project for 2-3 weeks and it has been hard to find time to work on batman. I guess i will not be back to normal working situation for at least

Re: [B.A.T.M.A.N.] development flow

2009-09-02 Thread Andrew Lunn
I would also suggest we post our patches as soon as possible, so we start getting feedback from the kernel community about what else needs adding to the TODO list etc. Yes, when and where should we post it ? Should the mailing list be migrated at that point (I felt a consensus concerning

Re: [B.A.T.M.A.N.] [patch] adding subgraph-feature to vis-output in dot-file-format

2009-08-31 Thread Andrew Lunn
Hi Linus, Simon One of the things on the TODO list for mainline is to strip out all the graphvis/JSON formatting done by the kernel and put it into user space, probably batctl, or another standalone tool, or maybe even a little library... Why: 1) No other file in /proc does any special

Re: [B.A.T.M.A.N.] development flow

2009-08-31 Thread Andrew Lunn
On Mon, Aug 31, 2009 at 01:26:29PM +0800, Marek Lindner wrote: On Monday 31 August 2009 04:23:06 Simon Wunderlich wrote: Usually we have stable versions (e.g. batman-adv 0.1) with a specific format, and an ongoing development in the svn trunk. Maybe we should do the same for future kernel

Re: [B.A.T.M.A.N.] [patch] adding subgraph-feature to vis-output in dot-file-format

2009-08-30 Thread Andrew Lunn
Cheers, Linus PPS: I had to introduce a src-field in the vis-packet-struct, therefore the compatibility version had to be increased as well. I'm thinking about linux-mainline here. Does it make sense to have a version number per message type? Some things we can do backward compatibility

Re: [B.A.T.M.A.N.] [patch] adding subgraph-feature to vis-output in dot-file-format

2009-08-30 Thread Andrew Lunn
Linus, Andrew: please give it a try on your systems. I currently don't have machines set up to test, so this is a dry run. :) I don't yet know if i can. I'm off to Finland for two weeks, working in the Finnish branch of the company i work for. I don't know how well the internal FI-CH network

[B.A.T.M.A.N.] List policy for none subscribers

2009-08-26 Thread Andrew Lunn
Hi folks Yesterday evening i sent an email to Greg KH about getting batman into mainline via staging. I CCed the list. Since i used an account which is not subscribed, i got a bounce: You are not allowed to post to this mailing list, and your message has been automatically rejected. If you

[B.A.T.M.A.N.] Getting batman into staging

2009-08-26 Thread Andrew Lunn
Hi Folks Here is the email i sent to Greg KH about getting into staging Andrew -- Hi Greg I've decided to take on the challenge of getting batman-advanced into mainline. This is a challenge since as to date all i've

[B.A.T.M.A.N.] Reply from Greg KH

2009-08-26 Thread Andrew Lunn
and here is the reply... Andrew -- On Tue, Aug 25, 2009 at 10:05:30PM +0200, Andrew Lunn wrote: Hi Greg I've decided to take on the challenge of getting batman-advanced into mainline. This is a challenge since as to date

Re: [B.A.T.M.A.N.] List policy for none subscribers

2009-08-26 Thread Andrew Lunn
the wiki is obviously wrong here. I see 2 options: I just thought of a third option. Ask for a list on vger.kernel.org and use its spam filtering, which i expect is pretty good. They seem to host some small lists. irda-users only has 10 subscribers. linux-rdma has 9. Andrew

[B.A.T.M.A.N.] Breaking long lines...

2009-08-26 Thread Andrew Lunn
I found also some other things and also told that Marek - but I think that not everything was included in the patch I send some weeks ago. Maybe it was only to break printk statements to fit in 80 chars per line, but I am not sure right now. Yes, you found a way to break a long string

[B.A.T.M.A.N.] Configuration interface...

2009-08-26 Thread Andrew Lunn
Should /proc/net/batman-adv/interface be replaced with an IOCTL interface similar to brctl? How to design the kernel-userspace interface that it doesn't end like wireless-tools? I'm not so familiar with the iwconfig situation you seem to refer to. Could you outline the issues ?

Re: [B.A.T.M.A.N.] List policy for none subscribers

2009-08-26 Thread Andrew Lunn
This is a good and important question. Even more so because Marek and I were having a initial discussion via VOIP about ideas and changes to the algorithm for the next generation mark 5 of the protocol algorithm. Our aim is (again) reduced computational and data overhead, faster convergence

Re: [B.A.T.M.A.N.] Getting batman into staging

2009-08-26 Thread Andrew Lunn
Hi Greg CC: to the batman list should now work for you. Your email address has been listed as O.K. to accept. There is an ongoing discussion about an open list and fighting SPAM etc. But first off, what is keeping this code from being added to the main portion of the kernel tree? Have you

Re: [B.A.T.M.A.N.] [batman-adv] Use prinkt instead of debug_log

2009-08-24 Thread Andrew Lunn
Does this patch mean you got in touch with a maintainer and he/she suggested to do that ? What else did he/she suggest ? No i've not asked yet. However, i don't know of any other kernel module which does debug output in a similar way. So my guess is this needs changing. I keep intending to

Re: [B.A.T.M.A.N.] [batman-adv] Use prinkt instead of debug_log

2009-08-24 Thread Andrew Lunn
Finish stripping out debug_log. Probably ok but how do we handle the routing protocol debugging stuff ? Should we pipe everything through printk ? Actually, that considerably slows down the system because many distros write that into a log file. By default, it would be disabled, at

[B.A.T.M.A.N.] [batman-adv] Use prinkt instead of debug_log

2009-08-23 Thread Andrew Lunn
mixed in with other kernel messages. LOG_TYPE_BATMAN and LOG_TYPE_ROUTES has not been changed. Signed-off-by: Andrew Lunn and...@lunn.ch Index: batman-adv-kernelland/vis.c === --- batman-adv-kernelland/vis.c (revision 1411) +++ batman

Re: [B.A.T.M.A.N.] [batman-adv] Use prinkt instead of debug_log

2009-08-23 Thread Andrew Lunn
Hi Folks I've been considering what to do with the remaining debug_log calls. We have three classes of output from debug_log: 1) Changes to HNA entries, all in translation-table.c. 2) Changes of routes, all in routing.c 3) All the remaining debug output scattered in a number of files. 1) and

[B.A.T.M.A.N.] tcpdump patch for batman-adv

2009-08-19 Thread Andrew Lunn
Hi Folks Attached is a patch for tcpdump which adds support for dissecting batman-adv messages. This patch is against: git://github.com/mcr/tcpdump.git It would be great if a few users could test it before i submit the patch upstream. Thanks Andrew

[B.A.T.M.A.N.] batman-adv applying for an official Ethertype?

2009-08-18 Thread Andrew Lunn
Hi Folks Has anybody investigated the process for applying for an approved Ethertype as needed by batman advanced? I found a few relevant documents: http://standards.ieee.org/regauth/ http://standards.ieee.org/regauth/ethertype/type-tut.html http://standards.ieee.org/regauth/faqs.html#q15 Not

Re: [B.A.T.M.A.N.] batman-adv applying for an official Ethertype?

2009-08-18 Thread Andrew Lunn
We know about it. Nobody gave us the money yet... and I think it will never happen that a rich boy come to us and give us that money just for 16 bit... The fee is about equivalent to 3 man days of work. So its not that big a sum for a commercial entity wanting to use batman in a product.

Re: [B.A.T.M.A.N.] batman-adv packet.h license

2009-08-18 Thread Andrew Lunn
yeah, also fine with me. Although I don't understand why we have to change the licence of our file for that (I never wrote dissectors for tcpdump). I'm directly using packet.h. As is, no changes. I need the packet structure definitions. The file has a GPL header, so its licensed under GPL. If

[B.A.T.M.A.N.] batman-adv packet.h license

2009-08-17 Thread Andrew Lunn
Hi Marek, Simon I'm writing a protocol dissector for tcpdump which understands batman-adv packets. To do this i need to use packet.h, at least that is the easiest way to do it. tcpdump uses the BSD license, where as packet.h is GPL2. So it is unlikely the tcpdump maintainers would accept packet.h

Re: [B.A.T.M.A.N.] batman-adv packet.h license

2009-08-17 Thread Andrew Lunn
And I think that it is still a good idea to have tcpdump dissectors as you maybe want to have live output over your seriell interface on you embedded device without much hassle. Yes, that is my aim. Wireshark has too much overhead for embedded system use. Writing the dissector was simple.

Re: [B.A.T.M.A.N.] [batman-adv] Cleanup proc.[ch]

2009-07-30 Thread Andrew Lunn
On Sat, Jul 25, 2009 at 07:50:55PM +0800, Marek Lindner wrote: On Saturday 18 July 2009 22:52:36 Andrew Lunn wrote: Make proc.[ch] clean with respect to the 2.6.29 checkpatch script. Exceptions are long lines with printk/seq_print. I just applied this patch with a small modification. You

Re: [B.A.T.M.A.N.] [batman-adv] Cleanup aggregation.[ch]

2009-07-23 Thread Andrew Lunn
On Thu, Jul 23, 2009 at 07:59:29PM +0800, Marek Lindner wrote: On Saturday 18 July 2009 22:32:50 Andrew Lunn wrote: Make aggregation.[ch] clean with respect to the 2.6.29 checkpatch script. Signed-off-by: Andrew Lunn andrew.l...@ascom.ch I applied your patch. I noticed you created

<    1   2   3   4   5   6   >