[B.A.T.M.A.N.] [PATCH] batctl: netlink: fix resetting mcast_flags_priv to unsupported state

This fixes a copy & paste error detected by Coverity. Fixes: b56061058113 ("batctl: add netlink dump function for multicast flags table") Reported-by: scan-ad...@coverity.com Signed-off-by: Linus Lüssing <linus.luess...@c0d3.blue> --- netlink.c | 2 +- 1 file changed, 1 inse

Re: [B.A.T.M.A.N.] New Defects reported by Coverity Scan for batctl

On Mon, Mar 19, 2018 at 01:17:37AM +, scan-ad...@coverity.com wrote: [...] > > *** CID 174547: Incorrect expression (COPY_PASTE_ERROR) > /netlink.c: 255 in info_callback() > 249

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: Disable CONFIG_BATMAN_ADV_DEBUGFS by default

On Sun, Mar 18, 2018 at 10:34:29AM +0100, Sven Eckelmann wrote: > All tools which were known to the batman-adv development team are > supporting the batman-adv netlink interface since a while. Also debugfs is > not supported for batman-adv interfaces in any non-default netns. Thus > disabling

[B.A.T.M.A.N.] [PATCH v3 4/4] batctl: add netlink dump function for multicast flags table

Signed-off-by: Linus Lüssing <linus.luess...@c0d3.blue> --- debug.c | 1 + netlink.c | 143 ++ netlink.h | 2 + 3 files changed, 146 insertions(+) diff --git a/debug.c b/debug.c index 5f9a87b..63fb633 100644 --- a/debug.c

[B.A.T.M.A.N.] [PATCH v3 3/4] batctl: add multicast flags netlink support

Dump the list of multicast flags entries via the netlink socket. Signed-off-by: Linus Lüssing <linus.luess...@c0d3.blue> --- batman_adv.h | 62 1 file changed, 62 insertions(+) diff --git a/batman_adv.h b/batman_adv.h index 9

[B.A.T.M.A.N.] [PATCH v3 2/4] batctl: add netlink dump function for DAT cache table

Signed-off-by: Linus Lüssing <linus.luess...@c0d3.blue> --- debug.c | 1 + netlink.c | 205 ++ netlink.h | 2 + 3 files changed, 156 insertions(+), 52 deletions(-) diff --git a/debug.c b/debug.c index a7c5adf..5f9a87b

[B.A.T.M.A.N.] [PATCH v3 0/4] batctl: netlink support for DAT and MCAST

This patchset adds netlink support for dumping DAT cache and multicast flags tables. Changes in v3: == - renamed netlink attributes: - BATADV_ATTR_DC_ADDRESS -> BATADV_ATTR_DAT_CACHE_IP4ADDRESS - BATADV_ATTR_DC_HWADDRESS -> BATADV_ATTR_DAT_CACHE_HWADDRESS - BATADV_ATTR_DC_VID

[B.A.T.M.A.N.] [PATCH v3 1/4] batctl: add DAT cache netlink support

Dump the list of DAT cache entries via the netlink socket. Signed-off-by: Linus Lüssing <linus.luess...@c0d3.blue> --- batman_adv.h | 20 1 file changed, 20 insertions(+) diff --git a/batman_adv.h b/batman_adv.h index 56ae289..95ab5db 100644 --- a/batman_adv.h

[B.A.T.M.A.N.] [PATCH v3 2/2] batman-adv: add multicast flags netlink support

Dump the list of multicast flags entries via the netlink socket. Signed-off-by: Linus Lüssing <linus.luess...@c0d3.blue> --- include/uapi/linux/batman_adv.h | 62 +++ net/batman-adv/multicast.c | 237 net/batman-adv/multicast.h

[B.A.T.M.A.N.] [PATCH v3 0/2] batman-adv: netlink support for DAT and MCAST

This patchset adds netlink support for dumping DAT cache and multicast flags tables. Changes in v3: == - renamed netlink attributes: - BATADV_ATTR_DC_ADDRESS -> BATADV_ATTR_DAT_CACHE_IP4ADDRESS - BATADV_ATTR_DC_HWADDRESS -> BATADV_ATTR_DAT_CACHE_HWADDRESS - BATADV_ATTR_DC_VID

[B.A.T.M.A.N.] [PATCH v2 4/4] batctl: add netlink dump function for multicast flags table

Signed-off-by: Linus Lüssing <linus.luess...@c0d3.blue> --- debug.c | 1 + netlink.c | 143 ++ netlink.h | 2 + 3 files changed, 146 insertions(+) diff --git a/debug.c b/debug.c index 5f9a87b..63fb633 100644 --- a/debug.c

[B.A.T.M.A.N.] [PATCH v2 3/4] batctl: add multicast flags netlink support

Dump the list of multicast flags entries via the netlink socket. Signed-off-by: Linus Lüssing <linus.luess...@c0d3.blue> --- batman_adv.h | 62 1 file changed, 62 insertions(+) diff --git a/batman_adv.h b/batman_adv.h index 8

[B.A.T.M.A.N.] [PATCH v2 1/4] batctl: add DAT cache netlink support

Dump the list of DAT cache entries via the netlink socket. Signed-off-by: Linus Lüssing <linus.luess...@c0d3.blue> --- batman_adv.h | 20 1 file changed, 20 insertions(+) diff --git a/batman_adv.h b/batman_adv.h index 56ae289..85c9fe8 100644 --- a/batman_adv.h

[B.A.T.M.A.N.] [PATCH v2 0/4] batctl: netlink support for DAT and MCAST

This patchset adds netlink support for dumping DAT cache and multicast flags tables. Changes in v2: == - Removed htonl() conversion for BATADV_ATTR_DC_ADDRESS as batman-adv now provides it in network byte order (via nla_put_in_addr() ) - Increased BATADV_ATTR_MCAST_FLAGS and

[B.A.T.M.A.N.] [PATCH v2 2/4] batctl: add netlink dump function for DAT cache table

Signed-off-by: Linus Lüssing <linus.luess...@c0d3.blue> --- debug.c | 1 + netlink.c | 101 ++ netlink.h | 2 ++ 3 files changed, 104 insertions(+) diff --git a/debug.c b/debug.c index a7c5adf..5f9a87b 100644 --- a/debug.c

[B.A.T.M.A.N.] [PATCH v2 2/2] batman-adv: add multicast flags netlink support

Dump the list of multicast flags entries via the netlink socket. Signed-off-by: Linus Lüssing <linus.luess...@c0d3.blue> --- include/uapi/linux/batman_adv.h | 62 +++ net/batman-adv/multicast.c | 237 net/batman-adv/multicast.h

[B.A.T.M.A.N.] [PATCH v2 0/2] batman-adv: netlink support for DAT and MCAST

This patchset adds netlink support for dumping DAT cache and multicast flags tables. Changes in v2: == - Added missing includes, "#include " and "#include ", to distributed-arp-table.c - Added missing forward declaration for "struct netlink_callback" to distributed-arp-table.h -

[B.A.T.M.A.N.] [PATCH v2 1/2] batman-adv: add DAT cache netlink support

Dump the list of DAT cache entries via the netlink socket. Signed-off-by: Linus Lüssing <linus.luess...@c0d3.blue> --- compat-include/net/netlink.h | 51 +++ include/uapi/linux/batman_adv.h| 20 + net/batman-adv/distributed-arp-table.c

[B.A.T.M.A.N.] [PATCH v3] batman-adv: Avoid redundant multicast TT entries

If a node signals that it wants all traffic for a specific protocol family then there is no need to announce individual multicast addresses via TT. Signed-off-by: Linus Lüssing <linus.luess...@c0d3.blue> --- v3: - use "static const u8 prefix[] =" instead of "const u

[B.A.T.M.A.N.] [PATCH v2] batman-adv: Avoid redundant multicast TT entries

If a node signals that it wants all traffic for a specific protocol family then there is no need to announce individual multicast addresses via TT. Signed-off-by: Linus Lüssing <linus.luess...@c0d3.blue> --- v2: - for consistency use "const u8 *addr" instead of "unsigned char

[B.A.T.M.A.N.] [PATCH maint v3] batman-adv: Fix multicast packet loss with a single WANT_ALL_IPV4/6 flag

lead to IPv6 multicast packet loss if only an IGMP but not an MLD querier is present for instance or vice versa. Fixes: 391b59cdb111 ("batman-adv: Add multicast optimization support for bridged setups") Signed-off-by: Linus Lüssing <linus.luess...@c0d3.blue> --- v3: Added "F

[B.A.T.M.A.N.] [PATCH] batman-adv: Avoid redundant multicast TT entries

If a node signals that it wants all traffic for a specific protocol family then there is no need to announce individual multicast addresses via TT. Signed-off-by: Linus Lüssing <linus.luess...@c0d3.blue> --- net/batman-adv/multicast.c | 56 ++

[B.A.T.M.A.N.] [PATCH maint v2] batman-adv: Fix multicast packet loss with a single WANT_ALL_IPV4/6 flag

lead to IPv6 multicast packet loss if only an IGMP but not an MLD querier is present for instance or vice versa. Signed-off-by: Linus Lüssing <linus.luess...@c0d3.blue> --- v2: Fixed typo in last sentence: "non" -> "not" net/batman-adv/multicast.c | 4 ++-- 1 fil

[B.A.T.M.A.N.] [PATCH maint] batman-adv: Fix multicast packet loss with a single WANT_ALL_IPV4/6 flag

lead to IPv6 multicast packet loss if only an IGMP but non an MLD querier is present for instance or vice versa. Signed-off-by: Linus Lüssing <linus.luess...@c0d3.blue> --- net/batman-adv/multicast.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/batman-adv/multi

[B.A.T.M.A.N.] [PATCH 4/4] batctl: add netlink dump function for multicast flags table

Signed-off-by: Linus Lüssing <linus.luess...@c0d3.blue> --- debug.c | 1 + netlink.c | 143 ++ netlink.h | 2 + 3 files changed, 146 insertions(+) diff --git a/debug.c b/debug.c index 5f9a87b..63fb633 100644 --- a/debug.c

[B.A.T.M.A.N.] [PATCH 1/4] batctl: add DAT cache netlink support

Dump the list of DAT cache entries via the netlink socket. Signed-off-by: Linus Lüssing <linus.luess...@c0d3.blue> --- batman_adv.h | 20 1 file changed, 20 insertions(+) diff --git a/batman_adv.h b/batman_adv.h index 56ae289..85c9fe8 100644 --- a/batman_adv.h

[B.A.T.M.A.N.] [PATCH 2/4] batctl: add netlink dump function for DAT cache table

Signed-off-by: Linus Lüssing <linus.luess...@c0d3.blue> --- debug.c | 1 + netlink.c | 103 ++ netlink.h | 2 ++ 3 files changed, 106 insertions(+) diff --git a/debug.c b/debug.c index a7c5adf..5f9a87b 100644 --- a/debug.c

[B.A.T.M.A.N.] [PATCH 3/4] batctl: add multicast flags netlink support

Dump the list of multicast flags entries via the netlink socket. Signed-off-by: Linus Lüssing <linus.luess...@c0d3.blue> --- batman_adv.h | 62 1 file changed, 62 insertions(+) diff --git a/batman_adv.h b/batman_adv.h index 8

[B.A.T.M.A.N.] [PATCH 1/2] batman-adv: add DAT cache netlink support

Dump the list of DAT cache entries via the netlink socket. Signed-off-by: Linus Lüssing <linus.luess...@c0d3.blue> --- include/uapi/linux/batman_adv.h| 20 + net/batman-adv/distributed-arp-table.c | 151 + net/batman-adv/distributed-arp-table.h

[B.A.T.M.A.N.] [PATCH 2/2] batman-adv: add multicast flags netlink support

Dump the list of multicast flags entries via the netlink socket. Signed-off-by: Linus Lüssing <linus.luess...@c0d3.blue> --- include/uapi/linux/batman_adv.h | 62 +++ net/batman-adv/multicast.c | 236 net/batman-adv/multicast.h

Re: [B.A.T.M.A.N.] [PATCH maint v2 1/2] batman-adv: fix packet checksum in receive path

On Tue, Jan 23, 2018 at 10:59:49AM +0100, Matthias Schiffer wrote: > eth_type_trans() internally calls skb_pull(), which does not adjust the > skb checksum; skb_postpull_rcsum() is necessary to avoid log spam of the > form "bat0: hw csum failure" when packets with CHECKSUM_COMPLETE are > received.

Re: [B.A.T.M.A.N.] Can b.a.t.m.a.n. be configured to ARP for unknown clients?

And one more question: How are the IPv4 addresses assigned? Static configuration or via DHCP? If the latter, what is your current lease timeout and would it be an option to lower it? Regards, Linus On Fri, Dec 29, 2017 at 05:01:23PM +, Robert Bates wrote: > Hello, > > Is it possible to

Re: [B.A.T.M.A.N.] Can b.a.t.m.a.n. be configured to ARP for unknown clients?

Hi, If I understood correctly then the ARP cache life on the polling/management platform is larger than 10min. Would it be an option for you to lower that one to some value below the 10min. translation table timeout? (the default for the ARP/neighbor in Linux is a random value between 30-90

[B.A.T.M.A.N.] Interpreting a Mem-Info Section of an OOM

Hi, With some larger mesh networks running Gluon some Out-of-Memory cases on 32MB RAM devices were reported [0]. For the following Mem-Info section, the number of free pages confuses me a little: [...] [ 236.529242] Mem-Info: [ 236.531561] active_anon:691 inactive_anon:9 isolated_anon:0 [

Re: [B.A.T.M.A.N.] [PATCH 3.16 076/294] batman-adv: fix TT sync flag inconsistencies

Hi Ben! On Mon, Nov 06, 2017 at 11:03:02PM +, Ben Hutchings wrote: > 3.16.50-rc1 review patch. If anyone has any objections, please let me know. > > -- > > From: Linus Lüssing <linus.luess...@c0d3.blue> > > commit 54e22f265e872ae140755b

Re: [B.A.T.M.A.N.] Manually Updating Translation table

Hi Kartik, On Wed, Oct 25, 2017 at 02:46:32PM +0200, Kartikeswar Koppula wrote: > I checked the routes manually and it looks okay. Could you share those? Next to "ip route show" the following tables would be interesting, too: $ ip address show $ brctl show $ batctl tg $ batctl o $ batctl n

Re: [B.A.T.M.A.N.] Manually Updating Translation table

ateway. > > Best Regards, > Kartik > > On Wed, Aug 16, 2017 at 4:47 PM, Linus Lüssing <linus.luess...@c0d3.blue> > wrote: > > Hi, > > > > Currently, no there isn't. The only thing you could do to manually > > add an entry from inside a node is by cra

Re: [B.A.T.M.A.N.] Manually Updating Translation table

Hi, Currently, no there isn't. The only thing you could do to manually add an entry from inside a node is by crafting a dummy packet with the desired ethernet source address and transmit it on bat0. That way batman-adv would add that MAC address. Deleting only happens after a timeout though, no

Re: [B.A.T.M.A.N.] No bandwidth over wired Batman mesh network

On Wed, Aug 09, 2017 at 08:31:43AM +0200, Mattias Vanhoutte wrote: > So here I see a large drop of the TCP bandwidth by using batman 430 -> 125 > Mbit/s. Is this normal behavior? Could be. Especially if you haven't increased the MTU on eth0 or lowered the MTU on bat0 to avoid the batman-adv

Re: [B.A.T.M.A.N.] [PATCH maint v2] batman-adv: fix TT sync flag inconsistencies

On Sat, Jul 29, 2017 at 10:25:37AM +0200, Sven Eckelmann wrote: > On Donnerstag, 6. Juli 2017 07:02:25 CEST Linus Lüssing wrote: > > This patch fixes an issue in the translation table code potentially > > leading to a TT Request + Response storm. The issue may occur for nodes &g

Re: [B.A.T.M.A.N.] [PATCH maint] batman-adv: fix TT sync flag inconsistencies

On Wed, Jul 05, 2017 at 07:59:40AM +0200, Linus Lüssing wrote: > If so, what would you prefer, should I replace the > "common->flags |= flags" with something like a > "common->flags |= flags & (~BATADV_TT_SYNC_MASK)"? Or would you > prefer setting the TEMP

[B.A.T.M.A.N.] [PATCH maint v2] batman-adv: fix TT sync flag inconsistencies

Response for one thing. And to be able to correctly unset sync flags once all nodes announcing a sync flag vanish for another. Fixes: fa614fd04692 ("batman-adv: fix tt_global_entries flags update") Signed-off-by: Linus Lüssing <linus.luess...@c0d3.blue> --- Changes v2: * Fix an issue w

Re: [B.A.T.M.A.N.] [PATCH maint] batman-adv: fix TT sync flag inconsistencies

Hi Antonio, Thanks for looking at it, too :-). On Mon, Jul 03, 2017 at 12:08:01PM +0800, Antonio Quartulli wrote: > [...] > > Linus, > > each originator announces flags covered by BATADV_TT_REMOTE_MASK (0x00FF), > however you are extracting only those covered by BATADV_TT_SYNC_MASK (0x00F0). >

Re: [B.A.T.M.A.N.] [PATCH maint] batman-adv: fix TT sync flag inconsistencies

On Sat, Jul 01, 2017 at 11:34:37PM +0800, Marek Lindner wrote: > On Friday, June 23, 2017 5:48:26 PM HKT Linus Lüssing wrote: > > @@ -1946,6 +1977,7 @@ batadv_tt_global_dump_subentry(struct sk_buff *msg, > > u32 portid, u32 seq, struct batadv_tt_orig_list_entry *

Re: [B.A.T.M.A.N.] [PATCH maint] batman-adv: fix TT sync flag inconsistencies

Hi Marek, Thanks for having a first glance at this patch! On Sat, Jul 01, 2017 at 11:34:37PM +0800, Marek Lindner wrote: > On Friday, June 23, 2017 5:48:26 PM HKT Linus Lüssing wrote: > > @@ -1946,6 +1977,7 @@ batadv_tt_global_dump_subentry(struct sk_buff *msg, > > u32 portid,

Re: [B.A.T.M.A.N.] [PATCH maint] batman-adv: fix TT sync flag inconsistencies

On Fri, Jun 23, 2017 at 05:48:26PM +0200, Linus Lüssing wrote: > [...] > This patch fixes this issue by storing the flags used in the CRC > calculation on a a per TT orig entry basis to be able to respond with > the correct, original flags in an intermediate TT Response for

[B.A.T.M.A.N.] [PATCH maint] batman-adv: fix TT sync flag inconsistencies

Response for one thing. And to be able to correctly unset sync flags once all nodes announcing a sync flag vanish for another. Fixes: fa614fd04692 ("batman-adv: fix tt_global_entries flags update") Signed-off-by: Linus Lüssing <linus.luess...@c0d3.blue> --- net/batman-adv/translat

Re: [B.A.T.M.A.N.] [PATCH maint] batman-adv: fix TT sync flag inconsistencies

On Fri, Jun 23, 2017 at 05:48:26PM +0200, Linus Lüssing wrote: > Fixes: fa614fd04692 ("batman-adv: fix tt_global_entries flags update") > Signed-off-by: Linus Lüssing <linus.luess...@c0d3.blue> Reported-by: Simon Wunderlich <s...@simonwunderlich.de>

Re: [B.A.T.M.A.N.] MAC addresses of loop detect frames in global translation-table

On Wed, May 31, 2017 at 03:39:23PM +0200, Simon Wunderlich wrote: > Hi Andreas, > > yes, those are loop detection packets. Preventing these entries from the > local > translation table has been implemented only recently. We can potentially do > the same for global addresses as well, it just

[B.A.T.M.A.N.] B.A.T.M.A.N. Agenda for BattleMesh

Hi, Thought it might be a good idea to collect the topics we could/should discuss or work on at the BattleMesh in Vienna concerning B.A.T.M.A.N. I started with a list of things I'd be interested in in the link below - feel free to add yours, too: https://etherpad.wikimedia.org/p/batman-wbm10

Re: [B.A.T.M.A.N.] [PATCH v4 0/4] Broadcast Avoidances, Neighborhood Hash

On Sun, Feb 05, 2017 at 07:45:46AM +0100, Linus Lüssing wrote: > Known limitations: Avoidance potential is not fully detected in a setup with > a mix of 100MBit/s and 1000MBit/s capable, wired nodes. I'm currently a little annoyed that I did not anticipate this limitation before implem

[B.A.T.M.A.N.] [PATCH v3 3/5] batman-adv: aggregation packet reception

-by: Linus Lüssing <linus.luess...@c0d3.blue> --- Makefile| 3 + gen-compat-autoconf.sh | 1 + net/batman-adv/Makefile | 1 + net/batman-adv/aggregation.c| 177 net/batman-adv/aggregation.h

[B.A.T.M.A.N.] [PATCH v3 4/5] batman-adv: aggregation packet queueing and transmission

-by: Linus Lüssing <linus.luess...@c0d3.blue> --- net/batman-adv/aggregation.c| 475 net/batman-adv/aggregation.h| 31 +++ net/batman-adv/bat_iv_ogm.c | 6 +- net/batman-adv/hard-interface.c | 5 + net/batman-adv/main.c | 10

[B.A.T.M.A.N.] [PATCH v3 2/5] batman-adv: Allow TVLVs greater than 128 bytes

to and including the TVLV within the received packet. Signed-off-by: Linus Lüssing <linus.luess...@c0d3.blue> --- net/batman-adv/bat_iv_ogm.c | 4 ++-- net/batman-adv/bat_v_ogm.c | 4 ++-- net/batman-adv/tvlv.c | 20 +++- net/batman-adv/tvlv.h | 4 ++-- 4

[B.A.T.M.A.N.] [PATCH v3 5/5] batman-adv: do not aggregate rebroadcasts in the same packet

into the aggregation queue and will be part of the next aggregation packet again. Signed-off-by: Linus Lüssing <linus.luess...@c0d3.blue> --- net/batman-adv/aggregation.c | 69 +++- net/batman-adv/bat_iv_ogm.c | 3 +- net/batman-adv/send.c

[B.A.T.M.A.N.] (no subject)

Hi, This patchset introduces aggregation support for BATMAN V - as well as any other packet type with a broadcast destination. Branch: * https://git.open-mesh.org/batman-adv.git/shortlog/refs/heads/linus/aggregation Regards, Linus --- Changelog: v3: * moved "Introduce packet type independent

[B.A.T.M.A.N.] [PATCH v3 1/5] batman-adv: Introduce packet type independent TVLV handler API

for unicast_tvlv packets too and migrate BATADV_TVLV_{DAT,NC,TT,ROAM} to new API after further testing. * Remove old TVLV handler API Signed-off-by: Linus Lüssing <linus.luess...@c0d3.blue> --- Old changelog (from neighborhood patchset): Changes in v4: * remove unnecessary bug.h include (not

Re: [B.A.T.M.A.N.] Duplicate #include guards with make-kpkg / out-of-tree compile errors

52AM +, Ben Hutchings wrote: > kernel-package is maintained by Manoj Srivastava (cc'd), not the kernel > team. > > Ben. > > On Sat, 2017-01-14 at 22:28 +0100, Linus Lüssing wrote: > > Hi Ben and others, > > > > Recently we stumbled upon some compile erro

[B.A.T.M.A.N.] [PATCH] RFC: batman-adv: Increase hashtable size for the global translation table

mesh networks has grown to nearly 4000. Therefore this patch inceases the global translation table size from 1024 to 16384 to reduce load in larger mesh networks. Signed-off-by: Linus Lüssing <linus.luess...@c0d3.blue> --- ToDo (maybe): Gather some statistics on how much this might reduc

Re: [B.A.T.M.A.N.] Node freezes but still alive

On Fri, Feb 24, 2017 at 10:48:35AM -0600, Derick Roman De Leon Leal wrote: > Thanks for the quick reply Linus, > > No transmission on IPv4 If that's for the adhoc0 interface directly then this seems to be a wireless driver issue and not a batman-adv one :(. Hm, if I'm not mistaken then the

Re: [B.A.T.M.A.N.] Node freezes but still alive

Hi Derick, On Thu, Feb 23, 2017 at 05:37:55PM -0600, Derick Roman De Leon Leal wrote: > I have a little setup with two nodes and one gateway, from time to > time one of the nodes just stops transmitting data. Very odd indeed. Can you check whether transmitting IPv4 or IPv6 packets on adhoc0

[B.A.T.M.A.N.] [PATCH] RFC: batman-adv: BATMAN V: Make route switching more opportunistic

Increase route switching likelikood with every seqno we missed from our currently selected router. This is safe to do without causing any loops at any time because the sequence number is strictly larger than the one we last got from our selected router. --- Another idea to improve route

[B.A.T.M.A.N.] [PATCH v2 4/6] batman-adv: privatize forw_packet skb assignment

An skb is assigned to a forw_packet only once, shortly after the forw_packet allocation. With this patch the assignment is moved into the this allocation function. Signed-off-by: Linus Lüssing <linus.luess...@c0d3.blue> --- net/batman-adv/bat_iv_ogm.c | 17 + net/batm

[B.A.T.M.A.N.] [PATCH v2 6/6] batman-adv: do not aggregate rebroadcasts in the same packet

into the aggregation queue and will be part of the next aggregation packet again. Signed-off-by: Linus Lüssing <linus.luess...@c0d3.blue> --- net/batman-adv/aggregation.c | 69 +++- net/batman-adv/bat_iv_ogm.c | 3 +- net/batman-adv/send.c

[B.A.T.M.A.N.] [PATCH v2 3/6] batman-adv: aggregation packet queueing and transmission

-by: Linus Lüssing <linus.luess...@c0d3.blue> --- net/batman-adv/aggregation.c| 475 net/batman-adv/aggregation.h| 31 +++ net/batman-adv/bat_iv_ogm.c | 6 +- net/batman-adv/hard-interface.c | 5 + net/batman-adv/main.c | 10

[B.A.T.M.A.N.] [PATCH v2 5/6] batman-adv: restructure rebroadcast counter into forw_packet API

access to num_bcasts private to batadv_forw_packet_*() Signed-off-by: Linus Lüssing <linus.luess...@c0d3.blue> --- net/batman-adv/distributed-arp-table.c | 2 +- net/batman-adv/main.c | 3 ++ net/batman-adv/send.c | 50 -- ne

[B.A.T.M.A.N.] [PATCH v2 2/6] batman-adv: aggregation packet reception

-by: Linus Lüssing <linus.luess...@c0d3.blue> --- Makefile| 3 + gen-compat-autoconf.sh | 1 + net/batman-adv/Makefile | 1 + net/batman-adv/aggregation.c| 177 net/batman-adv/aggregation.h| 51 +++

[B.A.T.M.A.N.] [PATCH v2 1/6] batman-adv: Allow TVLVs greater than 128 bytes

to and including the TVLV within the received packet. Signed-off-by: Linus Lüssing <linus.luess...@c0d3.blue> --- net/batman-adv/bat_iv_ogm.c | 4 ++-- net/batman-adv/bat_v_ogm.c | 4 ++-- net/batman-adv/tvlv.c | 20 +++- net/batman-adv/tvlv.h | 4 ++-- 4

[B.A.T.M.A.N.] [PATCH v2 0/6] batman-adv: broadcast packet aggregation

Hi, Here is a first patchset to reintroduce aggregation support for BATMAN V, too - as well as any other packet type with a broadcast destination. Branch: * https://git.open-mesh.org/batman-adv.git/shortlog/refs/heads/linus/aggregation Regards, Linus PS: Requires: "batman-adv: Introduce packet

Re: [B.A.T.M.A.N.] Distributing Data using BATMAN-Multicast

On Thu, Feb 16, 2017 at 12:35:32PM +, Shantanoo Desai wrote: > I have developed a Multicast based Data Distribution protocol and would > like to compare it with Batman's Multicast feature. Cool :-)! I would love to do the same, or at least have a look at the protocol algorithm you have

Re: [B.A.T.M.A.N.] [PATCH 3.2 049/126] batman-adv: fix splat on disabling an interface

On Wed, Feb 15, 2017 at 10:41:34PM +, Ben Hutchings wrote: > 3.2.85-rc1 review patch. If anyone has any objections, please let me know. > > -- > > From: Linus Lüssing <linus.luess...@c0d3.blue> > > commit 9799c50372b23ed774791bdb87d700f

Re: [B.A.T.M.A.N.] [PATCH maint] batman-adv: Fix transmission of final, 16th fragment

On Mon, Feb 13, 2017 at 10:23:52PM +0100, Sven Eckelmann wrote: > On Montag, 13. Februar 2017 21:00:08 CET Linus Lüssing wrote: > [...] > > And one more thing which seems fishy to me in this function: > > > > 526 /* Make room for the fra

Re: [B.A.T.M.A.N.] [PATCH maint] batman-adv: Fix transmission of final, 16th fragment

On Mon, Feb 13, 2017 at 08:44:31PM +0100, Linus Lüssing wrote: > Trying to split and transmit a unicast packet in 16 parts will fail for > the final fragment: After having sent the 15th one with a frag_packet.no > index of 14, we will increase the the index to 15 - and return with an >

[B.A.T.M.A.N.] [PATCH maint] batman-adv: Fix transmission of final, 16th fragment

and allowed. Fixing this issue by moving the check before incrementing the index. While at it, adding an unlikely(), because the check is actually more of an assertion. Signed-off-by: Linus Lüssing <linus.luess...@c0d3.blue> --- Compile time tested only --- net/batman-adv/fragmentation.

Re: [B.A.T.M.A.N.] [PATCH 2/2] batman-adv: Keep fragments equally sized

org> > --- > This patch is meant to enter master together with > https://patchwork.open-mesh.org/patch/16933/ > > net/batman-adv/fragmentation.c | 20 +--- > 1 file changed, 13 insertions(+), 7 deletions(-) Acked-by: Linus Lüssing <linus.luess...@c0d3.blue>

Re: [B.A.T.M.A.N.] how to hand ptp links and still access radio management interfaces

On Fri, Feb 10, 2017 at 09:50:32AM +0100, fboehm wrote: > Because the Airfiber isn't aware of Batman header and can't > process such network traffic. Hm, why is that? The Airfiber can surely forward ethernet frames, can't it? Been using a pair of Ubiquiti NanoBridges with their stock firmware in

Re: [B.A.T.M.A.N.] [PATCH 5/6] batman-adv: restructure rebroadcast counter into forw_packet API

On Mon, Feb 06, 2017 at 11:25:00AM +0100, Sven Eckelmann wrote: > I like this change but have some questions (but no time to check it). Is cb > initialized when a new skbuff is allocated? Hm, good point. It looks like skb->cb is set to zero for newly allocated skbs via a memset down to

Re: [B.A.T.M.A.N.] [PATCH v4 3/4] batman-adv: Introduce packet type independent TVLV handler API

Btw., if someone prefers looking at the aggregation patchset first, which is the more important one, then I can also move this patch to the aggregation patchset.

[B.A.T.M.A.N.] [PATCH v4 4/4] batman-adv: Evaluate and use neighborhood hash TVLV

will check whether either the ingress side or the egress side might be a bottleneck metric wise. In other words, whether a rebroadcast might not enhance any throughput. Signed-off-by: Linus Lüssing <linus.luess...@c0d3.blue> --- Changes in v4: * fix checkpatch warning for types

[B.A.T.M.A.N.] [PATCH v4 3/4] batman-adv: Introduce packet type independent TVLV handler API

for unicast_tvlv packets too and migrate BATADV_TVLV_{DAT,NC,TT,ROAM} to new API after further testing. * Remove old TVLV handler API Signed-off-by: Linus Lüssing <linus.luess...@c0d3.blue> --- Changes in v4: * remove unnecessary bug.h include (not needed anymore since the removal of the wr

[B.A.T.M.A.N.] [PATCH v4 2/4] batman-adv: Store and transmit own neighborhood hash

Adds a sha512 hash as a TVLV to an ELP packet. Hash is the "sum" of all neighbors (ordered alphabetically, concatenated, binary) a node sees on a specific interface. Furthermore, the best and worst TX metric of all these neighbors on an interface are added to the TVLV. Signed-off

[B.A.T.M.A.N.] [PATCH v4 1/4] batman-adv: Keep hard interface neighbor list sorted

The upcoming neighborhood hashing will compute a hash over the MAC address of all neighbors on an interface, from the smallest to the largest one. This patch keeps the hard interface neighbor list in order to ease the hash computation later. Signed-off-by: Linus Lüssing <linus.luess...@c0d3.b

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: decrease maximum fragment size

On Tue, Jan 31, 2017 at 12:07:24PM +0100, Sven Eckelmann wrote: > On Sonntag, 29. Januar 2017 06:14:28 CET Linus Lüssing wrote: > [...] > > However, currently "Fragmentation v2" does not support re-fragmentation. > > Which means that once a packet is split into two p

[B.A.T.M.A.N.] [PATCH 3/6] batman-adv: aggregation packet queueing and transmission

-by: Linus Lüssing <linus.luess...@c0d3.blue> --- net/batman-adv/aggregation.c| 475 net/batman-adv/aggregation.h| 31 +++ net/batman-adv/bat_iv_ogm.c | 6 +- net/batman-adv/hard-interface.c | 5 + net/batman-adv/main.c | 10

[B.A.T.M.A.N.] [PATCH 6/6] batman-adv: do not aggregate rebroadcasts in the same packet

into the aggregation queue and will be part of the next aggregation packet again. Signed-off-by: Linus Lüssing <linus.luess...@c0d3.blue> --- net/batman-adv/aggregation.c | 69 +++- net/batman-adv/bat_iv_ogm.c | 3 +- net/batman-adv/send.c

[B.A.T.M.A.N.] [PATCH 2/6] batman-adv: aggregation packet reception

-by: Linus Lüssing <linus.luess...@c0d3.blue> --- Makefile| 3 + gen-compat-autoconf.sh | 1 + net/batman-adv/Makefile | 1 + net/batman-adv/aggregation.c| 177 net/batman-adv/aggregation.h| 51 +++

[B.A.T.M.A.N.] [PATCH 0/6] batman-adv: broadcast packet aggregation

Hi, Here is a first patchset to reintroduce aggregation support for BATMAN V, too - as well as any other packet type with a broadcast destination. Branch: * https://git.open-mesh.org/batman-adv.git/shortlog/refs/heads/linus/aggregation Regards, Linus PS: Requires: "batman-adv: Introduce packet

[B.A.T.M.A.N.] [PATCH 1/6] batman-adv: Allow TVLVs greater than 128 bytes

to and including the TVLV within the received packet. Signed-off-by: Linus Lüssing <linus.luess...@c0d3.blue> --- net/batman-adv/bat_iv_ogm.c | 4 ++-- net/batman-adv/bat_v_ogm.c | 4 ++-- net/batman-adv/tvlv.c | 20 +++- net/batman-adv/tvlv.h | 4 ++-- 4

Re: [B.A.T.M.A.N.] [RFC PATCH 0/6] batman-adv: broadcast packet aggregation

On Sun, Jan 29, 2017 at 02:10:00PM +0100, Linus Lüssing wrote: > For instance the VPN tool "fastd", would add additional > headers in sizes of up to 86 bytes (40B IPv6 + 46B UDP+fastd) [1]. > Therefore reducing the number of broadcast packets by 2.79 should > reduce the effec

Re: [B.A.T.M.A.N.] [RFC PATCH 0/6] batman-adv: broadcast packet aggregation

On Sun, Jan 22, 2017 at 02:08:50PM +0100, Sven Eckelmann wrote: > On Montag, 19. Dezember 2016 12:25:29 CET Linus Lüssing wrote: > > Hi, > > > > Here is a first patchset to reintroduce aggregation support for BATMAN V, > > too. > > And while at it, for BATMAN

[B.A.T.M.A.N.] [PATCH] batman-adv: decrease maximum fragment size

noticeable for a user. Cc: Matthias Schiffer <mschif...@universe-factory.net> [linus.luess...@c0d3.blue: Added commit message] Signed-off-by: Linus Lüssing <linus.luess...@c0d3.blue> --- This patch is currently used in Gluon [1] because we stumbled over this issue in setups where batman-

[B.A.T.M.A.N.] [PATCH v3 4/4] batman-adv: Evaluate and use neighborhood hash TVLV

will check whether either the ingress side or the egress side might be a bottleneck metric wise. In other words, whether a rebroadcast might not enhance any throughput. Signed-off-by: Linus Lüssing <linus.luess...@c0d3.blue> --- Changes in v3: * ~((u32)0) -> U32_MAX * avoid one-l

[B.A.T.M.A.N.] [PATCH v3 0/4] Broadcast Avoidances, Neighborhood Hash

Hi, Here's the second broadcast avoidance patchset. Hopefully, those two patchsets together should be an automatic approach and replacement for the (non-upstream) no-rebroadcast flag patch and the cases it is currently used for. Documentation: *

[B.A.T.M.A.N.] [PATCH v3 2/4] batman-adv: Store and transmit own neighborhood hash

Adds a sha512 hash as a TVLV to an ELP packet. Hash is the "sum" of all neighbors (ordered alphabetically, concatenated, binary) a node sees on a specific interface. Furthermore, the best and worst TX metric of all these neighbors on an interface are added to the TVLV. Signed-off

[B.A.T.M.A.N.] [PATCH v3 1/4] batman-adv: Keep hard interface neighbor list sorted

The upcoming neighborhood hashing will compute a hash over the MAC address of all neighbors on an interface, from the smallest to the largest one. This patch keeps the hard interface neighbor list in order to ease the hash computation later. Signed-off-by: Linus Lüssing <linus.luess...@c0d3.b

Re: [B.A.T.M.A.N.] [PATCH 2/2] batman-adv: Fix includes for IS_ERR/ERR_PTR

On Sat, Jan 28, 2017 at 10:22:49PM +0100, Linus Lüssing wrote: > On Sat, Jan 28, 2017 at 10:25:26AM +0100, Sven Eckelmann wrote: > > IS_ERR/ERR_PTR are not defined in linux/device.h but in linux/err.h. The > > files using these macros therefore have to include the correct one. &g

Re: [B.A.T.M.A.N.] [PATCH 2/2] batman-adv: Fix includes for IS_ERR/ERR_PTR

On Sat, Jan 28, 2017 at 10:25:26AM +0100, Sven Eckelmann wrote: > IS_ERR/ERR_PTR are not defined in linux/device.h but in linux/err.h. The > files using these macros therefore have to include the correct one. > > Reported-by: Linus Luessing > Signed-off-by: Sven Eckelmann

Re: [B.A.T.M.A.N.] [PATCH v2 1/4] batman-adv: Keep hard interface neighbor list sorted

On Sat, Jan 28, 2017 at 04:13:11AM +0100, Linus Lüssing wrote: > On Wed, Dec 14, 2016 at 08:23:19PM +0100, Sven Eckelmann wrote: > > diff --git a/net/batman-adv/bat_v_elp.c b/net/batman-adv/bat_v_elp.c > > index 712bd428..a69614f5 100644 > > --- a/net/b

Re: [B.A.T.M.A.N.] [PATCH v2 1/4] batman-adv: Keep hard interface neighbor list sorted

On Wed, Dec 14, 2016 at 08:23:19PM +0100, Sven Eckelmann wrote: > diff --git a/net/batman-adv/bat_v_elp.c b/net/batman-adv/bat_v_elp.c > index 712bd428..a69614f5 100644 > --- a/net/batman-adv/bat_v_elp.c > +++ b/net/batman-adv/bat_v_elp.c > @@ -19,10 +19,10 @@ > #include

[B.A.T.M.A.N.] [PATCH] batman-adv: restructure cfg80211 compat code

nterface is used. c) Migrates cfg80211 compat code from compat.h to compat cfg80211.h to keep compat.h slim. Signed-off-by: Linus Lüssing <linus.luess...@c0d3.blue> --- compat-include/net/cfg80211.h | 21 - compat.h | 21

<    1   2   3   4   5   6   7   8   9   10   >