Re: [B.A.T.M.A.N.] bridge loop avoidance (v3)

2010-10-09 Thread Marek Lindner
On Wednesday 29 September 2010 15:20:13 Marek Lindner wrote: > the received comments motivated me to reword the commit messages to outline > that the loop is caused by bridging the payload traffic and not by the LAN > itself. Furthermore, the locking has been cleaned up and the neighbor

Re: [B.A.T.M.A.N.] (no subject)

2010-10-09 Thread Marek Lindner
On Thursday 30 September 2010 14:08:40 Marek Lindner wrote: > since the vis code and the bridge loop avoidance code already use > the kref library functions, I converted the remaining refcounting > code to use kref as well. These patches also got applied (revision 1818-1821). Regards, Marek

Re: [B.A.T.M.A.N.] Windows 7 and ad hoc network

2010-10-09 Thread Marek Lindner
On Thursday 07 October 2010 11:07:55 Magosányi Árpád wrote: > The windows seems to use dhcp request all times, never dhcp discover, > even after it obviosly figured out that the old IP won't work. > The dhcp servers aren't set to be authoritative, as it would create > problems where their area ov

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: Don't dereference unchecked incoming soft_iface

2010-10-09 Thread Marek Lindner
On Saturday 09 October 2010 02:19:42 Sven Eckelmann wrote: > send_packet derefenced forw_packet->if_incoming and checked if > forw_packet->if_incoming is NULL. > > This cannot happen, but still makes irritates when reading through the > functions. Applied in revision 1822. Thanks, Marek

[B.A.T.M.A.N.] [PATCH 1/3] batman-adv: decrease refcount of hard-interface when it gets removed

2010-10-10 Thread Marek Lindner
Signed-off-by: Marek Lindner --- batman-adv/hard-interface.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/batman-adv/hard-interface.c b/batman-adv/hard-interface.c index ec16dc9..afc2c3d 100644 --- a/batman-adv/hard-interface.c +++ b/batman-adv/hard-interface.c

Re: [B.A.T.M.A.N.] [PATCH 2/5] batman-adv: Introduce generic BAT_ATTR_* macros

2010-10-10 Thread Marek Lindner
On Sunday 10 October 2010 06:29:58 Linus Lüssing wrote: > Additionally, the sysfs entries "aggregate_ogms" and "fragmentation" > get renamed to "aggregation" and "frag" for consistency reasons, they > match the *_enabled parts in bat_priv now. I don't quite understand why you want to rename these

Re: [B.A.T.M.A.N.] [PATCH 3/5] batman-adv: Make hop_penalty configurable via sysfs

2010-10-10 Thread Marek Lindner
On Sunday 10 October 2010 06:29:59 Linus Lüssing wrote: > When having a mixed topology of both very mobile and rather static > nodes, you are usually best advised to set the originator interval on > all nodes to a level best suited for the most mobile node. > > However, if most of the nodes are ra

Re: [B.A.T.M.A.N.] [PATCH 4/5] batman-adv: Make number of (re)broadcasts configurable via sysfs

2010-10-10 Thread Marek Lindner
On Sunday 10 October 2010 06:30:00 Linus Lüssing wrote: > Depending on the scenario, people might want to adjust the number of > (re)broadcast of data packets - usually higher values in sparse or lower > values in dense networks. Is there a good reason to change this value at runtime or would a de

Re: [B.A.T.M.A.N.] [PATCH 1/3] batman-adv: decrease refcount of hard-interface when it gets removed

2010-10-12 Thread Marek Lindner
On Monday 11 October 2010 09:54:09 Sven Eckelmann wrote: > Acked-by: Sven Eckelmann Applied in revision 1820. Regards, Marek

Re: [B.A.T.M.A.N.] [PATCH 1/3] batman-adv: decrease refcount of hard-interface when it gets removed

2010-10-12 Thread Marek Lindner
On Tuesday 12 October 2010 11:47:00 Marek Lindner wrote: > On Monday 11 October 2010 09:54:09 Sven Eckelmann wrote: > > Acked-by: Sven Eckelmann > > Applied in revision 1820. Sorry, was 1823. Regards, Marek

Re: [B.A.T.M.A.N.] [PATCH 5/5] batman-adv: Fix resizing of broadcast seqno buffers on if deletion

2010-10-12 Thread Marek Lindner
On Sunday 10 October 2010 06:30:01 Linus Lüssing wrote: > Not only the entries of the deleted interface got erased, but also all > ones with a lower if_num. This commit fixes this issue by setting the > destination appropriately. Applied in revision 1824. Thanks, Marek

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: Fix wrongly formatted %pM in bat_dbg()

2010-10-12 Thread Marek Lindner
On Sunday 10 October 2010 15:38:11 Linus Lüssing wrote: > bat_dbg() invokes debug_log() which invokes the kernel's vscnprintf(), > which invokes the kernel's vsnprintf(), and not the customized > bat_vsnprintf(), which backports the %pM to older kernel versions! > > Therefore this commit ports a c

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: Keep line length to 80 chars

2010-10-12 Thread Marek Lindner
On Sunday 10 October 2010 12:07:06 Sven Eckelmann wrote: > 48628bb9419fb5b01a26ca995465d1aded1e47ed added a line over the limit of > 80 chars. This should be avoided according to the kernel > Documentation/CodingStyle. Applied in revision 1826. Regards, Marek

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: replace the use of -objs with -y

2010-10-12 Thread Marek Lindner
On Tuesday 12 October 2010 00:54:33 Sven Eckelmann wrote: > From: Tracey Dent > > Changed -objs to -y n Makefile. Applied in revision 1827. Thanks, Marek

[B.A.T.M.A.N.] [PATCH 1/3] batman-adv: protect against ogm packet overflow by checking table length

2010-10-15 Thread Marek Lindner
Reported-by: Sam Yeung Signed-off-by: Marek Lindner --- batman-adv/translation-table.c |9 +++-- 1 files changed, 7 insertions(+), 2 deletions(-) diff --git a/batman-adv/translation-table.c b/batman-adv/translation-table.c index 9cae140..75c8ce0 100644 --- a/batman-adv/translation

[B.A.T.M.A.N.] [PATCH 2/3] batman-adv: fix crash when new OGM is generated

2010-10-15 Thread Marek Lindner
If aggregation is not enabled the local translation table can grow much bigger and expects to fill a full ethernet packet. Reported-by: Sam Yeung Signed-off-by: Marek Lindner --- batman-adv/aggregation.c | 10 -- 1 files changed, 8 insertions(+), 2 deletions(-) diff --git a/batman

[B.A.T.M.A.N.] [PATCH 3/3] batman-adv: process OGMs bigger than MAX_AGGREGATION_BYTES

2010-10-15 Thread Marek Lindner
Reported-by: Sam Yeung Signed-off-by: Marek Lindner --- batman-adv/aggregation.c |7 +++ 1 files changed, 3 insertions(+), 4 deletions(-) diff --git a/batman-adv/aggregation.c b/batman-adv/aggregation.c index 16b268e..08624d4 100644 --- a/batman-adv/aggregation.c +++ b/batman-adv

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: Add batman-adv sysfs ABI documentation

2010-10-15 Thread Marek Lindner
On Tuesday 12 October 2010 12:45:46 Sven Eckelmann wrote: > The kernel requires to have all files in /sys documented and updated > when new files are added. > > batman-adv has two important classes of files: one class for each mesh > device and one for a directory in all normal netdevice folders.

[B.A.T.M.A.N.] [PATCH] batman-adv: document fragmentation sysfs API

2010-10-15 Thread Marek Lindner
Signed-off-by: Marek Lindner --- batman-adv/sysfs-class-net-mesh |8 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/batman-adv/sysfs-class-net-mesh b/batman-adv/sysfs-class-net-mesh index 5aa1912..b4cdb60 100644 --- a/batman-adv/sysfs-class-net-mesh +++ b/batman-adv

Re: [B.A.T.M.A.N.] [PATCH 5/4] batman-adv: Make hop_penalty configurable via sysfs

2010-10-15 Thread Marek Lindner
On Wednesday 13 October 2010 13:33:09 Linus Lüssing wrote: > Exposing the hop_penalty is especially useful for the stated scenario: A > static node can keep the default originator interval, a mobile node can > select a quicker one resulting in faster route updates towards this > mobile node. Additi

Re: [B.A.T.M.A.N.] Simplifying sysfs code

2010-10-15 Thread Marek Lindner
On Wednesday 13 October 2010 00:22:01 Linus Lüssing wrote: > Simon's idea so far was, to introduce a debug/ folder in sysfs which is > hidden by default and could be enabled with a KConfig option, so that > tinkerers still have a chance for their needs for tweaking parameters. > num_bcasts would pr

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: document fragmentation sysfs API

2010-10-18 Thread Marek Lindner
On Friday 15 October 2010 17:56:12 Marek Lindner wrote: > +Description: > +Indicates whether the data traffic going through the > +mesh will be fragmented or silently discarded if the > +packet size exceeds the outgoing interface MTU.

Re: [B.A.T.M.A.N.] [PATCH 1/3] batman-adv: protect against ogm packet overflow by checking table length

2010-10-18 Thread Marek Lindner
On Friday 15 October 2010 17:43:35 Marek Lindner wrote: > Reported-by: Sam Yeung Applied in revision 1830-1832. Regards, Marek

Re: [B.A.T.M.A.N.] Simplifying sysfs code

2010-10-18 Thread Marek Lindner
On Wednesday 13 October 2010 00:22:01 Linus Lüssing wrote: > thanks for all the feedback for the changes I wanted to make to the sysfs > code base. I tried to address bugs and suggestions. The macros are now a > bit smaller than in the beginning, the missing static has been added > (thanks Andrew a

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: Adding sysfs API documentation for hop_penalty

2010-10-18 Thread Marek Lindner
On Monday 18 October 2010 12:01:59 Linus Lüssing wrote: > + Defines the penalty which will be applied to an > + originator message's tq-field on every hop. In a > + mixed topology of static and mobile nodes, it might > + be desired to increase

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: Remove space before tab in bat_sysfs.c

2010-10-21 Thread Marek Lindner
On Tuesday 19 October 2010 01:46:30 Sven Eckelmann wrote: > -ssize_t show_##_name(struct kobject *kobj, struct attribute *attr, \ > +ssize_t show_##_name(struct kobject *kobj, struct attribute *attr, \ Applied in revision 1837. Thanks, Marek

Re: [B.A.T.M.A.N.] Polishing of the hash implementation

2010-10-22 Thread Marek Lindner
On Saturday 09 October 2010 14:16:35 Sven Eckelmann wrote: > David S. Miller wasn't amused[1] by our hash implementation. Instead he > proposed some changes we should make. I tried to implement most of them, > but don't think we should really manually inline every functionality > currently provided

Re: [B.A.T.M.A.N.] [PATCH 5/4] batman-adv: Make hop_penalty configurable via sysfs

2010-10-22 Thread Marek Lindner
On Wednesday 13 October 2010 13:33:09 Linus Lüssing wrote: > Exposing the hop_penalty is especially useful for the stated scenario: A > static node can keep the default originator interval, a mobile node can > select a quicker one resulting in faster route updates towards this > mobile node. Additi

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: Adding sysfs ABI documentation for hop_penalty

2010-10-22 Thread Marek Lindner
On Monday 18 October 2010 23:44:13 Linus Lüssing wrote: > +Description: > + Defines the penalty which will be applied to an > + originator message's tq-field on every hop. Applied in revision 1845. Thanks, Marek

Re: [B.A.T.M.A.N.] [PATCHv2] batman-adv: Limit spin_locks to spin_lock_bh

2010-10-23 Thread Marek Lindner
On Monday 18 October 2010 15:16:58 Sven Eckelmann wrote: > This makes it possible to exchange the quite complex spin_lock_irqsave > with spin_lock_bh which only stops bottom halves from running on the > current cpu, but allows interrupt handlers to take over to keep the > interrupt latency low. Ap

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: Add missing space in originator.c

2010-10-23 Thread Marek Lindner
On Saturday 23 October 2010 15:46:02 Sven Eckelmann wrote: > - swaphash = hash_resize(bat_priv->orig_hash,choose_orig, > + swaphash = hash_resize(bat_priv->orig_hash, choose_orig, Applied in revision 1847. Thanks, Marek

[B.A.T.M.A.N.] [PATCH] batman-adv: remove obsolete flags variable to avoid kernel warnings

2010-10-23 Thread Marek Lindner
Signed-off-by: Marek Lindner --- batman-adv/bat_debugfs.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/batman-adv/bat_debugfs.c b/batman-adv/bat_debugfs.c index 11e5f65..934c879 100644 --- a/batman-adv/bat_debugfs.c +++ b/batman-adv/bat_debugfs.c @@ -57,7 +57,6

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: remove obsolete flags variable to avoid kernel warnings

2010-10-23 Thread Marek Lindner
On Saturday 23 October 2010 17:19:21 Sven Eckelmann wrote: > Correct. Forgot them because I only build it in non-debug mode. Same here - I missed these warnings when I checked your patch before submitting it. Just applied this patch (revision 1848). Regards, Marek

[B.A.T.M.A.N.] batman-adv gateway handling

2010-10-23 Thread Marek Lindner
Hi, the batman-adv gateway functionality has been available in the trunk for quite some time but was never able to enter an official release because the sysfs API did not follow the Linux kernel guidelines. I wrote a series of patches meant to address these style issues. A comprehensive docume

[B.A.T.M.A.N.] [PATCH 1/8] batman-adv: remove redundant gw_node_list_free() function

2010-10-23 Thread Marek Lindner
Signed-off-by: Marek Lindner --- batman-adv/gateway_client.c | 30 +- batman-adv/gateway_client.h |3 +-- batman-adv/main.c |2 +- batman-adv/originator.c |2 +- 4 files changed, 12 insertions(+), 25 deletions(-) diff --git a/batman-adv

[B.A.T.M.A.N.] [PATCH 2/8] batman-adv: gateways silently drop DHCP requests

2010-10-23 Thread Marek Lindner
Signed-off-by: Marek Lindner --- batman-adv/gateway_client.c | 31 +-- batman-adv/gateway_client.h |2 +- batman-adv/soft-interface.c | 16 ++-- 3 files changed, 28 insertions(+), 21 deletions(-) diff --git a/batman-adv/gateway_client.c b/batman

[B.A.T.M.A.N.] [PATCH 3/8] batman-adv: move gateway selection class into its own sysfs file

2010-10-23 Thread Marek Lindner
The Linux kernel guidelines require each sysfs file to have a single value / purpose, therefore it is necessary to split up the sysfs gateway files. Signed-off-by: Marek Lindner --- batman-adv/bat_sysfs.c | 10 ++ batman-adv/gateway_client.c |6 +++--- batman-adv

[B.A.T.M.A.N.] [PATCH 4/8] batman-adv: move gateway bandwidth into its own sysfs file

2010-10-23 Thread Marek Lindner
The Linux kernel guidelines require each sysfs file to have a single value / purpose, therefore it is necessary to split up the sysfs gateway files. Signed-off-by: Marek Lindner --- batman-adv/bat_sysfs.c | 37 +-- batman-adv/gateway_client.c |6 +- batman-adv

[B.A.T.M.A.N.] [PATCH 5/8] batman-adv: cleanup gw mode sysfs file to only accept one value

2010-10-23 Thread Marek Lindner
The Linux kernel guidelines require each sysfs file to have a single value / purpose, therefore it is necessary to split up the sysfs gateway files. Signed-off-by: Marek Lindner --- batman-adv/bat_sysfs.c | 78 batman-adv/gateway_common.c | 214

[B.A.T.M.A.N.] [PATCH 6/8] batctl: support new gateway sysfs API

2010-10-23 Thread Marek Lindner
Signed-off-by: Marek Lindner --- batctl/main.c |3 +- batctl/man/batctl.8 |4 +- batctl/sys.c| 117 ++- batctl/sys.h|9 4 files changed, 128 insertions(+), 5 deletions(-) diff --git a/batctl/main.c b/batctl

[B.A.T.M.A.N.] [PATCH 7/8] batman-adv: document gateway sysfs ABI

2010-10-23 Thread Marek Lindner
Signed-off-by: Marek Lindner --- batman-adv/sysfs-class-net-mesh | 21 + 1 files changed, 21 insertions(+), 0 deletions(-) diff --git a/batman-adv/sysfs-class-net-mesh b/batman-adv/sysfs-class-net-mesh index bd20e14..748fe17 100644 --- a/batman-adv/sysfs-class-net-mesh

[B.A.T.M.A.N.] [PATCH 8/8] batman-adv: add gateway IPv6 support by filtering DHCPv6 messages

2010-10-23 Thread Marek Lindner
Signed-off-by: Marek Lindner --- batman-adv/gateway_client.c | 40 +++- 1 files changed, 31 insertions(+), 9 deletions(-) diff --git a/batman-adv/gateway_client.c b/batman-adv/gateway_client.c index e6cd9ac..128f851 100644 --- a/batman-adv/gateway_client.c

[B.A.T.M.A.N.] [PATCH] batman-adv: fix crash on mesh cleanup in bridge loop avoidance code

2010-10-24 Thread Marek Lindner
Signed-off-by: Marek Lindner --- batman-adv/soft-interface.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/batman-adv/soft-interface.c b/batman-adv/soft-interface.c index a13276b..5ae26e8 100644 --- a/batman-adv/soft-interface.c +++ b/batman-adv/soft-interface.c

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: Re-Enable Interface alternating and bonding

2010-10-25 Thread Marek Lindner
On Monday 25 October 2010 08:34:48 Chris Lang wrote: > r1765 incidentally disabled bonding of packets first entering the > mesh along with also disabling interface alternating regardless > of where the packet came from. This re-enables these options. Wow - what a catch! :-) We might have to reword

Re: [B.A.T.M.A.N.] batman-adv multi-hop route

2010-10-25 Thread Marek Lindner
On Monday 25 October 2010 06:03:01 Xianghua Xiao wrote: > I'm trying to test how much bandwidth is left after multi-hops using > dual-radio as the backbone(interface alternating), I have a few nodes > and want to force them cascaded, is there a way to set up 'static hop > route' somehow so the node

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: fix crash on mesh cleanup in bridge loop avoidance code

2010-10-25 Thread Marek Lindner
On Sunday 24 October 2010 22:03:22 Sven Eckelmann wrote: > Acked-by: Sven Eckelmann Applied in revision 1849. Regards, Marek

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: Remove useless braces

2010-10-25 Thread Marek Lindner
On Sunday 24 October 2010 00:42:22 Sven Eckelmann wrote: > 54466268785c9892d6e2af2ac2a54a684face022 added changes to vis.c which > trigger a checkpatch.pl warning about braces which are not necessary > anymore. Applied in revision 1850. Thanks, Marek

[B.A.T.M.A.N.] [PATCH] batman-adv: add seq_printf() wrapper for older kernels that don't support %pM

2010-10-25 Thread Marek Lindner
Signed-off-by: Marek Lindner --- batman-adv/bat_printk.c | 18 ++ batman-adv/compat.h |3 +++ 2 files changed, 21 insertions(+), 0 deletions(-) diff --git a/batman-adv/bat_printk.c b/batman-adv/bat_printk.c index 4fa3e18..69a7f95 100644 --- a/batman-adv/bat_printk.c

Re: [B.A.T.M.A.N.] [PATCH 1/2] batman-adv: Include compat.h only once

2010-10-25 Thread Marek Lindner
On Thursday 21 October 2010 13:26:50 Sven Eckelmann wrote: > The compat.h can also be included in main.h which is included by all > source files. In theory also all header files must include main.h. This > is currently not and hopefully will never be necessary. > > It is also important that all he

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: Re-Enabl e Interface alternating and bonding

2010-10-25 Thread Marek Lindner
On Monday 25 October 2010 17:36:30 Chris Lang wrote: > I don't have any issue with you rewording the commit message. I just > didn't think about making the commit message linux friendly. Ok, applied your patch in revision 1853. Thanks, Marek

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: add seq_printf() wrapper for older kernels that don't support %pM

2010-10-25 Thread Marek Lindner
On Tuesday 26 October 2010 00:14:59 Sven Eckelmann wrote: > Acked-by: Sven Eckelmann Applied in revision 1854. Regards, Marek

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: Convert kbuild version check to preprocessor check

2010-10-25 Thread Marek Lindner
On Sunday 24 October 2010 01:15:46 Sven Eckelmann wrote: > Makefile.kbuild includes a relative unreadable check for a version > number to decide if we should compile bat_printk.c to get out own print > implementations. This can easily be replaced using a simpler > preprocessor check as we know them

Re: [B.A.T.M.A.N.] batman-adv gateway handling

2010-10-31 Thread Marek Lindner
On Saturday 30 October 2010 14:14:02 Sven Eckelmann wrote: > > - struct gw_node *gw_node; > > - struct hlist_node *node, *node_tmp; > > + &bat_priv->gw_list, list) { > > + if (((!gw_node->deleted) || > > +(time_after(jiff

Re: [B.A.T.M.A.N.] batman-adv gateway handling

2010-11-01 Thread Marek Lindner
On Sunday 31 October 2010 16:55:40 Sven Eckelmann wrote: > Isn't it limited to 1 by BAT_ATTR_UINT? And if not (which I doubt) wouldn't > be the user still be able to set it to 0 after he changed it to client > mode? You got a point here. I'll come up with another solution. Cheers, Marek

Re: [B.A.T.M.A.N.] [PATCH 3/6] batctl: Remove unused variables

2010-11-01 Thread Marek Lindner
On Saturday 30 October 2010 17:00:55 Sven Eckelmann wrote: > -static void dump_arp(unsigned char *packet_buff, ssize_t buff_len, int > time_printed) +static void dump_arp(unsigned char *packet_buff, ssize_t > buff_len) { > struct ether_arp *arphdr; > > LEN_CHECK((size_t)buff_len,

Re: [B.A.T.M.A.N.] [PATCH] staging: batman-adv : Use linux/etherdevice.h address helper functions

2010-11-03 Thread Marek Lindner
On Wednesday 03 November 2010 11:25:12 Tobias Klauser wrote: > I was refering to the following part of the patch: > > - if (is_bcast(ethhdr->h_dest) || is_mcast(ethhdr->h_dest)) { > + if (is_multicast_ether_addr(ethhdr->h_dest)) { > > I think this change should be legitimate as the sa

[B.A.T.M.A.N.] [PATCH] batman-adv: suppress false warning when changing the mac address

2010-11-03 Thread Marek Lindner
sure they belong to different interfaces, thus always printing a warning. Signed-off-by: Marek Lindner --- batman-adv/hard-interface.c | 15 ++- 1 files changed, 10 insertions(+), 5 deletions(-) diff --git a/batman-adv/hard-interface.c b/batman-adv/hard-interface.c index 37f0f8b

Re: [B.A.T.M.A.N.] [PATCHv2] batman-adv: Don't call sysfs_del_hardif() in atomic context

2010-11-04 Thread Marek Lindner
On Sunday 31 October 2010 22:07:37 Linus Lüssing wrote: > sysfs_del_hardif invokes kobject_put, which might sleep. However, we > are not allowed to sleep during a call_rcu. There is also no need to > do the removal with an atomic call_rcu, as kobject_put only frees the > kobject when there is no mo

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: suppress false warning when changing the mac address

2010-11-04 Thread Marek Lindner
On Wednesday 03 November 2010 15:41:35 Marek Lindner wrote: > Whenever the mac address of an batman interface is changed > check_known_mac_addr() is called to print a warning if the newly added > mac address exists an another batman interface. While looping through > the batman in

Re: [B.A.T.M.A.N.] [PATCH 1/6] batctl: Correct format strings for 8 bit ttl

2010-11-04 Thread Marek Lindner
On Saturday 30 October 2010 17:00:53 Sven Eckelmann wrote: > Signed-off-by: Sven Eckelmann > --- > batctl/tcpdump.c|4 ++-- > batctl/traceroute.c |4 ++-- > 2 files changed, 4 insertions(+), 4 deletions(-) All patches have been applied (revision 1858-1863). I slightly modified patch

[B.A.T.M.A.N.] batman-adv gateway handling [v2]

2010-11-04 Thread Marek Lindner
Hi, here comes the second revision of the gateway style patches. Only a few things changed: * rebased on top of current head * time_after / time_before bug was squashed * gw_sel_class & gw_bandwidth default values were moved into softif_create() * indentation was improved Unless someone obj

[B.A.T.M.A.N.] [PATCH 1/8] batman-adv: remove redundant gw_node_list_free() function

2010-11-04 Thread Marek Lindner
Signed-off-by: Marek Lindner --- batman-adv/gateway_client.c | 30 +- batman-adv/gateway_client.h |3 +-- batman-adv/main.c |2 +- batman-adv/originator.c |2 +- 4 files changed, 12 insertions(+), 25 deletions(-) diff --git a/batman-adv

[B.A.T.M.A.N.] [PATCH 2/8] batman-adv: gateways silently drop DHCP requests

2010-11-04 Thread Marek Lindner
Signed-off-by: Marek Lindner --- batman-adv/gateway_client.c | 31 +-- batman-adv/gateway_client.h |2 +- batman-adv/soft-interface.c | 16 ++-- 3 files changed, 28 insertions(+), 21 deletions(-) diff --git a/batman-adv/gateway_client.c b/batman

[B.A.T.M.A.N.] [PATCH 3/8] batman-adv: move gateway selection class into its own sysfs file

2010-11-04 Thread Marek Lindner
The Linux kernel guidelines require each sysfs file to have a single value / purpose, therefore it is necessary to split up the sysfs gateway files. Signed-off-by: Marek Lindner --- batman-adv/bat_sysfs.c | 10 ++ batman-adv/gateway_client.c |6 +++--- batman-adv

[B.A.T.M.A.N.] [PATCH 4/8] batman-adv: move gateway bandwidth into its own sysfs file

2010-11-04 Thread Marek Lindner
The Linux kernel guidelines require each sysfs file to have a single value / purpose, therefore it is necessary to split up the sysfs gateway files. Signed-off-by: Marek Lindner --- batman-adv/bat_sysfs.c | 37 -- batman-adv/gateway_client.c |6 +- batman-adv

[B.A.T.M.A.N.] [PATCH 5/8] batman-adv: cleanup gw mode sysfs file to only accept one value

2010-11-04 Thread Marek Lindner
The Linux kernel guidelines require each sysfs file to have a single value / purpose, therefore it is necessary to split up the sysfs gateway files. Signed-off-by: Marek Lindner --- batman-adv/bat_sysfs.c | 70 ++ batman-adv/gateway_common.c | 213

[B.A.T.M.A.N.] [PATCH 7/8] batman-adv: document gateway sysfs ABI

2010-11-04 Thread Marek Lindner
Signed-off-by: Marek Lindner --- batman-adv/sysfs-class-net-mesh | 21 + 1 files changed, 21 insertions(+), 0 deletions(-) diff --git a/batman-adv/sysfs-class-net-mesh b/batman-adv/sysfs-class-net-mesh index bd20e14..748fe17 100644 --- a/batman-adv/sysfs-class-net-mesh

[B.A.T.M.A.N.] [PATCH 6/8] batctl: support new gateway sysfs API

2010-11-04 Thread Marek Lindner
Signed-off-by: Marek Lindner --- batctl/main.c |3 +- batctl/man/batctl.8 |4 +- batctl/sys.c| 117 ++- batctl/sys.h|9 4 files changed, 128 insertions(+), 5 deletions(-) diff --git a/batctl/main.c b/batctl

[B.A.T.M.A.N.] [PATCH 8/8] batman-adv: add gateway IPv6 support by filtering DHCPv6 messages

2010-11-04 Thread Marek Lindner
Some additional checks will be needed in case of extension headers like the fragmentation or hop-by-hop (for jumbo frames for example) headers or ipsec stuff. But this patch should do for most people for now, the rest can be added with a later one. Signed-off-by: Marek Lindner Acked-by: Linus

Re: [B.A.T.M.A.N.] batman-adv gateway handling [v2]

2010-11-07 Thread Marek Lindner
On Thursday 04 November 2010 18:20:43 Marek Lindner wrote: > Unless someone objects I'll merge the patches this weekend. Applied in revision 1864 - 1871. Regards, Marek

Re: [B.A.T.M.A.N.] patch "staging: batman-adv: Use linux/etherdevice.h address helper functions" added to staging tree

2010-11-10 Thread Marek Lindner
Greg, > The patch is only compile-tested. [..] > diff --git a/drivers/staging/batman-adv/main.c > b/drivers/staging/batman-adv/main.c index 0587940..6ea6420 100644 > --- a/drivers/staging/batman-adv/main.c > +++ b/drivers/staging/batman-adv/main.c > @@ -149,7 +149,7 @@ void dec_module_count(voi

Re: [B.A.T.M.A.N.] [PATCHv2] batman-adv: Allow promiscuous reception of unicast packets

2010-11-10 Thread Marek Lindner
On Wednesday 10 November 2010 01:48:13 Linus Lüssing wrote: > Firstly, a very mobile node moving towards the sender along the hop path > benefits from this as for such a mobility pattern the reception probability > increases, no matter how slow the topology convergence speed is. Would you mind exp

Re: [B.A.T.M.A.N.] patch "staging: batman-adv: U se linux/etherdevice.h address helper functions" add ed to staging tree

2010-11-11 Thread Marek Lindner
On Thursday 11 November 2010 02:11:37 Greg KH wrote: > > None of that happened yet. And yes, this wasn't the last mail we sent to > > him to get some response - no answer till now. > > Oops, my fault, I've now reverted this patch, sorry about that. No problem, that can happen. Thanks, Marek

[B.A.T.M.A.N.] batman-adv gateway documentation

2010-11-12 Thread Marek Lindner
Hi folks, the batman-adv gateway support has left the experimental stage and will show up in one of the following releases (probably early 2011). To make this feature a really useful one I wrote a wiki article to explain how it works and how it is supposed to be used: http://www.open-mesh.org/

Re: [B.A.T.M.A.N.] [Battlemesh] Another peer-reviewed assessment of Babel, Batman and OLSR

2010-11-15 Thread Marek Lindner
Hi, > We are happy to answer any questions people might have with that paper. Quote from: http://bridgingthelayers.org/docs/murray_routing.pdf "Upon inspection of the BATMAN L2 and BATMAN L3 results, the only major performance difference between data link layer routing and network layer routing

Re: [B.A.T.M.A.N.] patch "staging: batman-adv: Use linux/etherdevice.h address helper functions" added to staging tree

2010-11-15 Thread Marek Lindner
Hi, > Hello, im a BATMAN user and also a member of the website. Im doing a > project using BATMAN for MANET.I actually plan to modify codes from > batman-0.3.2, to be able to modify the packet header and send the codes > between notebooks. Any kind soul able to point me in the direction to look >

[B.A.T.M.A.N.] performance patches

2010-11-16 Thread Marek Lindner
Hi, after running a series of tests I noticed that batman-adv introduces a 10-20% performance overhead (depending on various factors) compared standard routing. I could identify the orig_hash locking as the main bottleneck as code all over the module requires to hold the lock causing a serious

[B.A.T.M.A.N.] [PATCH 1/8] batman-adv: protect neighbor nodes with reference counters

2010-11-16 Thread Marek Lindner
Signed-off-by: Marek Lindner --- batman-adv/originator.c | 20 +++- batman-adv/originator.h |8 +--- batman-adv/routing.c|7 +++ batman-adv/types.h |1 + 4 files changed, 28 insertions(+), 8 deletions(-) diff --git a/batman-adv/originator.c b

[B.A.T.M.A.N.] [PATCH 2/8] batman-adv: convert neighbor list to hlist

2010-11-16 Thread Marek Lindner
Signed-off-by: Marek Lindner --- batman-adv/originator.c | 28 +++- batman-adv/routing.c| 29 ++--- batman-adv/types.h |4 ++-- 3 files changed, 35 insertions(+), 26 deletions(-) diff --git a/batman-adv/originator.c b/batman-adv

[B.A.T.M.A.N.] [PATCH 3/8] batman-adv: protect neighbor list with rcu locks

2010-11-16 Thread Marek Lindner
Signed-off-by: Marek Lindner --- batman-adv/originator.c | 31 ++- batman-adv/routing.c| 13 + batman-adv/types.h |2 ++ 3 files changed, 41 insertions(+), 5 deletions(-) diff --git a/batman-adv/originator.c b/batman-adv/originator.c

[B.A.T.M.A.N.] [PATCH 4/8] batman-adv: remove hash resize functions

2010-11-16 Thread Marek Lindner
Signed-off-by: Marek Lindner --- batman-adv/hash.h | 38 -- batman-adv/originator.c| 14 +- batman-adv/translation-table.c | 32 ++-- 3 files changed, 3 insertions(+), 81 deletions(-) diff

[B.A.T.M.A.N.] [PATCH 5/8] batman-adv: protect each hash row with rcu locks

2010-11-16 Thread Marek Lindner
Signed-off-by: Marek Lindner --- batman-adv/hash.c | 46 +++ batman-adv/hash.h | 125 ++-- batman-adv/icmp_socket.c |2 + batman-adv/originator.c|2 + batman-adv/routing.c | 12

[B.A.T.M.A.N.] [PATCH 6/8] batman-adv: protect originator nodes with reference counters

2010-11-16 Thread Marek Lindner
Signed-off-by: Marek Lindner --- batman-adv/originator.c | 34 +++--- batman-adv/originator.h |1 + batman-adv/routing.c| 39 ++- batman-adv/types.h |2 ++ 4 files changed, 56 insertions(+), 20 deletions

[B.A.T.M.A.N.] [PATCH 7/8] batman-adv: replace orig_hash hash_iterate() with individual functions

2010-11-16 Thread Marek Lindner
Signed-off-by: Marek Lindner --- batman-adv/originator.c | 212 +-- batman-adv/routing.c| 32 ++-- batman-adv/vis.c| 157 ++ 3 files changed, 275 insertions(+), 126 deletions(-) diff --git a/batman

[B.A.T.M.A.N.] [PATCH 8/8] batman-adv: remove orig_hash spinlock

2010-11-16 Thread Marek Lindner
Signed-off-by: Marek Lindner --- batman-adv/icmp_socket.c | 35 +++--- batman-adv/main.c|1 - batman-adv/originator.c | 21 --- batman-adv/routing.c | 312 -- batman-adv/types.h |1 - batman-adv/unicast.c | 96

Re: [B.A.T.M.A.N.] [PATCH 1/2] batman-adv: Use kernel version min macro

2010-11-17 Thread Marek Lindner
On Tuesday 09 November 2010 00:53:00 Sven Eckelmann wrote: > The kernel headers already provide different versions of a min/max macro > which should be used by all modules according to > Documentation/CodingStyle. Applied in revision 1872. Thanks, Marek

Re: [B.A.T.M.A.N.] [PATCHv2 2/2] batman-adv: Use kernel functions to identify broadcasts

2010-11-17 Thread Marek Lindner
On Tuesday 09 November 2010 10:27:28 Sven Eckelmann wrote: > linux/etherdevice.h already provides functions to classify different > ethernet addresses. These inlineable functions should be used instead of > custom functions. Applied in revision 1873. Thanks, Marek

Re: [B.A.T.M.A.N.] patch "staging: batman-adv: U se linux/etherdevice.h address helper functions" add ed to staging tree

2010-11-17 Thread Marek Lindner
Tobias, > I'll send an updated patch, leaving out the compare_ether_addr part. not necessary anymore. Today I included a patch from Sven that does the job. Thanks for bringing this up, Marek

Re: [B.A.T.M.A.N.] [PATCH 1/8] batman-adv: protect neighbor nodes with reference counters

2010-11-20 Thread Marek Lindner
On Saturday 20 November 2010 19:27:01 Linus Lüssing wrote: > I guess you meant "kref_put(&neigh_node_tmp,... instead of > neigh_node (without tmp) here, as neigh_node_tmp won't be used anymore, not > neigh_node, right? Otherwise it also does not seem to make sense to first > increase the refcount a

[B.A.T.M.A.N.] batman-adv crash on Intel 3945ABG & 4965 AGN

2010-11-21 Thread Marek Lindner
d you please let us know the driver version that was used in your test setup ? A 'modinfo iwlagn | grep version' should do. We will then get in touch with the Intel wifi maintainers. Regards, Marek From a2496fe3ade7f6295b47f1271279de319831a8a7 Mon Sep 17 00:00:00 2001 From: Marek Lindner

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: Ensure that eth_type_trans gets linear memory

2010-11-21 Thread Marek Lindner
On Sunday 21 November 2010 15:33:01 Sven Eckelmann wrote: > eth_type_trans tries to pull data with the length of the ethernet header > from the skb. We only ensured that enough data for the first ethernet > header and the batman header is available in non-paged memory of the skb > and not for the e

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: Don't remove interface with spinlock held

2010-11-21 Thread Marek Lindner
On Sunday 21 November 2010 20:54:28 Sven Eckelmann wrote: > We call a lot of the netdevice code when holding if_list_lock which will > spin the whole time. This is not necessary because we only want to > protect the access to the list to be serialized. An extra queue can be > used which hold all in

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: Rename if_list_queue to if_queue

2010-11-21 Thread Marek Lindner
On Sunday 21 November 2010 23:37:16 Sven Eckelmann wrote: > The name "if_list_queue" would create lines longer than 80 chars which > can be avoided by shortened version "if_queue". Applied in revision 1880. Thanks, Marek

[B.A.T.M.A.N.] batman-adv 2010.2.0 released

2010-11-21 Thread Marek Lindner
e sending in patches: * Andreas Langer * Andy Shevchenko * Chris Lang * Linus Lüssing * Marek Lindner * Simon Wunderlich * Sven Eckelmann * Tracey Dent * Vasiliy Kulikov and to all those that supported us with good advice or rigorous testing: * Dan Carpenter * David S. Miller

Re: [B.A.T.M.A.N.] batman-adv for 2.6.38 (1)

2010-11-21 Thread Marek Lindner
Hi, > here are the feature patches which are targeted for 2.6.38. > > Important features include: > * Fragmentation of forward packets > * reassemble of fragmented packets during transfer > * softif bridge loop avoidance > * gateway support for dhcp(v6) filtering > * hash related optimizati

Re: [B.A.T.M.A.N.] [PATCH 1/2] batctl: Fix bisecting of OGMs with 32bit seqno

2010-11-22 Thread Marek Lindner
On Monday 22 November 2010 22:45:53 Linus Lüssing wrote: > -static int seqno_event_new(char *iface_addr, char *orig, char > *prev_sender, char *neigh, int seqno, int tq, int ttl) +static int > seqno_event_new(char *iface_addr, char *orig, char *prev_sender, char > *neigh, int64_t seqno, int tq, int

Re: [B.A.T.M.A.N.] [PATCH 2/2] batctl: Fix (skipped) substitutions of mac addresses

2010-11-22 Thread Marek Lindner
On Monday 22 November 2010 22:45:54 Linus Lüssing wrote: > This patch fixes two parts: For one thing "batctl l" won't remove commas > anymore if it cannot find the mac address in the bat-hosts file. > For another, it now allows the correct substitution of mac addresses > which have the suffix ')'.

Re: [B.A.T.M.A.N.] batctl bisect fixes, 2nd version

2010-11-28 Thread Marek Lindner
On Tuesday 23 November 2010 13:13:17 Linus Lüssing wrote: > Ok, this is the second version, let me know what you think it about it. Applied in revision 1881-1883. Thanks, Marek

[B.A.T.M.A.N.] performance patches (v2)

2010-11-29 Thread Marek Lindner
Hi, I continued improving the the performance patches which results in the first usable version. I tested it in a VM environment as well as on real hardware and did not encounter problematic behavior anymore. Changes since v1: * code rebased on top of the trunk * orig_node NULL pointer derefe

[B.A.T.M.A.N.] [PATCH 1/9] batman-adv: protect neighbor nodes with reference counters

2010-11-29 Thread Marek Lindner
Signed-off-by: Marek Lindner --- batman-adv/originator.c | 20 +++- batman-adv/originator.h |8 +--- batman-adv/routing.c|7 +++ batman-adv/types.h |1 + 4 files changed, 28 insertions(+), 8 deletions(-) diff --git a/batman-adv/originator.c b

<    4   5   6   7   8   9   10   11   12   13   >