Re: [B.A.T.M.A.N.] Line of Nodes

2014-03-12 Thread Simon Wunderlich
Hey Robert, > Hi, > > I have a little bit strange usecase for a wireless mesh network, and I'm > wondering if B.A.T.M.A.N could be a good choice: my network stations, > which are part of an industrial application, are located in a line: > > Gateway - A1 - A2 - A3 - A4 - A5 - ... - A120 > > An

Re: [B.A.T.M.A.N.] Line of Nodes

2014-03-12 Thread Simon Wunderlich
Hey Robert, > > > - Could the short distance be a problem? > > > > well you have interference between the nodes and the typical > > throughput limitations because of the half-duplex nature of WiFi. But > > if you take that into consideration and don't expect the same > > throughput as on a single

[B.A.T.M.A.N.] [PATCH-next v3 1/2] batctl: check for batman interface

2014-03-12 Thread Simon Wunderlich
From: Simon Wunderlich Check if the interface supplied by -m (or bat0 by default) is actually a batman interface. The check is performed by testing if the sysfs path is available. This change is required since debugfs now contains originator tables per hard interface. This might be confusing

[B.A.T.M.A.N.] [PATCH-next v3 2/2] batctl: add option for multiif orig table

2014-03-12 Thread Simon Wunderlich
From: Simon Wunderlich This patch adds batctl support for the recently introduced mesh wide multi interface optimization in batman-adv. Signed-off-by: Simon Wunderlich --- Changes to PATCHv1: * check if the supplied interface actually belongs to the interface * add README and manpage

Re: [B.A.T.M.A.N.] Anyone at CLT2014?

2014-03-12 Thread Simon Wunderlich
I'll be there. :) I'll make sure to wear something batman style. ;) BTW, you should check out the battlemesh too: http://battlemesh.org/BattleMeshV7 This years edition is in Germany, a whole week of mesh and wireless networking. :) Cheers, Simon > Hi, > > Is there a chance to meet some o

[B.A.T.M.A.N.] [PATCH-maint 0/3] fix multiif regressions

2014-03-19 Thread Simon Wunderlich
From: Simon Wunderlich There are some regressions introduced my network wide multi interface optimization patchset which are adressed by this patchset. All of them fix some kind of leaks caused reference counter imbalances, which may lead to problems when an interface is removed which was

[B.A.T.M.A.N.] [PATCH-maint 1/3] batman-adv: fix neigh_ifinfo imbalance

2014-03-19 Thread Simon Wunderlich
From: Simon Wunderlich The neigh_ifinfo object must be freed if it has been used in batadv_iv_ogm_process_per_outif(). This is a regression introduced by 9bb33b8d88e318c4879d37d06ad28e3e018b9036 ("batman-adv: split tq information in neigh_node struct") Reported-by: Antonio Quartul

[B.A.T.M.A.N.] [PATCH-maint 2/3] batman-adv: fix neigh reference imbalance

2014-03-19 Thread Simon Wunderlich
From: Simon Wunderlich When an interface is removed from batman-adv, the orig_ifinfo of a orig_node may be removed without releasing the router first. This will prevent the reference for the neighbor pointed at by the orig_ifinfo->router to be released, and this leak may result in refere

[B.A.T.M.A.N.] [PATCH-maint 3/3] batman-adv: always run purge_orig_neighbors

2014-03-19 Thread Simon Wunderlich
From: Simon Wunderlich The current code will not execute batadv_purge_orig_neighbors() when an orig_ifinfo has already been purged. However we need to run it in any case. Fix that. This is a regression introduced by de6bcc76ea84fecb136f8c8f5ba1862e4a13f06b ("batman-adv: split out router

[B.A.T.M.A.N.] [PATCH-maintv2 3/3] batman-adv: always run purge_orig_neighbors

2014-03-19 Thread Simon Wunderlich
From: Simon Wunderlich The current code will not execute batadv_purge_orig_neighbors() when an orig_ifinfo has already been purged. However we need to run it in any case. Fix that. This is a regression introduced by de6bcc76ea84fecb136f8c8f5ba1862e4a13f06b ("batman-adv: split out router

[B.A.T.M.A.N.] [PATCH-maintv3 0/4] fix multiif regressions

2014-03-26 Thread Simon Wunderlich
. The second series was only sent partially to the mailing list, and in this third revision another bugfix was added and a sparse warning was fixed. Thanks Antonio for your help tracking that down! Cheers, Simon Simon Wunderlich (4): batman-adv: fix neigh_ifinfo imbalance batman-adv

[B.A.T.M.A.N.] [PATCH-maintv3 1/4] batman-adv: fix neigh_ifinfo imbalance

2014-03-26 Thread Simon Wunderlich
From: Simon Wunderlich The neigh_ifinfo object must be freed if it has been used in batadv_iv_ogm_process_per_outif(). This is a regression introduced by 9bb33b8d88e318c4879d37d06ad28e3e018b9036 ("batman-adv: split tq information in neigh_node struct") Reported-by: Antonio Quartul

[B.A.T.M.A.N.] [PATCH-maintv3 2/4] batman-adv: fix neigh reference imbalance

2014-03-26 Thread Simon Wunderlich
From: Simon Wunderlich When an interface is removed from batman-adv, the orig_ifinfo of a orig_node may be removed without releasing the router first. This will prevent the reference for the neighbor pointed at by the orig_ifinfo->router to be released, and this leak may result in refere

[B.A.T.M.A.N.] [PATCH-maintv3 3/4] batman-adv: always run purge_orig_neighbors

2014-03-26 Thread Simon Wunderlich
From: Simon Wunderlich The current code will not execute batadv_purge_orig_neighbors() when an orig_ifinfo has already been purged. However we need to run it in any case. Fix that. This is a regression introduced by de6bcc76ea84fecb136f8c8f5ba1862e4a13f06b ("batman-adv: split out router

[B.A.T.M.A.N.] [PATCH-maintv3 4/4] batman-adv: fix removing neigh_ifinfo

2014-03-26 Thread Simon Wunderlich
From: Simon Wunderlich When an interface is removed separately, all neighbors need to be checked if they have a neigh_ifinfo structure for that particular interface. If that is the case, remove that ifinfo so any references to a hard interface can be freed. This is a regression introduced by

Re: [B.A.T.M.A.N.] Batman-adv high TQ and Low throughput

2014-04-24 Thread Simon Wunderlich
> Recently i have experienced something quite usual to my experience and > that was not happening previously in the same scenario where it is > happening now. > > Here is the example: > 2 nodes at with adhoc at 2.4ghz at a distance of 415 meters > one uses an omni 15 dbi antenna at 18dbi and anoth

Re: [B.A.T.M.A.N.] [PATCH 1/2] alfred: Handle EPERM on every sendto

2014-05-02 Thread Simon Wunderlich
> The announcements are currently only sent by alfred instances in master > mode. Slave instances don't announce themself and thus don't detect the > broken socket. To also catch such problems, it is useful to handle the > detection of EPERM during the send in send_alfred_packet which is always > c

Re: [B.A.T.M.A.N.] [PATCH 01/10] batadv-vis: Avoid memory leak after failed realloc

2014-05-27 Thread Simon Wunderlich
> realloc doesn't free the original buffer when the reallocation failed. An > abort of read_file without free'ing the buffer would leak it. > > Signed-off-by: Sven Eckelmann The whole series has been applied with two minor fixes: * fixed a typo: alfred-gpsd: Fix altitute verification check -> a

Re: [B.A.T.M.A.N.] [PATCH] alfred: Use memleak/error path free implementation of hash_resize

2014-05-27 Thread Simon Wunderlich
> The current implementation of hash_resize uses hash_add directly to > initialize two a new hash table. But hash_add has two error cases: Data > already exists and malloc fails. > > The check for the duplicated data is not really harmful (beside increasing > the time to re-add elements) but the m

Re: [B.A.T.M.A.N.] [PATCH] batadv-vis: Avoid file handler leak after failed realloc

2014-05-27 Thread Simon Wunderlich
> The read_file function opens the file and thus has to close the filehandler > after an realloc error. This was forgotten in the fix > 0ad384e11ed039d4c3025a7eaf19fe6bcfd41acf ("batadv-vis: Avoid memory leak > after failed realloc"). > Applied in revision 3b72283 Thanks, Simon

Re: [B.A.T.M.A.N.] [PATCHv2] alfred: Use memleak/error path free implementation of hash_resize

2014-05-27 Thread Simon Wunderlich
> v2 > * fixed comit message Sorry, I've already merged v1 and I don't think its worth to change history, the old one was good enough. :) Thanks anyway! Simon

Re: [B.A.T.M.A.N.] Update batman-adv

2014-06-10 Thread Simon Wunderlich
That doesn't need a guide ... Download the version you want from our download page. tar zxf batman-adv-.tar.gz cd batman-adv- make sudo make install done. :) Alternatively (and more cleanly, since you use the package system), update your kernel which contains the version you want. A list of wh

[B.A.T.M.A.N.] [PATCH] batman-adv: drop QinQ claim frames in bridge loop avoidance

2014-06-11 Thread Simon Wunderlich
From: Simon Wunderlich Since bridge loop avoidance only supports untagged or simple 802.1q tagged VLAN claim frames, claim frames with stacked VLAN headers (QinQ) should be detected and dropped. Transporting the over the mesh may cause problems on the receivers, or create bogus entries in the

[B.A.T.M.A.N.] [PATCHv2] batman-adv: drop QinQ claim frames in bridge loop avoidance

2014-06-13 Thread Simon Wunderlich
From: Simon Wunderlich Since bridge loop avoidance only supports untagged or simple 802.1q tagged VLAN claim frames, claim frames with stacked VLAN headers (QinQ) should be detected and dropped. Transporting the over the mesh may cause problems on the receivers, or create bogus entries in the

Re: [B.A.T.M.A.N.] question about batman-adv auto run configuration

2014-06-17 Thread Simon Wunderlich
> Hello, > If i andersdood all the configuration in my following architecture, if i > want to give IP address on each interfaces,i have to: - create a bridge on > the PC,Wifi card and LTE card > - creat a bat0 interface on each one, > - i don't need to start /etc/conf/batman-adv enable since, when

[B.A.T.M.A.N.] [PATCH] batman-adv: increase default hop penalty

2014-06-17 Thread Simon Wunderlich
From: Simon Wunderlich The default hop penalty is currently set to 15, which is applied like that for multi interface devices (e.g. dual band APs). Single band devices will still use an effective penalty of 30 (hop penalty + wifi penalty). After receiving reports of too long paths in mesh

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: increase default hop penalty

2014-06-18 Thread Simon Wunderlich
Hi Linus, > On Tue, Jun 17, 2014 at 12:16:03PM +0200, Simon Wunderlich wrote: > > This patch changes the hop penalty to 30, which will give an effective > > penalty of 60 on single band devices (hop penalty + wifi penalty). > > "batman-adv: encourage batman to take shor

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: increase default hop penalty

2014-06-19 Thread Simon Wunderlich
> On Wed, Jun 18, 2014 at 11:21:14AM +0200, Simon Wunderlich wrote: > > > Any data for others to check? > > > > Nope, unfortunately these are customer networks, and I can't reveal data > > from that in public. > > That's very, very unfortunate.

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: Add multicast optimization support for bridged setups

2014-06-21 Thread Simon Wunderlich
> On Wed, Jun 18, 2014 at 12:53:20PM +0800, Marek Lindner wrote: > > Thanks for the clarifications but that does not address my question. To > > be more precise: In batadv_mcast_mla_update() your code is calling > > batadv_mcast_mla_softif_get() which queries the bridge interface (if > > bridged).

Re: [B.A.T.M.A.N.] [PATCHv2] batman-adv: drop QinQ claim frames in bridge loop avoidance

2014-06-21 Thread Simon Wunderlich
> On Friday 13 June 2014 11:15:50 Simon Wunderlich wrote: > > +/** > > + * batadv_is_encapsulated_claim - checks if a claim frame is > > encapsulated + * @bat_priv: the bat priv with all the soft interface > > information + * @skb: skb to be checked > > + * >

[B.A.T.M.A.N.] [PATCHv3] batman-adv: drop QinQ claim frames in bridge loop avoidance

2014-06-23 Thread Simon Wunderlich
From: Simon Wunderlich Since bridge loop avoidance only supports untagged or simple 802.1q tagged VLAN claim frames, claim frames with stacked VLAN headers (QinQ) should be detected and dropped. Transporting the over the mesh may cause problems on the receivers, or create bogus entries in the

Re: [B.A.T.M.A.N.] [PATCHv2 1/2] alfred-gpsd: Calculate size of global buffer and not of a single char

2014-06-26 Thread Simon Wunderlich
> The global buffer is 65536 bytes in size and not only 1 byte. This > statement evaluated to a negative value which was casted to an unsigned > value (aka... very large value). > > This is a regression was introduced in > 71dbc00fd879f1e592b07d8397f724fb3f69ac64 ("alfred: Use strncpy instead of >

Re: [B.A.T.M.A.N.] [PATCHv3] batman-adv: Add multicast optimization support for bridged setups

2014-07-11 Thread Simon Wunderlich
a new table for debugfs for a global >mcast flag overview will be added in a separate patch later >as discussed with Simon) I've tested the previous version (PATCH RFC v2), but since the changes are minimal you can add for this patch: Tested-by: Simon Wunderlich The test inclu

Re: [B.A.T.M.A.N.] [PATCH 02/13] batman-adv: kernel doc fixes for bridge_loop_avoidance.c

2014-07-14 Thread Simon Wunderlich
> > + * @own_backbone: set if the requested backbone is local > > too many white spaces ^^ Apart from that, the rest of the patch looks good. :) Feel free to add my Acked-by if you want ... Thanks! Simon

[B.A.T.M.A.N.] [PATCH] batman-adv: remove obsolete variable primary_iface from orig_node

2014-07-16 Thread Simon Wunderlich
This variable became obsolete when changing to the new bonding mechanism based on the multi interface optimization. Since its not used anywhere, remove it. Reported-by: Linus Lüssing Signed-off-by: Simon Wunderlich --- types.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/types.h b

[B.A.T.M.A.N.] [PATCH] net: set name_assign_type in alloc_netdev()

2014-07-21 Thread Simon Wunderlich
here from the wrong commit Signed-off-by: Tom Gundersen Reviewed-by: David Herrmann Signed-off-by: David S. Miller [sw: added compat code] Signed-off-by: Simon Wunderlich --- compat.h | 14 ++ soft-interface.c | 2 +- 2 files changed, 15 insertions(+), 1 deletion(-) diff

Re: [B.A.T.M.A.N.] alfred - one gateway - multiple interfaces

2014-07-24 Thread Simon Wunderlich
Hey Tobias, thank you very much for stating your requirement - even if that it's not implemented yet, maybe there are people out there who want that too and can help implenting it. It shouldn't be too hard ... > As I said, a workaround could be to just simply duplicate the init > script (adjust

Re: [B.A.T.M.A.N.] [PATCH] alfred: Make unix socket path configurable

2014-07-28 Thread Simon Wunderlich
> The path to the socket used for client-server communication is currently > hardcoded in alfred and its complimentary daemons. This makes it hard to > run two instances of alfred on the same machine without any kind of > virtualization or containers. > > An user may still want to use two alfred i

Re: [B.A.T.M.A.N.] [PATCH 1/2] alfred: Print libc errors with perror

2014-07-29 Thread Simon Wunderlich
Series applied in commits 6f1a3f3 and e9e98b1. Thanks! Simon

Re: [B.A.T.M.A.N.] Opportunity to contribute in B.A.T.M.A.N

2014-07-29 Thread Simon Wunderlich
Hello Dhruvesh, > Hello, > > We are a group of students that are currently pursuing our undergraduate > degrees in Computer Science form Pune Institute of Computer Technology > (PICT), Maharashtra, India. We will be graduating in June 2015 and are > currently in our final year. For our fina

Re: [B.A.T.M.A.N.] [PATCH] alfred: add more debug output for libc errors

2014-07-30 Thread Simon Wunderlich
> perror(..) can automatically decode the errno variable and print more > information for an error. > > Signed-off-by: Sven Eckelmann Applied in commit c9f5a5d. Thanks Simon signature.asc Description: This is a digitally signed message part.

Re: [B.A.T.M.A.N.] How to set up the communication in layer 3 in mesh node with batman.adv

2014-08-01 Thread Simon Wunderlich
> hello, eveyone.I am a b.a.t.m.a.n. beginner.I work on openwrt with > batman-adv 2012.3.0. > > There are three mesh nodes. Node A is far from node C. A can't communicate > with C directly, but it can commuticate with C via node B, which is > between A and C. The path is A <--> B <--> C. > > O

[B.A.T.M.A.N.] [PATCH] batctl: fix backbone address in tcpdump for bla request frames

2014-08-06 Thread Simon Wunderlich
From: Simon Wunderlich hw_src just contains another copy of the destination. The backbone sending the request is setting its mac address into Ethernet source, so print that instead. For reference, see the documentation: http://www.open-mesh.org/projects/batman-adv/wiki/Bridge-loop-avoidance

Re: [B.A.T.M.A.N.] how to make IP layer handle the change of network topology

2014-08-07 Thread Simon Wunderlich
another one? > > Thanks! Best regards. > > liu --- Mit freundlichen Grüßen / kind regards Simon Wunderlich Fon: +49 (0) 3741 / 2518068-0 Fax: +49 (0) 3741 / 2518068-9

Re: [B.A.T.M.A.N.] how to make IP layer handle the change of network topology

2014-08-07 Thread Simon Wunderlich
Bah, i hit the wrong button before finishing the mail :) > Hi liu, > > > Hello, eveyone, I am learning the batman.adv recently. > > > > We know that batman.adv works on layer 2. When the network topology > > change, batman.adv can know this change and handle it. But the IP layer > > doesn't know

Re: [B.A.T.M.A.N.] alfred: IPC issues

2014-08-07 Thread Simon Wunderlich
Hello Jan, > Hei folks, > > I'm using alfred 2014.0.0 on OpenWRT Barrier Breaker. > > Alfred is running: > root@6466b34ffcac:~# ps -w | grep alfred > 1718 root 1100 S/usr/sbin/alfred -i br-freifunk -b bat0 > > But cannot be queried using the client: > root@6466b34ffcac:~# alfred -r 94

Re: [B.A.T.M.A.N.] Running alfred as non-root user?

2014-08-07 Thread Simon Wunderlich
> Hello, > > everytime I try to start alfred 2014.3.0 using a dedicated non-root user > it fails with: can't bind unix socket: Address already in use > > Running as root is successful. Is it possible to start alfred as non-root? You are most probably having another alfred instance already runnin

Re: [B.A.T.M.A.N.] [PATCHv6 2/3] batman-adv: Adding 'mcast' log level

2014-08-07 Thread Simon Wunderlich
Sorry, it seems the quotation is a little messed up, but I hope you can understand the rest: > This patch adds an 'mcast' log level. Currently, it will print changes > relevant to a nodes own multicast flag changes. > > Signed-off-by: Linus Lüssing > --- > multicast.c | 152 > +++

Re: [B.A.T.M.A.N.] [PATCHv6 3/3] batman-adv: Add debugfs table for mcast flags

2014-08-07 Thread Simon Wunderlich
> --- a/multicast.c > +++ b/multicast.c > @@ -995,6 +995,116 @@ void batadv_mcast_init(struct batadv_priv *bat_priv) > } > > /** > + * batadv_mcast_flags_print_header - print own mcast flags to debugfs > table + * @bat_priv: the bat priv with all the soft interface information > + * @seq: debugf

Re: [B.A.T.M.A.N.] how to make IP layer handle the change of network topology

2014-08-08 Thread Simon Wunderlich
Hello Liu, > Thanks for reply. I have tried to fix this problem followed by Simon's > guide. Unfortunately It stil doesn't work.I draw a pciture named > 'topo.jpg' in the attachment to describe my situation. > > Gateway B and C are wired to router 192.168.1.1 through their 'WAN' > interface. Th

Re: [B.A.T.M.A.N.] Enhancements for Unsolicited Neigh. Adv. / grat ARP Reply

2014-08-08 Thread Simon Wunderlich
Hello Linus, thank you very much for the patch proposal. > Hi there, > > Here's a little, rough patch to illustrate the idea we discussed a little > at the last Wireless Battle Mesh, that is forwarding the noisy IPv6 > Unsolicited Neighbor Advertisements and gratuitous ARP Replies via unicast. >

Re: [B.A.T.M.A.N.] Testing example of interface bonding

2014-08-11 Thread Simon Wunderlich
Hello Ray, thanks a lot for your mail. On Sunday 10 August 2014 15:00:51 Ray Gibson wrote: > Hello, > > Are there any documented cases (aside from the aging graph on the > wiki) on batman-adv bonding setups? Not as far as I know. The bonding feature does not seem to be the most popular one. :)

Re: [B.A.T.M.A.N.] [PATCHv7 0/3] Multicast optimizations for bridges

2014-08-11 Thread Simon Wunderlich
On Friday 08 August 2014 04:46:26 Linus Lüssing wrote: > This patchset enables the usage of the batman-adv multicast optimizations > for scenarios involving bridges on top of e.g. bat0, too. > > Along come two more patches adding according debugging facilities > to make it possible for the user to

[B.A.T.M.A.N.] [RFC] batman-adv: experimental sysfs variable to always apply half duplex penalty

2014-08-13 Thread Simon Wunderlich
sure if its a good idea to add that option, and it should probably go into debugfs anyway, but adding it in sysfs for now was the easiest option. :) In any way, I'd like to hear about your opinion and/or test results! Thanks, Simon Reported-by: Ray Gibson Signed-off-by: Simon

[B.A.T.M.A.N.] [PATCH] batman-adv: fix and simplify condition when bonding should be used

2014-08-13 Thread Simon Wunderlich
The current condition actually does NOT consider bonding when the interface the packet came in from is the soft interface, which is the opposite of what it should do (and the comment describes). Fix that and slightly simplify the condition. Reported-by: Ray Gibson Signed-off-by: Simon Wunderlich

Re: [B.A.T.M.A.N.] Testing example of interface bonding

2014-08-13 Thread Simon Wunderlich
Ray, On Tuesday 12 August 2014 11:21:18 Ray Gibson wrote: > > I've put all the output in a pastebin as to not clog up everyone's inbox: > > http://pastebin.com/6fqUUUYq > Thanks! The output actually looks fine. I've tried a little bit myself in a few VMs and noticed two problems which were p

Re: [B.A.T.M.A.N.] [PATCHv8 0/3] Multicast optimizations for bridges

2014-08-17 Thread Simon Wunderlich
quot;-" to "U/4/6" and "." > * fixing "no querier present" logic (introduced in [PATCHv7 3/3]) > Looks good now! I gave it another round in my emulator setup, and couldn't find anything to complain about. ;) Tested/Reviewed-by: Simon Wunderlich for this series. Thanks! Simon signature.asc Description: This is a digitally signed message part.

Re: [B.A.T.M.A.N.] [PATCHv2 2/2] batctl: adding mcast flags debugfs table

2014-08-17 Thread Simon Wunderlich
On Wednesday 30 July 2014 01:14:58 Linus Lüssing wrote: [...] > diff --git a/README b/README > index c5e3575..08c8e98 100644 > --- a/README > +++ b/README > @@ -425,6 +425,40 @@ display or modify the multicast mode setting > > Usage: batctl multicast_mode|mm [0|1] > > +batctl mcast_flags > +

[B.A.T.M.A.N.] [PATCH] batman-adv: add detection for complex bridge loops

2014-08-19 Thread Simon Wunderlich
From: Simon Wunderlich There are network setups where the current bridge loop avoidance can't detect bridge loops. The minimal setup affected would consist of two LANs and two separate meshes, connected in a ring like that: A...(mesh1)...B | | (LAN1)

[B.A.T.M.A.N.] [PATCH] alfred: support for changing interfaces

2014-08-25 Thread Simon Wunderlich
From: Simon Wunderlich This patch adds support for changing the interface alfreds listens to on the fly without restarting alfred. Signed-off-by: Simon Wunderlich --- alfred.h | 2 ++ client.c | 54 + main.c | 66

[B.A.T.M.A.N.] [PATCHv2] alfred: support for changing interfaces

2014-09-03 Thread Simon Wunderlich
From: Simon Wunderlich This patch adds support for changing the interface alfreds listens to on the fly without restarting alfred. Signed-off-by: Simon Wunderlich --- Changes to PATCH: * fix const warning --- alfred.h | 4 +++- client.c | 54

Re: [B.A.T.M.A.N.] [PATCHv2] alfred: support for changing interfaces

2014-09-03 Thread Simon Wunderlich
On Wednesday 03 September 2014 13:41:30 Simon Wunderlich wrote: > From: Simon Wunderlich > > This patch adds support for changing the interface alfreds listens to on > the fly without restarting alfred. > > Signed-off-by: Simon Wunderlich Merged in revision babd772.

Re: [B.A.T.M.A.N.] new alfred packet type *3* for solar tracer charging units

2014-10-06 Thread Simon Wunderlich
On Monday 06 October 2014 13:28:11 Ufo wrote: > Am 27.08.14 15:14, schrieb Ufo: > > best way for distributing the detailed data (about local sun impact..) > > was alfred. we used nr. 160 but now simon choosed nr. 3 for that. > > all the different values from solar units are now defined on our test

Re: [B.A.T.M.A.N.] alfred packet types for gluon node statistics?

2014-10-06 Thread Simon Wunderlich
On Monday 06 October 2014 16:40:23 Ufo wrote: > ah nice. but its a question to the batman-adv developers instead of the > gluon people.. > freifunk-gluon is used by many freifunk communities, so maybe it would > be better to "register" these datatypes? > > see http://git.open-mesh.org/alfred.git/b

Re: [B.A.T.M.A.N.] Inquiry on interface alternating

2014-10-10 Thread Simon Wunderlich
Hello Ming Ann, we had quite some changes for the interface alternation which were released with batman-adv 2014.1.0 / kernel 3.14. Could you please try your scenario with the latest batman-adv to make sure that we are not talking about old implementations? Here is a link which describes more

Re: [B.A.T.M.A.N.] new alfred packet type *3* for solar tracer charging units

2014-10-10 Thread Simon Wunderlich
On Monday 06 October 2014 23:04:28 Daniel Golle wrote: > On Mon, Oct 06, 2014 at 04:39:15PM +0200, Simon Wunderlich wrote: > > > so the next step should be to include these into alfred? > > > > We basically have two options here: > > * integrat the tracetools into

Re: [B.A.T.M.A.N.] batman-adv bonding feature - unable to get data packets fragmented into multiple wireless interfaces

2014-10-10 Thread Simon Wunderlich
Hey Syed, which version of batman-adv are you using? Please note there is a fix for a bonding problem which hasn't been merged yet, please merge it manually for your tests (assuming you are using a recent version) https://lists.open-mesh.org/pipermail/b.a.t.m.a.n/2014-August/012382.html Also

Re: [B.A.T.M.A.N.] batman-adv bonding feature - unable to get data packets fragmented into multiple wireless interfaces

2014-10-13 Thread Simon Wunderlich
abling bonding sometimes I can see simultaneous outbound udp > traffic in both interfaces wlan0 and wlan1. > > I will try with the patch and update. > > Thanks. > > Sent from my Xiaomi > > On 11 Oct 2014 03:03, Simon Wunderlich wrote: > Hey Syed, > > which ver

Re: [B.A.T.M.A.N.] Local Clients Expiring from Translation Table

2014-10-21 Thread Simon Wunderlich
On Tuesday 21 October 2014 09:55:23 Jon Fink wrote: > I'm experiencing some issues where clients connected to a batman node > (through a wired interface) are expiring from the local translation > table after a period of inactivity. I'm guessing this is an > intentional feature to support roaming bu

Re: [B.A.T.M.A.N.] [PATCH 1/2] alfred: Add support for multiple interfaces per master

2014-11-13 Thread Simon Wunderlich
On Wednesday 12 November 2014 14:54:29 Sven Eckelmann wrote: > It may required in some situations that all alfred master servers are > potentially connected to the same backbone network but cannot see each other > through the mesh. The data may still be exchanged and thus a master > instance must l

Re: [B.A.T.M.A.N.] [PATCHv9 0/4] Multicast optimizations for bridges

2014-11-23 Thread Simon Wunderlich
On Sunday 07 September 2014 07:42:36 Linus Lüssing wrote: > This patchset enables the usage of the batman-adv multicast optimizations > for scenarios involving bridges on top of e.g. bat0, too. > > Along come two more patches adding according debugging facilities > to make it possible for the user

Re: [B.A.T.M.A.N.] [PATCHv9 4/4] batman-adv: Forward IGMP/MLD reports to selected querier (only)

2014-11-24 Thread Simon Wunderlich
Hi Linus, On Sunday 07 September 2014 07:42:40 Linus Lüssing wrote: > With this patch IGMP or MLD reports are only forwarded to the selected > IGMP/MLD querier as RFC4541 suggests. > > This is necessary to avoid multicast packet loss in bridged scenarios: > An IGMPv2/MLDv1 querier does not active

Re: [B.A.T.M.A.N.] Out-of-date batman-adv module in Linux Mint (Ubuntu)

2014-12-16 Thread Simon Wunderlich
Hi Melroy, On Monday 15 December 2014 16:12:10 Melroy van den Berg wrote: > Hi devs, > > I found out that the batman-adv kernel modules is quite out-dated in > Linux Mint (and probably also Ubuntu/Debian unstable). > > Using 'lsmod batman-adv' it says: version 2013.5.0. But the current > version

Re: [B.A.T.M.A.N.] [PATCH 04/31] batman-adv: iv_ogm, divide and round for ring buffer avg

2015-01-12 Thread Simon Wunderlich
On Tuesday 02 December 2014 12:16:22 Markus Pargmann wrote: > Instead of the normal division which looses precision, use a division > with rounding. > > Signed-off-by: Markus Pargmann Why do we need to have more precise rounding here? In doubt, we should rather always round down to avoid any sp

Re: [B.A.T.M.A.N.] [PATCH v2 04/26] batman-adv: iv_ogm, divide and round for ring buffer avg

2015-01-12 Thread Simon Wunderlich
On Friday 26 December 2014 12:41:21 Markus Pargmann wrote: > Instead of the normal division which looses precision, use a division > with rounding. > > Signed-off-by: Markus Pargmann (sorry for the duplicate, sent the reply for the first patch version, so I'm replying another time on v2 ...) W

Re: [B.A.T.M.A.N.] [PATCH] alfred: Tighten size check on received packet

2015-01-23 Thread Simon Wunderlich
On Monday 19 January 2015 21:59:32 Jan-Philipp Litza wrote: > When first checking if a received packet is truncated, the size of the > alfred_tlv structure is ignored, thus allowing packets that are > truncated by 4 bytes or less to pass the check unnoticed. > > Even the check itself might access

Re: [B.A.T.M.A.N.] running alfred as unprivileged user

2015-02-05 Thread Simon Wunderlich
Hi Martin, On Wednesday 04 February 2015 21:06:33 MK wrote: > Hi list! > > Alfred daemon runs as user root in our current setup on the gateway. > > Regarding the faulty buffer size checks and improper use of strcpy in recent > history of this software this seems to be a very bad idea. that's a

Re: [B.A.T.M.A.N.] batctl: feature to filter nodes/clients

2015-02-05 Thread Simon Wunderlich
Hi, On Sunday 01 February 2015 14:15:16 Moritz Warning wrote: > Hi, > > I need to display the number of all nodes/clients as well as all neighbor > nodes/clients. This would be easy if batctl would be able to output the > respective list of mac addresses (batctl ... | wc -l). > > I've started wr

Re: [B.A.T.M.A.N.] [PATCH] alfred: Close socket after connect failure

2015-02-05 Thread Simon Wunderlich
On Thursday 05 February 2015 15:47:13 Sven Eckelmann wrote: > The socket is still using one file descriptor of the process when the > connection fails. This fd leak is non-problematic in the current client > process code because the client would be closed in this situation anyway > and therefore th

Re: [B.A.T.M.A.N.] [PATCH 1/2] alfred: Update copyright years for 2015

2015-02-05 Thread Simon Wunderlich
On Thursday 05 February 2015 16:45:23 Sven Eckelmann wrote: > Signed-off-by: Sven Eckelmann Applied in revision dfb1ea4. Thanks! Simon signature.asc Description: This is a digitally signed message part.

Re: [B.A.T.M.A.N.] batctl: feature to filter nodes/clients

2015-02-05 Thread Simon Wunderlich
On Thursday 05 February 2015 19:11:15 Moritz Warning wrote: > >> > >> Some explanation beforehand: > >> Clients are computers not running batman-adv, > >> represented by the MAC address of its network interface. > >> Nodes are computers running batman-adv, > >> represented by the MAC address of it

Re: [B.A.T.M.A.N.] wireshark-batman-adv dissector for v15

2015-02-06 Thread Simon Wunderlich
On Friday 06 February 2015 09:55:58 Gui Iribarren wrote: > On 06/02/15 09:38, Sven Eckelmann wrote: > > I can only talk about the simple two node installation I had when I > > was forced > > > to write the wireshark-batman-adv dissector for v15. > > last week i lurked the internet for this, with

Re: [B.A.T.M.A.N.] [PATCH] alfred: Add explanation how to run alfred as non-root user

2015-02-28 Thread Simon Wunderlich
On Saturday 28 February 2015 08:50:42 MK wrote: > Sven Eckelmann wrote: > > unix socket +can also be moved to a different directly which is accessible > > typo: directly -> directory Hey, did you try the patch Sven posted earlier this week? Would be great to add your acked-by or tested-by tag i

Re: [B.A.T.M.A.N.] [PATCH] alfred: Drop capabilities when not needed

2015-02-28 Thread Simon Wunderlich
On Saturday 28 February 2015 21:04:19 MK wrote: > Hi! > > Thanks for the patch. Setup seems to be still working. How can I verify that > privileges really dropped? > > There are further questions: > > Is _read_ access for the alfred user (resp. group) sufficient in > /sys/kernel/debug/batman_adv

Re: [B.A.T.M.A.N.] [PATCH] alfred: Drop capabilities when not needed

2015-03-11 Thread Simon Wunderlich
On Monday 23 February 2015 20:18:50 Sven Eckelmann wrote: > The alfred process only requires the capability to bind to a raw socket > (CAP_NET_RAW). It is enough to mark this capability as permitted on program > startup and mark it again as effective whenever a new netsock is > initialized. All oth

Re: [B.A.T.M.A.N.] [PATCHv2] alfred: Add explanation how to run alfred as non-root user

2015-03-11 Thread Simon Wunderlich
On Thursday 05 March 2015 09:12:31 Sven Eckelmann wrote: > Reported-by: MK > Signed-off-by: Sven Eckelmann > --- > v2: > - fix typo 'directly' -> 'directory' > Applied in revision be4d727. Thanks! Simon signature.asc Description: This is a digitally signed message part.

Re: [B.A.T.M.A.N.] [PATCH 1/2] alfred: Update version when adding data to dataset

2015-03-11 Thread Simon Wunderlich
On Saturday 07 March 2015 23:41:17 Sven Eckelmann wrote: > The dataset stores the source and the alfred_tlv of the send data next to > the actual data buffer. The source and alfred_tlv::type was used to find an > entry in the dataset hashtable when reading/updating the buffer. The > alfred_tlv::len

Re: [B.A.T.M.A.N.] [PATCHv2 2/2] alfred: Add option to the client to print extra data information

2015-03-11 Thread Simon Wunderlich
On Saturday 07 March 2015 23:45:53 Sven Eckelmann wrote: > The version of a dataset can be queried using the parameter --verbose/-d. It > is printed as third component of each dataset line when starting the unix > client in request mode. > > Signed-off-by: Sven Eckelmann > --- > v2: added missing

Re: [B.A.T.M.A.N.] alfred: checkpatch cleanup

2015-03-16 Thread Simon Wunderlich
On Saturday 14 March 2015 12:42:45 Sven Eckelmann wrote: > Hi, > > just some patches which should address some of the checkpatch > errors/warnings. It doesn't address things in list.h, debugfs.(c|h) or > vis/gpsd. > > Kind regards, > Sven Thanks a lot Sven! Applied the whole series except

Re: [B.A.T.M.A.N.] [PATCH] alfred: Remove manual \0 terminator after snprintf

2015-03-19 Thread Simon Wunderlich
On Tuesday 17 March 2015 08:47:29 Sven Eckelmann wrote: > snprintf already guarantees \0 terminated strings for size arguments is > 0. > > Reported-by: Anatoliy Lapitskiy > Signed-off-by: Sven Eckelmann Applied in revision f7914a8. Thanks! Simon signature.asc Description: This is a digit

Re: [B.A.T.M.A.N.] [PATCH v5] alfred: Add "--update-command" parameter

2015-03-19 Thread Simon Wunderlich
On Tuesday 17 March 2015 10:11:15 Anatoliy Lapitskiy wrote: > The "--update-command" parameter is created for adding a hook to run when > new information is received. > > At the moment "alfred-facters" are run by cron once per every 5 minutes. > For some tasks (like sharing dhcp leases) it can be

[B.A.T.M.A.N.] Fwd: [Battlemesh] Announcing Battlemesh V8 Maribor, Slovenia

2015-03-24 Thread Simon Wunderlich
I'm sure there are some on this list who will be interested in joining! Please spread the word. :) -- Forwarded Message -- Subject: [Battlemesh] Announcing Battlemesh V8 Maribor, Slovenia Date: Monday 23 March 2015, 17:13:18 From: Musti To: Battle of the Mesh Mailing List ==

Re: [B.A.T.M.A.N.] batman-adv: increased default hop penalty

2015-03-31 Thread Simon Wunderlich
Hi, to cite from my original answer: We did have some discussion on that patch too: https://lists.open-mesh.org/pipermail/b.a.t.m.a.n/2014-June/012155.html I wrote that patch because we had problems in commercial installations and dual radio access points, which were fixed by this patch (as de

Re: [B.A.T.M.A.N.] [PATCH] alfred: Make sure only link-local EUI64 is used as source

2015-05-05 Thread Simon Wunderlich
On Wednesday 25 March 2015 19:51:07 Sven Eckelmann wrote: > The linux kernel automatically chooses the source address. This can make > problems when the metric prefers an address which is not the link-local > EUI64 address. For example an user can add an additional address which also > can be used

Re: [B.A.T.M.A.N.] [PATCH] alfred: Fix dependency to IPv6

2015-05-05 Thread Simon Wunderlich
On Friday 24 April 2015 16:19:21 Sven Eckelmann wrote: > alfred always requires IPv6 support in the kernel and not only when > "Enable IPv6 support in packages" is enabled. > > Signed-off-by: Sven Eckelmann Applied in openwrt-routing and development feed. Thanks! Simon signature.asc Descrip

Re: [B.A.T.M.A.N.] FW: using Batman-adv

2015-05-07 Thread Simon Wunderlich
Hi Joseph, On Thursday 07 May 2015 13:00:52 Joseph Zimmer wrote: > Hello, > > I am working with BATMAN-ADV and have successfully setup a mesh. In my > implementation of the mesh, the network requires BATMAN to operate in a > linear topology and ideally have node 1 hop to node 2 then through node

Re: [B.A.T.M.A.N.] Patch to add mesh_no_rebroadcast

2015-05-18 Thread Simon Wunderlich
Hi Ruben, thanks for re-sending the patch - as Sven pointed out we need to have it formatted properly before we can accept it. He mentioned various links which we have on the wiki, if you have troubles to apply we can also help you on IRC. @All: I've been talking to Ruben personally at Wireles

[B.A.T.M.A.N.] The Joker attacks

2015-05-19 Thread Simon Wunderlich
After laying low for quite some time, the Joker finally makes its appearance! "The Joker" - a penetration testing and research tool to test security aspects of batman-adv networks - was developed by security researchers Pedro Larbig and Alexander Oberle at TU Darmstadt (Germany), and we finally

Re: [B.A.T.M.A.N.] [PATCH 1/6] alfred: Reduce MAX_PAYLOAD by the size of the UDP header

2015-06-01 Thread Simon Wunderlich
On Sunday 31 May 2015 13:35:55 Sven Eckelmann wrote: > The len field in the UDP header is 16 bit long. It can therefore store a > value of up to (2 ** 16 - 1). This value is currently used for MAX_PAYLOAD. > But the UDP len field not only stores the payload length but also the udp > header itself.

[B.A.T.M.A.N.] [PATCH maint 1/2] batman-adv: initialize up/down values when adding a gateway

2015-06-24 Thread Simon Wunderlich
From: Simon Wunderlich Without this initialization, gateways which actually announce up/down bandwidth of 0/0 could be added. If these nodes get purged later, the gw_node structure does not get removed since batadv_gw_node_delete() updates the gw_node with up/down bandwidth of 0/0, and the

  1   2   3   4   5   6   7   8   9   10   >