Re: [B.A.T.M.A.N.] Intel CC warning smashing

2008-12-01 Thread Simon Wunderlich
Hey Sven, thanks for all the patches! I applied all of them and tried to group them by topic. best regards, Simon On Mon, Dec 01, 2008 at 07:56:55PM +0100, Sven Eckelmann wrote: > Hi, > I had a small discussion with Simon Wunderlich about r1166 and showed > him a output

Re: [B.A.T.M.A.N.] [PATCH] batman-adv-kernelland: Fix memory corruption bug

2008-12-04 Thread Simon Wunderlich
Hey Scott, thank you very much for the fix! Can you confirm if this bug is related to https://dev.open-mesh.net/batman/ticket/86 ? This bug has very likely been caused by a memory corruption, but i couldn´t find where. (i have not experienced any kernel panics by this however ...). Thanks, best r

Re: [B.A.T.M.A.N.] [PATCH] batman-adv-kernelland: Fix memory corruption bug

2008-12-05 Thread Simon Wunderlich
Hey Scott, On Fri, Dec 05, 2008 at 11:40:30PM +1300, Scott Raynel wrote: > Hi Simon, > > On 5/12/2008, at 12:35 AM, Simon Wunderlich wrote: > > >Hey Scott, > > > >thank you very much for the fix! Can you confirm if this bug is > >related > >to

Re: [B.A.T.M.A.N.] Looking for batman-adv 0.1-alpha

2008-12-05 Thread Simon Wunderlich
Hey Tobias, are you using the kernelland or userspace version of batman-adv? If you want to use the userspace version, it's enough to compile and copy the binary from your desktop to the meshnode (it's i386 after all). However i'd recommend to use the latest revision of batman-adv-kernelland. Fo

Re: [B.A.T.M.A.N.] Looking for batman-adv 0.1-alpha

2008-12-08 Thread Simon Wunderlich
Hey Tobias, On Mon, Dec 08, 2008 at 09:29:12AM +0100, Tobias Gieseke wrote: > and thanks for the helpfull informations so far. As there is a command > "batmand-adv" available on the meshnode i assume they use the userspace > version of batman-adv (correct??). Can i copy the executeable file from

Re: [B.A.T.M.A.N.] [PATCH] Compile vis under FreeBSD and OSX

2009-01-13 Thread Simon Wunderlich
Hello guys, thank you very much for the patches! I've applied Svens patch because it is more general (including these headers in any case should not hurt). Compatibility patches are highly appreciated, we still have tickets open requesting Mac OS X support ... :) best regards Simon On T

Re: [B.A.T.M.A.N.] Install Batman

2009-01-21 Thread Simon Wunderlich
Hey, we also have precompiled binaries for x86: http://downloads.open-mesh.net/batman/stable/binaries/i386/ http://downloads.open-mesh.net/batman/development/binaries/i386/ another option is to compile/linu batmand with the -static flag on your x86 (i386) desktop and just copy it, as Sven explai

Re: [B.A.T.M.A.N.] possible on any device with batman?

2009-01-22 Thread Simon Wunderlich
Hello Maxx, would you please consider removing the batman mailing list from your advertisement recipient collection? Thank you ... best regards Simon On Thu, Jan 22, 2009 at 10:25:32PM +0100, M. Peterson wrote: [SPAM deleted] signature.asc Description: Digital signature

Re: [B.A.T.M.A.N.] batmand-howto conversation

2009-01-22 Thread Simon Wunderlich
Hey Sven, thanks for your work, it'd be nice to keep the howto up to date. We might as well merge the howto with our ongoing documentation [1]. What do you (and the others) think? Anyway, i'd upload the updated version of the howto as soon as you consider it ready. Just compiled it and it seems

Re: [B.A.T.M.A.N.] batman 0.3.1 released

2009-01-25 Thread Simon Wunderlich
Hey, On Sun, Jan 25, 2009 at 07:45:37PM +0100, Marek Lindner wrote: > BSD compability was committed. just to be clear: B.A.T.M.A.N. is currently not supported under *BSD, only the visualization server has been fixed. Maybe batmand compiles under *BSD, but lacks features like gateway functionalit

Re: [B.A.T.M.A.N.] Help in batman advanced configuration

2009-01-26 Thread Simon Wunderlich
Hello Gargi, your setup looks correct from what you've pasted. Some questions to find the reason: 1. Have you set "up" all the interfaces by doing "ifconfig up"? 2. If you set IPs on br0 of open-mesh1 and br0 of open-mesh2 manually, can they ping each other? 3. If yes (and configured within

Re: [B.A.T.M.A.N.] Stable adapters for Ad Hoc networks

2009-02-04 Thread Simon Wunderlich
Hey Breno, sounds like the well known ad-hoc cell splitting problem to me. A common workaround is to fixate the BSSID to some pre-defined value: iwconfig athX ap 02:CA:FF:EE:BA:BE hopefully all your drivers support this. :) best regards, Simon On Wed, Feb 04, 2009 at 03:03:35PM -0300,

Re: [B.A.T.M.A.N.] Using batman L2 on multiple wireless cards

2009-02-12 Thread Simon Wunderlich
Hello Gargi, yep, thats exactly the way to go. :) best regards Simon On Wed, Feb 11, 2009 at 09:06:46PM -0600, Gargi Purohit wrote: > Hi > > I was wondering if I can run L2 batman kernel module on hardware which > has 3 wireless cards. > Should be process be the same as in adding interf

Re: [B.A.T.M.A.N.] WiMAX

2009-02-12 Thread Simon Wunderlich
Hello Tim, unfortunately i have no experience with WiMAX, but as far as i know: * WiMAX is not license-free like WiFi (means you need to BUY a license, at least in germany) * where is the technical advantage of WiMAX over WiFi? Sure, the advertisements say "50 km or 108 MBit/s", but they

Re: [B.A.T.M.A.N.] B.A.T.M.A.N Digest, Vol 26, Issue 7

2009-02-13 Thread Simon Wunderlich
Hey Tim, On Thu, Feb 12, 2009 at 03:30:06PM -0600, Tim LePes wrote: > > I understand you can get good range with WiFi using directional > antennae, parabolic antennae, "cantennas", etc. I *have* thought about > directional antennas for back-haul, but the project idea was geared > toward emergenc

Re: [B.A.T.M.A.N.] B.A.T.M.A.N L2 over a Bluetooth PAN

2009-02-13 Thread Simon Wunderlich
Hello Breno, as far as i know, for 802.11 the SNAP protocol is used to encapsulate the complete Ethernet Frame [1]. This means that the Ethernet header is completly preserved and can be decapsulated on the receiver side. The BNEP protocol on the other hand seems to cut off the Ethernet header inst

Re: [B.A.T.M.A.N.] Wimax-Stuff and Ideas

2009-02-13 Thread Simon Wunderlich
Hey Bastian, On Fri, Feb 13, 2009 at 02:08:40PM +0100, Bastian Bittorf wrote: > * Simon Wunderlich [13.02.2009 01:30]: > > [sorry for mixing up threads] > > > WiFi has some kind of range limit due to the acknowledgement timeout, > > but you can easily overcome this b

Re: [B.A.T.M.A.N.] Using batman L2 on multiple wireless cards

2009-02-14 Thread Simon Wunderlich
Hello Gargi, the design of the main interface in BATMAN has the effect that only OGM packets from the main interface are distritibuted over the whole network. OGM packets from secondary interfaces are only sent with TTL=1, that means the next neighbor will drop them. The reason for this system i

Re: [B.A.T.M.A.N.] B.A.T.M.A.N. on NS-2 ?

2009-02-17 Thread Simon Wunderlich
Hello Arnaud, there is no implementation for the NS-2 simulator as far as i know. best regards, Simon On Mon, Feb 16, 2009 at 06:27:50PM +0100, Arnaud Kaiser wrote: > Hi, > > I wonder if it exists an implementation of B.A.T.M.A.N. on NS-2 simulator. > > Thanks. > > Arnaud. > _

Re: [B.A.T.M.A.N.] Running Batman

2009-03-03 Thread Simon Wunderlich
Hello Kartik, are you sure that ath0 is not already created before you run the "wlanconfig ath0 create ..." command? If so, you should first destroy it with: $ wlanconfig ath0 destroy You should be able to ping between the devices if they are in range, even if batman is not running. I suggest yo

Re: [B.A.T.M.A.N.] Maybe!?!

2009-03-03 Thread Simon Wunderlich
Hello Mario, maybe this link [1] helps you. best regards, Simon [1] http://freshmeat.net/search/?q=wifi+management§ion=projects On Mon, Mar 02, 2009 at 02:52:18PM +0100, Mario Roeber wrote: > Hello, > > i'know it's not direct a BATMAN problem/question. i'm looking for > opensource cen

Re: [B.A.T.M.A.N.] Batman-adv nodes do not recieve OGMs

2009-03-31 Thread Simon Wunderlich
Hello Kai, Quoting Kai Timmer : Hello, i have a problem using batman-adv. At the moment i use v0.1, but i had the same problem when trying the svn version 1241. All the nodes send their ogm, but none does recieve any of these. What i did on all nodes is: iwconfig $wlaninterface essid batman mo

Re: [B.A.T.M.A.N.] Trouble with SSH in L2 batman network

2009-04-14 Thread Simon Wunderlich
Hey Gargi, i've read your setup as you described it, and as far as i understood it is supposed to work. I've already built up similar setups without problems and don't see what your problem is here. Maybe you can provide some more information, e.g. your startup script, to get a clue here? kind r

Re: [B.A.T.M.A.N.] batman-adv use in Manchester NH

2009-05-07 Thread Simon Wunderlich
Hey Arc, On Tue, May 05, 2009 at 02:53:56PM -0400, Arc Riley wrote: > > Excellent! Is there a website for your project? > > > Not yet, in the next two weeks. > > > Are you fully committed to Batman or still in the evaluation phases? > > > There's room to be swayed, but batman-adv seems to be

Re: [B.A.T.M.A.N.] VIS server for batman-adv-kernelland

2009-05-22 Thread Simon Wunderlich
Hello Christoph, On Thu, May 21, 2009 at 10:19:40PM +0200, Christoph Pilka wrote: > Hi folks, > > my goal is to visualize batman-adv-kernelland network topology. 'echo > "server" > /proc/net/batman-adv/vis' activates vis server on the mesh > node directly, right? Yes, that's right. > Do the oth

Re: [B.A.T.M.A.N.] Batman gateway lock ups

2009-07-21 Thread Simon Wunderlich
Hello Dingo, i know it is a long time ago, but can you please verify if the problem present in Ticket 121 [1] still affects you? Or is it already solved? The entries are 10 months old and the issue is probably already fixed. Thank you very much, Simon [1] https://www.open-mesh.net/ticke

Re: [B.A.T.M.A.N.] batman-adv packet.h license

2009-08-17 Thread Simon Wunderlich
Hello Andrew, this is fine with me, let's hear what marek thinks. BTW, there are excellent batman dissectors for wireshark, have you tried them already? best regards, Simon On Mon, Aug 17, 2009 at 08:36:44PM +0200, Andrew Lunn wrote: > Hi Marek, Simon > > I'm writing a protocol dissect

Re: [B.A.T.M.A.N.] batman-adv applying for an official Ethertype?

2009-08-18 Thread Simon Wunderlich
Hey Andrew, i'm only aware of ether-wake which uses 0x8042 as (unregistered) ethertype to send WOL packets and was obviously used in scyld beowulf systems according to the manpage [1]. Wireshark also recognizes these packets [2]. I know this ethertype because we used this ethertype in our firs

Re: [B.A.T.M.A.N.] HSB announces the second Wireless Battle Mesh (Brussels, 17-18 Oct)

2009-08-30 Thread Simon Wunderlich
Sounds nice, i'm in. ;) On Sat, Aug 29, 2009 at 09:38:24AM +0200, Benjamin Henrion wrote: > > === > HackerSpaceBrussels announces the second Wireless Battle Mesh > WBM2009 v2 (Brussels, 17-18 October) >

Re: [B.A.T.M.A.N.] [patch] adding subgraph-feature to vis-output in dot-file-format

2009-08-30 Thread Simon Wunderlich
open-mesh.net/pipermail/b.a.t.m.a.n/2009-August/002832.html Signed-off-by: Simon Wunderlich From: Linus Lüssing Index: vis.c === --- vis.c (revision 1418) +++ vis.c (working copy) @@ -87,7 +87,7 @@ struct vis_in

Re: [B.A.T.M.A.N.] [patch] adding subgraph-feature to vis-output in dot-file-format

2009-08-30 Thread Simon Wunderlich
Hi, On Sun, Aug 30, 2009 at 09:37:52AM +0200, Andrew Lunn wrote: > > Cheers, Linus > > > > PPS: I had to introduce a src-field in the vis-packet-struct, > > therefore the compatibility version had to be increased as well. > > I'm thinking about linux-mainline here. > > Does it make sense to have

Re: [B.A.T.M.A.N.] IP from MAC

2009-09-18 Thread Simon Wunderlich
Hey, right, on batman-adv you can use a central DHCP server or use decentralized link-local IP autoconfiguration tools as Sven suggested. On Fri, Sep 18, 2009 at 06:42:18PM +1000, Lick A Prize wrote: > And for multi-hop networks, of the kind that BATMAN, OLSR, etc. are used > for? > > -

Re: [B.A.T.M.A.N.] BATMAN-Adv and MTU handling

2009-11-10 Thread Simon Wunderlich
Hey, On Tue, Nov 10, 2009 at 06:34:41PM +0800, Marek Lindner wrote: > > The motivation of using a higher MTU of 1524 at the beginning was > > the rumour, that there might be some client devices (which we > > would get into the network by bridging bat0 wifi wlan0 for > > instance) not able to handl

[B.A.T.M.A.N.] [PATCH] Removing the big batman lock

2009-11-29 Thread Simon Wunderlich
nodes etc, which seems to be clean so far. However there might be more race conditions introduced by this large patch, and i'm therefore requesting a careful review before committing. Signed-off-by: Simon Wunderlich --- Index: batman-adv-kernelland/

[B.A.T.M.A.N.] [PATCHv2] [batman-adv] Removing the big batman lock

2009-12-03 Thread Simon Wunderlich
referenced (e.g. as neighbor), and freed when there are no references left. This makes it neccesary to carefully reference and unreference nodes. * orig_nodes receive an individual spin lock to protect access to their data. Signed-off-by: Simon Wunderlich --- I did some testing, including

[B.A.T.M.A.N.] [PATCHv3] [batman-adv] Removing the big batman lock

2009-12-05 Thread Simon Wunderlich
referenced (e.g. as neighbor), and freed when there are no references left. This makes it neccesary to carefully reference and unreference nodes. * orig_nodes receive an individual spin lock to protect access to their data. Signed-off-by: Simon Wunderlich --- I did some testing, including

Re: [B.A.T.M.A.N.] [patchv2] batman-adv: Use printk(%pM) for MAC addres

2009-12-13 Thread Simon Wunderlich
Hello Andrew, i've checked your patch against older kernel, and there seem to be some compile problems. E.g. compiling against 2.6.26, i find: CC [M] /home/dotslash/msrc/batman-svn/batman-adv-kernelland/bat_printk.o /home/dotslash/msrc/batman-svn/batman-adv-kernelland/bat_printk.c: In function

Re: [B.A.T.M.A.N.] [PATCH] Removing the big batman lock

2009-12-13 Thread Simon Wunderlich
has some more severe problems (deadlocks etc) i will have to review this seperately ... :( On Mon, Nov 30, 2009 at 11:09:02AM +0100, Andrew Lunn wrote: > On Sun, Nov 29, 2009 at 09:09:50PM +0100, Simon Wunderlich wrote: > > > I did some testing, including loading, unloading, killin

Re: [B.A.T.M.A.N.] [PATCH] [batctl] Fix array out of bound exception

2009-12-14 Thread Simon Wunderlich
Dear Linus, thank you for your patch, i have applied it in svn r1496. On Fri, Dec 11, 2009 at 10:06:23PM +0100, Linus Lüssing wrote: > This patch fixes an array out of bound exception in line 201 of > functions.c. We need to reserve one extra character for the > appended null character. > > Sign

Re: [B.A.T.M.A.N.] [PATCH] [batman-adv] Remove whitespace style errors

2009-12-14 Thread Simon Wunderlich
Hello Sven, thank you for your patch, i applied it in svn revision r1494. On Thu, Dec 10, 2009 at 07:50:43PM +0100, Sven Eckelmann wrote: > checkpatch.pl found different smaller errors regarding trailing > whitespaces or trailing extra newlines before EOF. These should be > removed to follow linu

Re: [B.A.T.M.A.N.] [PATCH] [batman-adv] Remove NULL pointer check before calling kfree

2009-12-14 Thread Simon Wunderlich
Hello Sven, thank you, applied in svn revision r1493. best regards Simon On Thu, Dec 10, 2009 at 08:00:57PM +0100, Sven Eckelmann wrote: > It is safe to call kfree(NULL) which makes this extra check unneeded. It > was found using checkpatch.pl from linux-2.6 > > Signed-off-by: Sven Ecke

Re: [B.A.T.M.A.N.] Does batman-adv support gateway ?

2009-12-15 Thread Simon Wunderlich
Hello Wu, you can set an IP address on the bat0 interface, or include it in a bridge with eth0 or other devices which are not used for the mesh. You might as well use DHCP to provide addresses to your nodes (which is not possible with layer 3 daemons, btw). You don't need to set IP addresses of t

Re: [B.A.T.M.A.N.] [PATCH] [batman-debug4] Fix small typo "unkown" -> "unknown"

2009-12-16 Thread Simon Wunderlich
Hello Sven, thank you, applied in revision 1500. best regards Simon On Tue, Dec 15, 2009 at 04:20:10PM +0100, Sven Eckelmann wrote: > > Signed-off-by: Sven Eckelmann > --- > batman-debug4.pl |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/batman-debug4.p

Re: [B.A.T.M.A.N.] Typo in change set 1501

2009-12-16 Thread Simon Wunderlich
Hey Gus, thank you for point that out, i knew i forgot something. ;) fixed in revision 1502. best regards Simon On Wed, Dec 16, 2009 at 11:58:08AM -0800, Gus Wirth wrote: > The fixes for typos in changeset 1501 missed one. On line 183 the > "Neighbour" should be "Neighbor" to be consis

Re: [B.A.T.M.A.N.] required network to run

2009-12-17 Thread Simon Wunderlich
Hello Eric, the basic idea of meshing in general is: the destination nodes are probably not in the coverage area of your radio, but you still want to talk to these nodes. For example, imagine a city network where all nodes are connected to each other: You wifi cards signal is only strong enoug

Re: [B.A.T.M.A.N.] [BULK] Re: required network to run

2009-12-18 Thread Simon Wunderlich
ric > > > > > -Original Message- > From: b.a.t.m.a.n-boun...@lists.open-mesh.net > [mailto:b.a.t.m.a.n-boun...@lists.open-mesh.net] On Behalf Of Simon > Wunderlich > Sent: Wednesday, December 16, 2009 6:25 PM > To: The list for a Better Approach To Mobile Ad-hoc Netwo

Re: [B.A.T.M.A.N.] wireless adapter and linux kernel version

2009-12-19 Thread Simon Wunderlich
Hi Eric, there are a lot of wifi cards and drivers which don't support ad-hoc mode. I had bad experience with RTL based wifi cards. More info about drivers and supported modes can be found here: http://linuxwireless.org/en/users/Drivers Try to use Atheros based cards, most of them support Ad-Hoc

[B.A.T.M.A.N.] we are on our way into 2.6.33

2009-12-21 Thread Simon Wunderlich
Hello, just for your information (some of you probably already know it), we are on our way into the Linux mainline kernel, as you can see in the diffstat for 2.6.33-rc1: http://www.kernel.org/diff/diffview.cgi?file=/pub/linux/kernel/v2.6/testing/patch-2.6.33-rc1.bz2 (yes, it's huge, just search

[B.A.T.M.A.N.] [PATCH] batman-adv: receive packets directly using skbs

2009-12-23 Thread Simon Wunderlich
i can not talk about the performance from this setup. Signed-off-by: Simon Wunderlich --- Index: a/batman-adv-kernelland/types.h === --- a/batman-adv-kernelland/types.h (revision 1507) +++ b/batman-adv-kernelland/types.h (wo

[B.A.T.M.A.N.] [PATCHv2] batman-adv: receive packets directly using skbs

2009-12-27 Thread Simon Wunderlich
_headlen() instead of asking skb->len * fix some small bugs (use kfree(skb) -> kfree_skb(skb)) Signed-off-by: Simon Wunderlich --- Index: a/batman-adv-kernelland/types.h === --- a/batman-adv-kernelland/types.h (revision 1507

[B.A.T.M.A.N.] [PATCHv2 no pgp] batman-adv: receive packets directly using skbs

2009-12-28 Thread Simon Wunderlich
_headlen() instead of asking skb->len * fix some small bugs (use kfree(skb) -> kfree_skb(skb)) Signed-off-by: Simon Wunderlich --- Index: a/batman-adv-kernelland/types.h === --- a/batman-adv-kernelland/types.h (revision 1507

Re: [B.A.T.M.A.N.] [PATCHv2 no pgp] batman-adv: receive packets directly using skbs

2009-12-29 Thread Simon Wunderlich
e a little. best regards, Simon On Mon, Dec 28, 2009 at 04:10:08PM +0100, Simon Wunderlich wrote: > This patch removes the (ugly and racy) packet receiving thread and the > kernel socket usage. Instead, packets are received directly by registering > the ethernet type and handl

Re: [B.A.T.M.A.N.] [Patch 1/1] Staging: batman-adv: Use printk(%pM) for MAC addresses

2010-01-01 Thread Simon Wunderlich
ity in bat_printk.c so that > the code is more likely to build with older kernels. > > Only build bat_printk.c with kernels that require it, thanks to Simon > Wunderlich Makefile.kbuild patch. > > Signed-off-by: Andrew Lunn > Index: Makefile.kbuild >

Re: [B.A.T.M.A.N.] Coccinelle tests?

2010-01-01 Thread Simon Wunderlich
Hey Andrew, thanks for forwarding! I've commited a patch, revision 1527, which should fix these things. See some comments inline below. best regards, Simon On Thu, Dec 31, 2009 at 06:07:53PM +0100, Andrew Lunn wrote: > ***dev->dev_addr is a pointer. The size of an address is probably 6

Re: [B.A.T.M.A.N.] [PATCH 3/3] batman-adv: Remove unused variable

2010-01-01 Thread Simon Wunderlich
Hey Linus, sorry, i have not seen your patch and checked this in myself (r1525). Thanks for reporting it anyway. :) best regards, Simon On Thu, Dec 31, 2009 at 04:41:20AM +0100, =?UTF-8?q?Linus=20L=C3=BCssing?= wrote: > The variable 'flag' is never being used in this function, therefor

Re: [B.A.T.M.A.N.] [PATCH 2/3] batman-adv: No deact of aggregation on wrong input

2010-01-01 Thread Simon Wunderlich
Hello Linus, thank you for the patch, applied with minor style changes in svn revision 1528. best regards, Simon On Thu, Dec 31, 2009 at 04:39:55AM +0100, =?UTF-8?q?Linus=20L=C3=BCssing?= wrote: > A non-integer changes the aggregation mode. Therefore this patch changes > the behaviour t

Re: [B.A.T.M.A.N.] batmand advanced recipe for bitbake

2010-01-01 Thread Simon Wunderlich
Hello Eric, i'm not aware of bitbake receipts, but we would be happy to link it if you find one or write it. best regards Simon On Wed, Dec 30, 2009 at 10:12:12PM -0500, Conner, Eric wrote: > Has anyone created a BATMAN Advanced recipe for bitbake > openembedded.dev? > > > > thanks

Re: [B.A.T.M.A.N.] Missing unlocks

2010-01-01 Thread Simon Wunderlich
Hello Andrew, thank you, i've commited a patch for this in revision 1529. This should fix this bug and make sparse happy. :) best regards, Simon On Fri, Jan 01, 2010 at 06:52:59PM +0100, Andrew Lunn wrote: > Hi Simon > > I just built batman-adv with make C=1 so that sparse it used to c

[B.A.T.M.A.N.] [PATCH] batman-adv: Add bonding functionality

2010-01-04 Thread Simon Wunderlich
s are welcome. Signed-off-by: Simon Wunderlich --- Index: a/batman-adv-kernelland/types.h === --- a/batman-adv-kernelland/types.h (revision 1532) +++ b/batman-adv-kernelland/types.h (working copy) @@ -48,6 +48,7 @@ str

Re: [B.A.T.M.A.N.] batman adv to batmand

2010-01-05 Thread Simon Wunderlich
no, they operate on different layers. On Tue, Jan 05, 2010 at 09:00:15AM -0500, Conner, Eric wrote: > Can batman adv nodes see batmand nodes and vice versa? > > > > > > > > Eric C. Conner > > Senior Software Engineer > > QinetiQ North America > > Technology Solutions Group > > 110 Co

Re: [B.A.T.M.A.N.] B.A.T.M.A.N. V outlook

2010-01-07 Thread Simon Wunderlich
Hello, we probably did not make this very clear in the document, but we will focus our work on batman-adv (layer 2) and will keep the batmand (layer 3) as it is for now. As a consequence, some ideas for BATMAN V are layer 2 exclusive (mesh bonding, incoming interface based routing). On Thu, Jan

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: Add bonding functionality

2010-01-17 Thread Simon Wunderlich
ghbors are purged, the bonding candidate list gets updated instead of bonding switched off. best regards, Simon On Mon, Jan 04, 2010 at 07:27:10PM +0100, Simon Wunderlich wrote: > This patch introduces bonding functionality to batman-advanced, targeted > for the 0.3 release. As we are a

Re: [B.A.T.M.A.N.] Security on adhoc network

2010-01-17 Thread Simon Wunderlich
Hey Jaideep, as Sven mentioned correctly, using the WPA sequence numbers in WPA_NONE should be ignored. Some drivers (like madwifi) have to be teached to do that. Sequence numbers do not make much sense in Ad-Hoc anyway, as there is no central management for these sequence numbers. Of course, you

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: Add bonding functionality

2010-01-19 Thread Simon Wunderlich
Whoops, this is definitly a bug, thanks for pointing that out. Committed in r1552. On Mon, Jan 18, 2010 at 07:31:22PM +0800, Marek Lindner wrote: > > Hi, > > > i've just committed this patch in revision 1551, as no further comments and > > critiques came in. I would consider this patch rather

Re: [B.A.T.M.A.N.] batman-adv on different archs

2010-01-19 Thread Simon Wunderlich
Hello, just as a side note, would you mind sharing your changes which were required to cross compile for ARM? batman-adv is supposed to support 2.6.24, and if there is any trouble with this on ARM i'd like to add support for it. Thank you very much, Simon On Tue, Jan 19, 2010 at 03:51

Re: [B.A.T.M.A.N.] [Patch 1/1] Staging: batman-adv: Use?printk (%pM) for MAC addresses

2010-01-20 Thread Simon Wunderlich
Whoops ... added in r1559. On Wed, Jan 20, 2010 at 09:20:34AM +0800, Marek Lindner wrote: > > Hey, > > > thank you for the patch, it is committed now in r1526. I've added some > > changes to your patch to allow compatibility for all currently suported > > kernels again. This includes: > > > >

Re: [B.A.T.M.A.N.] batman-adv on different archs

2010-01-22 Thread Simon Wunderlich
Hello, maybe just an idea, but could it be that we have a regression from the skb patch that some skb headers are wrong? An idea would be to compare the behaviour with the batman-adv 0.2 release or an revision < 1517, which still uses raw sockets instead of working directly on the skb. regards

Re: [B.A.T.M.A.N.] race condition with activate_module?

2010-02-14 Thread Simon Wunderlich
Works fine and really seems to make a difference when trying with the ssleep() stuff from linus (which also crashes in my qemu testbed). After applying your patch it works fine. I have committed it along with some other sanity checks in r1573. On Fri, Feb 12, 2010 at 07:06:46PM +0800, Marek Lindn

Re: [B.A.T.M.A.N.] slowpath warning

2010-02-28 Thread Simon Wunderlich
recv_list, so we now need a new lock to protect that instead of vis_hash_lock. Also a few checkpatch cleanups. Reported-by: Linus Luessing Signed-off-by: Andrew Lunn Signed-off-by: Simon Wunderlich === --- batman-adv-kerne

Re: [B.A.T.M.A.N.] slowpath warning

2010-03-01 Thread Simon Wunderlich
ref on the vis_info object so that we can call send_vis_packets() without holding vis_hash_lock. vis_hash_lock also used to protect recv_list, so we now need a new lock to protect that instead of vis_hash_lock. Also a few checkpatch cleanups. Reported-by: Linus Luessing Signed-off-by: And

Re: [B.A.T.M.A.N.] slowpath warning

2010-03-02 Thread Simon Wunderlich
10 at 07:43:08AM +0100, Andrew Lunn wrote: > On Mon, Mar 01, 2010 at 05:57:06PM +0100, Simon Wunderlich wrote: > > Hey Andrew, > > > > all list-adds and list-removes do a kref_get or kref_put respectively, > > but that probably was not very clear. As soon as a refence

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: Fixing wrap-around bug in vis

2010-03-12 Thread Simon Wunderlich
Hey, nice catch! I'd like to join the party and propose this version: #define seq_before(x,y) ((int8_t) (x - y) < 0) #define seq_after(x,y) seq_before(y,x) Not so much bitshifting and may a little bit easier to understand, but also not general and does not pass Svens regression test ... :( Wr

[B.A.T.M.A.N.] [PATCH] batman-adv: Reorganize sequence number handling

2010-04-05 Thread Simon Wunderlich
code cleanups (at least i hope you feel the same) and also fixes a bug in count_real_packets() which falsely updated the last_real_seqno for slightly older packets within the seqno window if they are no duplicates. Signed-off-by: Simon Wunderlich Acked-by: Linus Luessing Index: a

Re: [B.A.T.M.A.N.] Minor change in vis.c

2010-04-05 Thread Simon Wunderlich
Hey guys, thank you very much for reporting and discussing, just committed a fix (r1617 and r1618). best regards, Simon On Fri, Mar 26, 2010 at 12:08:54AM +0100, Linus Lüssing wrote: > > So it looks like we need a field width of 3, not 2. > Ah, sorry forgot about the rest of the mail, so

[B.A.T.M.A.N.] [PATCH] batman-adv: Limit queue lengths for batman and broadcast packets

2010-04-05 Thread Simon Wunderlich
maximum space available in total for typical setups (assuming one packet including overhead does not require more than 2000 byte). This should also be reasonable for smaller routers, otherwise the defines can be tweaked later. Signed-off-by: Simon Wunderlich --- Index: a/batman-adv-kernelland

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: Limit queue lengths for batman and broadcast packets

2010-04-05 Thread Simon Wunderlich
Hey Sven, you are right, this might be indeed a problem. I'll send an updated patch which removes the problem by employing atomic_add_unless(). Marek also pointed out that global variables are not very pretty as we are moving all the global stuff into bat_priv to allow multiple mesh soft interfa

[B.A.T.M.A.N.] [PATCHv2] batman-adv: Limit queue lengths for batman and broadcast packets

2010-04-05 Thread Simon Wunderlich
maximum space available in total for typical setups (assuming one packet including overhead does not require more than 2000 byte). This should also be reasonable for smaller routers, otherwise the defines can be tweaked later. Signed-off-by: Simon Wunderlich --- Index: a/batman-adv-kernelland/send.c

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: Reorganize sequence number handling

2010-04-06 Thread Simon Wunderlich
protect it! > [ 506.836694] XXX protect it! > [ 537.036869] XXX protect it! > [ 567.056133] XXX protect it! > [ 597.058637] XXX protect it! > [ 847.936099] XXX protect it! > [ 848.560450] XXX protect it! > [ 907.686827] XXX protect it! > [ 1994.836111] XXX protect

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: Reorganize sequence number handling

2010-04-06 Thread Simon Wunderlich
t the original sender flood the same packets on all interfaces ... I'll look into this, thanks. Simon On Tue, Apr 06, 2010 at 03:11:05PM +0200, Linus Lüssing wrote: > On Tue, Apr 06, 2010 at 12:41:29PM +0200, Simon Wunderlich wrote: > > Hi Linus, > > > > from the ti

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: Reorganize sequence number handling

2010-04-06 Thread Simon Wunderlich
good idea. best regards, Simon On Tue, Apr 06, 2010 at 07:58:09PM +0200, Simon Wunderlich wrote: > Hi Linus, > > i've verified and can reproduce the problem. The queue limitation patch > removes > the OOM problems, but the same packets are still broadcasted. It

[B.A.T.M.A.N.] [PATCHv2] batman-adv: Reorganize sequence number handling

2010-04-06 Thread Simon Wunderlich
ft() reads from outside of the seqno window, and removes the loop for seq_diff == -64 which was present in the first patch. Signed-off-by: Simon Wunderlich --- Index: a/batman-adv-kernelland/types.h === --- a/batman-adv-kernelland/typ

[B.A.T.M.A.N.] [PATCHv3] batman-adv: Limit queue lengths for batman and broadcast packets

2010-04-07 Thread Simon Wunderlich
sequence number when the queue is already full. Signed-off-by: Simon Wunderlich --- Index: a/batman-adv-kernelland/send.c === --- a/batman-adv-kernelland/send.c (revision 1616) +++ a/batman-adv-kernelland/send.c (working copy

Re: [B.A.T.M.A.N.] Patch batman-adv for kernel 2.6.15

2010-04-12 Thread Simon Wunderlich
Hello Franz, the workqueues are the most "non-trivial" thing which prevented us so far from backporting batman-adv to these older kernel. I'd also be interested to integrate patches if anyone has a solution for this. :) best regards, Simon On Mon, Apr 12, 2010 at 09:28:30AM +0200, Fran

Re: [B.A.T.M.A.N.] [PATCHv3] batman-adv: Limit queue lengths for batman and broadcast packets

2010-04-12 Thread Simon Wunderlich
22 jiffies (88 ms) > [ 4175.921259] Took 19 jiffies (76 ms) > [ 4176.026627] Took 20 jiffies (80 ms) > [ 4176.135124] Took 20 jiffies (80 ms) > [ 4176.243757] Took 21 jiffies (84 ms) > [ 4176.349231] Took 21 jiffies (84 ms) > [ 4176.444639] Took 18 jiffies (72 ms) > [ 4176.543197] Took 18 jiffi

[B.A.T.M.A.N.] [PATCH] 32bit sequence number and TTL for broadcasts

2010-04-25 Thread Simon Wunderlich
ust to make sure. These changes required to increase the compatibility level once again. It should therefore only applied to the upcoming 0.3 branch. Signed-off-by: Simon Wunderlich --- Index: a/batman-adv-kernelland/vis.c === --

Re: [B.A.T.M.A.N.] Security & node authentication in BATMAN network

2010-04-26 Thread Simon Wunderlich
Hello Adrian, quite good answers have already been on the list. Maybe it is helpful to create VLANs for your purpose on top of the mesh, e.g.: 1. An open patient/customer VLAN for internet traffic etc 2. a hospital internal VLAN for your sensitive information 3. an administration VLAN for maint

Re: [B.A.T.M.A.N.] [PATCH] 32bit sequence number and TTL for broadcasts

2010-04-26 Thread Simon Wunderlich
Hello Sven, thank you for your review. I've compiled and tested it in my openwrt qemu build environment, which is built on linux 2.6.31.1. I have not checked it on any other platforms so far. best regards, Simon On Sun, Apr 25, 2010 at 10:48:13PM +0200, Sven Eckelmann wrote: > First th

Re: [B.A.T.M.A.N.] sysfs compat

2010-05-03 Thread Simon Wunderlich
Hi, personally i need 2.6.24, and don't care much about 2.6.20, so i would not bother to drop support for this special version - We can however integrate patches, i'm sure someone will look at it if it is a trivial conversion. Marek, i've tested your patches with all major kernel releases from 2

Re: [B.A.T.M.A.N.] [PATCH 13/26] staging:batman-adv: convert multiple /proc files to use sysfs

2010-05-16 Thread Simon Wunderlich
Hello Andrew, thank you very much for your suggetions. I'm currently sitting here with Marek and Sven in Berlin and we were discussing your suggestions. Our conclusion is: * We could write and read "enable/disable" only from the respective files (like aggregation). In this case we don't need

[B.A.T.M.A.N.] [PATCH] Staging: batman-adv: bonding and interface alternating

2010-05-26 Thread Simon Wunderlich
experimental patch and targeted for upcoming experiments at Wireless Battle Mesh v3 in Bracciano/Italy. Feedback, comments and reviews appreciated! Signed-off-by: Simon Wunderlich --- Index: a/batman-adv-kernelland/types.h === --- a

Re: [B.A.T.M.A.N.] [PATCH] Staging: batman-adv: bonding and interface alternating

2010-06-04 Thread Simon Wunderlich
Hey, i've checked in a changed and fixed up version of this patch in r1686. This version has the interface alternating enabled by default, so we don't need to change the "bonding_enabled" to "bonding_mode" anymore. We have decided here in Bracciano to have alternating as default as it appears to

Re: [B.A.T.M.A.N.] [PATCH] Staging: batman-adv: bonding and interface alternating

2010-06-05 Thread Simon Wunderlich
Hey Sven, On Fri, Jun 04, 2010 at 10:56:50PM +0200, Sven Eckelmann wrote: > Simon Wunderlich wrote: > > I've also followed your other comments (hopefully correctly), so thank > > you very much for the review. > [...] > > > > This is an experimental patch and t

Re: [B.A.T.M.A.N.] [PATCHv2-trunk] batman-adv: Convert MAC_FMT to %pM

2010-06-05 Thread Simon Wunderlich
Thank you, i've applied this patch in svn r1688. I've tested compiling against 2.6.21, 2.6.24, 2.6.27 - no problem. best regards, Simon On Fri, Jun 04, 2010 at 04:18:57PM +0200, Sven Eckelmann wrote: > From: Joe Perches > > Remove the last uses of MAC_FMT > > Signed-off-by: Joe Perche

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: return -EFAULT on copy_to_user errors

2010-06-05 Thread Simon Wunderlich
Thank you, applied in svn r1689. On Thu, Jun 03, 2010 at 01:33:27PM +0200, Sven Eckelmann wrote: > From: Dan Carpenter > > copy_to_user() returns the number of bites remaining but we want to > return a negative error code here. > > Signed-off-by: Dan Carpenter > [sven.eckelm...@gmx.de: Move ch

Re: [B.A.T.M.A.N.] [PATCH 2/3] batman-adv: Correct gw_speed down bit mask

2010-06-05 Thread Simon Wunderlich
Thanks, committed in r1690. On Thu, Jun 03, 2010 at 12:58:35AM +0200, Sven Eckelmann wrote: > We want to get bits .... and not as the mask would suggest .O.. > when we decode the encoded bits for the download part of the gateway > speed. > > Reported-By: Bill Meier > Signed-off-by: Sven

Re: [B.A.T.M.A.N.] [PATCH 1/3] batman: Correct gw_speed down bit mask

2010-06-05 Thread Simon Wunderlich
Thanks, applied in svn r1691. On Thu, Jun 03, 2010 at 12:58:34AM +0200, Sven Eckelmann wrote: > We want to get bits .... and not as the mask would suggest .O.. > when we decode the encoded bits for the download part of the gateway > speed. > > Reported-By: Bill Meier > Signed-off-by: Sve

Re: [B.A.T.M.A.N.] release cycle

2010-06-10 Thread Simon Wunderlich
Hello, the year numbering scheme would be fine with me, currently i can't think of anything which would speak against it and it would represent our evolutional model quite well. I would vote to apply it. best regards, Simon On Wed, Jun 09, 2010 at 02:06:03PM +0200, Sven Eckelmann wrote:

Re: [B.A.T.M.A.N.] [PATCH v2 2/3] batman-adv: Fix non-atomic bla_claim::backbone_gw access

2016-07-01 Thread Simon Wunderlich
On Thursday 30 June 2016 20:11:33 Sven Eckelmann wrote: > The pointer batadv_bla_claim::backbone_gw can be changed at any time. > Therefore, access to it must be protected to ensure that two function > accessing the same backbone_gw are actually accessing the same. This is > especially important wh

Re: [B.A.T.M.A.N.] [PATCH v5 4/6] batman-adv: drop unicast packets from other backbone gw

2016-07-01 Thread Simon Wunderlich
ames lead to looping unicast traffic backbone->mesh->backbone. > > Signed-off-by: Andreas Pape Acked-by: Simon Wunderlich I believe Svens previous concerns have been cleared. When you resend this patchset, please add my Acked-by into your commit message (unless you do major

Re: [B.A.T.M.A.N.] [PATCH v5 2/6] batman-adv: speed up dat by snooping received ip traffic

2016-07-01 Thread Simon Wunderlich
Hi Andreas, as suggested by yourself and according to the discussion, please drop this patch from the patchset on the next resend. It may be better to resend it separately when the concerns are cleared. Thanks! Simon On Friday 10 June 2016 13:11:00 Andreas Pape wrote: > Speeding up dat add

<    4   5   6   7   8   9   10   11   12   13   >