[B.A.T.M.A.N.] [PATCH v5 11/19] batman-adv: Add gateway mesh genl configuration

2019-02-09 Thread Sven Eckelmann
the attributes: * u8 BATADV_ATTR_GW_MODE (0 == off, 1 == client, 2 == server) * u32 BATADV_ATTR_GW_BANDWIDTH_DOWN (in 100 kbit/s steps) * u32 BATADV_ATTR_GW_BANDWIDTH_UP (in 100 kbit/s steps) * u32 BATADV_ATTR_GW_SEL_CLASS Signed-off-by: Sven Eckelmann --- Cc: Marek Lindner Cc: Antonio Quartulli

[B.A.T.M.A.N.] [PATCH v5 09/19] batman-adv: Add distributed_arp_table mesh genl configuration

2019-02-09 Thread Sven Eckelmann
. Setting the u8 to zero will disable this feature and setting it to something else is enabling this feature. Signed-off-by: Sven Eckelmann --- Cc: Antonio Quartulli --- include/uapi/linux/batman_adv.h | 8 net/batman-adv/netlink.c| 17 + 2 files changed, 25

[B.A.T.M.A.N.] [PATCH v5 06/19] batman-adv: Add ap_isolation mesh/vlan genl configuration

2019-02-09 Thread Sven Eckelmann
attributes BATADV_ATTR_ISOLATION_MARK and BATADV_ATTR_ISOLATION_MASK. Signed-off-by: Sven Eckelmann --- Cc: Antonio Quartulli --- include/uapi/linux/batman_adv.h | 19 +++ net/batman-adv/netlink.c| 89 + 2 files changed, 108 insertions(+) diff --git a/include

[B.A.T.M.A.N.] [PATCH v5 04/19] batman-adv: Prepare framework for vlan genl config

2019-02-09 Thread Sven Eckelmann
t; mcast group using the BATADV_CMD_SET_VLAN command message type that settings might have been changed and what the current values are. Signed-off-by: Sven Eckelmann --- include/uapi/linux/batman_adv.h | 17 +++ net/batman-adv/netlink.c| 191 +++- 2 files changed,

[B.A.T.M.A.N.] [PATCH v5 05/19] batman-adv: Add aggregated_ogms mesh genl configuration

2019-02-09 Thread Sven Eckelmann
will disable this feature and setting it to something else is enabling this feature. Signed-off-by: Sven Eckelmann --- Cc: Marek Lindner --- include/uapi/linux/batman_adv.h | 6 ++ net/batman-adv/netlink.c| 12 2 files changed, 18 insertions(+) diff --git a/include/uapi/linux

[B.A.T.M.A.N.] [PATCH v5 01/19] batman-adv: Move common genl doit code pre/post hooks

2019-02-09 Thread Sven Eckelmann
Signed-off-by: Sven Eckelmann --- net/batman-adv/netlink.c | 143 +++ 1 file changed, 100 insertions(+), 43 deletions(-) diff --git a/net/batman-adv/netlink.c b/net/batman-adv/netlink.c index 5fe833cc..e56c40d1 100644 --- a/net/batman-adv/netlink.c +++ b/net/

[B.A.T.M.A.N.] [PATCH v5 07/19] batman-adv: Add bonding mesh genl configuration

2019-02-09 Thread Sven Eckelmann
will disable this feature and setting it to something else is enabling this feature. Signed-off-by: Sven Eckelmann --- include/uapi/linux/batman_adv.h | 6 ++ net/batman-adv/netlink.c| 11 +++ 2 files changed, 17 insertions(+) diff --git a/include/uapi/linux/batman_adv.h b

[B.A.T.M.A.N.] [PATCH v5 03/19] batman-adv: Prepare framework for hardif genl config

2019-02-09 Thread Sven Eckelmann
een changed and what the current values are. Signed-off-by: Sven Eckelmann --- include/uapi/linux/batman_adv.h | 16 ++- net/batman-adv/netlink.c| 240 +--- 2 files changed, 233 insertions(+), 23 deletions(-) diff --git a/include/uapi/linux/batman_adv.h b/include/uap

[B.A.T.M.A.N.] [PATCH v5 02/19] batman-adv: Prepare framework for mesh genl config

2019-02-09 Thread Sven Eckelmann
ht have been changed and what the current values are. Signed-off-by: Sven Eckelmann --- include/uapi/linux/batman_adv.h | 16 +++- net/batman-adv/netlink.c| 160 +++- 2 files changed, 111 insertions(+), 65 deletions(-) diff --git a/include/uapi/linux/batman_adv.h

[B.A.T.M.A.N.] [PATCH] batman-adv: Fix typo "reseved" -> "reserved"

2019-02-08 Thread Sven Eckelmann
+ * @flags: reseved for routing relevant flags - currently always 0 Signed-off-by: Sven Eckelmann --- include/uapi/linux/batadv_packet.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/uapi/linux/batadv_packet.h b/include/uapi/linux/batadv_packet.h index 7eb2936a..c9933

Re: [B.A.T.M.A.N.] Alfred problem reading other nodes

2019-02-08 Thread Sven Eckelmann
On Friday, 8 February 2019 16.58.46 CET beth.fli...@telegrid.com wrote: [...] > Unicast does not produce any errors at the sendto function and looks like it > is working but tcpdump doesn't see it and nothing gets to the receive side. > Tcpdump does see the multicast announcement packets. You

Re: [B.A.T.M.A.N.] [RFC v4 00/19] batman-adv: netlink restructuring, part 2

2019-02-07 Thread Sven Eckelmann
On Wednesday, 6 February 2019 20:08:14 CET Linus Lüssing wrote: > Ok, will rewrite the batctl part later then. And probably keep "batctl > mm" as a (hidden?) option for compatibility reasons? Yes, sounds good. Kind regards, Sven signature.asc Description: This is a digitally signed

Re: [B.A.T.M.A.N.] [patch 2/2] scripts/spdxcheck.py: Handle special quotation mark comments

2019-02-06 Thread Sven Eckelmann
On Sunday, 20 January 2019 19.39.55 CET Joe Perches wrote: > Well, maybe checkpatch should remove the comment trailer. > --- > Miscellanea: In case you are waiting for me (haven't seen it popping up in linux-next): yes, this patch solves the problem for me. Tested-by: Sven Eckelmann

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: fix memory leak in in batadv_dat_put_dhcp

2019-02-06 Thread Sven Eckelmann
On Wednesday, 6 February 2019 15.39.14 CET Martin Weinelt via B.A.T.M.A.N wrote: > Consume the skb to avoid leaking memory. > > Fixes: 1fd1ce2d383f ("batman-adv: Snoop DHCPACKs for DAT") > Signed-off-by: Martin Weinelt Good catch. I've modified the commit message to make it better

Re: [B.A.T.M.A.N.] [RFC v4 00/19] batman-adv: netlink restructuring, part 2

2019-02-06 Thread Sven Eckelmann
On Tuesday, 5 February 2019 20.24.10 CET Linus Lüssing wrote: [...] > Another thought, if all this is too vague for now... Yes, it is to vague for the integration in netlink :D > what about > ommiting the BATADV_ATTR_MULTICAST_(MODE)_ENABLED for now and use > a reverse logic instead? Like >

Re: [B.A.T.M.A.N.] Alfred problem reading other nodes

2019-02-06 Thread Sven Eckelmann
On Wednesday, 6 February 2019 17.56.00 CET beth.fli...@telegrid.com wrote: [...] > I am having a problem getting alfred retrieve info from other nodes. I am > running openwrt and alfred 2018.0. Which OpenWrt version should that be? There is no release with 2018.0 and the current version in

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: Increase purge timeout on DAT DHT candidates

2019-02-01 Thread Sven Eckelmann
On Friday, 11 January 2019 22.02.08 CET Linus Lüssing wrote: > Currently, the DHT_GET messages of the DAT will likely be left > unanswered due to the following issues: [...] > With this patch the purge timeout for local DAT cache entries and > entries submitted via a DHT_PUT message is

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: Add multicast-to-unicast support for multiple targets

2019-01-29 Thread Sven Eckelmann
On Saturday, 19 January 2019 07.14.22 CET Linus Lüssing wrote: [...] > + ret = batadv_send_skb_unicast(bat_priv, newskb, > + BATADV_UNICAST, 0, > + orig_entry->orig_node, vid); > + > + if

Re: [B.A.T.M.A.N.] [RFC v4 00/19] batman-adv: netlink restructuring, part 2

2019-01-26 Thread Sven Eckelmann
On Saturday, 19 January 2019 16.56.07 CET Sven Eckelmann wrote: [...] > There were also two topics which were not yet really discussed and thus > these requests (from Linus) were not yet implemented: @Jiri, @Linus maybe you can discuss these topics further and select the correct so

Re: [B.A.T.M.A.N.] [PATCH maint] batman-adv: release station info tidstats

2019-01-25 Thread Sven Eckelmann
On Friday, 25 January 2019 08.16.46 CET Berg, Johannes wrote: > Huh, sorry about that. > > > From: Felix Fietkau > > If Felix had nothing to do with the patch, why would you pretend otherwise? This is what he has dropped and Martin Weinelt forwarded to us:

[B.A.T.M.A.N.] [PATCH maint] batman-adv: release station info tidstats

2019-01-25 Thread Sven Eckelmann
11: dynamically allocate per-tid stats for station info") [s...@narfation.org: add commit message, add compat code] Signed-off-by: Sven Eckelmann --- Cc: Johannes Berg Cc: Arend van Spriel Felix Fietkau didn't really send this patch to us and thus also didn't signed it off. This is just a p

[B.A.T.M.A.N.] [PATCH] batman-adv: simplify ip_mc_check_igmp() and ipv6_mc_check_mld() calls

2019-01-25 Thread Sven Eckelmann
. Signed-off-by: Linus Lüssing Signed-off-by: David S. Miller [s...@narfation.org: Added compat code] Signed-off-by: Sven Eckelmann --- compat-include/linux/igmp.h | 12 +++- compat-include/net/addrconf.h | 12 +++- compat-sources/net/ipv4/igmp.c| 22

Re: [B.A.T.M.A.N.] [patch 2/2] scripts/spdxcheck.py: Handle special quotation mark comments

2019-01-20 Thread Sven Eckelmann
On Wednesday, 16 January 2019 11.26.53 CET Thomas Gleixner wrote: > The SuperH boot code files use a magic format for the SPDX identifier > comment: > > LIST "SPDX-License-Identifier: " > > The trailing quotation mark is not stripped before the token parser is > invoked and causes the

[B.A.T.M.A.N.] [RFC v4 18/19] batman-adv: Add throughput_override hardif genl configuration

2019-01-19 Thread Sven Eckelmann
commands allow to set/get the configuration of this feature using the u32 BATADV_ATTR_THROUGHPUT_OVERRIDE attribute. The used unit is in 100 Kbit/s. If the value is set to 0 then batman-adv will try to estimate the throughput by itself. Signed-off-by: Sven Eckelmann --- Cc: Antonio Quartulli

[B.A.T.M.A.N.] [RFC v4 15/19] batman-adv: Add network_coding mesh genl configuration

2019-01-19 Thread Sven Eckelmann
the BATADV_ATTR_NETWORK_CODING_ENABLED attribute. Setting the u8 to zero will disable this feature and setting it to something else is enabling this feature. Signed-off-by: Sven Eckelmann --- Cc: Martin Hundeboll Cc: Marek Lindner --- include/uapi/linux/batman_adv.h | 7 +++ net/batman-adv

[B.A.T.M.A.N.] [RFC v4 19/19] batman-adv: Trigger genl notification on sysfs config change

2019-01-19 Thread Sven Eckelmann
multicast group. Signed-off-by: Sven Eckelmann --- net/batman-adv/netlink.c | 10 +++ net/batman-adv/netlink.h | 6 net/batman-adv/sysfs.c | 63 +--- 3 files changed, 63 insertions(+), 16 deletions(-) diff --git a/net/batman-adv/netlink.c b/net/

[B.A.T.M.A.N.] [RFC v4 11/19] batman-adv: Add gateway mesh genl configuration

2019-01-19 Thread Sven Eckelmann
the attributes: * u8 BATADV_ATTR_GW_MODE (0 == off, 1 == client, 2 == server) * u32 BATADV_ATTR_GW_BANDWIDTH_DOWN (in 100 kbit/s steps) * u32 BATADV_ATTR_GW_BANDWIDTH_UP (in 100 kbit/s steps) * u32 BATADV_ATTR_GW_SEL_CLASS Signed-off-by: Sven Eckelmann --- Cc: Marek Lindner Cc: Antonio Quartulli

[B.A.T.M.A.N.] [RFC v4 13/19] batman-adv: Add log_level mesh genl configuration

2019-01-19 Thread Sven Eckelmann
attribute. Signed-off-by: Sven Eckelmann --- Cc: Marek Lindner --- include/uapi/linux/batman_adv.h | 6 ++ net/batman-adv/netlink.c| 17 + 2 files changed, 23 insertions(+) diff --git a/include/uapi/linux/batman_adv.h b/include/uapi/linux/batman_adv.h index b37cb923

[B.A.T.M.A.N.] [RFC v4 14/19] batman-adv: Add multicast_mode mesh genl configuration

2019-01-19 Thread Sven Eckelmann
to zero will disable this feature and setting it to something else is enabling this feature. Signed-off-by: Sven Eckelmann --- Cc: Linus Lüssing --- include/uapi/linux/batman_adv.h | 8 net/batman-adv/netlink.c| 15 +++ 2 files changed, 23 insertions(+) diff --git

[B.A.T.M.A.N.] [RFC v4 16/19] batman-adv: Add orig_interval mesh genl configuration

2019-01-19 Thread Sven Eckelmann
-by: Sven Eckelmann --- Cc: Marek Lindner --- include/uapi/linux/batman_adv.h | 6 ++ net/batman-adv/netlink.c| 17 + 2 files changed, 23 insertions(+) diff --git a/include/uapi/linux/batman_adv.h b/include/uapi/linux/batman_adv.h index 2f0dbcc0..5c18d454 100644

[B.A.T.M.A.N.] [RFC v4 17/19] batman-adv: Add elp_interval hardif genl configuration

2019-01-19 Thread Sven Eckelmann
BATADV_ATTR_ELP_INTERVAL attribute. Signed-off-by: Sven Eckelmann --- Cc: Linus Lüssing --- include/uapi/linux/batman_adv.h | 6 ++ net/batman-adv/netlink.c| 17 + 2 files changed, 23 insertions(+) diff --git a/include/uapi/linux/batman_adv.h b/include/uapi/linux/batman_adv.h index

[B.A.T.M.A.N.] [RFC v4 12/19] batman-adv: Add hop_penalty mesh genl configuration

2019-01-19 Thread Sven Eckelmann
allow to set/get the configuration of this feature using the u8 BATADV_ATTR_HOP_PENALTY attribute. Signed-off-by: Sven Eckelmann --- Cc: Linus Lüssing Cc: Marek Lindner Cc: Antonio Quartulli Cc: Simon Wunderlich --- include/uapi/linux/batman_adv.h | 6 ++ net/batman-adv/netlink.c

[B.A.T.M.A.N.] [RFC v4 05/19] batman-adv: Add aggregated_ogms mesh genl configuration

2019-01-19 Thread Sven Eckelmann
will disable this feature and setting it to something else is enabling this feature. Signed-off-by: Sven Eckelmann --- Cc: Marek Lindner --- include/uapi/linux/batman_adv.h | 6 ++ net/batman-adv/netlink.c| 12 2 files changed, 18 insertions(+) diff --git a/include/uapi/linux

[B.A.T.M.A.N.] [RFC v4 10/19] batman-adv: Add fragmentation mesh genl configuration

2019-01-19 Thread Sven Eckelmann
will disable this feature and setting it to something else is enabling this feature. Signed-off-by: Sven Eckelmann --- Cc: Andreas Langer Cc: Martin Hundeboll Cc: Marek Lindner --- include/uapi/linux/batman_adv.h | 7 +++ net/batman-adv/netlink.c| 12 2 files changed

[B.A.T.M.A.N.] [RFC v4 06/19] batman-adv: Add ap_isolation mesh/vlan genl configuration

2019-01-19 Thread Sven Eckelmann
attributes BATADV_ATTR_ISOLATION_MARK and BATADV_ATTR_ISOLATION_MASK. Signed-off-by: Sven Eckelmann --- Cc: Antonio Quartulli --- include/uapi/linux/batman_adv.h | 19 +++ net/batman-adv/netlink.c| 89 + 2 files changed, 108 insertions(+) diff --git a/include

[B.A.T.M.A.N.] [RFC v4 08/19] batman-adv: Add bridge_loop_avoidance mesh genl configuration

2019-01-19 Thread Sven Eckelmann
of this feature using the BATADV_ATTR_BRIDGE_LOOP_AVOIDANCE_ENABLED attribute. Setting the u8 to zero will disable this feature and setting it to something else is enabling this feature. Signed-off-by: Sven Eckelmann --- Cc: Simon Wunderlich --- include/uapi/linux/batman_adv.h | 7 +++ net/batman-adv

[B.A.T.M.A.N.] [RFC v4 07/19] batman-adv: Add bonding mesh genl configuration

2019-01-19 Thread Sven Eckelmann
will disable this feature and setting it to something else is enabling this feature. Signed-off-by: Sven Eckelmann --- Cc: Simon Wunderlich --- include/uapi/linux/batman_adv.h | 6 ++ net/batman-adv/netlink.c| 11 +++ 2 files changed, 17 insertions(+) diff --git a/include

[B.A.T.M.A.N.] [RFC v4 04/19] batman-adv: Prepare framework for vlan genl config

2019-01-19 Thread Sven Eckelmann
t; mcast group using the BATADV_CMD_SET_VLAN command message type that settings might have been changed and what the current values are. Signed-off-by: Sven Eckelmann --- include/uapi/linux/batman_adv.h | 17 +++ net/batman-adv/netlink.c| 191 +++- 2 files changed,

[B.A.T.M.A.N.] [RFC v4 09/19] batman-adv: Add distributed_arp_table mesh genl configuration

2019-01-19 Thread Sven Eckelmann
. Setting the u8 to zero will disable this feature and setting it to something else is enabling this feature. Signed-off-by: Sven Eckelmann --- Cc: Antonio Quartulli --- include/uapi/linux/batman_adv.h | 8 net/batman-adv/netlink.c| 17 + 2 files changed, 25

[B.A.T.M.A.N.] [RFC v4 02/19] batman-adv: Prepare framework for mesh genl config

2019-01-19 Thread Sven Eckelmann
ht have been changed and what the current values are. Signed-off-by: Sven Eckelmann --- include/uapi/linux/batman_adv.h | 16 +++- net/batman-adv/netlink.c| 160 +++- 2 files changed, 111 insertions(+), 65 deletions(-) diff --git a/include/uapi/linux/batman_adv.h

[B.A.T.M.A.N.] [RFC v4 00/19] batman-adv: netlink restructuring, part 2

2019-01-19 Thread Sven Eckelmann
e format. Kind regards, Sven [1] https://www.open-mesh.org/issues/300 [2] https://patchwork.open-mesh.org/cover/17610/ Sven Eckelmann (19): batman-adv: Move common genl doit code pre/post hooks batman-adv: Prepare framework for mesh genl config batman-adv: Prepare framework for

[B.A.T.M.A.N.] [RFC v4 03/19] batman-adv: Prepare framework for hardif genl config

2019-01-19 Thread Sven Eckelmann
een changed and what the current values are. Signed-off-by: Sven Eckelmann --- include/uapi/linux/batman_adv.h | 16 ++- net/batman-adv/netlink.c| 240 +--- 2 files changed, 233 insertions(+), 23 deletions(-) diff --git a/include/uapi/linux/batman_adv.h b/include/uap

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: Add multicast-to-unicast support for multiple targets

2019-01-19 Thread Sven Eckelmann
On Saturday, 19 January 2019 07.14.22 CET Linus Lüssing wrote: [...] > This patch introduces a new sysfs parameter even though upstream has > signalized that we should switch to / add netlink support for > configuration. > > If upstream were to complain about yet another sysfs-only parameter, I'd

[B.A.T.M.A.N.] [PATCH] batman-adv: Remove 'type' argument from access_ok() function

2019-01-08 Thread Sven Eckelmann
-by: Sven Eckelmann --- Original commit: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=96d4f267e40f9509e8a66e2b39e8b95655617693 compat-include/linux/uaccess.h | 44 ++ net/batman-adv/icmp_socket.c | 2 +- net/batman-adv/log.c

Re: [B.A.T.M.A.N.] [RFC v3 02/19] batman-adv: Prepare framework for mesh genl config

2019-01-07 Thread Sven Eckelmann
On Monday, 7 January 2019 19.49.06 CET Linus Lüssing wrote: [...] > I seem to be able to trigger a null pointer dereference for this > batadv_hardif_put() call here. With the following steps I end up > with a primary_if == NULL: > > $ batctl if add 1 > > root@Linus-Debian:~# batctl o > Error -

Re: [B.A.T.M.A.N.] [RFC v4 00/20] batctl: netlink restructuring, part 3

2019-01-07 Thread Sven Eckelmann
On Monday, 7 January 2019 19.57.13 CET Linus Lüssing wrote: [...] > Is "batctl if" supposed to use netlink to get the interface status > yet? > > Currently, with the items in *_attr[] in sysfs.c in batman-adv > commented out, I get these errors: > > --- > root@Linus-Debian:~# batctl if > ens3:

Re: [B.A.T.M.A.N.] [RFC v3 03/19] batman-adv: Prepare framework for hardif genl config

2019-01-05 Thread Sven Eckelmann
On Saturday, 5 January 2019 16.12.24 CET Linus Lüssing wrote: [...] > > > often with these net_device reference counters...) Same for > > > batadv_get_softif_from_info(). > > > > No, no, no, no, no, no, no and again no. The net_device is the only thing > > with > > a refcounter here. The

Re: [B.A.T.M.A.N.] [RFC v3 05/19] batman-adv: Add aggregated_ogms mesh genl configuration

2019-01-04 Thread Sven Eckelmann
On Friday, 4 January 2019 02.40.06 CET Linus Lüssing wrote: > On Fri, Dec 07, 2018 at 02:58:32PM +0100, Sven Eckelmann wrote: > > + /** > > +* @BATADV_ATTR_AGGREGATED_OGMS: whether the batman protocol messages > > +* of the mesh mesh interfac

Re: [B.A.T.M.A.N.] [RFC v3 19/19] batman-adv: Trigger genl notification on sysfs config change

2019-01-03 Thread Sven Eckelmann
On Friday, 4 January 2019 03.29.16 CET Linus Lüssing wrote: [...] > I'm wondering, before it was quite easy to add new sysfs > attributes with just a few lines thanks to macros. Now we > need to add code in four more places in netlink.c whenever we introduce a > new configuration option. > >

Re: [B.A.T.M.A.N.] [RFC v3 03/19] batman-adv: Prepare framework for hardif genl config

2019-01-03 Thread Sven Eckelmann
On Friday, 4 January 2019 01.39.54 CET Linus Lüssing wrote: > On Fri, Dec 07, 2018 at 02:58:30PM +0100, Sven Eckelmann wrote: > [...] > > +/** > > + * batadv_get_hardif_from_info() - Retrieve hardif from genl attributes > > + * @bat_priv: the bat priv with all the so

Re: [B.A.T.M.A.N.] [RFC v3 14/19] batman-adv: Add multicast_mode mesh genl configuration

2019-01-03 Thread Sven Eckelmann
On Friday, 4 January 2019 02.57.26 CET Linus Lüssing wrote: > On Fri, Dec 07, 2018 at 02:58:41PM +0100, Sven Eckelmann wrote: > > diff --git a/net/batman-adv/netlink.c b/net/batman-adv/netlink.c > > index 8e3a1b6e..32762003 100644 > > --- a/net/batman-adv/netlink.c >

[B.A.T.M.A.N.] [PATCH 0/3] batman-adv & co: Update copyright years for 2019

2018-12-31 Thread Sven Eckelmann
Hi, here is just the annual update of the copyright years for batman-adv, batctl and alfred. Kind regards, Sven Sven Eckelmann (1): alfred: Update copyright years for 2019 batctl: Update copyright years for 2019 batman-adv: Update copyright years for 2019 -- 2.19.2

[B.A.T.M.A.N.] [PATCH 2/3] alfred: Update copyright years for 2019

2018-12-31 Thread Sven Eckelmann
Signed-off-by: Sven Eckelmann --- Makefile | 2 +- alfred.h | 2 +- batadv_query.c | 2 +- batadv_query.h | 2 +- batadv_querynl.c | 2 +- batadv_querynl.h | 2 +- batman_adv.h | 2 +- bitops.h | 2 +- client.c | 2 +- gpsd/Makefile

[B.A.T.M.A.N.] [PATCH 3/3] batctl: Update copyright years for 2019

2018-12-31 Thread Sven Eckelmann
Signed-off-by: Sven Eckelmann --- Makefile| 2 +- aggregation.c | 2 +- allocate.h | 2 +- ap_isolation.c | 2 +- backbonetable.c | 2 +- bat-hosts.c | 2 +- bat-hosts.h | 2 +- batadv_packet.h | 2

[B.A.T.M.A.N.] [PATCH 1/3] batman-adv: Update copyright years for 2019

2018-12-31 Thread Sven Eckelmann
Signed-off-by: Sven Eckelmann --- Makefile | 2 +- compat-include/linux/average.h | 2 +- compat-include/linux/build_bug.h | 2 +- compat-include/linux/cache.h | 2 +- compat-include/linux/compiler.h| 3 ++- compat-include/linux

[B.A.T.M.A.N.] [PATCH maint] batman-adv: Force mac header to start of data on xmit

2018-12-31 Thread Sven Eckelmann
) Reported-by: syzbot+9d7405c7faa390e60...@syzkaller.appspotmail.com Reported-by: syzbot+7d20bc3f1c0f9...@syzkaller.appspotmail.com Signed-off-by: Sven Eckelmann --- Cc: syzkaller-b...@googlegroups.com --- net/batman-adv/soft-interface.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/net/

Re: [B.A.T.M.A.N.] [RFC v3 03/19] batman-adv: Prepare framework for hardif genl config

2018-12-31 Thread Sven Eckelmann
On Monday, 31 December 2018 12.59.36 CET Linus Lüssing wrote: [...] > > static int batadv_pre_doit(const struct genl_ops *ops, struct sk_buff *skb, > >struct genl_info *info) > > { > > - struct batadv_priv *bat_priv; > > + struct batadv_hard_iface *hard_iface; > > +

Re: [B.A.T.M.A.N.] [RFC v3 02/19] batman-adv: Prepare framework for mesh genl config

2018-12-31 Thread Sven Eckelmann
On Monday, 31 December 2018 12.09.50 CET Linus Lüssing wrote: [...] > [...] > > > #ifdef CONFIG_BATMAN_ADV_BLA > > if (nla_put_u16(msg, BATADV_ATTR_BLA_CRC, > > ntohs(bat_priv->bla.claim_dest.group))) > > - goto out; > > + goto nla_put_failure; > >

Re: [B.A.T.M.A.N.] [RFC v3 01/19] batman-adv: Move common genl doit code pre/post hooks

2018-12-31 Thread Sven Eckelmann
On Sunday, 30 December 2018 17.57.54 CET Linus Lüssing wrote: > On Fri, Dec 07, 2018 at 02:58:28PM +0100, Sven Eckelmann wrote: > > +/** > > + * batadv_get_softif_from_info() - Retrieve soft interface from genl attributes > > + * @net: the applicable net namespace &g

Re: [B.A.T.M.A.N.] [PATCH v7] batman-adv: Snoop DHCPACKs for DAT

2018-12-30 Thread Sven Eckelmann
On Saturday, 29 December 2018 04.10.40 CET Linus Lüssing wrote: > +#define BATADV_DHCP_YIADDR_LEN sizeof(((struct batadv_dhcp_packet > *)0)->chaddr) > +#define BATADV_DHCP_CHADDR_LEN sizeof(((struct batadv_dhcp_packet > *)0)->chaddr) Why do you use chaddr to calculate the size of yiaddr? yiaddr

[B.A.T.M.A.N.] [PATCH maint] batman-adv: Avoid WARN on net_device without parent in netns

2018-12-30 Thread Sven Eckelmann
eated on batman-adv as hard-interface") Reported-by: syzbot+c764de0fcfadca9a8...@syzkaller.appspotmail.com Reported-by: Dmitry Vyukov Signed-off-by: Sven Eckelmann --- Cc: syzbot Cc: Dmitry Vyukov Cc: syzkaller-b...@googlegroups.com --- net/batman-adv/hard-interface.c | 5 +++-- 1 file

Re: [B.A.T.M.A.N.] WARNING in batadv_is_on_batman_iface

2018-12-30 Thread Sven Eckelmann
On Sunday, 30 December 2018 11.41.03 CET syzbot wrote: [...] > HEAD commit:d8924c0d76aa Merge tag 'devprop-4.21-rc1' of git://git.ker.. > git tree: upstream > console output: https://syzkaller.appspot.com/x/log.txt?x=122a373f40 > kernel config:

Re: [B.A.T.M.A.N.] [PATCH] batman-adv/main: Fix check on return value of rtnl_link_register

2018-12-24 Thread Sven Eckelmann
On Monday, 24 December 2018 18.49.26 CET Aditya Pakki wrote: > rtnl_link_register() may fail and can impact registering the device. > The fix checks the return value and pushes the error upstream. Regarding the commit message - what is "batman-adv/main"? Shouldn't this be "batman-adv: "? And

Re: [B.A.T.M.A.N.] [PATCH] batman-adv/main: Fix check on return value of rtnl_link_register

2018-12-24 Thread Sven Eckelmann
On Monday, 24 December 2018 18.49.26 CET Aditya Pakki wrote: [...] > diff --git a/net/batman-adv/main.c b/net/batman-adv/main.c > index 69c0d85bceb3..e0007f242823 100644 > --- a/net/batman-adv/main.c > +++ b/net/batman-adv/main.c > @@ -109,7 +109,10 @@ static int __init batadv_init(void) >

Re: [B.A.T.M.A.N.] gw_mode & vlan

2018-12-20 Thread Sven Eckelmann
On Thursday, 20 December 2018 11.09.01 CET Sylvain PRUDENT wrote: > A lot of clients may connect to the lan so I would like to use gateway > mode (client/server) feature to avoid dhcp broadcast storms. > Is it possible to use gw_mode for the main lan network without affecting > dhcp traffic on

[B.A.T.M.A.N.] [PATCH 2/2] batctl: Drop incorrect check for existing meshif directory

2018-12-07 Thread Sven Eckelmann
module. Consult the README if you wish to learn more about compiling options into batman-adv. And for routing_algo, the problem of the missing batman-adv module should already be catched when the batman-adv module version path is checked. Reported-by: Andre Kasper Signed-off-by: Sven Eckelmann

[B.A.T.M.A.N.] [PATCH 1/2] batctl: Remove check of compiled_out files

2018-12-07 Thread Sven Eckelmann
therefore be printed for read/writes from/to all files when the caller didn't ask to disable error messages. Signed-off-by: Sven Eckelmann --- bridge_loop_avoidance.c | 2 +- distributed_arp_table.c | 2 +- functions.c | 36 +--- loglevel.c

[B.A.T.M.A.N.] [PATCH] batctl: Rename option_watch_interval to option_timeout_interval

2018-12-07 Thread Sven Eckelmann
The watch interval is actually a different option for debug tables which uses the parameter '-w'. The configuration to enable/disable the parameter to set the timeout for not displaying not seen originators should therefore use a different name. Signed-off-by: Sven Eckelmann --- debug.c

[B.A.T.M.A.N.] [RFC v4 17/20] batctl: Support generic netlink for fragmentation command

2018-12-07 Thread Sven Eckelmann
the commands BATADV_CMD_SET_MESH/BATADV_CMD_GET_MESH to set/get the configuration of the u8 (boolean) BATADV_ATTR_FRAGMENTATION attribute. Signed-off-by: Sven Eckelmann --- Cc: Andreas Langer Cc: Martin Hundeboll Cc: Marek Lindner --- fragmentation.c | 45 +++-- 1

[B.A.T.M.A.N.] [RFC v4 15/20] batctl: Support generic netlink for bridge_loop_avoidance command

2018-12-07 Thread Sven Eckelmann
the commands BATADV_CMD_SET_MESH/BATADV_CMD_GET_MESH to set/get the configuration of the u8 (boolean) BATADV_ATTR_BRIDGE_LOOP_AVOIDANCE attribute. Signed-off-by: Sven Eckelmann --- Cc: Simon Wunderlich --- bridge_loop_avoidance.c | 46 +++-- 1 file changed, 44

[B.A.T.M.A.N.] [RFC v4 20/20] batctl: Drop settings_date param lists

2018-12-07 Thread Sven Eckelmann
The parsing and validation of the settings command parameters is handled by the parse function. The params struct member is therefore no longer used and can just be dropped. Signed-off-by: Sven Eckelmann --- sys.c | 32 sys.h | 3 --- 2 files changed, 35

[B.A.T.M.A.N.] [RFC v4 16/20] batctl: Support generic netlink for distributed_arp_table command

2018-12-07 Thread Sven Eckelmann
the commands BATADV_CMD_SET_MESH/BATADV_CMD_GET_MESH to set/get the configuration of the u8 (boolean) BATADV_ATTR_DISTRIBUTED_ARP_TABLE attribute. Signed-off-by: Sven Eckelmann --- Cc: Antonio Quartulli --- distributed_arp_table.c | 46 +++-- 1 file changed, 44

[B.A.T.M.A.N.] [RFC v4 18/20] batctl: Support generic netlink for multicast_mode command

2018-12-07 Thread Sven Eckelmann
the commands BATADV_CMD_SET_MESH/BATADV_CMD_GET_MESH to set/get the configuration of the u8 (boolean) BATADV_ATTR_MULTICAST_MODE attribute. Signed-off-by: Sven Eckelmann --- Cc: Linus Lüssing --- multicast_mode.c | 45 +++-- 1 file changed, 43 insertions(+), 2

[B.A.T.M.A.N.] [RFC v4 19/20] batctl: Support generic netlink for network_coding command

2018-12-07 Thread Sven Eckelmann
the commands BATADV_CMD_SET_MESH/BATADV_CMD_GET_MESH to set/get the configuration of the u8 (boolean) BATADV_ATTR_NETWORK_CODING attribute. Signed-off-by: Sven Eckelmann --- Cc: Martin Hundeboll Cc: Marek Lindner --- network_coding.c | 45 +++-- 1 file changed, 43

[B.A.T.M.A.N.] [RFC v4 14/20] batctl: Support generic netlink for bonding command

2018-12-07 Thread Sven Eckelmann
BATADV_CMD_SET_MESH/BATADV_CMD_GET_MESH to set/get the configuration of the u8 (boolean) BATADV_ATTR_BONDING attribute. Signed-off-by: Sven Eckelmann --- Cc: Simon Wunderlich --- bonding.c | 45 +++-- 1 file changed, 43 insertions(+), 2 deletions(-) diff

[B.A.T.M.A.N.] [RFC v4 13/20] batctl: Support generic netlink for ap_isolation command

2018-12-07 Thread Sven Eckelmann
the commands BATADV_CMD_SET_MESH/BATADV_CMD_GET_MESH and BATADV_CMD_SET_VLAN/BATADV_CMD_GET_VLAN to set/get the configuration of the u8 (boolean) BATADV_ATTR_AP_ISOLATION attribute. Signed-off-by: Sven Eckelmann --- Cc: Antonio Quartulli --- ap_isolation.c | 67

[B.A.T.M.A.N.] [RFC v4 11/20] batctl: Add helper to read/write boolean configuration values

2018-12-07 Thread Sven Eckelmann
settings command implementation. Signed-off-by: Sven Eckelmann --- functions.c | 17 + functions.h | 1 + sys.c | 55 + sys.h | 8 4 files changed, 81 insertions(+) diff --git a/functions.c b/functions.c index

[B.A.T.M.A.N.] [RFC v4 12/20] batctl: Support generic netlink for aggregation command

2018-12-07 Thread Sven Eckelmann
BATADV_CMD_SET_MESH/BATADV_CMD_GET_MESH to set/get the configuration of the u8 (boolean) BATADV_ATTR_AGGREGATED_OGMS attribute. Signed-off-by: Sven Eckelmann --- Cc: Marek Lindner --- aggregation.c | 45 +++-- 1 file changed, 43 insertions(+), 2 deletions

[B.A.T.M.A.N.] [RFC v4 07/20] batctl: Support generic netlink for gw_mode command

2018-12-07 Thread Sven Eckelmann
BATADV_ATTR_GW_SEL_CLASS - 1-255 for BATMAN_IV - 1-UINT32_MAX for BATMAN_V Signed-off-by: Sven Eckelmann --- Cc: Marek Lindner Cc: Antonio Quartulli --- gw_mode.c | 275 -- 1 file changed, 206 insertions(+), 69 deletions(-) diff --git a/gw_mode.c b

[B.A.T.M.A.N.] [RFC v4 09/20] batctl: Support generic netlink for isolation_mark command

2018-12-07 Thread Sven Eckelmann
the commands BATADV_CMD_SET_MESH/BATADV_CMD_GET_MESH to set/get the configuration of the mark/mask using the u32 attributes BATADV_ATTR_ISOLATION_MARK and BATADV_ATTR_ISOLATION_MASK. Signed-off-by: Sven Eckelmann --- Cc: Antonio Quartulli --- isolation_mark.c | 123

[B.A.T.M.A.N.] [RFC v4 06/20] batctl: Add netlink simple query helper

2018-12-07 Thread Sven Eckelmann
the reply message (callback) The sys_simple_nlquery provides this but requires that the netlink socket and the single use nl_cb was allocated by the initialization helper via COMMAND_FLAG_MESH_IFACE. Signed-off-by: Sven Eckelmann --- sys.c | 59

[B.A.T.M.A.N.] [RFC v4 08/20] batctl: Support generic netlink for loglevel command

2018-12-07 Thread Sven Eckelmann
BATADV_CMD_SET_MESH/BATADV_CMD_GET_MESH to set/get the configuration of this feature using the u32 (bitmask) BATADV_ATTR_LOG_LEVEL attribute. Signed-off-by: Sven Eckelmann --- Cc: Marek Lindner --- loglevel.c | 138 ++--- 1 file changed, 110

[B.A.T.M.A.N.] [RFC v4 10/20] batctl: Support generic netlink for orig_interval command

2018-12-07 Thread Sven Eckelmann
the commands BATADV_CMD_SET_MESH/BATADV_CMD_GET_MESH to set/get the configuration of the u32 BATADV_ATTR_ORIG_INTERVAL attribute. Signed-off-by: Sven Eckelmann --- Cc: Marek Lindner --- orig_interval.c | 84 +++-- 1 file changed, 82 insertions(+), 2 deletions

[B.A.T.M.A.N.] [RFC v4 05/20] batctl: Parse the arguments for gw_mode

2018-12-07 Thread Sven Eckelmann
The generic netlink interface requires that the configuration settings are parsed in userspace. But it can also be used to do a more fine grained validation of the input data before it is written to the sysfs files. Signed-off-by: Sven Eckelmann --- Cc: Marek Lindner Cc: Antonio Quartulli

[B.A.T.M.A.N.] [RFC v4 04/20] batctl: Add settings_data hooks for netlink integration

2018-12-07 Thread Sven Eckelmann
. Signed-off-by: Sven Eckelmann --- sys.c | 56 sys.h | 4 2 files changed, 56 insertions(+), 4 deletions(-) diff --git a/sys.c b/sys.c index be20be7..e883369 100644 --- a/sys.c +++ b/sys.c @@ -63,6 +63,47 @@ static void settings_usage

[B.A.T.M.A.N.] [RFC v4 02/20] batctl: Don't allocate new buffer for vlan parent device

2018-12-07 Thread Sven Eckelmann
The buffer size is limited by IF_NAMESIZE and can easily be stored on the stack. This will also make it easier to store this as part of the the state of batctl. Signed-off-by: Sven Eckelmann --- functions.c | 23 ++- functions.h | 2 +- sys.c | 6 +++--- 3 files

[B.A.T.M.A.N.] [RFC v4 03/20] batctl: Automatically translate vlan to mesh_iface

2018-12-07 Thread Sven Eckelmann
before the rest of the program runs. Signed-off-by: Sven Eckelmann --- functions.c | 34 ++ functions.h | 6 -- gateways.c| 10 ++ main.c| 10 ++ main.h| 6 +- mcast_flags.c | 10 ++ netlink.c | 12

[B.A.T.M.A.N.] [RFC v4 01/20] batctl: Add support for config mcast group in event monitor

2018-12-07 Thread Sven Eckelmann
The netlink set netlink messages issued by the config subcommands get as reply a multicast message with the new value. The event monitor should show these messages similar to the tp_meter results. Signed-off-by: Sven Eckelmann --- batman_adv.h | 188

[B.A.T.M.A.N.] [RFC v4 00/20] batctl: netlink restructuring, part 3

2018-12-07 Thread Sven Eckelmann
kernel-doc in batman_adv.h * add three patches to use the netlink interface with the already existing setting commands v2: * drop of generic config command * reimplementation of the event command Kind regards, Sven Sven Eckelmann (20): batctl: Add support for config mcast group in event

[B.A.T.M.A.N.] [RFC v3 17/19] batman-adv: Add elp_interval hardif genl configuration

2018-12-07 Thread Sven Eckelmann
BATADV_ATTR_ELP_INTERVAL attribute. Signed-off-by: Sven Eckelmann --- Cc: Linus Lüssing --- include/uapi/linux/batman_adv.h | 6 ++ net/batman-adv/netlink.c| 17 + 2 files changed, 23 insertions(+) diff --git a/include/uapi/linux/batman_adv.h b/include/uapi/linux/batman_adv.h index

[B.A.T.M.A.N.] [RFC v3 16/19] batman-adv: Add orig_interval mesh genl configuration

2018-12-07 Thread Sven Eckelmann
-by: Sven Eckelmann --- Cc: Marek Lindner --- include/uapi/linux/batman_adv.h | 6 ++ net/batman-adv/netlink.c| 17 + 2 files changed, 23 insertions(+) diff --git a/include/uapi/linux/batman_adv.h b/include/uapi/linux/batman_adv.h index 7e8a086f..b8cb26d2 100644

[B.A.T.M.A.N.] [RFC v3 19/19] batman-adv: Trigger genl notification on sysfs config change

2018-12-07 Thread Sven Eckelmann
multicast group. Signed-off-by: Sven Eckelmann --- net/batman-adv/netlink.c | 10 +++ net/batman-adv/netlink.h | 6 net/batman-adv/sysfs.c | 63 +--- 3 files changed, 63 insertions(+), 16 deletions(-) diff --git a/net/batman-adv/netlink.c b/net/

[B.A.T.M.A.N.] [RFC v3 18/19] batman-adv: Add throughput_override hardif genl configuration

2018-12-07 Thread Sven Eckelmann
commands allow to set/get the configuration of this feature using the u32 BATADV_ATTR_THROUGHPUT_OVERRIDE attribute. The used unit is in 100 Kbit/s. If the value is set to 0 then batman-adv will try to estimate the throughput by itself. Signed-off-by: Sven Eckelmann --- Cc: Antonio Quartulli

[B.A.T.M.A.N.] [RFC v3 15/19] batman-adv: Add network_coding mesh genl configuration

2018-12-07 Thread Sven Eckelmann
the BATADV_ATTR_NETWORK_CODING attribute. Setting the u8 to zero will disable this feature and setting it to something else is enabling this feature. Signed-off-by: Sven Eckelmann --- Cc: Martin Hundeboll Cc: Marek Lindner --- include/uapi/linux/batman_adv.h | 7 +++ net/batman-adv/netlink.c

[B.A.T.M.A.N.] [RFC v3 13/19] batman-adv: Add log_level mesh genl configuration

2018-12-07 Thread Sven Eckelmann
attribute. Signed-off-by: Sven Eckelmann --- Cc: Marek Lindner --- include/uapi/linux/batman_adv.h | 6 ++ net/batman-adv/netlink.c| 17 + 2 files changed, 23 insertions(+) diff --git a/include/uapi/linux/batman_adv.h b/include/uapi/linux/batman_adv.h index 7cc69802

[B.A.T.M.A.N.] [RFC v3 14/19] batman-adv: Add multicast_mode mesh genl configuration

2018-12-07 Thread Sven Eckelmann
will disable this feature and setting it to something else is enabling this feature. Signed-off-by: Sven Eckelmann --- Cc: Linus Lüssing --- include/uapi/linux/batman_adv.h | 8 net/batman-adv/netlink.c| 15 +++ 2 files changed, 23 insertions(+) diff --git a/include

[B.A.T.M.A.N.] [RFC v3 08/19] batman-adv: Add bridge_loop_avoidance mesh genl configuration

2018-12-07 Thread Sven Eckelmann
of this feature using the BATADV_ATTR_BRIDGE_LOOP_AVOIDANCE attribute. Setting the u8 to zero will disable this feature and setting it to something else is enabling this feature. Signed-off-by: Sven Eckelmann --- Cc: Simon Wunderlich --- include/uapi/linux/batman_adv.h | 7 +++ net/batman-adv

[B.A.T.M.A.N.] [RFC v3 09/19] batman-adv: Add distributed_arp_table mesh genl configuration

2018-12-07 Thread Sven Eckelmann
the u8 to zero will disable this feature and setting it to something else is enabling this feature. Signed-off-by: Sven Eckelmann --- Cc: Antonio Quartulli --- include/uapi/linux/batman_adv.h | 8 net/batman-adv/netlink.c| 17 + 2 files changed, 25 insertions

[B.A.T.M.A.N.] [RFC v3 10/19] batman-adv: Add fragmentation mesh genl configuration

2018-12-07 Thread Sven Eckelmann
will disable this feature and setting it to something else is enabling this feature. Signed-off-by: Sven Eckelmann --- Cc: Andreas Langer Cc: Martin Hundeboll Cc: Marek Lindner --- include/uapi/linux/batman_adv.h | 7 +++ net/batman-adv/netlink.c| 12 2 files changed, 19

[B.A.T.M.A.N.] [RFC v3 12/19] batman-adv: Add hop_penalty mesh genl configuration

2018-12-07 Thread Sven Eckelmann
allow to set/get the configuration of this feature using the u8 BATADV_ATTR_HOP_PENALTY attribute. Signed-off-by: Sven Eckelmann --- Cc: Linus Lüssing Cc: Marek Lindner Cc: Antonio Quartulli Cc: Simon Wunderlich --- include/uapi/linux/batman_adv.h | 6 ++ net/batman-adv/netlink.c

<    2   3   4   5   6   7   8   9   10   11   >