Re: [PATCH] batman-adv: Don't skb_split skbuffs with frag_list

On Sat, Apr 16, 2022 at 07:17:28PM +0200, Sven Eckelmann wrote: > On Saturday, 16 April 2022 16:21:19 CEST Andrew Lunn wrote: > > This is not an area of the kernel i'm very familiar with. But i'm > > wondering, is this a BATMAN specific problem, or a generic problem? >

Re: [PATCH] batman-adv: Don't skb_split skbuffs with frag_list

On Sat, Apr 16, 2022 at 02:24:34PM +0200, Sven Eckelmann wrote: > The receiving interface might have used GRO to receive more fragments than > MAX_SKB_FRAGS fragments. In this case, these will not be stored in > skb_shinfo(skb)->frags but merged into the frag list. > > batman-adv relies on the

Re: [B.A.T.M.A.N.] [PATCH 8/9] batman-adv: Change batman_adv.h license to MIT

damn lies, and statistics", but everything with an SPDX tag has some form of GPL/LGPL. Now, adding SPDX tags is a new activity, and adding the GPLs tags have been done first, since they are easier to do. So it could be there are a lot of UAPI header files which are not {L}GPL. Also, given th

Re: [B.A.T.M.A.N.] wired performance

> And there is currently no special batman-adv support for the flow > dissector [1] in the kernel. This could be also a reason why multiple flows > are not distributed well to different cores when you enable RPS/XPS. It is > not > yet know whether this will actually be helpful but at least

Re: [B.A.T.M.A.N.] Interface limit 127 in bat0?!

Hi Jens The script i just used is: # add one if per 3 second and give output, also monitor dmesg dmesg -w & for i in `seq 1 255`; do # one interface ip link add gre$i type gretap local 192.168.99.1 remote 192.168.3.$i ttl 255 dev lan1 ip link set up dev gre$i batctl if add gre$i

Re: [B.A.T.M.A.N.] Interface limit 127 in bat0?!

> |Error - can't write to file > '/sys/class/net/gre127/batman_adv/mesh_iface': Cannot allocate memory| As the message suggests, you are out of memory. This is not a BATMAN limit, it is a limit from the amount of RAM you have in your device. Andrew

Re: [B.A.T.M.A.N.] limit of if per batman

On Wed, Jan 25, 2017 at 03:21:58AM +0100, jens wrote: > On 24.01.2017 14:39, Sven Eckelmann wrote: > > There is no artificial limit added by batman-adv. But transmitting a lot of > > broadcasts over 255 virtual links sharing the same physical link > > might get interesting (independent of

[B.A.T.M.A.N.] [PATCH v7 09/11] batman-adv: add B.A.T.M.A.N. Dump gateways via netlink

Dump the list of gateways via the netlink socket. Signed-off-by: Andrew Lunn <and...@lunn.ch> --- include/uapi/linux/batman_adv.h | 8 +++ net/batman-adv/gateway_client.c | 148 net/batman-adv/gateway_client.h | 2 + net/batman-adv/net

[B.A.T.M.A.N.] [PATCH v7 11/11] batman-adv: Indicate netlink socket can be used with netns.

Set the netnsof flag on the family structure, indicating it can be used with different network name spaces. Signed-off-by: Andrew Lunn <and...@lunn.ch> --- net/batman-adv/netlink.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/batman-adv/netlink.c b/net/batman-adv/netlink.c

[B.A.T.M.A.N.] [PATCH v7 10/11] batman-adv: add B.A.T.M.A.N. Dump BLA claims via netlink

Dump the list of bridge loop avoidance claims via the netlink socket. Signed-off-by: Andrew Lunn <and...@lunn.ch> --- include/uapi/linux/batman_adv.h| 12 +++ net/batman-adv/bridge_loop_avoidance.c | 166 + net/batman-adv/bridge_loop_avoidance.h

[B.A.T.M.A.N.] [PATCH v7 08/11] batman-adv: add B.A.T.M.A.N. V bat_{orig, neigh}_dump implementations

From: Matthias Schiffer <mschif...@universe-factory.net> Dump the algo V originators and neighbours. Signed-off-by: Matthias Schiffer <mschif...@universe-factory.net> Signed-off-by: Andrew Lunn <and...@lunn.ch> --- include/uapi/linux/batman_adv.h | 2 + net/batman-adv/bat_

[B.A.T.M.A.N.] [PATCH v7 07/11] batman-adv: add B.A.T.M.A.N. IV bat_{orig, neigh}_dump implementations

From: Matthias Schiffer <mschif...@universe-factory.net> Signed-off-by: Matthias Schiffer <mschif...@universe-factory.net> Signed-off-by: Andrew Lunn <and...@lunn.ch> --- include/uapi/linux/batman_adv.h | 4 + net/batman-adv/bat_iv_ogm.c | 359 +++

[B.A.T.M.A.N.] [PATCH v7 03/11] batman-adv: netlink: add routing_algo query

From: Matthias Schiffer <mschif...@universe-factory.net> BATADV_CMD_GET_ROUTING_ALGOS is used to get the list of supported routing algorithms. Signed-off-by: Matthias Schiffer <mschif...@universe-factory.net> Signed-off-by: Andrew Lunn <and...@lunn.ch> [sven.eckelm...@ope

[B.A.T.M.A.N.] [PATCH v7 04/11] batman-adv: netlink: hardif query

From: Matthias Schiffer <mschif...@universe-factory.net> BATADV_CMD_GET_HARDIFS will return the list of hardifs (including index, name and MAC address) of all hardifs for a given softif. Signed-off-by: Matthias Schiffer <mschif...@universe-factory.net> Signed-off-by: Andrew Lunn <

[B.A.T.M.A.N.] [PATCH v7 06/11] batman-adv: netlink: add originator and neighbor table queries

tthias Schiffer <mschif...@universe-factory.net> Signed-off-by: Andrew Lunn <and...@lunn.ch> --- include/uapi/linux/batman_adv.h | 4 + net/batman-adv/netlink.c| 13 net/batman-adv/originator.c | 160 net/batman-adv/originator.

[B.A.T.M.A.N.] [PATCH v7 05/11] batman-adv: netlink: add translation table query

expose it as part of the netlink API. Signed-off-by: Matthias Schiffer <mschif...@universe-factory.net> Signed-off-by: Andrew Lunn <and...@lunn.ch> --- include/uapi/linux/batman_adv.h| 58 ++ net/batman-adv/netlink.c | 24 ++- net/batman-adv/netlink.h | 1

[B.A.T.M.A.N.] [PATCH v7 01/11] batman-adv: Handle parent interfaces in a different netns

the parents name space when finding the parent and use it when doing the comparison. Signed-off-by: Andrew Lunn <and...@lunn.ch> Signed-off-by: Sven Eckelmann <s...@narfation.org> Acked-by: Antonio Quartulli <a...@untable.cc> --- compat.h| 7 ++ n

[B.A.T.M.A.N.] [PATCH v7 02/11] batman-adv: Suppress debugfs entries for netns's

, but there will soon be a netlink interface which is netns aware. Signed-off-by: Andrew Lunn <and...@lunn.ch> --- net/batman-adv/debugfs.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/net/batman-adv/debugfs.c b/net/batman-adv/debugfs.c index f187a8f..50545b0

[B.A.T.M.A.N.] [PATCH v7 00/11] netns and netlink support

. Note: BLA is untested, so best assume it is broken... v7: Fix compat.h get_link_net() - Thanks Sven Move originator.h in netlink.c to the correct place. Andrew Lunn (5): batman-adv: Handle parent interfaces in a different netns batman-adv: Suppress debugfs entries for netns's batman

Re: [B.A.T.M.A.N.] [PATCH v5 00/11] netns and netlink support

> headers ecsv/netlink > > > diff --git a/net/batman-adv/bat_v.c b/net/batman-adv/bat_v.c > index 25fd4be..c5e6db5 100644 > --- a/net/batman-adv/bat_v.c > +++ b/net/batman-adv/bat_v.c > @@ -19,9 +19,9 @@ > #include "main.h" > > #include >

[B.A.T.M.A.N.] [PATCH] batman-adv: Fix hardif remove/add race

keeps open files still available. Signed-off-by: Andrew Lunn <and...@lunn.ch> --- net/batman-adv/debugfs.c| 23 +++ net/batman-adv/debugfs.h| 1 + net/batman-adv/hard-interface.c | 19 +++ net/batman-adv/sysfs.c

Re: [B.A.T.M.A.N.] [PATCH v6 01/11] batman-adv: Handle parent interfaces in a different netns

On Tue, May 17, 2016 at 02:22:29PM +0200, Sven Eckelmann wrote: > On Tuesday 17 May 2016 14:18:35 Andrew Lunn wrote: > > I'm actually getting close to the point where i'm going to give up. > > Ok, I will try to not review anything from you again. Sorry for trying to > infor

Re: [B.A.T.M.A.N.] [PATCH v6 00/11] netns and netlink support

On Mon, May 16, 2016 at 08:58:13PM +0200, Sven Eckelmann wrote: > On Monday 16 May 2016 19:27:58 Andrew Lunn wrote: > > * No change to code indentation. I consider it a false positive. The > > code is more readable the way it is, checkpatch is happy, and it > > does

[B.A.T.M.A.N.] [PATCH v6 11/11] batman-adv: Indicate netlink socket can be used with netns.

Set the netnsof flag on the family structure, indicating it can be used with different network name spaces. Signed-off-by: Andrew Lunn <and...@lunn.ch> --- net/batman-adv/netlink.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/batman-adv/netlink.c b/net/batman-adv/netlink.c

[B.A.T.M.A.N.] [PATCH v6 09/11] batman-adv: add B.A.T.M.A.N. Dump gateways via netlink

Dump the list of gateways via the netlink socket. Signed-off-by: Andrew Lunn <and...@lunn.ch> --- include/uapi/linux/batman_adv.h | 8 +++ net/batman-adv/gateway_client.c | 148 net/batman-adv/gateway_client.h | 2 + net/batman-adv/net

[B.A.T.M.A.N.] [PATCH v6 10/11] batman-adv: add B.A.T.M.A.N. Dump BLA claims via netlink

Dump the list of bridge loop avoidance claims via the netlink socket. Signed-off-by: Andrew Lunn <and...@lunn.ch> --- include/uapi/linux/batman_adv.h| 12 +++ net/batman-adv/bridge_loop_avoidance.c | 166 + net/batman-adv/bridge_loop_avoidance.h

[B.A.T.M.A.N.] [PATCH v6 08/11] batman-adv: add B.A.T.M.A.N. V bat_{orig, neigh}_dump implementations

From: Matthias Schiffer <mschif...@universe-factory.net> Dump the algo V originators and neighbours. Signed-off-by: Matthias Schiffer <mschif...@universe-factory.net> Signed-off-by: Andrew Lunn <and...@lunn.ch> --- include/uapi/linux/batman_adv.h | 2 + net/batman-adv/bat_

[B.A.T.M.A.N.] [PATCH v6 04/11] batman-adv: netlink: hardif query

From: Matthias Schiffer <mschif...@universe-factory.net> BATADV_CMD_GET_HARDIFS will return the list of hardifs (including index, name and MAC address) of all hardifs for a given softif. Signed-off-by: Matthias Schiffer <mschif...@universe-factory.net> Signed-off-by: Andrew Lunn <

[B.A.T.M.A.N.] [PATCH v6 03/11] batman-adv: netlink: add routing_algo query

From: Matthias Schiffer <mschif...@universe-factory.net> BATADV_CMD_GET_ROUTING_ALGOS is used to get the list of supported routing algorithms. Signed-off-by: Matthias Schiffer <mschif...@universe-factory.net> Signed-off-by: Andrew Lunn <and...@lunn.ch> [sven.eckelm...@ope

[B.A.T.M.A.N.] [PATCH v6 06/11] batman-adv: netlink: add originator and neighbor table queries

tthias Schiffer <mschif...@universe-factory.net> Signed-off-by: Andrew Lunn <and...@lunn.ch> --- include/uapi/linux/batman_adv.h | 4 + net/batman-adv/netlink.c| 13 net/batman-adv/originator.c | 160 net/batman-adv/originator.

[B.A.T.M.A.N.] [PATCH v6 07/11] batman-adv: add B.A.T.M.A.N. IV bat_{orig, neigh}_dump implementations

From: Matthias Schiffer <mschif...@universe-factory.net> Signed-off-by: Matthias Schiffer <mschif...@universe-factory.net> Signed-off-by: Andrew Lunn <and...@lunn.ch> --- include/uapi/linux/batman_adv.h | 4 + net/batman-adv/bat_iv_ogm.c | 359 +++

[B.A.T.M.A.N.] [PATCH v6 02/11] batman-adv: Suppress debugfs entries for netns's

, but there will soon be a netlink interface which is netns aware. Signed-off-by: Andrew Lunn <and...@lunn.ch> --- net/batman-adv/debugfs.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/net/batman-adv/debugfs.c b/net/batman-adv/debugfs.c index f187a8f..50545b0

[B.A.T.M.A.N.] [PATCH v6 01/11] batman-adv: Handle parent interfaces in a different netns

the parents name space when finding the parent and use it when doing the comparison. Signed-off-by: Andrew Lunn <and...@lunn.ch> Signed-off-by: Sven Eckelmann <s...@narfation.org> Acked-by: Antonio Quartulli <a...@untable.cc> --- compat.h| 7 ++ n

[B.A.T.M.A.N.] [PATCH v6 05/11] batman-adv: netlink: add translation table query

expose it as part of the netlink API. Signed-off-by: Matthias Schiffer <mschif...@universe-factory.net> Signed-off-by: Andrew Lunn <and...@lunn.ch> --- include/uapi/linux/batman_adv.h| 58 ++ net/batman-adv/netlink.c | 24 ++- net/batman-adv/netlink.h | 1

[B.A.T.M.A.N.] [PATCH v6 00/11] netns and netlink support

still broken... * Merged in the compat code Sven suggested. Only compile tested with 4.5.0 Andrew Lunn (5): batman-adv: Handle parent interfaces in a different netns batman-adv: Suppress debugfs entries for netns's batman-adv: add B.A.T.M.A.N. Dump gateways via netlink batman-adv: add

[B.A.T.M.A.N.] [PATCH v5 06/11] batman-adv: netlink: add originator and neighbor table queries

tthias Schiffer <mschif...@universe-factory.net> Signed-off-by: Andrew Lunn <and...@lunn.ch> --- include/uapi/linux/batman_adv.h | 4 + net/batman-adv/netlink.c| 13 net/batman-adv/originator.c | 160 net/batman-adv/originator.

[B.A.T.M.A.N.] [PATCH v5 09/11] batman-adv: add B.A.T.M.A.N. Dump gateways via netlink

Dump the list of gateways via the netlink socket. Signed-off-by: Andrew Lunn <and...@lunn.ch> --- include/uapi/linux/batman_adv.h | 8 +++ net/batman-adv/gateway_client.c | 148 net/batman-adv/gateway_client.h | 2 + net/batman-adv/net

[B.A.T.M.A.N.] [PATCH v5 10/11] batman-adv: add B.A.T.M.A.N. Dump BLA claims via netlink

Dump the list of bridge loop avoidance claims via the netlink socket. Signed-off-by: Andrew Lunn <and...@lunn.ch> --- include/uapi/linux/batman_adv.h| 11 +++ net/batman-adv/bridge_loop_avoidance.c | 166 + net/batman-adv/bridge_loop_avoidance.h

[B.A.T.M.A.N.] [PATCH v5 03/11] batman-adv: netlink: add routing_algo query

From: Matthias Schiffer <mschif...@universe-factory.net> BATADV_CMD_GET_ROUTING_ALGOS is used to get the list of supported routing algorithms. Signed-off-by: Matthias Schiffer <mschif...@universe-factory.net> Signed-off-by: Andrew Lunn <and...@lunn.ch> [sven.eckelm...@ope

[B.A.T.M.A.N.] [PATCH v5 11/11] batman-adv: Indicate netlink socket can be used with netns.

Set the netnsof flag on the family structure, indicating it can be used with different network name spaces. Signed-off-by: Andrew Lunn <and...@lunn.ch> --- net/batman-adv/netlink.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/batman-adv/netlink.c b/net/batman-adv/netlink.c

[B.A.T.M.A.N.] [PATCH v5 08/11] batman-adv: add B.A.T.M.A.N. V bat_{orig, neigh}_dump implementations

From: Matthias Schiffer <mschif...@universe-factory.net> Dump the algo V originators and neighbours. Signed-off-by: Matthias Schiffer <mschif...@universe-factory.net> Signed-off-by: Andrew Lunn <and...@lunn.ch> --- include/uapi/linux/batman_adv.h | 2 + net/batman-adv/bat_

[B.A.T.M.A.N.] [PATCH v5 01/11] batman-adv: Handle parent interfaces in a different netns

the parents name space when finding the parent and use it when doing the comparison. Signed-off-by: Andrew Lunn <and...@lunn.ch> Signed-off-by: Sven Eckelmann <s...@narfation.org> Acked-by: Antonio Quartulli <a...@untable.cc> --- compat.h| 7 ++ n

[B.A.T.M.A.N.] [PATCH v5 07/11] batman-adv: add B.A.T.M.A.N. IV bat_{orig, neigh}_dump implementations

From: Matthias Schiffer <mschif...@universe-factory.net> Signed-off-by: Matthias Schiffer <mschif...@universe-factory.net> Signed-off-by: Andrew Lunn <and...@lunn.ch> --- include/uapi/linux/batman_adv.h | 4 + net/batman-adv/bat_iv_ogm.c | 361 +++

[B.A.T.M.A.N.] [PATCH v5 05/11] batman-adv: netlink: add translation table query

expose it as part of the netlink API. Signed-off-by: Matthias Schiffer <mschif...@universe-factory.net> Signed-off-by: Andrew Lunn <and...@lunn.ch> --- include/uapi/linux/batman_adv.h| 56 ++ net/batman-adv/netlink.c | 24 ++- net/batman-adv/netlink.h | 1

[B.A.T.M.A.N.] [PATCH v5 04/11] batman-adv: netlink: hardif query

From: Matthias Schiffer <mschif...@universe-factory.net> BATADV_CMD_GET_HARDIFS will return the list of hardifs (including index, name and MAC address) of all hardifs for a given softif. Signed-off-by: Matthias Schiffer <mschif...@universe-factory.net> Signed-off-by: Andrew Lunn <

[B.A.T.M.A.N.] [PATCH v5 00/11] netns and netlink support

, but it is probably still broken... * Merged in the compat code Sven suggested. Only compile tested with 4.5.0 Andrew Lunn (5): batman-adv: Handle parent interfaces in a different netns batman-adv: Suppress debugfs entries for netns's batman-adv: add B.A.T.M.A.N. Dump gateways via netlink

Re: [B.A.T.M.A.N.] [PATCHv4 00/12] netns and netlink support

> I hope this helps to reduce the conflicts (even when not resolving it > completely) between the tp_meter and the netlink patchset. Hi Sven Do you want to take over my patches and merge them all into one set? Andrew

[B.A.T.M.A.N.] [PATCHv4 12/12] batman-adv: add B.A.T.M.A.N. Dump BLA claims via netlink

Dump the list of bridge loop avoidance claims via the netlink socket. Signed-off-by: Andrew Lunn <and...@lunn.ch> --- v2: Missing includes and forward declarations Fix exit on error when dumping. --- include/uapi/linux/batman_adv.h| 6 ++ net/batman-adv/bridge_loop_avoid

[B.A.T.M.A.N.] [PATCHv4 11/12] batman-adv: add B.A.T.M.A.N. Dump gateways via netlink

Dump the list of gateways via the netlink socket. Signed-off-by: Andrew Lunn <and...@lunn.ch> --- v2: Add missing includes and forward declarations. --- include/uapi/linux/batman_adv.h | 4 ++ net/batman-adv/gateway_client.c | 131 net/batm

[B.A.T.M.A.N.] [PATCHv5] batctl: Use netlink to replace some of debugfs

The kernel has gained support for exporting some information via netlink. Use this when available, rather than debugfs. If netlink is not available, or the information is not yet available via netlink, batctl will fall back to debugfs. Signed-off-by: Andrew Lunn <and...@lunn.ch> --- v2:

[B.A.T.M.A.N.] [PATCHv4 10/12] batman-adv: Indicate netlink socket can be used with netns.

Set the netnsof flag on the family structure, indicating it can be used with different network name spaces. Signed-off-by: Andrew Lunn <and...@lunn.ch> --- net/batman-adv/netlink.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/batman-adv/netlink.c b/net/batman-adv/netlink.c

[B.A.T.M.A.N.] [PATCHv4 04/12] batman-adv: add generic netlink query API to replace debugfs files

of all hardifs for a given softif Signed-off-by: Matthias Schiffer <mschif...@universe-factory.net> Signed-off-by: Andrew Lunn <and...@lunn.ch> --- v2: Added missing includes and forward declarations of structures. --- Makefile| 1 + include/uapi/linux/

[B.A.T.M.A.N.] [PATCHv4 06/12] batman-adv: netlink: add translation table query

expose it as part of the netlink API. Signed-off-by: Matthias Schiffer <mschif...@universe-factory.net> Signed-off-by: Andrew Lunn <and...@lunn.ch> --- v2: Add missing header files. --- include/uapi/linux/batman_adv.h| 47 ++ net/batman-adv/netlink.c | 13 ++ net/b

[B.A.T.M.A.N.] [PATCHv4 09/12] batman-adv: add B.A.T.M.A.N. V bat_{orig, neigh}_dump implementations

From: Matthias Schiffer <mschif...@universe-factory.net> Signed-off-by: Matthias Schiffer <mschif...@universe-factory.net> Signed-off-by: Andrew Lunn <and...@lunn.ch> --- v2: Add missing includes --- include/uapi/linux/batman_adv.h | 1 + net/batman-adv/bat_iv_ogm.c | 3

[B.A.T.M.A.N.] [PATCHv4 07/12] batman-adv: netlink: add originator and neighbor table queries

tthias Schiffer <mschif...@universe-factory.net> Signed-off-by: Andrew Lunn <and...@lunn.ch> --- v2: Add missing includes and forward declarations Add kernel doc to the two dump functions. v3: Add kernel doc for new members in batadv_algo_ops --- include/uapi/linux/batman_adv.h | 2

[B.A.T.M.A.N.] [PATCHv4 05/12] batman-adv: compat: Workarounds for previous patch

* NETLINK_CB portid changed name * info->snd_portid changed name * genl_register_family_with_ops implementation Signed-off-by: Sven Eckelmann <s...@narfation.org> Signed-off-by: Andrew Lunn <and...@lunn.ch> --- compat-include/linux

[B.A.T.M.A.N.] [PATCHv4 00/12] netns and netlink support

kerneldoc v2: All changes requested by Sven: * Added lots of missing includes and structure forward declarations * Add two kernel doc comments * Fixed an obvious bug in BLA, but it is probably still broken... * Merged in the compat code Sven suggested. Only compile tested with 4.5.0 Andrew Lunn (7

[B.A.T.M.A.N.] [PATCHv4 02/12] batman-adv: compat.h: Add workaround for get_link_net()

Signed-off-by: Sven Eckelmann <s...@narfation.org> Signed-off-by: Andrew Lunn <and...@lunn.ch> --- v2: Fix accidental newline deletion --- compat.h | 7 +++ 1 file changed, 7 insertions(+) diff --git a/compat.h b/compat.h index 5a5f478..813e637 100644 --- a/compat.h +++ b/compat

[B.A.T.M.A.N.] [PATCH 2/2] batman-adv: Include frame priority in fragment header

ing a fragment, use this information to set the skb->priority for when the fragment is forwarded. Signed-off-by: Andrew Lunn <and...@lunn.ch> --- net/batman-adv/fragmentation.c | 2 ++ net/batman-adv/packet.h| 7 +-- net/batman-adv/routing.c | 2 ++ 3 files changed, 9 inse

[B.A.T.M.A.N.] [PATCH 1/2] batman-adv: Set skb priority in fragments

BATMAN will set the skb->priority based on the IP precedence or 802.1q tag. However, if it needs to fragment the frame, it currently leaves the fragment skb with the default priority and actually overwrites the priority in the unfragmented frame. Fix this. Signed-off-by: Andrew L

[B.A.T.M.A.N.] [PATCH 0/2] Fragments and QoS

into the fragment header, and upon reception of a fragment, copies it into the skb priority, so that when the fragment is retransmitted, it is correctly prioritised. Andrew Lunn (2): batman-adv: Set skb priority in fragments batman-adv: Include frame priority in fragment header net/batman-adv

Re: [B.A.T.M.A.N.] [PATCHv4] batctl: Use netlink to replace some of debugfs

On Mon, May 09, 2016 at 06:28:29PM +0200, Sven Eckelmann wrote: > On Wednesday 04 May 2016 16:30:07 Andrew Lunn wrote: > > + [BATADV_ATTR_THROUGHPUT]= { .type = NLA_FLAG }, > > Why is throughput a flag when you access it with > > throughput_kbit

Re: [B.A.T.M.A.N.] [PATCHv4] batctl: Use netlink to replace some of debugfs

> This is actually a report of a possible problem by Simon (I've only > checked it): Hi Sven, Simon > It looks like the orig_iface handling isn't handled here (see > handle_debug_table "case 'i'") or am I missing something? Yes, the -i handling is missing. Also -m and -u for translocal and

[B.A.T.M.A.N.] [PATCHv4] batctl: Use netlink to replace some of debugfs

The kernel has gained support for exporting some information via netlink. Use this when available, rather than debugfs. If netlink is not available, or the information is not yet available via netlink, batctl will fall back to debugfs. Signed-off-by: Andrew Lunn <and...@lunn.ch> --- v2:

Re: [B.A.T.M.A.N.] [PATCHv2] batctl: Use netlink to replace some of debugfs

> > Once the code is mostly complete and stable, i think a local copy > > would be good. It does seems to be the common way. > > A local copy sounds like a sensible choice and common practice. Hi Marek v3 has a local copy. Andrew

Re: [B.A.T.M.A.N.] [PATCHv3] batctl: Use netlink to replace some of debugfs

Hi Sven > diff --git a/debug.c b/debug.c > index 3db3ed9..c61970e 100644 > --- a/debug.c > +++ b/debug.c > @@ -23,10 +23,12 @@ > #include > #include > #include > +#include > > #include "debug.h" > #include "debugfs.h" > #include "functions.h" > +#include "netlink.h" > #include

Re: [B.A.T.M.A.N.] [PATCHv2] batctl: Use netlink to replace some of debugfs

On Tue, May 03, 2016 at 02:54:26PM +0200, Sven Eckelmann wrote: > On Tuesday 03 May 2016 14:47:19 Andrew Lunn wrote: > > On Tue, May 03, 2016 at 02:26:34PM +0200, Sven Eckelmann wrote: > > > On Tuesday 03 May 2016 14:20:46 Andrew Lunn wrote: > > > [...] > > &g

Re: [B.A.T.M.A.N.] [PATCHv2] batctl: Use netlink to replace some of debugfs

On Tue, May 03, 2016 at 02:26:34PM +0200, Sven Eckelmann wrote: > On Tuesday 03 May 2016 14:20:46 Andrew Lunn wrote: > [...] > > There does not seem to be a way to say that BATADV_ATTR_VERSION is > > also an NLA_STRING. > > Please check "policy" in the link I g

Re: [B.A.T.M.A.N.] [PATCHv2] batctl: Use netlink to replace some of debugfs

> It looks like the header line is missing here. The debugfs table show > something like: > > " Originator last-seen (#/255) Nexthop [outgoingIF]: > Potential nexthops ...\n"); > > or > > " Originator last-seen ( throughput) Nexthop > [outgoingIF]:

Re: [B.A.T.M.A.N.] [PATCHv2] batctl: Use netlink to replace some of debugfs

On Tue, May 03, 2016 at 09:07:35AM +0200, Sven Eckelmann wrote: > [...] > > +ifeq ($(origin LIBNL_GENL_CFLAGS) $(origin LIBNL_GENL_LDLIBS), undefined > > undefined) > > + LIBNL_GENL_NAME ?= libnl-genl-3.0 > > + ifeq ($(shell $(PKG_CONFIG) --modversion $(LIBNL_GENL_NAME) > > 2>/dev/null),) > >

[B.A.T.M.A.N.] [PATCHv2] batctl: Use netlink to replace some of debugfs

The kernel has gained support for exporting some information via netlink. Use this when available, rather than debugfs. If netlink is not available, or the information is not yet available via netlink, batctl will fall back to debugfs. Signed-off-by: Andrew Lunn <and...@lunn.ch> --- v2:

[B.A.T.M.A.N.] [PATCH v3 12/12] batman-adv: add B.A.T.M.A.N. Dump BLA claims via netlink

Dump the list of bridge loop avoidance claims via the netlink socket. Signed-off-by: Andrew Lunn <and...@lunn.ch> --- v2: Missing includes and forward declarations Fix exit on error when dumping. --- include/uapi/linux/batman_adv.h| 6 ++ net/batman-adv/bridge_loop_avoid

[B.A.T.M.A.N.] [PATCH v3 10/12] batman-adv: Indicate netlink socket can be used with netns.

Set the netnsof flag on the family structure, indicating it can be used with different network name spaces. Signed-off-by: Andrew Lunn <and...@lunn.ch> --- net/batman-adv/netlink.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/batman-adv/netlink.c b/net/batman-adv/netlink.c

[B.A.T.M.A.N.] [PATCH v3 11/12] batman-adv: add B.A.T.M.A.N. Dump gateways via netlink

Dump the list of gateways via the netlink socket. Signed-off-by: Andrew Lunn <and...@lunn.ch> --- v2: Add missing includes and forward declarations. --- include/uapi/linux/batman_adv.h | 4 ++ net/batman-adv/gateway_client.c | 131 net/batm

[B.A.T.M.A.N.] [PATCH v3 09/12] batman-adv: add B.A.T.M.A.N. V bat_{orig, neigh}_dump implementations

From: Matthias Schiffer <mschif...@universe-factory.net> Signed-off-by: Matthias Schiffer <mschif...@universe-factory.net> Signed-off-by: Andrew Lunn <and...@lunn.ch> --- v2: Add missing includes --- include/uapi/linux/batman_adv.h | 1 + net/batman-adv/bat_iv_ogm.c | 3

[B.A.T.M.A.N.] [PATCH v3 06/12] batman-adv: netlink: add translation table query

expose it as part of the netlink API. Signed-off-by: Matthias Schiffer <mschif...@universe-factory.net> Signed-off-by: Andrew Lunn <and...@lunn.ch> --- v2: Add missing header files. --- include/uapi/linux/batman_adv.h| 47 ++ net/batman-adv/netlink.c | 13 ++ net/b

[B.A.T.M.A.N.] [PATCH v3 05/12] batman-adv: compat: Workarounds for previous patch

* NETLINK_CB portid changed name * info->snd_portid changed name * genl_register_family_with_ops implementation Signed-off-by: Sven Eckelmann <s...@narfation.org> Signed-off-by: Andrew Lunn <and...@lunn.ch> --- compat-include/linux

[B.A.T.M.A.N.] [PATCH v3 03/12] batman-adv: Suppress debugfs entries for netns's

, but there will soon be a netlink interface which is netns aware. Signed-off-by: Andrew Lunn <and...@lunn.ch> --- v2: Fix accidental change to __printf Add missing includes. --- net/batman-adv/debugfs.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/net/batm

[B.A.T.M.A.N.] [PATCH v3 02/12] batman-adv: compat.h: Add workaround for get_link_net()

Signed-off-by: Sven Eckelmann <s...@narfation.org> Signed-off-by: Andrew Lunn <and...@lunn.ch> --- v2: Fix accidental newline deletion --- compat.h | 7 +++ 1 file changed, 7 insertions(+) diff --git a/compat.h b/compat.h index 5a5f478..813e637 100644 --- a/compat.h +++ b/compat

[B.A.T.M.A.N.] [PATCH v3 00/12] netns and netlink support

* Add two kernel doc comments * Fixed an obvious bug in BLA, but it is probably still broken... * Merged in the compat code Sven suggested. Only compile tested with 4.5.0 *** BLURB HERE *** Andrew Lunn (7): batman-adv: Handle parent interfaces in a different netns batman-adv: compat.h: Add

[B.A.T.M.A.N.] [PATCH v3 08/12] batman-adv: add B.A.T.M.A.N. IV bat_{orig, neigh}_dump implementations

From: Matthias Schiffer Signed-off-by: Matthias Schiffer --- include/uapi/linux/batman_adv.h | 2 + net/batman-adv/bat_iv_ogm.c | 268 2 files changed, 270 insertions(+) diff --git

[B.A.T.M.A.N.] [PATCH v3 01/12] batman-adv: Handle parent interfaces in a different netns

the parents name space when finding the parent and use it when doing the comparison. Signed-off-by: Andrew Lunn <and...@lunn.ch> Signed-off-by: Sven Eckelmann <s...@narfation.org> Acked-by: Antonio Quartulli <a...@untable.cc> --- v2: Add missing header files Use Sven's

[B.A.T.M.A.N.] [PATCH v2 12/12] batman-adv: add B.A.T.M.A.N. Dump BLA claims via netlink

Dump the list of bridge loop avoidance claims via the netlink socket. Signed-off-by: Andrew Lunn <and...@lunn.ch> --- v2: Missing includes and forward declarations Fix exit on error when dumping. --- include/uapi/linux/batman_adv.h| 6 ++ net/batman-adv/bridge_loop_avoid

[B.A.T.M.A.N.] [PATCH v2 11/12] batman-adv: add B.A.T.M.A.N. Dump gateways via netlink

Dump the list of gateways via the netlink socket. Signed-off-by: Andrew Lunn <and...@lunn.ch> --- v2: Add missing includes and forward declarations. --- include/uapi/linux/batman_adv.h | 4 ++ net/batman-adv/gateway_client.c | 131 net/batm

[B.A.T.M.A.N.] [PATCH v2 07/12] batman-adv: netlink: add originator and neighbor table queries

tthias Schiffer <mschif...@universe-factory.net> Signed-off-by: Andrew Lunn <and...@lunn.ch> --- v2: Add missing includes and forward declarations Add kernel doc to the two dump functions. --- include/uapi/linux/batman_adv.h | 2 + net/batman-adv/netlink.c| 14 net/batma

[B.A.T.M.A.N.] [PATCH v2 10/12] batman-adv: Indicate netlink socket can be used with netns.

Set the netnsof flag on the family structure, indicating it can be used with different network name spaces. Signed-off-by: Andrew Lunn <and...@lunn.ch> --- net/batman-adv/netlink.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/batman-adv/netlink.c b/net/batman-adv/netlink.c

[B.A.T.M.A.N.] [PATCH v2 05/12] batman-adv: compat: Workarounds for previous patch

* NETLINK_CB portid changed name * info->snd_portid changed name * genl_register_family_with_ops implementation Signed-off-by: Sven Eckelmann <s...@narfation.org> Signed-off-by: Andrew Lunn <and...@lunn.ch> --- compat-include/linux

[B.A.T.M.A.N.] [PATCH v2 03/12] batman-adv: Suppress debugfs entries for netns's

, but there will soon be a netlink interface which is netns aware. Signed-off-by: Andrew Lunn <and...@lunn.ch> --- v2: Fix accidental change to __printf Add missing includes. --- net/batman-adv/debugfs.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/net/batm

[B.A.T.M.A.N.] [PATCH v2 06/12] batman-adv: netlink: add translation table query

expose it as part of the netlink API. Signed-off-by: Matthias Schiffer <mschif...@universe-factory.net> Signed-off-by: Andrew Lunn <and...@lunn.ch> --- v2: Add missing header files. --- include/uapi/linux/batman_adv.h| 47 ++ net/batman-adv/netlink.c | 13 ++ net/b

[B.A.T.M.A.N.] [PATCH v2 01/12] batman-adv: Handle parent interfaces in a different netns

the parents name space when finding the parent and use it when doing the comparison. Signed-off-by: Andrew Lunn <and...@lunn.ch> Signed-off-by: Sven Eckelmann <s...@narfation.org> Acked-by: Antonio Quartulli <a...@untable.cc> --- v2: Add missing header files Use Sven's

[B.A.T.M.A.N.] [PATCH v2 04/12] batman-adv: add generic netlink query API to replace debugfs files

of all hardifs for a given softif Signed-off-by: Matthias Schiffer <mschif...@universe-factory.net> Signed-off-by: Andrew Lunn <and...@lunn.ch> --- v2: Added missing includes and forward declarations of structures. --- Makefile| 1 + include/uapi/linux/

[B.A.T.M.A.N.] [PATCH v2 02/12] batman-adv: compat.h: Add workaround for get_link_net()

Signed-off-by: Sven Eckelmann <s...@narfation.org> Signed-off-by: Andrew Lunn <and...@lunn.ch> --- compat.h | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/compat.h b/compat.h index 5a5f478..f746163 100644 --- a/compat.h +++ b/compat.h @@ -137,9 +137,15 @

[B.A.T.M.A.N.] [PATCH v2 08/12] batman-adv: add B.A.T.M.A.N. IV bat_{orig, neigh}_dump implementations

From: Matthias Schiffer Signed-off-by: Matthias Schiffer --- include/uapi/linux/batman_adv.h | 2 + net/batman-adv/bat_iv_ogm.c | 268 2 files changed, 270 insertions(+) diff --git

[B.A.T.M.A.N.] [PATCH v2 00/12] netns and netlink support

suggested. Only compile tested with 4.5.0 Sven: I added a SOB for some of your code. If you disagree, please so say and i will remove them. Andrew Lunn (7): batman-adv: Handle parent interfaces in a different netns batman-adv: compat.h: Add workaround for get_link_net() batman-adv: Suppress debugfs

Re: [B.A.T.M.A.N.] [PATCH 10/10] batman-adv: add B.A.T.M.A.N. Dump BLA claims via netlink

On Fri, Apr 29, 2016 at 11:07:37PM +0200, Sven Eckelmann wrote: > On Thursday 28 April 2016 22:37:28 Andrew Lunn wrote: > > + hlist_for_each_entry_rcu(claim, head, hash_entry) { > > + if (idx++ < *idx_skip) > > +

Re: [B.A.T.M.A.N.] [PATCH 2/2] batctl: Use netlink when available, rather than debugfs

On Fri, Apr 29, 2016 at 08:12:47AM +0200, Sven Eckelmann wrote: > On Thursday 28 April 2016 22:54:57 Andrew Lunn wrote: > > The kernel has gained support for exporting information via netlink. > > Use this when available, rather than debugfs. Netlink has the > > advantage

Re: [B.A.T.M.A.N.] [PATCH 01/10] batman-adv: Handle parent interfaces in a different netns

On Fri, Apr 29, 2016 at 07:52:42AM +0200, Sven Eckelmann wrote: > On Thursday 28 April 2016 22:37:19 Andrew Lunn wrote: > > batman-adv tries to prevent the user from placing a batX soft > > interface into another batman mesh as a hard interface. It does this > > by walkin

[B.A.T.M.A.N.] [PATCH 2/2] batctl: Use netlink when available, rather than debugfs

with older kernel versions. Signed-off-by: Andrew Lunn <and...@lunn.ch> --- Makefile| 20 +- debug.c | 19 +- debug.h | 4 +- functions.c | 11 + functions.h | 1 + main.h | 1 + netlink.c | 810 7

[B.A.T.M.A.N.] [PATCH 1/2] batctl: Document a network namespaces example.

Add example of has BATMAN can be used with network name spaces in the README. Signed-off-by: Andrew Lunn <and...@lunn.ch> --- README | 58 ++ 1 file changed, 58 insertions(+) diff --git a/README b/README index f87c551..431c62e

[B.A.T.M.A.N.] [PATCH 0/2] batctl: Netlink support

broken. Andrew Lunn (2): batctl: Document a network namespaces example. batctl: Use netlink when available, rather than debugfs Makefile| 20 +- README | 58 + debug.c | 19 +- debug.h | 4 +- functions.c | 11 + functions.h | 1 + main.h | 1 + netlink.c

  1   2   3   4   5   6   >