Re: Problem starting A.L.F.R.E.D on batman-adv?

2024-01-28 Thread Linus Lüssing
On Sun, Jan 28, 2024 at 10:29:00PM -, doug.faja...@gmail.com wrote: > I cant seem to get A.L.F.R.E.D. to start: > doug@dougwork:~/sdshome/alfred$ sudo alfred -b bat0 > Can't start server: interface missing I think it's complaining because the "-i" parameter is missing. Try using "alfread -i

[PATCH net v2] bridge: mcast: fix disabled snooping after long uptime

2024-01-27 Thread Linus Lüssing
this ULONG_MAX/2 difference limitation. Fixes: b00589af3b04 ("bridge: disable snooping if there is no querier") Signed-off-by: Linus Lüssing --- Changelog v2: * removed "inline" from br_multicast_query_delay_expired() net/bridge/br_multicast.c | 20 +++- net/bridge

[PATCH net] bridge: mcast: fix disabled snooping after long uptime

2024-01-26 Thread Linus Lüssing
this ULONG_MAX/2 difference limitation. Fixes: b00589af3b04 ("bridge: disable snooping if there is no querier") Signed-off-by: Linus Lüssing --- net/bridge/br_multicast.c | 20 +++- net/bridge/br_private.h | 4 ++-- 2 files changed, 17 insertions(+), 7 deletions(-) diff -

[PATCH] batman-adv: mcast: fix memory leak on deleting a batman-adv interface

2024-01-16 Thread Linus Lüssing
dc4060f0cb...@google.com/ Signed-off-by: Linus Lüssing --- net/batman-adv/multicast.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/batman-adv/multicast.c b/net/batman-adv/multicast.c index c8620905c2dc..38fab5e46ae2 100644 --- a/net/batman-adv/multicast.c +++ b/net/batman-adv/m

[PATCH] batman-adv: mcast: fix mcast packet type counter on timeouted nodes

2024-01-09 Thread Linus Lüssing
this by reducing the according counter when such a node times out. Fixes: be9b0169c840 ("batman-adv: mcast: implement multicast packet generation") Signed-off-by: Linus Lüssing --- net/batman-adv/multicast.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/net/batman-adv/multicast.c b/

Re: [PATCH RFC 2/2] batman-adv: Better half duplex penalty estimation

2023-10-14 Thread Linus Lüssing
On Thu, Sep 28, 2023 at 02:39:36PM +0200, Remi Pommarel wrote: > diff --git a/net/batman-adv/bat_v_ogm.c b/net/batman-adv/bat_v_ogm.c > index 27597f4cdf3e..9b7d4de182d0 100644 > --- a/net/batman-adv/bat_v_ogm.c > +++ b/net/batman-adv/bat_v_ogm.c > @@ -866,10 +866,12 @@ static u32

Re: [PATCH RFC 2/2] batman-adv: Better half duplex penalty estimation

2023-10-14 Thread Linus Lüssing
On Sat, Oct 14, 2023 at 07:10:28AM +0200, Linus Lüssing wrote: > In the following scenario: > > +---+ ch.1 +---+ ch.2 +---+ ch.2 +---+ > | Orig0 | <- | Orig1 | <-- | Orig2 | <-- | Orig3 | > +---+ 300 +---+

Re: [PATCH RFC 2/2] batman-adv: Better half duplex penalty estimation

2023-10-13 Thread Linus Lüssing
Hi, Thanks for taking your time to look into this and the detailed explanations! Generally, the issues both patches try to address make sense to me. On Thu, Sep 28, 2023 at 02:39:36PM +0200, Remi Pommarel wrote: > Let's consider the below topology [...] > However the following formula seems to

Re: Fwd: Possibility of dual-licensing to ease bringing into FreeBSD

2023-09-15 Thread Linus Lüssing
Hi Aymetric, Nice work! For my part, I'd be a bit reluctant. We've had requests for batman-adv from big companies in the past for an extra license, which we turned down. So there might unfortunately be vultures out there who'd like to build on top of batman-adv without giving back. And I'd feel

[PATCH v7 3/3] batman-adv: mcast: shrink tracker packet after scrubbing

2023-09-06 Thread Linus Lüssing
, smaller with every interested receiver on the way and on each splitting intersection. Which can save some valuable bandwidth. Signed-off-by: Linus Lüssing --- net/batman-adv/multicast_forw.c | 207 1 file changed, 207 insertions(+) diff --git a/net/batman-adv

[PATCH v7 2/3] batman-adv: mcast: implement multicast packet generation

2023-09-06 Thread Linus Lüssing
broadcast packet. Signed-off-by: Linus Lüssing --- net/batman-adv/multicast.c | 79 +++- net/batman-adv/multicast.h | 25 +- net/batman-adv/multicast_forw.c | 732 net/batman-adv/soft-interface.c | 6 +- net/batman-adv/types.h | 6 + 5 files

[PATCH v7 1/3] batman-adv: mcast: implement multicast packet reception and forwarding

2023-09-06 Thread Linus Lüssing
of handling a batman-adv multicast packet and multicast tracker TVLV. And that all of our hard interfaces have an MTU of at least 1280 bytes (IPv6 minimum MTU), as a simple solution for now to avoid MTU issues while forwarding. Signed-off-by: Linus Lüssing --- include/uapi/linux/batadv_packet.h | 45

[PATCH v7 0/3] Implementation of a Stateless Multicast Packet Type

2023-09-06 Thread Linus Lüssing
In-Reply-To: Hi, The following patchset implements a stateless, TVLV capable batman-adv multicast packet type. The new batman-adv multicast packet type allows to contain several originator destination MAC addresses within a TVLV. Routers on the way will potentially split the batman-adv

[PATCH 1/2] batctl: mcast_flags: update to current state

2023-07-31 Thread Linus Lüssing
Add the new "P" flag, which signals support for the new batman-adv multicast packet type, to the "batctl mcast_flags" and "batctl tcpdump" outputs. The examples in the README.rst are updated, too, including a description for the R4 and R6 flags. Signed-off-by:

[PATCH 2/2] batctl: tcpdump: parse batman-adv mcast packet type

2023-07-31 Thread Linus Lüssing
Implement a batctl tcpdump parsing of the new batman-adv multicast packet type, including its multicast tracker TVLV and encapsulated payload data. Signed-off-by: Linus Lüssing --- tcpdump.c | 134 +++--- tcpdump.h | 1 + 2 files changed, 119

[PATCH v6 3/3] batman-adv: mcast: shrink tracker packet after scrubbing

2023-07-19 Thread Linus Lüssing
, smaller with every interested receiver on the way and on each splitting intersection. Which can save some valuable bandwidth. Signed-off-by: Linus Lüssing --- net/batman-adv/multicast_forw.c | 195 1 file changed, 195 insertions(+) diff --git a/net/batman-adv

[PATCH v6 2/3] batman-adv: mcast: implement multicast packet generation

2023-07-19 Thread Linus Lüssing
broadcast packet. Signed-off-by: Linus Lüssing --- net/batman-adv/multicast.c | 79 +++- net/batman-adv/multicast.h | 25 +- net/batman-adv/multicast_forw.c | 727 net/batman-adv/soft-interface.c | 6 +- net/batman-adv/types.h | 6 + 5 files

[PATCH v6 1/3] batman-adv: mcast: implement multicast packet reception and forwarding

2023-07-19 Thread Linus Lüssing
of handling a batman-adv multicast packet and multicast tracker TVLV. And that all of our hard interfaces have an MTU of at least 1280 bytes (IPv6 minimum MTU), as a simple solution for now to avoid MTU issues while forwarding. Signed-off-by: Linus Lüssing --- include/uapi/linux/batadv_packet.h | 45

[PATCH v6 0/3] Implementation of a Stateless Multicast Packet Type

2023-07-19 Thread Linus Lüssing
Hi, The following patchset implements a stateless, TVLV capable batman-adv multicast packet type. The new batman-adv multicast packet type allows to contain several originator destination MAC addresses within a TVLV. Routers on the way will potentially split the batman-adv multicast packet and

[PATCH v5 3/3] batman-adv: mcast: shrink tracker packet after scrubbing

2023-07-08 Thread Linus Lüssing
, smaller with every interested receiver on the way and on each splitting intersection. Which can save some valuable bandwidth. Signed-off-by: Linus Lüssing --- net/batman-adv/multicast_forw.c | 194 1 file changed, 194 insertions(+) diff --git a/net/batman-adv

[PATCH v5 2/3] batman-adv: mcast: implement multicast packet generation

2023-07-08 Thread Linus Lüssing
broadcast packet. Signed-off-by: Linus Lüssing --- net/batman-adv/multicast.c | 79 +++- net/batman-adv/multicast.h | 25 +- net/batman-adv/multicast_forw.c | 715 net/batman-adv/soft-interface.c | 6 +- net/batman-adv/types.h | 6 + 5 files

[PATCH v5 1/3] batman-adv: mcast: implement multicast packet reception and forwarding

2023-07-08 Thread Linus Lüssing
of handling a batman-adv multicast packet and multicast tracker TVLV. And that all of our hard interfaces have an MTU of at least 1280 bytes (IPv6 minimum MTU), as a simple solution for now to avoid MTU issues while forwarding. Signed-off-by: Linus Lüssing --- include/uapi/linux/batadv_packet.h | 45

[PATCH v5 0/3] Implementation of a Stateless Multicast Packet Type

2023-07-08 Thread Linus Lüssing
[PATCH v5 0/3] Implementation of a Stateless Multicast Packet Type Hi, The following patchset implements a stateless, TVLV capable batman-adv multicast packet type. The new batman-adv multicast packet type allows to contain several originator destination MAC addresses within a TVLV. Routers on

Re: forwarding works fine with 802.1ad vlans

2023-07-04 Thread Linus Lüssing
Hi pony, Thanks for the feedback! I've added a comment to this Wiki entry, that you should not rely on packets being filtered. I'm not sure if this filtering is 100% intentional or just a byproduct of the early VLAN awareness implementation. So far we typically advertised batman-adv as "it just

Re: [PATCH 1/5] batman-adv: Start new development cycle

2023-02-02 Thread Linus Lüssing
On Mon, Jan 30, 2023 at 03:55:08PM +0100, Jiri Pirko wrote: > Fri, Jan 27, 2023 at 11:21:29AM CET, s...@simonwunderlich.de wrote: > >This version will contain all the (major or even only minor) changes for > >Linux 6.3. > > > >The version number isn't a semantic version number with major and minor

Re: [PATCH v4 3/5] batman-adv: mcast: implement multicast packet reception and forwarding

2023-01-21 Thread Linus Lüssing
On Thu, Jan 19, 2023 at 01:47:25PM +0100, Simon Wunderlich wrote: > On Tuesday, December 27, 2022 8:34:07 PM CET Linus Lüssing wrote: > > +/** > > + * struct batadv_tvlv_mcast_tracker - payload of a multicast tracker tvlv > > + * @num_dests: number of subsequent desti

Re: [PATCH v4 3/5] batman-adv: mcast: implement multicast packet reception and forwarding

2023-01-16 Thread Linus Lüssing
On Sun, Jan 15, 2023 at 06:56:37PM +0100, Sven Eckelmann wrote: > [...] > > +static void > > +batadv_mcast_forw_scrub_dests(struct batadv_priv *bat_priv, > > + struct batadv_neigh_node *comp_neigh, u8 *dest, > > + u8 *next_dest, u16 num_dests) > > +{

[PATCH v4 5/5] batman-adv: mcast: shrink tracker packet after scrubbing

2022-12-27 Thread Linus Lüssing
, smaller with every interested receiver on the way and on each splitting intersection. Which can save some valuable bandwidth. Signed-off-by: Linus Lüssing --- net/batman-adv/multicast_forw.c | 212 1 file changed, 212 insertions(+) diff --git a/net/batman-adv

[PATCH v4 4/5] batman-adv: mcast: implement multicast packet generation

2022-12-27 Thread Linus Lüssing
broadcast packet. Signed-off-by: Linus Lüssing --- net/batman-adv/multicast.c | 79 - net/batman-adv/multicast.h | 25 +- net/batman-adv/multicast_forw.c | 513 net/batman-adv/soft-interface.c | 6 +- net/batman-adv/types.h | 6 + 5 files

[PATCH v4 3/5] batman-adv: mcast: implement multicast packet reception and forwarding

2022-12-27 Thread Linus Lüssing
of handling a batman-adv multicast packet and multicast tracker TVLV. And that all of our hard interfaces have an MTU of at least 1280 bytes (IPv6 minimum MTU), as a simple solution for now to avoid MTU issues while forwarding. Signed-off-by: Linus Lüssing --- include/uapi/linux/batadv_packet.h | 48

[PATCH v4 2/5] batman-adv: tvlv: prepare for tvlv enabled multicast packet type

2022-12-27 Thread Linus Lüssing
(), as later the multicast packet's TVLV handler will need to have access not only to the TVLV but the full skb for forwarding. Forwarding will be invoked from the multicast packet's TVLVs' contents later. Signed-off-by: Linus Lüssing --- include/uapi/linux/batadv_packet.h | 2 + net/batman-adv

[PATCH v4 0/5] Implementation of a Stateless Multicast Packet Type

2022-12-27 Thread Linus Lüssing
Hi, The following patchset implements a stateless, TVLV capable batman-adv multicast packet type. The new batman-adv multicast packet type allows to contain several originator destination MAC addresses within a TVLV. Routers on the way will potentially split the batman-adv multicast packet and

[PATCH v4 1/5] batman-adv: mcast: remove now redundant single ucast forwarding

2022-12-27 Thread Linus Lüssing
enum to prepare for the new batman-adv multicast packet type. Signed-off-by: Linus Lüssing --- net/batman-adv/multicast.c | 249 ++-- net/batman-adv/multicast.h | 38 + net/batman-adv/soft-interface.c | 26 ++-- 3 files changed, 33 insertions(+), 280

[PATCH] build_test: don't warn about "Macro argument reuse" in multicast_forw.c

2022-12-27 Thread Linus Lüssing
eof(num_dests) __batadv_forw_num_dests = num_dests; \ *__batadv_forw_num_dests; \ (*__batadv_forw_num_dests)--, (dest) += ETH_ALEN) Signed-off-by: Linus Lüssing --- checkstuff.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) d

Re: [PATCH v3 3/5] batman-adv: mcast: implement multicast packet reception and forwarding

2022-12-27 Thread Linus Lüssing
On Tue, Dec 27, 2022 at 10:07:36AM +0100, Sven Eckelmann wrote: > ecsv/pu: checkpatch ./net/batman-adv/multicast_forw.c > - > > CHECK: Macro argument reuse 'num_dests' - possible side-effects? > #25: FILE:

[PATCH v3 5/5] batman-adv: mcast: shrink tracker packet after scrubbing

2022-12-26 Thread Linus Lüssing
, smaller with every interested receiver on the way and on each splitting intersection. Which can save some valuable bandwidth. Signed-off-by: Linus Lüssing --- net/batman-adv/multicast_forw.c | 212 1 file changed, 212 insertions(+) diff --git a/net/batman-adv

[PATCH v3 4/5] batman-adv: mcast: implement multicast packet generation

2022-12-26 Thread Linus Lüssing
broadcast packet. Signed-off-by: Linus Lüssing --- net/batman-adv/multicast.c | 79 - net/batman-adv/multicast.h | 24 +- net/batman-adv/multicast_forw.c | 511 net/batman-adv/soft-interface.c | 6 +- net/batman-adv/types.h | 6 + 5 files

[PATCH v3 3/5] batman-adv: mcast: implement multicast packet reception and forwarding

2022-12-26 Thread Linus Lüssing
of handling a batman-adv multicast packet and multicast tracker TVLV. And that all of our hard interfaces have an MTU of at least 1280 bytes (IPv6 minimum MTU), as a simple solution for now to avoid MTU issues while forwarding. Signed-off-by: Linus Lüssing --- include/uapi/linux/batadv_packet.h | 48

[PATCH v3 2/5] batman-adv: tvlv: prepare for tvlv enabled multicast packet type

2022-12-26 Thread Linus Lüssing
(), as later the multicast packet's TVLV handler will need to have access not only to the TVLV but the full skb for forwarding. Forwarding will be invoked from the multicast packet's TVLVs' contents later. Signed-off-by: Linus Lüssing --- include/uapi/linux/batadv_packet.h | 2 + net/batman-adv

[PATCH v3 1/5] batman-adv: mcast: remove now redundant single ucast forwarding

2022-12-26 Thread Linus Lüssing
enum to prepare for the new batman-adv multicast packet type. Signed-off-by: Linus Lüssing --- net/batman-adv/multicast.c | 249 ++-- net/batman-adv/multicast.h | 38 + net/batman-adv/soft-interface.c | 26 ++-- 3 files changed, 33 insertions(+), 280

[PATCH v3 0/5] Implementation of a Stateless Multicast Packet Type

2022-12-26 Thread Linus Lüssing
Hi, The following patchset implements a stateless, TVLV capable batman-adv multicast packet type. The new batman-adv multicast packet type allows to contain several originator destination MAC addresses within a TVLV. Routers on the way will potentially split the batman-adv multicast packet and

[PATCH v2 4/5] batman-adv: mcast: implement multicast packet generation

2022-12-26 Thread Linus Lüssing
broadcast packet. Signed-off-by: Linus Lüssing --- net/batman-adv/multicast.c | 79 - net/batman-adv/multicast.h | 24 +- net/batman-adv/multicast_forw.c | 504 net/batman-adv/soft-interface.c | 6 +- net/batman-adv/types.h | 6 + 5 files

[PATCH v2 5/5] batman-adv: mcast: shrink tracker packet after scrubbing

2022-12-26 Thread Linus Lüssing
, smaller with every interested receiver on the way and on each splitting intersection. Which can save some valuable bandwidth. Signed-off-by: Linus Lüssing --- net/batman-adv/multicast_forw.c | 207 1 file changed, 207 insertions(+) diff --git a/net/batman-adv

[PATCH v2 3/5] batman-adv: mcast: implement multicast packet reception and forwarding

2022-12-26 Thread Linus Lüssing
of handling a batman-adv multicast packet and multicast tracker TVLV. And that all of our hard interfaces have an MTU of at least 1280 bytes (IPv6 minimum MTU), as a simple solution for now to avoid MTU issues while forwarding. Signed-off-by: Linus Lüssing --- include/uapi/linux/batadv_packet.h | 48

[PATCH v2 2/5] batman-adv: tvlv: prepare for tvlv enabled multicast packet type

2022-12-26 Thread Linus Lüssing
(), as later the multicast packet's TVLV handler will need to have access not only to the TVLV but the full skb for forwarding. Forwarding will be invoked from the multicast packet's TVLVs' contents later. Signed-off-by: Linus Lüssing --- include/uapi/linux/batadv_packet.h | 2 + net/batman-adv

[PATCH v2 1/5] batman-adv: mcast: remove now redundant single ucast forwarding

2022-12-26 Thread Linus Lüssing
enum to prepare for the new batman-adv multicast packet type. Signed-off-by: Linus Lüssing --- net/batman-adv/multicast.c | 248 ++-- net/batman-adv/multicast.h | 38 + net/batman-adv/soft-interface.c | 25 ++-- 3 files changed, 33 insertions(+), 278

[PATCH v2 0/5] Implementation of a Stateless Multicast Packet Type

2022-12-26 Thread Linus Lüssing
Hi, The following patchset implements a stateless, TVLV capable batman-adv multicast packet type. The new batman-adv multicast packet type allows to contain several originator destination MAC addresses within a TVLV. Routers on the way will potentially split the batman-adv multicast packet and

[PATCH 5/5] batman-adv: mcast: shrink tracker packet after scrubbing

2022-12-26 Thread Linus Lüssing
, smaller with every interested receiver on the way and on each splitting intersection. Which can save some valuable bandwidth. Signed-off-by: Linus Lüssing --- net/batman-adv/multicast_forw.c | 207 1 file changed, 207 insertions(+) diff --git a/net/batman-adv

[PATCH 4/5] batman-adv: mcast: implement multicast packet generation

2022-12-26 Thread Linus Lüssing
broadcast packet. Signed-off-by: Linus Lüssing --- net/batman-adv/multicast.c | 79 - net/batman-adv/multicast.h | 24 +- net/batman-adv/multicast_forw.c | 504 net/batman-adv/soft-interface.c | 6 +- net/batman-adv/types.h | 6 + 5 files

[PATCH 3/5] batman-adv: mcast: implement multicast packet reception and forwarding

2022-12-26 Thread Linus Lüssing
of handling a batman-adv multicast packet and multicast tracker TVLV. And that all of our hard interfaces have an MTU of at least 1280 bytes (IPv6 minimum MTU), as a simple solution for now to avoid MTU issues while forwarding. Signed-off-by: Linus Lüssing --- include/uapi/linux/batadv_packet.h | 48

[PATCH 2/5] batman-adv: tvlv: prepare for tvlv enabled multicast packet type

2022-12-26 Thread Linus Lüssing
(), as later the multicast packet's TVLV handler will need to have access not only to the TVLV but the full skb for forwarding. Forwarding will be invoked from the multicast packet's TVLVs' contents later. Signed-off-by: Linus Lüssing --- include/uapi/linux/batadv_packet.h | 2 + net/batman-adv

[PATCH 1/5] batman-adv: mcast: remove now redundant single ucast forwarding

2022-12-26 Thread Linus Lüssing
enum to prepare for the new batman-adv multicast packet type. Signed-off-by: Linus Lüssing --- net/batman-adv/multicast.c | 248 ++-- net/batman-adv/multicast.h | 38 + net/batman-adv/soft-interface.c | 25 ++-- 3 files changed, 33 insertions(+), 278

Implementation of a Stateless Multicast Packet Type

2022-12-26 Thread Linus Lüssing
Hi, The following patchset implements a stateless, TVLV capable batman-adv multicast packet type. The new batman-adv multicast packet type allows to contain several originator destination MAC addresses within a TVLV. Routers on the way will potentially split the batman-adv multicast packet and

Re: [pim] draft-ietf-6lo-multicast-registration-08 replacing MLD

2022-09-13 Thread Linus Lüssing
On Mon, Aug 08, 2022 at 10:21:05AM -0700, Stig Venaas wrote: > Hi 6lo and draft authors > > I have some concerns about this draft replacing MLD for group registration. > > Having 2 different protocols for the same thing can be problematic. > Hosts or routers may need to support both protocols.

Re: [RFC PATCH v3 1/1] mac80211: use AQL airtime for expected throughput.

2022-05-31 Thread Linus Lüssing
On Tue, May 31, 2022 at 12:09:22PM +0200, Baligh Gasmi wrote: > Since the integration of AQL, packet TX airtime estimation is > calculated and counted to be used for the dequeue limit. > > Use this estimated airtime to compute expected throughput for > each station. > > It will be a generic

[PATCH maint] batman-adv: mcast: don't send link-local multicast to mcast routers

2021-12-31 Thread Linus Lüssing
mcast: apply optimizations for routable packets, too") Signed-off-by: Linus Lüssing --- net/batman-adv/multicast.c | 15 ++- net/batman-adv/multicast.h | 5 +++-- net/batman-adv/soft-interface.c | 7 +-- 3 files changed, 18 insertions(+), 9 deletions(-) diff --git a/

Re: Unable to get DHCP after join wlan0 WIFI mesh network

2021-11-06 Thread Linus Lüssing
On Fri, Nov 05, 2021 at 04:22:11PM -0700, Dweb Fan wrote: > 4. I follow the document > https://www.kernel.org/doc/Documentation/networking/batman-adv.txt, > but seems like unable to see batman related files/folders under > /sys/class/net/wlan0. Here is output: > $ ls /sys/class/net/wlan0 Hm,

Re: Unable to get DHCP after join wlan0 WIFI mesh network

2021-11-06 Thread Linus Lüssing
Hi, Glad to see that more and more people are experimenting with WiFi mesh networks. On Fri, Nov 05, 2021 at 04:22:11PM -0700, Dweb Fan wrote: > Dear all, > > Thanks for making such a great project! > > I'm following the guide from > https://github.com/binnes/WiFiMeshRaspberryPi, and setting

[PATCHv3] batman-adv: allow netlink usage in unprivileged containers

2021-11-01 Thread Linus Lüssing
ng_algo. Instead it is advised to use the newly introduced "batctl if create routing_algo RA_NAME" / IFLA_BATADV_ALGO_NAME to set the routing algorithm on interface creation, which already works fine in an unprivileged container. Cc: Tycho Andersen Signed-off-by: Linus Lüssing --- C

[PATCHv2] batman-adv: allow netlink usage in unprivileged containers

2021-10-31 Thread Linus Lüssing
ng_algo. Instead it is advised to use the newly introduced "batctl if create routing_algo RA_NAME" / IFLA_BATADV_ALGO_NAME to set the routing algorithm on interface creation, which already works fine in an unprivileged container. Cc: Tycho Andersen Signed-off-by: Linus Lüssing --- Changel

[PATCH] batman-adv: allow netlink usage in unprivileged containers

2021-10-31 Thread Linus Lüssing
ng_algo. Instead it is advised to use the newly introduced "batctl if create routing_algo RA_NAME" / IFLA_BATADV_ALGO_NAME to set the routing algorithm on interface creation, which already works fine in an unprivileged container. Cc: Tycho Andersen Signed-off-by: Linus Lüssing --

Re: Dynamic DHCP server assignment and spin-up on batman-adv mesh network

2021-09-01 Thread Linus Lüssing
On Wed, Sep 01, 2021 at 09:54:36PM +0200, Linus Lüssing wrote: > On Tue, Aug 31, 2021 at 05:28:41PM -, tanner.perk...@cnftech.com wrote: > > If this is not the best place to ask questions regarding mesh networks > > utilizing the batman-adv kernel module, I apologies and

[PATCH v3 3/3] batman-adv: bcast: remove remaining skb-copy calls for broadcasts

2021-05-16 Thread Linus Lüssing
riteable skb we use skb_cow() to avoid sharing skb data with the skb clones in the forwarding calls. Signed-off-by: Linus Lüssing --- Changelog v3: * newly added this patch, to move skb_copy()->skb_clone() changes from PATCH 01/03 to a separate patch with its own explanation net/batm

[PATCH v3 2/3] batman-adv: bcast: avoid skb-copy for (re)queued broadcasts

2021-05-16 Thread Linus Lüssing
nes as it uses batadv_skb_head_push()->skb_cow_head(). Signed-off-by: Linus Lüssing --- Changelog v3: * newly added this patch, to move skb_copy()->skb_clone() change from PATCH 01/03 to a separate patch with its own explanation net/batman-adv/send.c | 2 +- 1 file changed, 1 insert

[PATCH v3 1/3] batman-adv: bcast: queue per interface, if needed

2021-05-16 Thread Linus Lüssing
alternative strategies for transmissions on wireless interfaces in the future (for instance sending via unicast transmissions on wireless interfaces, without queueing in batman-adv, if appropriate). Signed-off-by: Linus Lüssing --- Changelog v3: * changed all skb_clone() calls to skb_cop

[PATCH] batman-adv: mcast: add MRD + routable IPv4 multicast with bridges support

2021-05-15 Thread Linus Lüssing
:2), which every IPv6 multicast router is listening to. However this would also include more nodes than necessary: For instance nodes which are just a router for unicast, but not multicast would be included, too. Signed-off-by: Linus Lüssing --- Please double check the Linux version in compat-inc

Re: [PATCH v2] batman-adv: bcast: queue per interface, if needed

2021-05-14 Thread Linus Lüssing
On Fri, May 14, 2021 at 10:28:53AM +0200, Sven Eckelmann wrote: > On Tuesday, 27 April 2021 20:45:27 CEST Linus Lüssing wrote: > > - * The skb is not consumed, so the caller should make sure that the > > - * skb is freed. > > + * This call clones the given skb, hence the

Re: [net-next v2 09/11] net: bridge: mcast: split multicast router state for IPv4 and IPv6

2021-05-11 Thread Linus Lüssing
On Tue, May 11, 2021 at 12:29:41PM +0300, Nikolay Aleksandrov wrote: > [...] > > -static void br_multicast_mark_router(struct net_bridge *br, > > -struct net_bridge_port *port) > > +#if IS_ENABLED(CONFIG_IPV6) > > +struct hlist_node * > >

[net-next v2 11/11] net: bridge: mcast: export multicast router presence adjacent to a port

2021-05-09 Thread Linus Lüssing
of the bridge. Signed-off-by: Linus Lüssing --- net/bridge/br_multicast.c | 58 +++ 1 file changed, 58 insertions(+) diff --git a/net/bridge/br_multicast.c b/net/bridge/br_multicast.c index b625fd6..e963de5 100644 --- a/net/bridge/br_multicast.c +++ b/net/bridge

[net-next v2 10/11] net: bridge: mcast: add ip4+ip6 mcast router timers to mdb netlink

2021-05-09 Thread Linus Lüssing
Now that we have split the multicast router state into two, one for IPv4 and one for IPv6, also add individual timers to the mdb netlink router port dump. Leaving the old timer attribute for backwards compatibility. Signed-off-by: Linus Lüssing --- include/uapi/linux/if_bridge.h | 2 ++ net

[net-next v2 09/11] net: bridge: mcast: split multicast router state for IPv4 and IPv6

2021-05-09 Thread Linus Lüssing
include a multicast router timeout for both IPv4 and IPv6. Signed-off-by: Linus Lüssing --- net/bridge/br_forward.c | 8 ++ net/bridge/br_mdb.c | 10 ++ net/bridge/br_multicast.c | 197 ++ net/bridge/br_private.h | 6 +- 4 files changed, 201

[net-next v2 08/11] net: bridge: mcast: split router port del+notify for mcast router split

2021-05-09 Thread Linus Lüssing
to avoid sending one for IPv4 and one for IPv6. For that the split is needed. Signed-off-by: Linus Lüssing --- net/bridge/br_multicast.c | 40 ++- 1 file changed, 31 insertions(+), 9 deletions(-) diff --git a/net/bridge/br_multicast.c b/net/bridge/br_multicast.c

[net-next v2 07/11] net: bridge: mcast: prepare add-router function for mcast router split

2021-05-09 Thread Linus Lüssing
In preparation for the upcoming split of multicast router state into their IPv4 and IPv6 variants move the protocol specific router list access to an ip4 wrapper function. Signed-off-by: Linus Lüssing --- net/bridge/br_multicast.c | 59 +++ 1 file changed, 41

[net-next v2 06/11] net: bridge: mcast: prepare expiry functions for mcast router split

2021-05-09 Thread Linus Lüssing
In preparation for the upcoming split of multicast router state into their IPv4 and IPv6 variants move the protocol specific timer access to an ip4 wrapper function. Signed-off-by: Linus Lüssing --- net/bridge/br_multicast.c | 31 ++- 1 file changed, 22 insertions

[net-next v2 05/11] net: bridge: mcast: prepare is-router function for mcast router split

2021-05-09 Thread Linus Lüssing
to ip6_mc_router_timer later when the split is performed. While at it also renames the "1" and "2" constants in br_multicast_is_router() to the MDB_RTR_TYPE_TEMP_QUERY and MDB_RTR_TYPE_PERM enums. Signed-off-by: Linus Lüssing --- net/bridge/br_input.c | 2 +- net/bridge/br_multicast.c |

[net-next v2 04/11] net: bridge: mcast: prepare query reception for mcast router split

2021-05-09 Thread Linus Lüssing
In preparation for the upcoming split of multicast router state into their IPv4 and IPv6 variants and as the br_multicast_mark_router() will be split for that remove the select querier wrapper and instead add ip4 and ip6 variants for br_multicast_query_received(). Signed-off-by: Linus Lüssing

[net-next v2 03/11] net: bridge: mcast: prepare mdb netlink for mcast router split

2021-05-09 Thread Linus Lüssing
to be able put one router port entry with both the IPv4 and IPv6 multicast router info later. Signed-off-by: Linus Lüssing --- net/bridge/br_mdb.c | 39 ++- 1 file changed, 34 insertions(+), 5 deletions(-) diff --git a/net/bridge/br_mdb.c b/net/bridge/br_mdb.c index

[net-next v2 02/11] net: bridge: mcast: add wrappers for router node retrieval

2021-05-09 Thread Linus Lüssing
In preparation for the upcoming split of multicast router state into their IPv4 and IPv6 variants and to avoid IPv6 #ifdef clutter later add two wrapper functions for router node retrieval in the payload forwarding code. Signed-off-by: Linus Lüssing --- net/bridge/br_forward.c | 15

[net-next v2 01/11] net: bridge: mcast: rename multicast router lists and timers

2021-05-09 Thread Linus Lüssing
In preparation for the upcoming split of multicast router state into their IPv4 and IPv6 variants, rename the affected variable to the IPv4 version first to avoid some renames in later commits. Signed-off-by: Linus Lüssing --- net/bridge/br_forward.c | 2 +- net/bridge/br_mdb.c | 6

[PATCH net-next v2 00/11] net: bridge: split IPv4/v6 mc router state and export for batman-adv

2021-05-09 Thread Linus Lüssing
Hi, The following patches are splitting the so far combined multicast router state in the Linux bridge into two ones, one for IPv4 and one for IPv6, for a more fine-grained detection of multicast routers. This avoids sending IPv4 multicast packets to an IPv6-only multicast router and avoids

[PATCH v2] batman-adv: bcast: queue per interface, if needed

2021-04-27 Thread Linus Lüssing
alternative strategies for transmissions on wireless interfaces in the future (for instance sending via unicast transmissions on wireless interfaces, without queueing in batman-adv, if appropriate). Signed-off-by: Linus Lüssing --- Changelog v2: * removed the other two patches from the patchset f

[PATCH net-next 2/2] net: bridge: mcast: export multicast router presence adjacent to a port

2021-04-25 Thread Linus Lüssing
of the bridge. Signed-off-by: Linus Lüssing --- include/linux/if_bridge.h | 8 ++ net/bridge/br_multicast.c | 58 +++ 2 files changed, 66 insertions(+) diff --git a/include/linux/if_bridge.h b/include/linux/if_bridge.h index 2cc35038a8ca..12e9a32dbca0 100644

[PATCH net-next 1/2] net: bridge: mcast: split multicast router state for IPv4 and IPv6

2021-04-25 Thread Linus Lüssing
include a multicast router timeout for both IPv4 and IPv6. Signed-off-by: Linus Lüssing --- include/uapi/linux/if_bridge.h | 2 + net/bridge/br_forward.c| 22 ++- net/bridge/br_input.c | 2 +- net/bridge/br_mdb.c| 38 +++- net/bridge/br_multicast.c | 341

[PATCH net-next 0/2] net: bridge: split IPv4/v6 mc router state and export for batman-adv

2021-04-25 Thread Linus Lüssing
Hi, The following are two patches for the Linux bridge regarding multicast routers. They are rebased on top of the following fix: "net: bridge: mcast: fix broken length + header check for MRDv6 Adv." [0] And should be applied afterwards. The first one splits the so far combined multicast router

[PATCH net-next 0/2] net: bridge: split IPv4/v6 mc router state and export for batman-adv

2021-04-25 Thread Linus Lüssing
Hi, The following are two patches for the Linux bridge regarding multicast routers. They are rebased on top of the following fix: "net: bridge: mcast: fix broken length + header check for MRDv6 Adv." [0] And should be applied afterwards. The first one splits the so far combined multicast router

Re: [RFC PATCH] batman-adv: convert ifmcaddr6 to RCU

2021-04-18 Thread Linus Lüssing
On Sun, Apr 18, 2021 at 10:16:07PM +0200, Linus Lüssing wrote: > On Sun, Apr 18, 2021 at 10:14:22PM +0200, Linus Lüssing wrote: > > [...] > > diff --git a/net/batman-adv/multicast.c b/net/batman-adv/multicast.c > > index 28166402..1d63c8cb 100644 > > --- a/net/batman-ad

Re: [RFC PATCH] batman-adv: convert ifmcaddr6 to RCU

2021-04-18 Thread Linus Lüssing
On Sun, Apr 18, 2021 at 10:14:22PM +0200, Linus Lüssing wrote: > [...] > diff --git a/net/batman-adv/multicast.c b/net/batman-adv/multicast.c > index 28166402..1d63c8cb 100644 > --- a/net/batman-adv/multicast.c > +++ b/net/batman-adv/multicast.c >

[RFC PATCH] batman-adv: convert ifmcaddr6 to RCU

2021-04-18 Thread Linus Lüssing
can be switched to sleepable. Suggested-by: Cong Wang Signed-off-by: Taehee Yoo Signed-off-by: David S. Miller [linus.luess...@c0d3.blue: Add compat code] Signed-off-by: Linus Lüssing --- @Sven: maybe something like this? Seems to compile fine for me, without warnings and seems to run f

Re: How to mesh over ethernet VLAN?

2021-04-14 Thread Linus Lüssing
On Fri, Apr 09, 2021 at 03:38:15PM +0200, Andi Depressivum wrote: > Actual OpenWRT trunk on TP-Link C7 / C2600 devices. Can decrease to > anything lower than 1500 but cannot raise above 1500. Hm, yes, many/most ethernet devices don't support jumbo frames. You could test with iperf3 and its

Re: How to mesh over ethernet VLAN?

2021-04-09 Thread Linus Lüssing
On Tue, Apr 06, 2021 at 11:33:26PM +0200, Andi Depressivum wrote: > That was my very first configuration approach but it's rather slow > (about 200mbit/s over a gigabit link) compared to native VLANs. I've > tried to set the MTU size to 1536 for the mesh interface but for some > reason the MTU of

Re: Problems with Multiple Interfaces

2021-04-09 Thread Linus Lüssing
On Fri, Apr 09, 2021 at 12:17:36PM +0200, Simon Wunderlich wrote: > On Thursday, April 8, 2021 7:56:29 AM CEST j...@careyhome.org wrote: > > Hi Everybody, > > > > I'm running BATMAN v 2019.2 with ath10k on OpenWRT. The particular router > > I'm using has two interfaces, 2.4 GHz and 5GHz. With

IPv4/IPv6 separation in bridge code for multicast routers

2021-04-06 Thread Linus Lüssing
Hi, I wanted to add the remaining pieces for batman-adv to support IPv4 multicast groups in bridged setups, next to the IPv6 support already in place. For which we'd need MRD support. So once more I'd tap into the bridge for this information from batman-adv. Then I realized again that the bridge

Re: How to mesh over ethernet VLAN?

2021-04-06 Thread Linus Lüssing
On Sun, Apr 04, 2021 at 07:52:35PM +0200, Andi Depressivum wrote: > Hello everybody, > > What's the correct setup to mesh also over an existing ethernet VLAN link? > > My core network with all routers & servers is running on VLAN 3 > (eth0.3 in the routers). How do I have to setup batman-adv to

Re: Batman adv selective broadcast mechanism

2021-03-28 Thread Linus Lüssing
Hi Oytun, Are you able to recompile the kernel module and batctl? If so, I could have a look at updating that patch for a more recent batman-adv version. Actually, I'm also kind of curious about your use-case. Sounds like it's not 802.11 wifi you are using, right? Regards, Linus On Thu, Mar

Re: Batman adv selective broadcast mechanism

2021-03-24 Thread Linus Lüssing
Hi, On Wed, Mar 24, 2021 at 12:16:16PM -, oytunya...@hotmail.com wrote: > Hi everybody, > > As I check, batman-adv protocol, sends IP broadcast packets, to every > slave interface, including the slave interface from which the broadcast > packet is received. Is there any way for

[PATCH maint] batman-adv: Fix order of kernel doc in batadv_priv

2021-03-23 Thread Linus Lüssing
During the inlining process of kerneldoc some comments were placed at the wrong struct members. Fixing this by reordering the comments. Fixes: 6369b8e999af ("batman-adv: Use inline kernel-doc for enum/struct") Signed-off-by: Linus Lüssing --- Note: checkpatch shows me a warning: ```

Re: batman-adv for kbit level speeds, external neighbor info

2021-03-16 Thread Linus Lüssing
On Tue, Mar 16, 2021 at 01:17:50PM -, oytunya...@hotmail.com wrote: > Hi everybody, > > I have some questions about batman-adv. > Do you suggest, batman-adv, for speeds like 2.4kbit/s (very slow > networks)? I tried to use batctl throughput_override, for such a setup. It > seems at

[PATCH v2] net: bridge: mcast: rename br_ip's u member to dst

2020-09-28 Thread Linus Lüssing
Signed-off-by: Nikolay Aleksandrov [linus.luess...@c0d3.blue: Add compat code] Signed-off-by: Linus Lüssing --- Compat v2: * added BUILD_BUG_ON size+offset checks as suggested by Sven (thanks!) compat-include/linux/if_bridge.h | 56 net/batman-adv/multicast.c

Re: [PATCH 2/2] batman-adv: mcast: rename br_ip's u member to dst

2020-09-27 Thread Linus Lüssing
On Sat, Sep 26, 2020 at 10:12:20AM +0200, Sven Eckelmann wrote: > From: Nikolay Aleksandrov > > Since now we have src in br_ip, u no longer makes sense so rename > it to dst. No functional changes. > > Signed-off-by: Nikolay Aleksandrov > Signed-off-by: David S. Miller > [s...@narfation.org:

[PATCH] net: bridge: mcast: rename br_ip's u member to dst

2020-09-27 Thread Linus Lüssing
Signed-off-by: Nikolay Aleksandrov [linus.luess...@c0d3.blue: Add compat code] Signed-off-by: Linus Lüssing --- compat-include/linux/if_bridge.h | 39 net/batman-adv/multicast.c | 14 ++-- 2 files changed, 46 insertions(+), 7 deletions(-) create mode

  1   2   3   4   5   6   7   8   9   10   >