Re: [B.A.T.M.A.N.] [PATCH] batman-adv: add compat support for the new netlink ops

2013-02-20 Thread Antonio Quartulli
Hi Simon, ip link set dev $iface master bat0 This doesn't work. eth0 is not added to batman. To further test, I've added it via batctl. I'm not sure..but I think this does not work because the set master command does not use ioctl, but rtnl only. Since in this kernel we don't have rtnl

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: add compat support for the new netlink ops

2013-02-20 Thread Simon Wunderlich
On Wed, Feb 20, 2013 at 02:26:25PM +0100, Antonio Quartulli wrote: Hi Simon, ip link set dev $iface master bat0 This doesn't work. eth0 is not added to batman. To further test, I've added it via batctl. I'm not sure..but I think this does not work because the set master command

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: add compat support for the new netlink ops

2013-02-20 Thread Antonio Quartulli
On Wed, Feb 20, 2013 at 03:14:13PM +0100, Simon Wunderlich wrote: On Wed, Feb 20, 2013 at 02:26:25PM +0100, Antonio Quartulli wrote: Hi Simon, ip link set dev $iface master bat0 This doesn't work. eth0 is not added to batman. To further test, I've added it via batctl.

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: add compat support for the new netlink ops

2013-02-20 Thread Antonio Quartulli
On Wed, Feb 20, 2013 at 03:27:27PM +0100, Antonio Quartulli wrote: Nothing on my side. Thanks again :) I just realised that the ioctl commands this code is handling are for a bridge interface. Since batman-adv does not have its own set of ioctls, then the ndo_do_ioctl() callback should simply

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: add compat support for the new netlink ops

2013-02-19 Thread Simon Wunderlich
On Tue, Feb 19, 2013 at 09:08:44AM +0800, Marek Lindner wrote: Hi Simon, I've tested this (just test, no code review) in my 2.6.32 qemu (Debian squeeze, iproute from wheezy). It generally loads and batctl if add/del seems to work, but there is something weird going on with bridge

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: add compat support for the new netlink ops

2013-02-18 Thread Simon Wunderlich
Hey Antonio, I've tested this (just test, no code review) in my 2.6.32 qemu (Debian squeeze, iproute from wheezy). It generally loads and batctl if add/del seems to work, but there is something weird going on with bridge interaction. After calling the following 3 commands: brctl addbr br0

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: add compat support for the new netlink ops

2013-02-18 Thread Marek Lindner
Hi Simon, I've tested this (just test, no code review) in my 2.6.32 qemu (Debian squeeze, iproute from wheezy). It generally loads and batctl if add/del seems to work, but there is something weird going on with bridge interaction. After calling the following 3 commands: brctl addbr br0

[B.A.T.M.A.N.] [PATCH] batman-adv: add compat support for the new netlink ops

2013-02-17 Thread Antonio Quartulli
This patches enable the new rtnl ops to compile on kernels starting from 2.6.32 Signed-off-by: Antonio Quartulli or...@autistici.org --- Could not be uglier. *Compile tested only* because linux-2.6.32 does not compile on my laptop compat.h | 40 1