Re: [B.A.T.M.A.N.] [PATCH] batman-adv: don't rely on positions in struct for hashing

2012-09-09 Thread Marek Lindner
On Friday, August 31, 2012 00:22:27 Simon Wunderlich wrote: The hash functions in the bridge loop avoidance code expects the VLAN vid to be right after the mac address, but this is not guaranteed. Fix this by explicitly hashing over the right fields of the struct. Reported-by: Marek

[B.A.T.M.A.N.] [PATCH] batman-adv: don't rely on positions in struct for hashing

2012-08-30 Thread Simon Wunderlich
The hash functions in the bridge loop avoidance code expects the VLAN vid to be right after the mac address, but this is not guaranteed. Fix this by explicitly hashing over the right fields of the struct. Reported-by: Marek Lindner lindner_ma...@yahoo.de Signed-off-by: Simon Wunderlich

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: don't rely on positions in struct for hashing

2012-08-30 Thread Antonio Quartulli
On Thu, Aug 30, 2012 at 06:22:27PM +0200, Simon Wunderlich wrote: The hash functions in the bridge loop avoidance code expects the VLAN vid to be right after the mac address, but this is not guaranteed. Fix this by explicitly hashing over the right fields of the struct. What about creating

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: don't rely on positions in struct for hashing

2012-08-30 Thread Antonio Quartulli
On Thu, Aug 30, 2012 at 06:33:52PM +0200, Antonio Quartulli wrote: On Thu, Aug 30, 2012 at 06:22:27PM +0200, Simon Wunderlich wrote: The hash functions in the bridge loop avoidance code expects the VLAN vid to be right after the mac address, but this is not guaranteed. Fix this by