Re: [B.A.T.M.A.N.] [PATCHv4 4/6] batman-adv: remove packed from batadv_ogm_packet

[Marek Lindner]

On Thursday, April 25, 2013 16:37:24 Simon Wunderlich wrote:
 As we decreased the struct size from 26 to 24 byte, we can remove
 __packed as the compiler will not add any more padding.
 
 Signed-off-by: Simon Wunderlich s...@hrz.tu-chemnitz.de
 ---
  packet.h |5 -
  1 file changed, 4 insertions(+), 1 deletion(-)

Applied in revision 85cc6b9.

Thanks,
Marek

[B.A.T.M.A.N.] [PATCHv4 4/6] batman-adv: remove packed from batadv_ogm_packet

[Simon Wunderlich]

As we decreased the struct size from 26 to 24 byte, we can remove
__packed as the compiler will not add any more padding.

Signed-off-by: Simon Wunderlich s...@hrz.tu-chemnitz.de
---
 packet.h |5 -
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/packet.h b/packet.h
index 6d3b943..6982d16 100644
--- a/packet.h
+++ b/packet.h
@@ -178,7 +178,10 @@ struct batadv_ogm_packet {
uint8_t  reserved;
uint8_t  tq;
__be16   tvlv_len;
-} __packed;
+   /* __packed is not needed as the struct size is divisible by 4,
+* and the largest data type in this struct has a size of 4.
+*/
+};
 
 #define BATADV_OGM_HLEN sizeof(struct batadv_ogm_packet)
 
-- 
1.7.10.4