[B.A.T.M.A.N.] [PATCH 1/7] batman-adv: fix packet checksum in receive path

2018-03-02 Thread Simon Wunderlich
From: Matthias Schiffer eth_type_trans() internally calls skb_pull(), which does not adjust the skb checksum; skb_postpull_rcsum() is necessary to avoid log spam of the form "bat0: hw csum failure" when packets with CHECKSUM_COMPLETE are received. Note that in usual setups, packets don't reach b

[B.A.T.M.A.N.] [PATCH 0/7] pull request for net: batman-adv 2018-03-02

2018-03-02 Thread Simon Wunderlich
git repository at: git://git.open-mesh.org/linux-merge.git tags/batadv-net-for-davem-20180302 for you to fetch changes up to f22e08932c2960f29b5e828e745c9f3fb7c1bb86: batman-adv: Fix internal interface indices types (2018-02-25 20:19:34 +0100

[B.A.T.M.A.N.] [PATCH 3/7] batman-adv: Ignore invalid batadv_iv_gw during netlink send

2018-03-02 Thread Simon Wunderlich
From: Sven Eckelmann The function batadv_iv_gw_dump stops the processing loop when batadv_iv_gw_dump_entry returns a non-0 return code. This should only happen when the buffer is full. Otherwise, an empty message may be returned by batadv_gw_dump. This empty message will then stop the netlink dum

[B.A.T.M.A.N.] [PATCH 2/7] batman-adv: invalidate checksum on fragment reassembly

2018-03-02 Thread Simon Wunderlich
From: Matthias Schiffer A more sophisticated implementation could try to combine fragment checksums when all fragments have CHECKSUM_COMPLETE and are split at even offsets. For now, we just set ip_summed to CHECKSUM_NONE to avoid "hw csum failure" warnings in the kernel log when fragmented frames

[B.A.T.M.A.N.] [PATCH 4/7] batman-adv: Ignore invalid batadv_v_gw during netlink send

2018-03-02 Thread Simon Wunderlich
From: Sven Eckelmann The function batadv_v_gw_dump stops the processing loop when batadv_v_gw_dump_entry returns a non-0 return code. This should only happen when the buffer is full. Otherwise, an empty message may be returned by batadv_gw_dump. This empty message will then stop the netlink dumpi

[B.A.T.M.A.N.] [PATCH 5/7] batman-adv: Fix netlink dumping of BLA claims

2018-03-02 Thread Simon Wunderlich
From: Sven Eckelmann The function batadv_bla_claim_dump_bucket must be able to handle non-complete dumps of a single bucket. It tries to do that by saving the latest dumped index in *idx_skip to inform the caller about the current state. But the caller only assumes that buckets were not complete

[B.A.T.M.A.N.] [PATCH 7/7] batman-adv: Fix internal interface indices types

2018-03-02 Thread Simon Wunderlich
From: Sven Eckelmann batman-adv uses internal indices for each enabled and active interface. It is currently used by the B.A.T.M.A.N. IV algorithm to identifify the correct position in the ogm_cnt bitmaps. The type for the number of enabled interfaces (which defines the next interface index) was

[B.A.T.M.A.N.] [PATCH 6/7] batman-adv: Fix netlink dumping of BLA backbones

2018-03-02 Thread Simon Wunderlich
From: Sven Eckelmann The function batadv_bla_backbone_dump_bucket must be able to handle non-complete dumps of a single bucket. It tries to do that by saving the latest dumped index in *idx_skip to inform the caller about the current state. But the caller only assumes that buckets were not compl

[B.A.T.M.A.N.] [PATCH 0/5] pull request for net-next: batman-adv 2018-03-02

2018-03-02 Thread Simon Wunderlich
git repository at: git://git.open-mesh.org/linux-merge.git tags/batadv-next-for-davem-20180302 for you to fetch changes up to a163dc22d515d17844435c8217ff66193d35b3fa: batman-adv: always assume 2-byte packet alignment (2018-02-27 13:02:54 +0100

[B.A.T.M.A.N.] [PATCH 1/5] batman-adv: Start new development cycle

2018-03-02 Thread Simon Wunderlich
Signed-off-by: Simon Wunderlich --- net/batman-adv/main.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/batman-adv/main.h b/net/batman-adv/main.h index f7ba3f96d8f3..69bfedfad174 100644 --- a/net/batman-adv/main.h +++ b/net/batman-adv/main.h @@ -25,7 +25,7 @@ #define BA

[B.A.T.M.A.N.] [PATCH 2/5] batman-adv: Update copyright years for 2018

2018-03-02 Thread Simon Wunderlich
From: Sven Eckelmann Signed-off-by: Sven Eckelmann Signed-off-by: Simon Wunderlich --- include/uapi/linux/batadv_packet.h | 2 +- include/uapi/linux/batman_adv.h| 2 +- net/batman-adv/Kconfig | 2 +- net/batman-adv/Makefile| 2 +- net/batman-adv/bat_

[B.A.T.M.A.N.] [PATCH 4/5] batman-adv: Avoid relation operator comparison with bool

2018-03-02 Thread Simon Wunderlich
From: Sven Eckelmann commit 785ea1144182 ("batman-adv: Distributed ARP Table - create DHT helper functions") introduced a return check of batadv_compare_eth which uses a boolean return value since commit 16af73458aca ("batman-adv: main, batadv_compare_eth return bool"). A relational (<, >, <= or

[B.A.T.M.A.N.] [PATCH 5/5] batman-adv: always assume 2-byte packet alignment

2018-03-02 Thread Simon Wunderlich
From: Matthias Schiffer NIC drivers generally try to ensure that the "network header" is aligned to a 4-byte boundary. This is not always possible: When Ethernet frames are encapsulated in other packets with 4-byte aligned headers, the inner Ethernet header will have 4-byte alignment, and in cons

[B.A.T.M.A.N.] [PATCH 3/5] batman-adv: Fix indentation of batadv_seq_before

2018-03-02 Thread Simon Wunderlich
From: Sven Eckelmann Also multiline macros should have their statements start on a tabstop. This was detected by checkpatch.pl after commit a134f8de9f40 ("checkpatch: improve the TABSTOP test to include declarations"). Signed-off-by: Sven Eckelmann Signed-off-by: Simon Wunderlich --- net/batm