There is a typo here where an extra '!' made the check to the opposite
of what was intended.
Signed-off-by: Dan Carpenter
diff --git a/net/batman-adv/gateway_client.c b/net/batman-adv/gateway_client.c
index 9373a14..24403a7 100644
--- a/net/batman-adv/gateway_client.c
+++ b/net/
uct unicast_packet) +
uneven_correction;
54
55 return merged_size <= mtu;
56 }
Can the skb->len be less than sizeof(*unicast_packet) (ie 20 bytes)?
If "len" is less than 10 then we would return false but if it's
over 10 then we would return true. Roughly.
regards,
dan carpenter
ate that
> the
> patch is for linux-next.
>
It doesn't go through Stephen Rothwell. It goes through Andrew
Morton and it should be CC'd to Sasha Levin.
regards,
dan carpenter
fragmentation enabled we can fragment external packets
easily */
274 min_mtu = min_t(int, min_mtu, ETH_DATA_LEN);
^^^
min_mtu would still be negative here.
275
276 out:
277 return min_mtu - batadv_max_header_len();
278 }
regards,
dan carpenter
minimum check there but why is it 68 bytes?
regards,
dan carpenter
On Mon, Mar 08, 2010 at 04:15:30PM +0100, Sven Eckelmann wrote:
> Andrew Lunn wrote:
> > Does somebody have time to look at this?
> > - Forwarded message from Dan Carpenter -
> [...]
> > drivers/staging/batman-adv/routing.c
> > 88 } else
mp;bat_priv->tt.last_changeset_lock);
3297 } else {
See also:
net/batman-adv/translation-table.c:3313 batadv_send_my_tt_response()
error: uninitialized symbol 'tt_change'.
regards,
dan carpenter
On Fri, Dec 02, 2016 at 05:34:39PM +0100, Sven Eckelmann wrote:
> On Mittwoch, 30. November 2016 22:53:27 CET Dan Carpenter wrote:
> > Hello Antonio Quartulli,
> >
> > The patch 7ea7b4a14275: "batman-adv: make the TT CRC logic VLAN
> > specific" from Jul 30
t really require any action from you. I just wanted you to
know my thinking here.
regards,
dan carpenter
tmail.com
> > Fixes: d68dbb0c9ac8 ("arch: handle arches who do not yet define clone3")
> >
> > For information about bisection process see: https://goo.gl/tpsmEJ#bisection
>
> This bisect seems bogus.
>
Yeah. József Kadlecsik already fixed the bug in a different thread. It
was reported as seven different bugs so there was a bunch of threads for
it.
regards,
dan carpenter
10 matches
Mail list logo
