Re: [B.A.T.M.A.N.] translation of batman-adv

2007-09-14 Thread Simon Wunderlich
Hey, i tested this today (and fixed a 2 bugs regarding this ;), and that works. I used the same setup as you described, and when reassociating it kept pinging ... :) The host-announcements for the bridging are sent with the batman-packets, and it takes 1 second maximum for the ap node to make the

Re: [B.A.T.M.A.N.] translation of batman-adv

2007-09-14 Thread Simon Wunderlich
No, the batman-adv currently has a timeout for client-macs of 5 minutes. But as soon as another new ap announce the mac as his node, the old ap will recognize this, update his table (remove the client-mac) and stop announcing it. So only the new ap will keep on announcing, not both. Regards,

Re: [B.A.T.M.A.N.] batman-adv / mac-addresses without leading zeros

2008-03-13 Thread Simon Wunderlich
Hello Bastian, the output comes from ether_ntoa(), but i personally like the padded output more, too. ;) So the latest revision should print pretty MACs. :) best regards, Simon On Wed, Mar 12, 2008 at 03:00:58PM +, Bastian Bittorf wrote: during batch/debug-mode the output of all

Re: [B.A.T.M.A.N.] Node with two wireless interfaces - to bridge them or not?

2008-04-03 Thread Simon Wunderlich
Hello Pele, bridging multiple interfaces is probably not a good idea, because as soon as you have a cycle there will be bridging loops. The frames will cycle until they are droppend and there is no TTL to stop them! :) In Ethernet, a solution for this is STP [1], which will cut off (one of) the

Re: [B.A.T.M.A.N.] Who can help with BATMAN-ADV integration into ROBIN-FW?

2008-04-22 Thread Simon Wunderlich
Hello Solon, thank you for the offer, but i really think we should do this workshop in the c-base, because all people will be assembled there, and i'm sure there are some people who will join us spontanously. It would be nice if you could bring some FON-routers (like 5 to 10) that we can use for

Re: [B.A.T.M.A.N.] batmand 0.3-1 uploaded to Debian sid

2008-05-23 Thread Simon Wunderlich
Good work, thank you :D Simon On Fri, May 23, 2008 at 06:51:20PM +0200, Holger Levsen wrote: Hi, subject says it all, batmand 0.3-1 has been uploaded to Debian sid. http://packages.qa.debian.org/b/batmand.html regards, Holger

Re: [B.A.T.M.A.N.] Batman-Advanced Kernel land

2008-06-05 Thread Simon Wunderlich
Hello, I can not reproduce the problem on 2.6.24, but i can on 2.6.22.19 with the same batman-adv source (rev1084). So it looks like the two kernel have a different behaviour for this problem. @Paolo: Which kernel version did you use? As i can reproduce it now, i'll look in this problem. :)

Re: [B.A.T.M.A.N.] Batman-Advanced Kernel land

2008-06-08 Thread Simon Wunderlich
Hey Paolo, thanks again for your testing. I've tried a few old revisions and could reproduce the ping of death problem in Svens 2.6.22 enviroment. Even Revision 1024, which worked flawlessly before in my UML, on Accton routers and other devices in various setups, showed this problem. :( So

Re: [B.A.T.M.A.N.] Error LibG3D-WARNING **: no handler for file with meshs3d

2008-06-16 Thread Simon Wunderlich
Hello, you're probably missing the plugins for 3ds. Libg3d has a main library and is outsourcing file-specific handlers into plugins (e.g. for .3ds models), and maybe you have not installed them. best regards, Simon On Sun, Jun 15, 2008 at 04:24:09PM +0200, thomas anderson wrote:

[B.A.T.M.A.N.] Re: BATMAN ADVANCED KERNEL LAND LOOP

2008-07-02 Thread Simon Wunderlich
Hey, Just as an update for other people interested in batman-advanced: Paolo and me were hunting the bug(s) in private, and these issues should be resolved with rev1090. Thank you again for reporting and testing, Paolo! Simon On Fri, Jun 27, 2008 at 02:28:50PM +0200, cipollone wrote:

Re: [B.A.T.M.A.N.] BATMAN Gateway

2008-07-03 Thread Simon Wunderlich
Hello, please note that the BATMAN Gateway module has nothing to do with batman-advanced (user/kernelspace). The BATMAN Gateway module can be used to accelerate the BATMAN Layer 3 (and only Layer 3) Gateway functionality. BATMAN will automagically detect the kernel module and use it if its

Re: [B.A.T.M.A.N.] [PATCH] batman-adv-kernelland linux-2.6.21 compatibility

2008-07-17 Thread Simon Wunderlich
Hey Scott, thank you for the patch, it looks good to me so i applied it. Having a compat.h is a good idea, maybe we should use it even more to get rid of some ugly #ifdef's. :) I've tested your patch against various kernels, it seems to work until 2.6.20, but breaks for 2.6.19. We welcome any

Re: [B.A.T.M.A.N.] Batman gateway lock ups

2008-09-09 Thread Simon Wunderlich
Hey Sven, thanks for you analysis!! On Mon, Sep 08, 2008 at 11:18:42PM +0200, Sven Eckelmann wrote: Ok, I got the /proc/modules file now. Current situation is following: it crashes inside the the batman module add position 0x0aa4 a60: 3c02lui v0,0x0 a64:

Re: [B.A.T.M.A.N.] BATGAT

2008-09-10 Thread Simon Wunderlich
Hello Gustavo, batman works fine without the batgat kernel module. The batgat kernel module will only accelerate the gateway functionality, but batman can do without it. If you don't want it, don't insmod batgat. Batman will detect it at runtime, no need to recompile. The gateway should still

Re: [B.A.T.M.A.N.] Re: batman in atheros

2008-10-24 Thread Simon Wunderlich
Hello Max, BATMAN is a routing daemon, a userspace program modifying the routing table on each node to build up the mesh network. It sends UDP packets to exchange information. This is very different from 802.11s, which is building the mesh on the Link Layer. In 802.11s, routing information is

Re: [B.A.T.M.A.N.] batman - how does fast internet connection connection work

2008-10-30 Thread Simon Wunderlich
Hello David, On Wed, Oct 29, 2008 at 11:49:30PM -0700, david johnson wrote: Hi First an introduction - I am a David Johnson - I've been working on mesh protocols for a few years now and I've built a 49 node wireless grid to benchmark mesh protocols in South Africa:

Re: [B.A.T.M.A.N.] VIS usage

2008-11-11 Thread Simon Wunderlich
Hello Gustavo, installing the vis outside of the Mesh is no problem. Just make sure that the computer outside is reachable for the reporting batman nodes. Give them the vis' internet IP, and everything should be fine. :) regards, Simon On Tue, Nov 11, 2008 at 11:47:30AM -0200, Gustavo

Re: [B.A.T.M.A.N.] RetroMessenger Linux for PC/Mobile 0.2 has been released

2008-11-15 Thread Simon Wunderlich
On Sat, Nov 15, 2008 at 08:37:11PM +0100, Sven Eckelmann wrote: On Saturday 15 November 2008 08:21:22 M. Peterson wrote: Hello RetroMessenger, the small tiny messenger gui for pc mobile phones, has been released - for Linux. please test, thanks. [...] Please test and reports

Re: [B.A.T.M.A.N.] batman-adv debian announcement

2008-11-16 Thread Simon Wunderlich
Hey, yep, bmxd/batman0.3 and batman-adv are both not compatible to each other. You should know that batman-adv does not have special gateway support like the layer 3 batman versions. It can be considered as a big switch where every node is one virtual hop away. You can therefore configure it

Re: [B.A.T.M.A.N.] Visualization server

2008-11-17 Thread Simon Wunderlich
Hello, sorry for the link breakage, we're in the middle of moving our wiki to a new system. Please use https://www.open-mesh.net/batman-old/vis in the meantime. (btw, Can you tell me where you have seen the link to this page?) regards, Simon On Mon, Nov 17, 2008 at 10:04:26AM -,

Re: [B.A.T.M.A.N.] MASQUERADING on the gate0 NIC

2008-11-18 Thread Simon Wunderlich
Hello Derek, BATMAN will only open one gate0, so this should be fine. The tunnel is always pointing to the currently selected gateway. Make sure that you add something like --source 192.168.100.0/24 to your iptables line, otherwise other packets might make into in your NAT which you don't want

Re: [B.A.T.M.A.N.] gateX interfaces

2008-11-22 Thread Simon Wunderlich
Hey, On Sat, Nov 22, 2008 at 02:27:45PM -, Derek C wrote: Hi, Currently I'm constantly killing batmand and starting it up again (different debugging levels, etc). Sometimes I end up with a 2nd gate tunnel (so I'd have a gate0 and a gate1). I understand (guess?) that it's because I

Re: [B.A.T.M.A.N.] BATMAN routing (via gate0)

2008-11-23 Thread Simon Wunderlich
Hey, On Sun, Nov 23, 2008 at 11:37:10AM +0800, Marek Lindner wrote: On Sunday 23 November 2008 05:05:36 Derek C wrote: Does this mean that the mesh nodes cannot ping all the other nodes? This is if there is no routing to allow the nodes talk to far-away nodes not within their own AdHoc

Re: [B.A.T.M.A.N.] b.a.t.m.a.n. under Windows, Linux

2008-11-25 Thread Simon Wunderlich
Hey Resul (or Mr. E.), it's possible to use BATMAN under Linux, and Linux only. Mac OS, Windows and BSD are currently not supported due to some routing specialities only available under Linux. Maybe its not hard to port it to the other OSs (we had BSD support in the past), but there is currently

Re: [B.A.T.M.A.N.] [PATCH] batman-adv-kernelland: Fix memory corruption bug

2008-12-04 Thread Simon Wunderlich
Hey Scott, thank you very much for the fix! Can you confirm if this bug is related to https://dev.open-mesh.net/batman/ticket/86 ? This bug has very likely been caused by a memory corruption, but i couldn´t find where. (i have not experienced any kernel panics by this however ...). Thanks, best

Re: [B.A.T.M.A.N.] [PATCH] batman-adv-kernelland: Fix memory corruption bug

2008-12-05 Thread Simon Wunderlich
Hey Scott, On Fri, Dec 05, 2008 at 11:40:30PM +1300, Scott Raynel wrote: Hi Simon, On 5/12/2008, at 12:35 AM, Simon Wunderlich wrote: Hey Scott, thank you very much for the fix! Can you confirm if this bug is related to https://dev.open-mesh.net/batman/ticket/86 ? This bug has very

Re: [B.A.T.M.A.N.] Looking for batman-adv 0.1-alpha

2008-12-08 Thread Simon Wunderlich
Hey Tobias, On Mon, Dec 08, 2008 at 09:29:12AM +0100, Tobias Gieseke wrote: and thanks for the helpfull informations so far. As there is a command batmand-adv available on the meshnode i assume they use the userspace version of batman-adv (correct??). Can i copy the executeable file from

Re: [B.A.T.M.A.N.] [PATCH] Compile vis under FreeBSD and OSX

2009-01-13 Thread Simon Wunderlich
Hello guys, thank you very much for the patches! I've applied Svens patch because it is more general (including these headers in any case should not hurt). Compatibility patches are highly appreciated, we still have tickets open requesting Mac OS X support ... :) best regards Simon On

Re: [B.A.T.M.A.N.] Install Batman

2009-01-21 Thread Simon Wunderlich
Hey, we also have precompiled binaries for x86: http://downloads.open-mesh.net/batman/stable/binaries/i386/ http://downloads.open-mesh.net/batman/development/binaries/i386/ another option is to compile/linu batmand with the -static flag on your x86 (i386) desktop and just copy it, as Sven

Re: [B.A.T.M.A.N.] batmand-howto conversation

2009-01-22 Thread Simon Wunderlich
Hey Sven, thanks for your work, it'd be nice to keep the howto up to date. We might as well merge the howto with our ongoing documentation [1]. What do you (and the others) think? Anyway, i'd upload the updated version of the howto as soon as you consider it ready. Just compiled it and it seems

Re: [B.A.T.M.A.N.] batman 0.3.1 released

2009-01-25 Thread Simon Wunderlich
Hey, On Sun, Jan 25, 2009 at 07:45:37PM +0100, Marek Lindner wrote: BSD compability was committed. just to be clear: B.A.T.M.A.N. is currently not supported under *BSD, only the visualization server has been fixed. Maybe batmand compiles under *BSD, but lacks features like gateway

Re: [B.A.T.M.A.N.] Help in batman advanced configuration

2009-01-26 Thread Simon Wunderlich
Hello Gargi, your setup looks correct from what you've pasted. Some questions to find the reason: 1. Have you set up all the interfaces by doing ifconfig dev up? 2. If you set IPs on br0 of open-mesh1 and br0 of open-mesh2 manually, can they ping each other? 3. If yes (and configured within

Re: [B.A.T.M.A.N.] Using batman L2 on multiple wireless cards

2009-02-12 Thread Simon Wunderlich
Hello Gargi, yep, thats exactly the way to go. :) best regards Simon On Wed, Feb 11, 2009 at 09:06:46PM -0600, Gargi Purohit wrote: Hi I was wondering if I can run L2 batman kernel module on hardware which has 3 wireless cards. Should be process be the same as in adding interfaces

Re: [B.A.T.M.A.N.] WiMAX

2009-02-12 Thread Simon Wunderlich
Hello Tim, unfortunately i have no experience with WiMAX, but as far as i know: * WiMAX is not license-free like WiFi (means you need to BUY a license, at least in germany) * where is the technical advantage of WiMAX over WiFi? Sure, the advertisements say 50 km or 108 MBit/s, but they

Re: [B.A.T.M.A.N.] B.A.T.M.A.N L2 over a Bluetooth PAN

2009-02-13 Thread Simon Wunderlich
Hello Breno, as far as i know, for 802.11 the SNAP protocol is used to encapsulate the complete Ethernet Frame [1]. This means that the Ethernet header is completly preserved and can be decapsulated on the receiver side. The BNEP protocol on the other hand seems to cut off the Ethernet header

Re: [B.A.T.M.A.N.] Wimax-Stuff and Ideas

2009-02-13 Thread Simon Wunderlich
Hey Bastian, On Fri, Feb 13, 2009 at 02:08:40PM +0100, Bastian Bittorf wrote: * Simon Wunderlich simon.wunderl...@s2003.tu-chemnitz.de [13.02.2009 01:30]: [sorry for mixing up threads] WiFi has some kind of range limit due to the acknowledgement timeout, but you can easily overcome

Re: [B.A.T.M.A.N.] Using batman L2 on multiple wireless cards

2009-02-14 Thread Simon Wunderlich
Hello Gargi, the design of the main interface in BATMAN has the effect that only OGM packets from the main interface are distritibuted over the whole network. OGM packets from secondary interfaces are only sent with TTL=1, that means the next neighbor will drop them. The reason for this system

Re: [B.A.T.M.A.N.] Running Batman

2009-03-03 Thread Simon Wunderlich
Hello Kartik, are you sure that ath0 is not already created before you run the wlanconfig ath0 create ... command? If so, you should first destroy it with: $ wlanconfig ath0 destroy You should be able to ping between the devices if they are in range, even if batman is not running. I suggest you

Re: [B.A.T.M.A.N.] Maybe!?!

2009-03-03 Thread Simon Wunderlich
Hello Mario, maybe this link [1] helps you. best regards, Simon [1] http://freshmeat.net/search/?q=wifi+managementsection=projects On Mon, Mar 02, 2009 at 02:52:18PM +0100, Mario Roeber wrote: Hello, i'know it's not direct a BATMAN problem/question. i'm looking for opensource

Re: [B.A.T.M.A.N.] Trouble with SSH in L2 batman network

2009-04-14 Thread Simon Wunderlich
Hey Gargi, i've read your setup as you described it, and as far as i understood it is supposed to work. I've already built up similar setups without problems and don't see what your problem is here. Maybe you can provide some more information, e.g. your startup script, to get a clue here? kind

Re: [B.A.T.M.A.N.] batman-adv use in Manchester NH

2009-05-07 Thread Simon Wunderlich
Hey Arc, On Tue, May 05, 2009 at 02:53:56PM -0400, Arc Riley wrote: Excellent! Is there a website for your project? Not yet, in the next two weeks. Are you fully committed to Batman or still in the evaluation phases? There's room to be swayed, but batman-adv seems to be the best

Re: [B.A.T.M.A.N.] VIS server for batman-adv-kernelland

2009-05-22 Thread Simon Wunderlich
Hello Christoph, On Thu, May 21, 2009 at 10:19:40PM +0200, Christoph Pilka wrote: Hi folks, my goal is to visualize batman-adv-kernelland network topology. 'echo server /proc/net/batman-adv/vis' activates vis server on the mesh node directly, right? Yes, that's right. Do the other nodes

Re: [B.A.T.M.A.N.] batman-adv packet.h license

2009-08-17 Thread Simon Wunderlich
Hello Andrew, this is fine with me, let's hear what marek thinks. BTW, there are excellent batman dissectors for wireshark, have you tried them already? best regards, Simon On Mon, Aug 17, 2009 at 08:36:44PM +0200, Andrew Lunn wrote: Hi Marek, Simon I'm writing a protocol dissector

Re: [B.A.T.M.A.N.] batman-adv applying for an official Ethertype?

2009-08-18 Thread Simon Wunderlich
Hey Andrew, i'm only aware of ether-wake which uses 0x8042 as (unregistered) ethertype to send WOL packets and was obviously used in scyld beowulf systems according to the manpage [1]. Wireshark also recognizes these packets [2]. I know this ethertype because we used this ethertype in our

Re: [B.A.T.M.A.N.] HSB announces the second Wireless Battle Mesh (Brussels, 17-18 Oct)

2009-08-30 Thread Simon Wunderlich
Sounds nice, i'm in. ;) On Sat, Aug 29, 2009 at 09:38:24AM +0200, Benjamin Henrion wrote: === HackerSpaceBrussels announces the second Wireless Battle Mesh WBM2009 v2 (Brussels, 17-18 October)

Re: [B.A.T.M.A.N.] [patch] adding subgraph-feature to vis-output in dot-file-format

2009-08-30 Thread Simon Wunderlich
/b.a.t.m.a.n/2009-August/002832.html Signed-off-by: Simon Wunderlich simon.wunderl...@s2003.tu-chemnitz.de From: Linus Lüssing linus.luess...@web.de Index: vis.c === --- vis.c (revision 1418) +++ vis.c (working copy) @@ -87,7

Re: [B.A.T.M.A.N.] [patch] adding subgraph-feature to vis-output in dot-file-format

2009-08-30 Thread Simon Wunderlich
Hi, On Sun, Aug 30, 2009 at 09:37:52AM +0200, Andrew Lunn wrote: Cheers, Linus PPS: I had to introduce a src-field in the vis-packet-struct, therefore the compatibility version had to be increased as well. I'm thinking about linux-mainline here. Does it make sense to have a version

Re: [B.A.T.M.A.N.] IP from MAC

2009-09-18 Thread Simon Wunderlich
Hey, right, on batman-adv you can use a central DHCP server or use decentralized link-local IP autoconfiguration tools as Sven suggested. On Fri, Sep 18, 2009 at 06:42:18PM +1000, Lick A Prize wrote: And for multi-hop networks, of the kind that BATMAN, OLSR, etc. are used for?

Re: [B.A.T.M.A.N.] BATMAN-Adv and MTU handling

2009-11-10 Thread Simon Wunderlich
Hey, On Tue, Nov 10, 2009 at 06:34:41PM +0800, Marek Lindner wrote: The motivation of using a higher MTU of 1524 at the beginning was the rumour, that there might be some client devices (which we would get into the network by bridging bat0 wifi wlan0 for instance) not able to handle any

[B.A.T.M.A.N.] [PATCH] Removing the big batman lock

2009-11-29 Thread Simon Wunderlich
nodes etc, which seems to be clean so far. However there might be more race conditions introduced by this large patch, and i'm therefore requesting a careful review before committing. Signed-off-by: Simon Wunderlich simon.wunderl...@s2003.tu-chemnitz.de --- Index: batman-adv-kernelland/vis.c

[B.A.T.M.A.N.] [PATCHv3] [batman-adv] Removing the big batman lock

2009-12-05 Thread Simon Wunderlich
or referenced (e.g. as neighbor), and freed when there are no references left. This makes it neccesary to carefully reference and unreference nodes. * orig_nodes receive an individual spin lock to protect access to their data. Signed-off-by: Simon Wunderlich simon.wunderl...@s2003.tu-chemnitz.de

Re: [B.A.T.M.A.N.] [patchv2] batman-adv: Use printk(%pM) for MAC addres

2009-12-13 Thread Simon Wunderlich
Hello Andrew, i've checked your patch against older kernel, and there seem to be some compile problems. E.g. compiling against 2.6.26, i find: CC [M] /home/dotslash/msrc/batman-svn/batman-adv-kernelland/bat_printk.o /home/dotslash/msrc/batman-svn/batman-adv-kernelland/bat_printk.c: In

Re: [B.A.T.M.A.N.] [PATCH] Removing the big batman lock

2009-12-13 Thread Simon Wunderlich
has some more severe problems (deadlocks etc) i will have to review this seperately ... :( On Mon, Nov 30, 2009 at 11:09:02AM +0100, Andrew Lunn wrote: On Sun, Nov 29, 2009 at 09:09:50PM +0100, Simon Wunderlich wrote: I did some testing, including loading, unloading, killing individual

Re: [B.A.T.M.A.N.] [PATCH] [batman-adv] Remove NULL pointer check before calling kfree

2009-12-14 Thread Simon Wunderlich
Hello Sven, thank you, applied in svn revision r1493. best regards Simon On Thu, Dec 10, 2009 at 08:00:57PM +0100, Sven Eckelmann wrote: It is safe to call kfree(NULL) which makes this extra check unneeded. It was found using checkpatch.pl from linux-2.6 Signed-off-by: Sven

Re: [B.A.T.M.A.N.] [PATCH] [batman-debug4] Fix small typo unkown - unknown

2009-12-16 Thread Simon Wunderlich
Hello Sven, thank you, applied in revision 1500. best regards Simon On Tue, Dec 15, 2009 at 04:20:10PM +0100, Sven Eckelmann wrote: Signed-off-by: Sven Eckelmann sven.eckelm...@gmx.de --- batman-debug4.pl |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git

Re: [B.A.T.M.A.N.] Typo in change set 1501

2009-12-16 Thread Simon Wunderlich
Hey Gus, thank you for point that out, i knew i forgot something. ;) fixed in revision 1502. best regards Simon On Wed, Dec 16, 2009 at 11:58:08AM -0800, Gus Wirth wrote: The fixes for typos in changeset 1501 missed one. On line 183 the Neighbour should be Neighbor to be consistent.

Re: [B.A.T.M.A.N.] required network to run

2009-12-17 Thread Simon Wunderlich
Hello Eric, the basic idea of meshing in general is: the destination nodes are probably not in the coverage area of your radio, but you still want to talk to these nodes. For example, imagine a city network where all nodes are connected to each other: You wifi cards signal is only strong

Re: [B.A.T.M.A.N.] [BULK] Re: required network to run

2009-12-18 Thread Simon Wunderlich
[mailto:b.a.t.m.a.n-boun...@lists.open-mesh.net] On Behalf Of Simon Wunderlich Sent: Wednesday, December 16, 2009 6:25 PM To: The list for a Better Approach To Mobile Ad-hoc Networking Subject: [BULK] Re: [B.A.T.M.A.N.] required network to run Importance: Low Hello Eric, the basic idea of meshing

Re: [B.A.T.M.A.N.] wireless adapter and linux kernel version

2009-12-19 Thread Simon Wunderlich
Hi Eric, there are a lot of wifi cards and drivers which don't support ad-hoc mode. I had bad experience with RTL based wifi cards. More info about drivers and supported modes can be found here: http://linuxwireless.org/en/users/Drivers Try to use Atheros based cards, most of them support

[B.A.T.M.A.N.] we are on our way into 2.6.33

2009-12-21 Thread Simon Wunderlich
Hello, just for your information (some of you probably already know it), we are on our way into the Linux mainline kernel, as you can see in the diffstat for 2.6.33-rc1: http://www.kernel.org/diff/diffview.cgi?file=/pub/linux/kernel/v2.6/testing/patch-2.6.33-rc1.bz2 (yes, it's huge, just

[B.A.T.M.A.N.] [PATCH] batman-adv: receive packets directly using skbs

2009-12-23 Thread Simon Wunderlich
not talk about the performance from this setup. Signed-off-by: Simon Wunderlich s...@hrz.tu-chemnitz.de --- Index: a/batman-adv-kernelland/types.h === --- a/batman-adv-kernelland/types.h (revision 1507) +++ b/batman-adv-kernelland

[B.A.T.M.A.N.] [PATCHv2] batman-adv: receive packets directly using skbs

2009-12-27 Thread Simon Wunderlich
() instead of asking skb-len * fix some small bugs (use kfree(skb) - kfree_skb(skb)) Signed-off-by: Simon Wunderlich s...@hrz.tu-chemnitz.de --- Index: a/batman-adv-kernelland/types.h === --- a/batman-adv-kernelland/types.h (revision

[B.A.T.M.A.N.] [PATCHv2 no pgp] batman-adv: receive packets directly using skbs

2009-12-28 Thread Simon Wunderlich
() instead of asking skb-len * fix some small bugs (use kfree(skb) - kfree_skb(skb)) Signed-off-by: Simon Wunderlich s...@hrz.tu-chemnitz.de --- Index: a/batman-adv-kernelland/types.h === --- a/batman-adv-kernelland/types.h (revision

Re: [B.A.T.M.A.N.] [PATCHv2 no pgp] batman-adv: receive packets directly using skbs

2009-12-29 Thread Simon Wunderlich
. best regards, Simon On Mon, Dec 28, 2009 at 04:10:08PM +0100, Simon Wunderlich wrote: This patch removes the (ugly and racy) packet receiving thread and the kernel socket usage. Instead, packets are received directly by registering the ethernet type and handling skbs instead of self

Re: [B.A.T.M.A.N.] [Patch 1/1] Staging: batman-adv: Use printk(%pM) for MAC addresses

2010-01-01 Thread Simon Wunderlich
with older kernels. Only build bat_printk.c with kernels that require it, thanks to Simon Wunderlich Makefile.kbuild patch. Signed-off-by: Andrew Lunn and...@lunn.ch Index: Makefile.kbuild === --- Makefile.kbuild (revision 1524

Re: [B.A.T.M.A.N.] Coccinelle tests?

2010-01-01 Thread Simon Wunderlich
Hey Andrew, thanks for forwarding! I've commited a patch, revision 1527, which should fix these things. See some comments inline below. best regards, Simon On Thu, Dec 31, 2009 at 06:07:53PM +0100, Andrew Lunn wrote: ***dev-dev_addr is a pointer. The size of an address is probably 6.

Re: [B.A.T.M.A.N.] [PATCH 3/3] batman-adv: Remove unused variable

2010-01-01 Thread Simon Wunderlich
Hey Linus, sorry, i have not seen your patch and checked this in myself (r1525). Thanks for reporting it anyway. :) best regards, Simon On Thu, Dec 31, 2009 at 04:41:20AM +0100, =?UTF-8?q?Linus=20L=C3=BCssing?= wrote: The variable 'flag' is never being used in this function,

Re: [B.A.T.M.A.N.] Missing unlocks

2010-01-01 Thread Simon Wunderlich
Hello Andrew, thank you, i've commited a patch for this in revision 1529. This should fix this bug and make sparse happy. :) best regards, Simon On Fri, Jan 01, 2010 at 06:52:59PM +0100, Andrew Lunn wrote: Hi Simon I just built batman-adv with make C=1 so that sparse it used to

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: Add bonding functionality

2010-01-17 Thread Simon Wunderlich
are purged, the bonding candidate list gets updated instead of bonding switched off. best regards, Simon On Mon, Jan 04, 2010 at 07:27:10PM +0100, Simon Wunderlich wrote: This patch introduces bonding functionality to batman-advanced, targeted for the 0.3 release. As we are able to route

Re: [B.A.T.M.A.N.] Security on adhoc network

2010-01-17 Thread Simon Wunderlich
Hey Jaideep, as Sven mentioned correctly, using the WPA sequence numbers in WPA_NONE should be ignored. Some drivers (like madwifi) have to be teached to do that. Sequence numbers do not make much sense in Ad-Hoc anyway, as there is no central management for these sequence numbers. Of course,

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: Add bonding functionality

2010-01-19 Thread Simon Wunderlich
Whoops, this is definitly a bug, thanks for pointing that out. Committed in r1552. On Mon, Jan 18, 2010 at 07:31:22PM +0800, Marek Lindner wrote: Hi, i've just committed this patch in revision 1551, as no further comments and critiques came in. I would consider this patch rather

Re: [B.A.T.M.A.N.] batman-adv on different archs

2010-01-19 Thread Simon Wunderlich
Hello, just as a side note, would you mind sharing your changes which were required to cross compile for ARM? batman-adv is supposed to support 2.6.24, and if there is any trouble with this on ARM i'd like to add support for it. Thank you very much, Simon On Tue, Jan 19, 2010 at

Re: [B.A.T.M.A.N.] race condition with activate_module?

2010-02-14 Thread Simon Wunderlich
Works fine and really seems to make a difference when trying with the ssleep() stuff from linus (which also crashes in my qemu testbed). After applying your patch it works fine. I have committed it along with some other sanity checks in r1573. On Fri, Feb 12, 2010 at 07:06:46PM +0800, Marek

Re: [B.A.T.M.A.N.] slowpath warning

2010-02-28 Thread Simon Wunderlich
-off-by: Simon Wunderlich s...@hrz.tu-chemnitz.de === --- batman-adv-kernelland/vis.c (revision 1578) +++ batman-adv-kernelland/vis.c (working copy) @@ -30,22 +30,26 @@ struct hashtable_t *vis_hash; DEFINE_SPINLOCK(vis_hash_lock

Re: [B.A.T.M.A.N.] slowpath warning

2010-03-01 Thread Simon Wunderlich
-off-by: Simon Wunderlich s...@hrz.tu-chemnitz.de Index: a/batman-adv-kernelland/vis.c === --- a/batman-adv-kernelland/vis.c (revision 1578) +++ a/batman-adv-kernelland/vis.c (working copy) @@ -30,22 +30,26 @@ struct hashtable_t

Re: [B.A.T.M.A.N.] slowpath warning

2010-03-02 Thread Simon Wunderlich
at 07:43:08AM +0100, Andrew Lunn wrote: On Mon, Mar 01, 2010 at 05:57:06PM +0100, Simon Wunderlich wrote: Hey Andrew, all list-adds and list-removes do a kref_get or kref_put respectively, but that probably was not very clear. As soon as a refence is created (by linking into the hash

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: Fixing wrap-around bug in vis

2010-03-12 Thread Simon Wunderlich
Hey, nice catch! I'd like to join the party and propose this version: #define seq_before(x,y) ((int8_t) (x - y) 0) #define seq_after(x,y) seq_before(y,x) Not so much bitshifting and may a little bit easier to understand, but also not general and does not pass Svens regression test ... :(

[B.A.T.M.A.N.] [PATCH] batman-adv: Reorganize sequence number handling

2010-04-05 Thread Simon Wunderlich
feel the same) and also fixes a bug in count_real_packets() which falsely updated the last_real_seqno for slightly older packets within the seqno window if they are no duplicates. Signed-off-by: Simon Wunderlich s...@hrz.tu-chemnitz.de Acked-by: Linus Luessing linus.luess...@web.de Index: a/batman

Re: [B.A.T.M.A.N.] Minor change in vis.c

2010-04-05 Thread Simon Wunderlich
Hey guys, thank you very much for reporting and discussing, just committed a fix (r1617 and r1618). best regards, Simon On Fri, Mar 26, 2010 at 12:08:54AM +0100, Linus Lüssing wrote: So it looks like we need a field width of 3, not 2. Ah, sorry forgot about the rest of the mail,

[B.A.T.M.A.N.] [PATCH] batman-adv: Limit queue lengths for batman and broadcast packets

2010-04-05 Thread Simon Wunderlich
of maximum space available in total for typical setups (assuming one packet including overhead does not require more than 2000 byte). This should also be reasonable for smaller routers, otherwise the defines can be tweaked later. Signed-off-by: Simon Wunderlich s...@hrz.tu-chemnitz.de --- Index

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: Limit queue lengths for batman and broadcast packets

2010-04-05 Thread Simon Wunderlich
Hey Sven, you are right, this might be indeed a problem. I'll send an updated patch which removes the problem by employing atomic_add_unless(). Marek also pointed out that global variables are not very pretty as we are moving all the global stuff into bat_priv to allow multiple mesh soft

[B.A.T.M.A.N.] [PATCHv2] batman-adv: Limit queue lengths for batman and broadcast packets

2010-04-05 Thread Simon Wunderlich
of maximum space available in total for typical setups (assuming one packet including overhead does not require more than 2000 byte). This should also be reasonable for smaller routers, otherwise the defines can be tweaked later. Signed-off-by: Simon Wunderlich s...@hrz.tu-chemnitz.de --- Index: a/batman

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: Reorganize sequence number handling

2010-04-06 Thread Simon Wunderlich
it! [ 847.936099] XXX protect it! [ 848.560450] XXX protect it! [ 907.686827] XXX protect it! [ 1994.836111] XXX protect it! Cheers, Linus On Mon, Apr 05, 2010 at 12:01:20AM +0200, Simon Wunderlich wrote: BATMAN and broadcast packets are tracked with a sequence number window

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: Reorganize sequence number handling

2010-04-06 Thread Simon Wunderlich
but the original sender flood the same packets on all interfaces ... I'll look into this, thanks. Simon On Tue, Apr 06, 2010 at 03:11:05PM +0200, Linus Lüssing wrote: On Tue, Apr 06, 2010 at 12:41:29PM +0200, Simon Wunderlich wrote: Hi Linus, from the time where the messages come (the printk

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: Reorganize sequence number handling

2010-04-06 Thread Simon Wunderlich
be a good idea. best regards, Simon On Tue, Apr 06, 2010 at 07:58:09PM +0200, Simon Wunderlich wrote: Hi Linus, i've verified and can reproduce the problem. The queue limitation patch removes the OOM problems, but the same packets are still broadcasted. It is always the same sequence

[B.A.T.M.A.N.] [PATCHv2] batman-adv: Reorganize sequence number handling

2010-04-06 Thread Simon Wunderlich
window, and removes the loop for seq_diff == -64 which was present in the first patch. Signed-off-by: Simon Wunderlich s...@hrz.tu-chemnitz.de --- Index: a/batman-adv-kernelland/types.h === --- a/batman-adv-kernelland/types.h

[B.A.T.M.A.N.] [PATCHv3] batman-adv: Limit queue lengths for batman and broadcast packets

2010-04-07 Thread Simon Wunderlich
sequence number when the queue is already full. Signed-off-by: Simon Wunderlich s...@hrz.tu-chemnitz.de --- Index: a/batman-adv-kernelland/send.c === --- a/batman-adv-kernelland/send.c (revision 1616) +++ a/batman-adv-kernelland

Re: [B.A.T.M.A.N.] Patch batman-adv for kernel 2.6.15

2010-04-12 Thread Simon Wunderlich
Hello Franz, the workqueues are the most non-trivial thing which prevented us so far from backporting batman-adv to these older kernel. I'd also be interested to integrate patches if anyone has a solution for this. :) best regards, Simon On Mon, Apr 12, 2010 at 09:28:30AM +0200, Franz

Re: [B.A.T.M.A.N.] [PATCHv3] batman-adv: Limit queue lengths for batman and broadcast packets

2010-04-12 Thread Simon Wunderlich
) -- Cheers, Linus On Wed, Apr 07, 2010 at 10:11:23AM +0200, Simon Wunderlich wrote: This patch limits the queue lengths of batman and broadcast packets. BATMAN packets are held back for aggregation and jittered to avoid interferences. Broadcast packets are stored to be sent out multiple

[B.A.T.M.A.N.] [PATCH] 32bit sequence number and TTL for broadcasts

2010-04-25 Thread Simon Wunderlich
to make sure. These changes required to increase the compatibility level once again. It should therefore only applied to the upcoming 0.3 branch. Signed-off-by: Simon Wunderlich s...@hrz.tu-chemnitz.de --- Index: a/batman-adv-kernelland/vis.c

Re: [B.A.T.M.A.N.] [PATCH] 32bit sequence number and TTL for broadcasts

2010-04-26 Thread Simon Wunderlich
Hello Sven, thank you for your review. I've compiled and tested it in my openwrt qemu build environment, which is built on linux 2.6.31.1. I have not checked it on any other platforms so far. best regards, Simon On Sun, Apr 25, 2010 at 10:48:13PM +0200, Sven Eckelmann wrote: First

Re: [B.A.T.M.A.N.] [PATCH 13/26] staging:batman-adv: convert multiple /proc files to use sysfs

2010-05-16 Thread Simon Wunderlich
Hello Andrew, thank you very much for your suggetions. I'm currently sitting here with Marek and Sven in Berlin and we were discussing your suggestions. Our conclusion is: * We could write and read enable/disable only from the respective files (like aggregation). In this case we don't need

Re: [B.A.T.M.A.N.] [PATCH] Staging: batman-adv: bonding and interface alternating

2010-06-04 Thread Simon Wunderlich
Hey, i've checked in a changed and fixed up version of this patch in r1686. This version has the interface alternating enabled by default, so we don't need to change the bonding_enabled to bonding_mode anymore. We have decided here in Bracciano to have alternating as default as it appears to be

Re: [B.A.T.M.A.N.] [PATCH] Staging: batman-adv: bonding and interface alternating

2010-06-05 Thread Simon Wunderlich
Hey Sven, On Fri, Jun 04, 2010 at 10:56:50PM +0200, Sven Eckelmann wrote: Simon Wunderlich wrote: I've also followed your other comments (hopefully correctly), so thank you very much for the review. [...] This is an experimental patch and targeted for upcoming experiments

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: return -EFAULT on copy_to_user errors

2010-06-05 Thread Simon Wunderlich
Thank you, applied in svn r1689. On Thu, Jun 03, 2010 at 01:33:27PM +0200, Sven Eckelmann wrote: From: Dan Carpenter erro...@gmail.com copy_to_user() returns the number of bites remaining but we want to return a negative error code here. Signed-off-by: Dan Carpenter erro...@gmail.com

Re: [B.A.T.M.A.N.] [PATCH 1/3] batman: Correct gw_speed down bit mask

2010-06-05 Thread Simon Wunderlich
Thanks, applied in svn r1691. On Thu, Jun 03, 2010 at 12:58:34AM +0200, Sven Eckelmann wrote: We want to get bits .... and not as the mask would suggest .O.. when we decode the encoded bits for the download part of the gateway speed. Reported-By: Bill Meier wme...@newsguy.com

Re: [B.A.T.M.A.N.] release cycle

2010-06-10 Thread Simon Wunderlich
Hello, the year numbering scheme would be fine with me, currently i can't think of anything which would speak against it and it would represent our evolutional model quite well. I would vote to apply it. best regards, Simon On Wed, Jun 09, 2010 at 02:06:03PM +0200, Sven Eckelmann

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: permit setting ogm interval to JITTER*2

2010-06-18 Thread Simon Wunderlich
Thanks Linus, applied in r1701. On Fri, Jun 18, 2010 at 07:54:04PM +0200, Linus Lüssing wrote: When trying to set the originator interval to 40ms, we are asked to set it to a minimum value of 40ms. This patch permits setting an originator interval of JITTER*20 (40ms by default) now.

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: Avoid rounding issues for local hna timeout

2010-06-20 Thread Simon Wunderlich
Hey Linus, thanks, applied in r1710. Cheers, Simon On Sat, Jun 19, 2010 at 05:24:34PM +0200, Linus Lüssing wrote: With the current default values, this patch is not critical, as LOCAL_HNA_TIMEOUT is a multiple of 1000 anyway. However, if someone would like to change this #define, the

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: permit setting ogm interval to JITTER*2

2010-06-20 Thread Simon Wunderlich
Guess i forgot to mention that your patch was applied in r1701. :) Thank you, Simon On Fri, Jun 18, 2010 at 07:54:04PM +0200, Linus Lüssing wrote: When trying to set the originator interval to 40ms, we are asked to set it to a minimum value of 40ms. This patch permits setting an

  1   2   3   4   5   6   7   8   9   10   >