Re: [B.A.T.M.A.N.] [PATCH] batman-adv: compat: Substitute compat code for netlink constification

2016-10-20 Thread Linus Lüssing
On Wed, Oct 19, 2016 at 08:31:03AM +0200, Sven Eckelmann wrote: > On Mittwoch, 19. Oktober 2016 01:22:39 CEST Linus Lüssing wrote: > > On Tue, Oct 18, 2016 at 11:28:23PM +0200, Sven Eckelmann wrote: > > > Doesn't seem to scale. Especially when we think about batadv_netlink_ops > > > which should

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: compat: Substitute compat code for netlink constification

2016-10-19 Thread Sven Eckelmann
On Mittwoch, 19. Oktober 2016 01:22:39 CEST Linus Lüssing wrote: > On Tue, Oct 18, 2016 at 11:28:23PM +0200, Sven Eckelmann wrote: > > Doesn't seem to scale. Especially when we think about batadv_netlink_ops > > which should also be const. It is currently not const because of the > > Linux <= 3.13

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: compat: Substitute compat code for netlink constification

2016-10-18 Thread Linus Lüssing
On Tue, Oct 18, 2016 at 11:28:23PM +0200, Sven Eckelmann wrote: > Doesn't seem to scale. Especially when we think about batadv_netlink_ops > which should also be const. It is currently not const because of the > Linux <= 3.13 workaround. Hm, okay, batadv_netlink_ops is a little more

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: compat: Substitute compat code for netlink constification

2016-10-18 Thread Sven Eckelmann
On Dienstag, 18. Oktober 2016 23:21:25 CEST Linus Lüssing wrote: > Substitutes the compat-patches approach for the netlink const changes to > the prefered way of using compat-includes. > > Signed-off-by: Linus Lüssing > --- > compat-include/net/genetlink.h | 15

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: compat: Substitute compat code for netlink constification

2016-10-18 Thread Linus Lüssing
On Tue, Oct 18, 2016 at 11:21:25PM +0200, Linus Lüssing wrote: > Substitutes the compat-patches approach for the netlink const changes to > the prefered way of using compat-includes. > > Signed-off-by: Linus Lüssing > --- Actually, it isn't a substitution yet, the