2012/7/25 Joe Perches :
> On Wed, 2012-07-25 at 16:22 +0200, Rafał Miłecki wrote:
>> 2012/7/25 Joe Perches :
>> > On Wed, 2012-07-25 at 16:47 +0200, Rafał Miłecki wrote:
>> >> use PHY names instead of magic numbers.
>> > []
>> >> diff --git a/drivers/net/wireless/b43/main.c
>> >> b/drivers/net/wir
On Wed, 2012-07-25 at 16:22 +0200, Rafał Miłecki wrote:
> 2012/7/25 Joe Perches :
> > On Wed, 2012-07-25 at 16:47 +0200, Rafał Miłecki wrote:
> >> use PHY names instead of magic numbers.
> > []
> >> diff --git a/drivers/net/wireless/b43/main.c
> >> b/drivers/net/wireless/b43/main.c
> > []
> >> @@
2012/7/25 Joe Perches :
> On Wed, 2012-07-25 at 16:47 +0200, Rafał Miłecki wrote:
>> use PHY names instead of magic numbers.
> []
>> diff --git a/drivers/net/wireless/b43/main.c
>> b/drivers/net/wireless/b43/main.c
> []
>> @@ -4277,6 +4277,37 @@ out:
> []
>> +static char *b43_phy_name(struct b43_w
On Wed, 2012-07-25 at 16:47 +0200, Rafał Miłecki wrote:
> use PHY names instead of magic numbers.
[]
> diff --git a/drivers/net/wireless/b43/main.c b/drivers/net/wireless/b43/main.c
[]
> @@ -4277,6 +4277,37 @@ out:
[]
> +static char *b43_phy_name(struct b43_wldev *dev, u8 phy_type)
> +{
> + swi
First of all, use PHY names instead of magic numbers. It should make
configuring kernel easier in case of not enabled PHY type support.
Secondly, always print info about PHY. This is really basic info about
hardware and quite important for the support level.
Signed-off-by: Rafał Miłecki
---
V2: a