reless-next and wireless-testing. Sending a patch series is a lot
easier and causes less tears.
--
Kalle Valo
___
b43-dev mailing list
b43-dev@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/b43-dev
xt.
>
> It should be possible for it to be based on the latest release from
> Linus.
But then it would not contain all the changes in wireless-testing.
--
Kalle Valo
___
b43-dev mailing list
b43-dev@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/b43-dev
David Woodhouse writes:
> On Sat, 2011-08-27 at 15:08 +0300, Kalle Valo wrote:
>> > It should be possible for it to be based on the latest release from
>> > Linus.
>>
>> But then it would not contain all the changes in wireless-testing.
>
> That is the poi
emplates for this
> pointer in the function, b43_update_templates internally in the
> function, b43_op_beacon_set_tim.
>
> Signed-off-by: Nicholas Krause
Based on the discussion I have dropped this patch.
--
Kalle Valo
___
b43-
gt; [] ieee80211_queue_work+0x20/0x40 [mac80211]
> [] b43_led_brightness_set+0x28/0x30 [b43]
> [] led_timer_function+0xd5/0xe0
> [] call_timer_fn+0xa4/0x4a0
>
> Signed-off-by: Sabrina Dubroca
Thanks, applied to wireless-drivers-next.git.
Kalle Valo
__
ending small patches allows better review of changes & should
> result in a better code quality. Let me know if there are any
> problems.
Sounds good to me. Just keep dependency to BROKEN until it's usable and
make sure that the code compiles after every patch.
--
Kalle Valo
_
hael Buesch
> Tested-by: Larry Finger
Thanks, applied to wireless-drivers-next.git.
Kalle Valo
___
b43-dev mailing list
b43-dev@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/b43-dev
tch my patch. Trying again.
Odd, I still don't see it in patchwork. I wonder what caused that?
--
Kalle Valo
___
b43-dev mailing list
b43-dev@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/b43-dev
Jonas Gorski writes:
> On Tue, Mar 3, 2015 at 4:05 PM, Kalle Valo wrote:
>>> RESEND: It seems patchwork didn't catch my patch. Trying again.
>>
>> Odd, I still don't see it in patchwork. I wonder what caused that?
>
> I also see it neither in my b43-dev
ation. But thanks for double checking, I
can sleep safer now :)
--
Kalle Valo
___
b43-dev mailing list
b43-dev@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/b43-dev
> Use bool constants as the return values instead of 1 and 0.
>
> Signed-off-by: Joe Perches
Thanks, applied to wireless-drivers-next.git.
Kalle Valo
___
b43-dev mailing list
b43-dev@lists.infradead.org
http://lists.infradead.org/mailman
> This fixes a typo in the "b43_lo_g_maintenance_work" function
> name.
>
> Signed-off-by: Nik Nyby
> Acked-by: Larry Finger
> Acked-by: Michael Buesch
Thanks, applied to wireless-drivers-next.git.
Kalle Valo
___
Should this go to 4.2?
--
Kalle Valo
___
b43-dev mailing list
b43-dev@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/b43-dev
Hauke Mehrtens writes:
> On 07/30/2015 08:54 AM, Rafał Miłecki wrote:
>> On 30 July 2015 at 07:40, Kalle Valo wrote:
>>> Hauke Mehrtens writes:
>>>
>>>> On the 2GHz and and on the 5GHZ band only the extpa_gain setting from
>>>> the 5GHz band
> On the 2GHz and and on the 5GHZ band only the extpa_gain setting from
> the 5GHz band was checked. this patch makes it check the property from
> the correct band.
>
> Signed-off-by: Hauke Mehrtens
Thanks, applied to wireless-drivers.g
tch instead, so we can finally apply it.
>
> It needs to be tested on both ssb and bcma. Come on. This isn't too
> hard. :) Please somebody with any hardware test it. (I currently don't
> have any b43 hardware)
And the patch can be downloaded from patchwork:
https://patchwork.
xt.git:
10fbc7cf031d b43: Remove unnecessary synchronize_irq() before free_irq()
400b43c58269 rtlwifi: Remove unnecessary synchronize_irq() before free_irq()
Kalle Valo
___
b43-dev mailing list
b43-dev@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/b43-dev
important fix, we should probably apply it.
>
> Sudip, can you please update the patch so it applies cleanly on the
> current tree? You can add my acked-by if you want.
>
> Kalle, can you please apply it afterwards?
Will do.
--
Kalle Valo
___
b43-dev mailing list
b43-dev@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/b43-dev
; Thanks Michael for his suggestion.
>
> Signed-off-by: Jia-Ju Bai
> Acked-by: Michael Büsch
> Signed-off-by: Sudip Mukherjee
If no objections I'm planning to queue this to 4.6-rc2.
--
Kalle Valo
___
b43-dev mail
suggestion.
>
> Signed-off-by: Jia-Ju Bai
> Acked-by: Michael Büsch
> Signed-off-by: Sudip Mukherjee
Thanks, applied to wireless-drivers.git.
Kalle Valo
___
b43-dev mailing list
b43-dev@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/b43-dev
x27;t submitted correctly (didn't
> go to linux-wireless):
> https://lkml.org/lkml/2015/11/2/154
Nobody resubmitted that patch?
--
Kalle Valo
___
b43-dev mailing list
b43-dev@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/b43-dev
Michael Büsch writes:
> In the final submission please send this to Kalle Valo and add [PATCH]
> to the subject, so tools can pick this up.
And remember to CC linux-wireless so that patchwork sees the patch. I
skip the patches sent via email and only follow patchwork:
and aren't affected by this change.
>
> Signed-off-by: Adrian Chadd
Two cosmetic problems: s/\[b43\]/b43: / and remove the tab before the
S-o-b. I can fix them before applying. But most probably I'll apply this
only after the merge window clos
Adrian Chadd wrote:
> Check the current PHY operating mode (gmode) to see if we should
> fall back from 6MB OFDM to 11MB CCK. For 5GHz operation this isn't
> allowed.
>
> Note, the fallback lookup is only done for RTS rates; normal fallback
> rates are done via mac80211 and aren't affected by th
Lucas Stach wrote:
> Only hardcode the LED behavior if the SROM doesn't provide any for all
> LEDs of the card. This avoids instantiating LED triggers for unconnected
> LEDs, while (hopefully) keeping things working for old cards with a
> blank SROM.
>
> Signed-off-by: Lucas Stach
Thanks, 1 pat
Guenter Roeck wrote:
> gcc-6 reports the following error with -Werror=unused-const-variable.
>
> drivers/net/wireless/broadcom/b43/phy_a.c:576:40: error:
> 'b43_phyops_a' defined but not used
>
> Per Michael Büsch: "All a-phy code is usused", so remove it all,
> and move the remaining Type
Michael Büsch writes:
> On Thu, 16 Jun 2016 15:23:37 + (UTC)
> Kalle Valo wrote:
>
>> Guenter Roeck wrote:
>> > gcc-6 reports the following error with -Werror=unused-const-variable.
>> >
>> > drivers/net/wireless/broadcom/b43/phy_a.c:576:40: err
ntroduction of intermediate
>> fops in debugfs by commit 9fd4dcece43a
>> ("debugfs: prevent access to possibly dead file_operations at file open")
>
> Because of this, these should all be backported to 4.7-stable, and
> 4.8-stable, right?
Via which tree should these go,
Greg KH writes:
> On Sun, Sep 18, 2016 at 10:54:18AM +0300, Kalle Valo wrote:
>> Greg KH writes:
>>
>> > On Sat, Sep 17, 2016 at 09:43:02PM +0200, Christian Lamparter wrote:
>> >> Ben Greear reported:
>> >> > I see lots of instabilit
Iwai
With recent you mean three years ago? ;) Some of these were added by
Rafal (CCed) in commit 15be8e89cdd99 and some in a60f99f75dd35.
I'll replace the word recent and add:
Fixes: 15be8e89cdd9 ("b43: add more bcma cores")
But as this is so old bug I'
Takashi Iwai wrote:
> Some firmware entries were forgotten to be added via MODULE_FIRMWARE(), which
> may result in the non-functional state when the driver is loaded in initrd.
>
> Link: http://bugzilla.opensuse.org/show_bug.cgi?id=1037344
> Fixes: 15be8e89cdd9 ("b43: add more bcma cores")
> Sig
gt;irq_lock, flags);
To me this looks like a fragile workaround and not a real fix. You can
easily add new race conditions with releasing the lock like this.
--
Kalle Valo
___
b43-dev mailing list
b43-dev@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/b43-dev
you also mention your tool in the commit log, makes understanding
the background of the patch easier.
--
Kalle Valo
___
b43-dev mailing list
b43-dev@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/b43-dev
sleeping with a lock held.
Sure, but IMHO in general I think the practise of releasing the lock
like this in a middle of function is dangerous as one can easily miss
that upper and lower halves of the function are not actually atomic
anymore. And in this case that it's under a co
Colin Ian King wrote:
> From: Colin Ian King
>
> The u8 char array ret is not being initialized and elements outside
> the range start to end contain just garbage values from the stack.
> This results in a later scan of the array to read potentially
> uninitialized values. Fix this by initiali
Colin Ian King wrote:
> From: Colin Ian King
>
> Don't populate const arrays on the stack, instead make them static.
> Makes the object code smaller by over 60 bytes:
>
> Before:
>text data bss dec hex filename
> 14816 1296 0 161123ef0 b43/phy_ht
Jia-Ju Bai wrote:
> b43_radio_2057_init_post is not called in an interrupt handler
> nor holding a spinlock.
> The function mdelay in it can be replaced with msleep, to reduce busy wait.
>
> Signed-off-by: Jia-Ju Bai
You submitted an identical patch a week earlier:
https://patchwork.kernel.o
Larry Finger writes:
> On 01/08/2018 10:21 AM, Kalle Valo wrote:
>> Jia-Ju Bai wrote:
>>
>>> b43_radio_2057_init_post is not called in an interrupt handler
>>> nor holding a spinlock.
>>> The function mdelay in it can be replaced with msleep, to reduc
Jia-Ju Bai wrote:
> b43_radio_2057_init_post is not called in an interrupt handler
> nor holding a spinlock.
> The function mdelay in it can be replaced with usleep_range,
> to reduce busy wait.
>
> Signed-off-by: Jia-Ju Bai
> Acked-by: Larry Finger
Patch applied to wireless-drivers-next.git
and other maintainers as
well, need to waste time trying to guess what's your plan.
I will now drop the four wireless patches from my queue. So if you want
to me to take them please resubmit.
--
Kalle Valo
___
b43-dev mailing list
b43-dev@li
Kalle Valo writes:
> Joe Perches writes:
>
>> Use the new ether_broadcast_addr global instead to save some object code.
>>
>> Signed-off-by: Joe Perches
>> ---
>> drivers/net/wireless/admtek/adm8211.c | 3 +--
>> drivers/net/wireless/ath/c
Jia-Ju Bai wrote:
> dma_tx_fragment() is never called in atomic context.
>
> dma_tx_fragment() is only called by b43legacy_dma_tx(), which is
> only called by b43legacy_tx_work().
> b43legacy_tx_work() is only set a parameter of INIT_WORK() in
> b43legacy_wireless_init().
>
> Despite never ge
mentation/submittingpatches#commit_title_is_wrong
--
Kalle Valo
___
b43-dev mailing list
b43-dev@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/b43-dev
k...@sra-tohoku.co.jp wrote:
> From: Taketo Kabe
>
> Fix for b43 wireless card stopping transmission when switching VTs.
>
> Setup:
> Using BCM4306 rev.03 chip based CardBus wireless card.
> IRQ is shared with yenta (cardbus bridge) and i915 (display) driver.
> For firmware, installed latest bu
k...@sra-tohoku.co.jp wrote:
> From: Taketo Kabe
>
> Setup:
> Using BCM4306 rev.03 chip based CardBus wireless card.
> IRQ is shared with yenta (cardbus bridge) and i915 (display) driver.
> For firmware, installed latest but dated openfwwf 5.2
> (http://netweb.ing.unibs.it/~openfwwf/)
>
> How-t
0d1950f b43/leds: Ensure NUL-termination of LED name string
--
Kalle Valo
___
b43-dev mailing list
b43-dev@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/b43-dev
Michael Büsch writes:
> strncpy might not NUL-terminate the string, if the name equals the buffer
> size.
> Use strlcpy instead.
>
> Signed-off-by: Michael Buesch
> Cc: sta...@vger.kernel.org
Applied manually:
4d77a89e3924 b43legacy/leds: Ensure NUL-termination of LED name
ichael Buesch
> Cc: Joe Perches
Applied manually:
4d77a89e3924 b43legacy/leds: Ensure NUL-termination of LED name string
--
Kalle Valo
___
b43-dev mailing list
b43-dev@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/b43-dev
ch
Applied manually:
209b43759d65 ssb: Remove SSB_WARN_ON, SSB_BUG_ON and SSB_DEBUG
--
Kalle Valo
___
b43-dev mailing list
b43-dev@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/b43-dev
Kalle Valo writes:
> Michael Büsch writes:
>
>> Replace the ssb printk wrappers by standard print helpers.
>> Also remove SSB_SILENT. Nobody should use it anyway.
>>
>> Originally submitted by Joe Perches .
>> Modified to add dev_... based printks.
>>
&
Jonas Gorski writes:
> On 9 August 2018 at 17:28, Kalle Valo wrote:
>> Michael Büsch writes:
>>
>>> strncpy might not NUL-terminate the string, if the name equals the buffer
>>> size.
>>> Use strlcpy instead.
>>>
>>> Signed-off-by:
Jonas Gorski writes:
> On 9 August 2018 at 18:15, Kalle Valo wrote:
>> Jonas Gorski writes:
>>
>>> On 9 August 2018 at 17:28, Kalle Valo wrote:
>>>> Michael Büsch writes:
>>>>
>>>>> strncpy might not NUL-terminate the strin
Jonas Gorski writes:
> On 9 August 2018 at 19:01, Kalle Valo wrote:
>> Jonas Gorski writes:
>>
>>> On 9 August 2018 at 18:15, Kalle Valo wrote:
>>>> Jonas Gorski writes:
>>>>
>>>>> On 9 August 2018 at 17:28, Kalle Valo wrote:
alle, can you please revert the commit
> 66cffd6daab76caebab26eb803b92182414fc182
> ?
Please submit a proper patch with an explanation why it needs to be
reverted.
--
Kalle Valo
___
b43-dev mailing list
b43-dev@lists.infradead.org
http://lists.i
Colin King wrote:
> From: Colin Ian King
>
> Trivial fix to spelling mistake struct field name, rename it.
>
> Signed-off-by: Colin Ian King
Patch applied to wireless-drivers-next.git, thanks.
297fab130cdf b43: fix spelling mistake "hw_registred" -> "hw_registered"
--
https://patchwork.ke
YueHaibing wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/net/wireless/broadcom/b43/main.c: In function 'b43_one_core_detach':
> drivers/net/wireless/broadcom/b43/main.c:5496:17: warning:
> variable 'wl' set but not used [-Wunused-but-set-variable]
>
> After commit 644aa4
all five patches in patchwork.
Also I don't see MAINTAINERS entry for cordic.[c|h], that would be good
to have as well.
--
Kalle Valo
___
b43-dev mailing list
b43-dev@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/b43-dev
Kalle Valo writes:
> Priit Laes writes:
>
>> b43 wireless driver included internal implementation of cordic
>> algorithm which has now been removed in favor of library
>> implementation.
>>
>> During the process, brcmfmac was driver was also cleaned.
>&g
Arend van Spriel writes:
> On 11/5/2018 9:02 AM, Kalle Valo wrote:
>> Also I don't see MAINTAINERS entry for cordic.[c|h], that would be good
>> to have as well.
>
> We added the cordic library functions during brcm80211 staging
> cleanup. We can add it to MAI
Priit Laes writes:
> Signed-off-by: Priit Laes
No empty commit logs, please.
And IMHO you could fold patch 5 into patch 4.
--
Kalle Valo
___
b43-dev mailing list
b43-dev@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/b43-dev
series=43097
I'll now wait for the review comments.
--
Kalle Valo
___
b43-dev mailing list
b43-dev@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/b43-dev
t; https://gist.github.com/plaes/284993a4fc65e0926d0628a11f0cf874
>
> So at current state, this is self-NAK from me too and this patch should
> be dropped.
Ok, I'll drop patch 3 but keep patches 1-2 still in review. Thanks for
verifying this!
But of course it would be better if s
get fixed. Of course, your 3rd patch will need
> to be revised. If all 4 of the patches get submitted together there
> will be no problems with the timing. My change will exist for seconds
> in the mainline kernel, but it will get propagated back through
> stable.
Sorry Larry, I'm not fully understanding what you mean here. So I'm
going to just drop the whole series and assume that Priit will submit a
new version. Please let me know if I should do something else.
--
Kalle Valo
___
b43-dev mailing list
b43-dev@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/b43-dev
;
>
> Gah.. I missed the series version in subject. Shall I resend?
No need, I'll remember now that this is v4.
--
Kalle Valo
___
b43-dev mailing list
b43-dev@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/b43-dev
Priit Laes wrote:
> Now that these macros are in header file, we can eventually
> clean up the duplicate macros present in the drivers that
> utilize the same cordic algorithm implementation.
>
> Also add CORDIC_ prefix to nonprefixed macros.
>
> Reviewed-by: Arend van Spriel
> Signed-off-by:
YueHaibing wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/net/wireless/broadcom/b43/phy_n.c: In function
> 'b43_nphy_op_recalc_txpower':
> drivers/net/wireless/broadcom/b43/phy_n.c:5898:7: warning:
> variable 'tx_pwr_state' set but not used [-Wunused-but-set-variable]
>
>
Greg Kroah-Hartman wrote:
> When calling debugfs functions, there is no need to ever check the
> return value. The function can work or not, but the code logic should
> never do something different based on this.
>
> Cc: Kalle Valo
> Cc: linux-wirel...@vger.kernel
Greg Kroah-Hartman wrote:
> When calling debugfs functions, there is no need to ever check the
> return value. The function can work or not, but the code logic should
> never do something different based on this.
>
> Cc: Larry Finger
> Cc: Kalle Valo
> Cc: linux-wirel...
Arnd Bergmann wrote:
> Clang warns about what is clearly a case of passing an uninitalized
> variable into a static function:
>
> drivers/net/wireless/broadcom/b43/phy_lp.c:1852:23: error: variable 'gains'
> is uninitialized when used here
> [-Werror,-Wuninitialized]
> lpp
43/main.c | 7 +--
> 1 file changed, 1 insertion(+), 6 deletions(-)
You can use just "b43:" as prefix, no need to have "net:" nor
"wireless:" in the title. I'll fix it this time, but please use correct
style in the future.
https://wireless.wiki.kernel.or
Jia-Ju Bai wrote:
> In b43_request_firmware(), when ieee80211_register_hw() fails,
> b43_one_core_detach() is called. In b43_bcma_remove() and
> b43_ssb_remove(), b43_one_core_detach() is called again. In this case,
> null-pointer dereferences and double-free problems can occur when
> the drive
Jia-Ju Bai wrote:
> In b43_request_firmware(), when ieee80211_register_hw() fails,
> b43_one_core_detach() is called. In b43_bcma_remove() and
> b43_ssb_remove(), b43_one_core_detach() is called again. In this case,
> null-pointer dereferences and double-free problems can occur when
> the drive
Christoph Hellwig wrote:
> These days drivers are not required to fallback to smaller DMA masks,
> but can just set the largest mask they support, removing the need for
> this trial and error logic.
>
> Signed-off-by: Christoph Hellwig
> Tested-by: Larry Finger
4 patches applied to wireless-d
Christoph Hellwig wrote:
> These days drivers are not required to fallback to smaller DMA masks,
> but can just set the largest mask they support, removing the need for
> this trial and error logic.
>
> Signed-off-by: Christoph Hellwig
> Tested-by: Larry Finger
4 patches applied to wireless-d
>
> Remove the wrapper and invoke cond_resched() directly.
>
> Found while looking for CONFIG_PREEMPT dependent code treewide.
>
> Signed-off-by: Thomas Gleixner
> Cc: net...@vger.kernel.org
> Cc: b43-dev@lists.infradead.org
> Cc: Kalle Valo
> Cc: Larry Finger
I use
Thomas Gleixner wrote:
> cond_resched() can be used unconditionally. If CONFIG_PREEMPT is set, it
> becomes a NOP scheduler wise.
>
> Also the B43_BUG_ON() in that wrapper is a homebrewn variant of
> __might_sleep() which is part of cond_resched() already.
>
> Remove the cruft and invoke cond_r
Thomas Gleixner wrote:
> cond_resched() can be used unconditionally. If CONFIG_PREEMPT is set, it
> becomes a NOP scheduler wise.
>
> Also the B43_BUG_ON() in that wrapper is a homebrewn variant of
> __might_sleep() which is part of cond_resched() already.
>
> Remove the cruft and invoke cond_r
(manually fixing the Cc field)
Saurav Girepunje writes:
> use true/false for bool type variables assignment.
>
> Signed-off-by: Saurav Girepunje
I don't see any of your three patches in linux-wireless list and hence
neither in patchwork:
https://patchwork.kernel.org/project/linux-wireless/lis
Saurav Girepunje wrote:
> use true/false on bool type variable assignment.
>
> Signed-off-by: Saurav Girepunje
Patch applied to wireless-drivers-next.git, thanks.
6db774c17250 b43: main: Fix use true/false for bool type
--
https://patchwork.kernel.org/patch/11216303/
https://wireless.wiki.
Saurav Girepunje wrote:
> use true/false for bool type variables assignment.
>
> Signed-off-by: Saurav Girepunje
Patch applied to wireless-drivers-next.git, thanks.
a9160bb35ad9 b43: dma: Fix use true/false for bool type variable
--
https://patchwork.kernel.org/patch/11216307/
https://wire
qiwuche...@gmail.com wrote:
> From: chenqiwu
>
> The simple_strtol() function is deprecated since it does not
> check for the range overflow. Use kstrtoint() instead.
>
> Signed-off-by: chenqiwu
Patch applied to wireless-drivers-next.git, thanks.
871b4b48cdbf b43legacy: replace simple_strtol
Jason Yan wrote:
> Fix the following coccicheck warning:
>
> drivers/net/wireless/broadcom/b43/phy_n.c:5510:19-32: WARNING:
> Comparison of 0/1 to bool variable
>
> Signed-off-by: Jason Yan
Patch applied to wireless-drivers-next.git, thanks.
e2b9ac590810 b43: remove Comparison of 0/1 to bool
Jason Yan wrote:
> Fix the following coccicheck warning:
>
> drivers/net/wireless/broadcom/b43/pio.c:768:10-25: WARNING: Comparison
> of 0/1 to bool variable
>
> Signed-off-by: Jason Yan
Patch applied to wireless-drivers-next.git, thanks.
f8f24ece2192 b43: remove Comparison of 0/1 to bool va
Jason Yan wrote:
> This function is dead for more than 10 years. Remove it.
>
> Signed-off-by: Jason Yan
Patch applied to wireless-drivers-next.git, thanks.
f2cd32a443da rndis_wlan: Remove logically dead code
--
https://patchwork.kernel.org/patch/11533111/
https://wireless.wiki.kernel.org/
Michael Büsch writes:
> On Thu, 21 May 2020 16:47:41 -0500
> Larry Finger wrote:
>
>> On 5/21/20 3:23 PM, Rui Salvaterra wrote:
>> > On Thu, 21 May 2020 at 20:19, Rui Salvaterra
>> > wrote:
>> >>
>> >> Sure, I'll give it a spin. I'm now compiling the kernel for the laptop
>> >> with the othe
Rafał Miłecki writes:
> On Fri, 22 May 2020 at 23:06, Larry Finger wrote:
>> On 5/22/20 3:40 PM, Rui Salvaterra wrote:
>> > On Fri, 22 May 2020 at 19:02, Larry Finger
>> > wrote:
>> >>
>> >> Rui,
>> >>
>> >> Does this one-line
>> >> patch work for WPA3 without setting the nohwcrypt option?
>>
Pali Rohár writes:
> Add _WLAN suffix to macro names for consistency with other Marvell macros.
> These IDs represents wlan function of combo bt/wlan cards. Other functions
> of these cards have different IDs.
>
> Signed-off-by: Pali Rohár
Acked-by: Kalle V
Pali Rohár writes:
> Also replace generic MANUFACTURER macros by proper SDIO IDs macros.
>
> Check for "AR6003 or later" is slightly modified to use SDIO device IDs.
> This allows removal of all custom MANUFACTURER macros from ath6kl.
>
> Signed-off-by: Pali
igned-off-by: Kees Cook
To which tree should this go? If something else than wireless-drivers
tree:
Acked-by: Kalle Valo
But let me know if you want me to take this.
--
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
___
Kees Cook writes:
> Using uninitialized_var() is dangerous as it papers over real bugs[1]
> (or can in the future), and suppresses unrelated compiler warnings (e.g.
> "unused variable"). If the compiler thinks it is uninitialized, either
> simply initialize the variable or make compiler changes.
| 2 +-
> drivers/net/wireless/intel/iwlegacy/3945.c | 2 +-
> drivers/net/wireless/intel/iwlegacy/4965-mac.c | 2 +-
> .../net/wireless/realtek/rtlwifi/rtl8192cu/hw.c | 4 ++--
For wireless drivers:
Acked-by: Kalle Valo
--
https://wireless.wiki.kernel.org/en/developers/document
Flavio Suligoi wrote:
> In some ath files, the wiki url is still the old
> "wireless.kernel.org" instead of the new
> "wireless.wiki.kernel.org"
>
> Signed-off-by: Flavio Suligoi
> Signed-off-by: Kalle Valo
Patch applied to ath-next branch of ath.gi
Flavio Suligoi wrote:
> The wiki url is still the old "wireless.kernel.org"
> instead of the new "wireless.wiki.kernel.org"
>
> Signed-off-by: Flavio Suligoi
3 patches applied to wireless-drivers-next.git, thanks.
0ef2c2d1a9d0 wireless: fix wiki website url in main Kconfig
eb17a4f9acf1 atmel:
Flavio Suligoi wrote:
> In some Intesil files, the wiki url is still the old
> "wireless.kernel.org" instead of the new
> "wireless.wiki.kernel.org"
>
> Signed-off-by: Flavio Suligoi
Fails to apply:
fatal: corrupt patch at line 97
error: could not build fake ancestor
Applying: intersil: fix w
Kees Cook wrote:
> Using uninitialized_var() is dangerous as it papers over real bugs[1]
> (or can in the future), and suppresses unrelated compiler warnings (e.g.
> "unused variable"). If the compiler thinks it is uninitialized, either
> simply initialize the variable or make compiler changes. A
"Alexander A. Klimov" wrote:
> Rationale:
> Reduces attack surface on kernel devs opening the links for MITM
> as HTTPS traffic is much harder to manipulate.
>
> Deterministic algorithm:
> For each file:
> If not .svg:
> For each line:
> If doesn't contain `\bxmlns\b`:
> For
"Alexander A. Klimov" wrote:
> Rationale:
> Reduces attack surface on kernel devs opening the links for MITM
> as HTTPS traffic is much harder to manipulate.
>
> Deterministic algorithm:
> For each file:
> If not .svg:
> For each line:
> If doesn't contain `\bxmlns\b`:
> For
ment [-Wempty-body]
> drivers/net/wireless/broadcom/b43/main.c: In function
> ‘b43_do_interrupt_thread’:
> drivers/net/wireless/broadcom/b43/main.c:2017:3: warning: suggest braces
> around empty body in an ‘if’ statement [-Wempty-body]
>
> Cc: Kalle Valo
> Cc: "David S. Miller
Lee Jones writes:
> On Fri, 14 Aug 2020, Kalle Valo wrote:
>
>> Lee Jones writes:
>>
>> > Fixes the following W=1 kernel build warning(s):
>> >
>> > drivers/net/wireless/broadcom/b43/main.c: In function
>> > ‘b43_dummy_transmission’
Lee Jones writes:
> On Fri, 14 Aug 2020, Kalle Valo wrote:
>
>> Lee Jones writes:
>>
>> > On Fri, 14 Aug 2020, Kalle Valo wrote:
>> >
>> >> Lee Jones writes:
>> >>
>> >> > Fixes the following W=1 kernel build warning
1 - 100 of 141 matches
Mail list logo
