Re: [Babel-users] The b8fb6d896a234eaa06 commit in master
> I didn't mean any present incorrect behaviour, but rather a weakness which may > (or may not) reappear at some point later and cause painful bugs I'm not worried, that's the kind of issue that valgrind is good at detecting (and I regularly run babeld through valgrind). There's plenty of other places in babeld where I use this style. Thanks for the note, and please continue reviewing master, I'm doing my best to release it Real Soon Now. -- Juliusz ___ Babel-users mailing list Babel-users@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/babel-users
Re: [Babel-users] The b8fb6d896a234eaa06 commit in master
I didn't mean any present incorrect behaviour, but rather a weakness which
may
(or may not) reappear at some point later and cause painful bugs (a
zeroed-out
struct stands out way more than a gibberish-filled uninitialized one).
`do_filter` is two frames deeper from that `filter_result`'s declaration -
and
that gives opportunity to use it before it's ready.
Personally I'd lose the `filter_result.src_prefix = NULL;`in xroute.c:290
and leave the `= {0};` alone.
Thanks,
Stanislaw
pt., 9 mar 2018 o 14:38 użytkownik Juliusz Chroboczek napisał:
> >> I noticed that there's this new commit (b8fb6d896a234eaa06) which
> removes
> >> explicit initialization from check_xroutes() in xroute.c.
>
> > Fixed, thanks.
>
> Er, no. do_filter unconditionally initialises the result, so the code is
> correct. Am I missing something?
>
> -- Juliusz
>
___
Babel-users mailing list
Babel-users@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/babel-users
Re: [Babel-users] The b8fb6d896a234eaa06 commit in master
> I noticed that there's this new commit (b8fb6d896a234eaa06) which removes > explicit initialization from check_xroutes() in xroute.c. Fixed, thanks. (I don't know what I was thinking when I accepted this patch. I need a rest.) -- Juliusz ___ Babel-users mailing list Babel-users@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/babel-users
Re: [Babel-users] The b8fb6d896a234eaa06 commit in master
On Fri, Mar 9, 2018, at 13:21, Stanisław Drozd wrote: > Hello, > I noticed that there's this new commit (b8fb6d896a234eaa06) > which removes> explicit initialization from check_xroutes() in xroute.c. > > Personally I don't think it's a great idea I noticed that too and had exactly the same thought. Gabriel ___ Babel-users mailing list Babel-users@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/babel-users
